oUF - Layout discussion

[Bruners]

you also need to register an event for the tag like this

oUF.Tags["[customtag]"] = function(unit)
  local m, n = UnitHealthMax(unit), UnitHealth(unit)
  return m == 0 and 0 or n ~= m and string.format("-%s|r", (m - n)) or m == n and m
end

oUF.TagEvents["[customtag]"] = "UNIT_HEALTH UNIT_MAXHEALTH"

and to use it something like this

	local hp = CreateFrame"StatusBar"
	hp:SetHeight(20)
	hp:SetStatusBarTexture(texture)
	hp:SetPoint(top)

	local hpp = hp:CreateFontString(nil, 'OVERLAY', 'GameFontHighlightSmallRight')
	hpp:SetPoint("RIGHT", -2, 0)
	hpp:SetTextColor(1, 1, 1)
	self:Tag(hpp, "[customtag]")
	
	hp.bg = hpbg
	self.Health = hp

[Alkar]

Originally Posted by Bruners you also need to register an event for the tag like this oUF.Tags["[customtag]"] = function(unit) local m, n = UnitHealthMax(unit), UnitHealth(unit) return m == 0 and 0 or n ~= m and string.format("-%s|r", (m - n)) or m == n and m end oUF.TagEvents["[customtag]"] = "UNIT_HEALTH UNIT_MAXHEALTH" and to use it something like this local hp = CreateFrame"StatusBar" hp:SetHeight(20) hp:SetStatusBarTexture(texture) hp:SetPoint(top) local hpp = hp:CreateFontString(nil, 'OVERLAY', 'GameFontHighlightSmallRight') hpp:SetPoint("RIGHT", -2, 0) hpp:SetTextColor(1, 1, 1) self:Tag(hpp, "[customtag]") hp.bg = hpbg self.Health = hp

Again Bruners u are a life saver workin great atm cept i keep getting some error with tags in oUF_131 but i think thats a tag problem in my code.. its a unitisdead something lol

[Alkar]

Nother question ...
When i right click on my frames and do set focus it comes up with a blizzard only function is there away around this something in the menu drop down that needs to be put in there or fixed?

[haste]

Originally Posted by Alkar Nother question ... When i right click on my frames and do set focus it comes up with a blizzard only function is there away around this something in the menu drop down that needs to be put in there or fixed?

Only way to fix that would be to implement a secure menu from scratch.

[Alkar]

Tag error?

[2009/01/14 19:25:54-896-x1]: oUF-1.3.1\elements\tags.lua:55: Usage: UnitIsDead("unit")
oUF-1.3.1\elements\tags.lua:55: in function `func'
oUF-1.3.1\elements\tags.lua:193: in function `UpdateTag'
oUF-1.3.1\elements\tags.lua:105: in function <Interface\AddOns\oUF\elements\tags.lua:100>

[Bruners]

Originally Posted by Alkar Tag error? [2009/01/14 19:25:54-896-x1]: oUF-1.3.1\elements\tags.lua:55: Usage: UnitIsDead("unit") oUF-1.3.1\elements\tags.lua:55: in function `func' oUF-1.3.1\elements\tags.lua:193: in function `UpdateTag' oUF-1.3.1\elements\tags.lua:105: in function <Interface\AddOns\oUF\elements\tags.lua:100>

try with a if(not unit) then return end in your tag(s)

[haste]

Originally Posted by Alkar Tag error? [2009/01/14 19:25:54-896-x1]: oUF-1.3.1\elements\tags.lua:55: Usage: UnitIsDead("unit") oUF-1.3.1\elements\tags.lua:55: in function `func' oUF-1.3.1\elements\tags.lua:193: in function `UpdateTag' oUF-1.3.1\elements\tags.lua:105: in function <Interface\AddOns\oUF\elements\tags.lua:100>

Explaining where and when and how is always useful .

[Alkar]

Originally Posted by haste Explaining where and when and how is always useful .

ROFLMAo i figured it out had an extra tag that didnt lead to anything :P

[haste]

This commit fixes your issue.

[showbiz]

Is there a better way to ensure party frames never show up, while in party or raid, than just:
oUF:Spawn('header', 'oUF_Party'):Hide()


Even without the Hide() call the frames don't show up, but I get the feeling there's more that can be done. I notice in ouf.lua that HandleUnit it goes about unregistering events on the party members' frames.. wasn't sure if that would need to be replicated as well.

The end goal is just to use Grid for all party/raid frames, while using say oUF_P3lim for player, target, etc.

[Banur]

Hi there I just started creating an ouf layout because I'm new to lua I started ripping apart a working one (sorry zork/roth its your orb layout).

http://i40.tinypic.com/3ekaq.jpg

As you can see the portrait is to big and not well placed so I'm asking if the pic can be scaled.

if(unit == 'player' or unit == 'target') then
		self.Portrait = CreateFrame('PlayerModel', nil, self)
		self.Portrait:SetFrameStrata("BACKGROUND")
		self.Portrait:SetPoint('TOPLEFT', 000, 000)
		self.Portrait:SetPoint('BOTTOMRIGHT', 000, 000)
		self.Portrait:SetScale(0.5)

I tried SetScale(0.5) and SetModelScale(0.5) but all it does is mashing the portrait (but I guess I'm using it in the wrong way).

[p3lim]

Originally Posted by Banur Hi there I just started creating an ouf layout because I'm new to lua I started ripping apart a working one (sorry zork/roth its your orb layout). http://i40.tinypic.com/3ekaq.jpg As you can see the portrait is to big and not well placed so I'm asking if the pic can be scaled. if(unit == 'player' or unit == 'target') then self.Portrait = CreateFrame('PlayerModel', nil, self) self.Portrait:SetFrameStrata("BACKGROUND") self.Portrait:SetPoint('TOPLEFT', 000, 000) self.Portrait:SetPoint('BOTTOMRIGHT', 000, 000) self.Portrait:SetScale(0.5) I tried SetScale(0.5) and SetModelScale(0.5) but all it does is mashing the portrait (but I guess I'm using it in the wrong way).

When you anchor it to two points the points decides its size

[Banur]

Ah of course! That explains the stretching of the pic as I played with the coords. Thanks a lot.

[Waterdark]

hi there, just started messing around with LUA and oUF layouts.

Using Lyn's layout as a base (as it's very nicely splitted into sections), I'm trying to modify it to suit my needs, and I'm currently wondering about castbar coloring.

In a more general way, how can I check if the targeted unit is hostile or friendly? I'd like to have the target's castbar colored blue for friends casting, and red for enemies. Tried something like

-- check if the target is friendly for a blue bar or hostile for a red one
if (UnitIsFriend("target", "player")) then
	self.Castbar:SetStatusBarColor(0,0,1) --blue
else 
	self.Castbar:SetStatusBarColor(1,0,0)	--red
end

but it always turns out red, even if I target myself.

Any info appreciated, thanks

[p3lim]

Originally Posted by Waterdark hi there, just started messing around with LUA and oUF layouts. Using Lyn's layout as a base (as it's very nicely splitted into sections), I'm trying to modify it to suit my needs, and I'm currently wondering about castbar coloring. In a more general way, how can I check if the targeted unit is hostile or friendly? I'd like to have the target's castbar colored blue for friends casting, and red for enemies. Tried something like -- check if the target is friendly for a blue bar or hostile for a red one if (UnitIsFriend("target", "player")) then self.Castbar:SetStatusBarColor(0,0,1) --blue else self.Castbar:SetStatusBarColor(1,0,0) --red end but it always turns out red, even if I target myself. Any info appreciated, thanks

UnitIsEnemy(unit, 'player')

[Freebaser]

Im using a XML template to spawn my party targets and pets, but for some reason i cant select or "click" the party pet frame. Party target works fine. Anyone run into this issue?

[Philr]

Originally Posted by Freebaser Im using a XML template to spawn my party targets and pets, but for some reason i cant select or "click" the party pet frame. Party target works fine. Anyone run into this issue?

Yes. Did you blindly copy the partytarget frame xml and replace 'target' with 'pet' like I did? :-)

This attribute:

<Attribute name="type1" type="string" value="target"/>

is the action to perform on left-click. 'target' means target the unit. 'pet' means perform a pet action on the unit. Change it back to 'target'. :-)

[Philr]

I'm also using an XML template to spawn partytarget and partypet frames. I'm using range fading on every frame. It seems that the partytarget and partypet frames inherit their alpha value from their parent party frame. Either the range check isn't being called for these frames or the alpha set by it is just overridden. Any way to change this behaviour so I can see when pets are in range independent of their master?

[Freebaser]

Originally Posted by Philr This attribute: <Attribute name="type1" type="string" value="target"/> is the action to perform on left-click. 'target' means target the unit. 'pet' means perform a pet action on the unit. Change it back to 'target'. :-)

Ah, I see now. Thanks, that was the issue

[Waterdark]

Originally Posted by p3lim UnitIsEnemy(unit, 'player')

Thank you for the suggestion, but I tried this, too, without success

-- check if the target is friendly for a blue bar or hostile for a red one
if (UnitIsEnemy('target', 'player')) then
	self.Castbar:SetStatusBarColor(0.80, 0.01, 0)
else 
	self.Castbar:SetStatusBarColor(0, 0.01, 0.80)			
end

--	original line in Lyn's layout code			
--	self.Castbar:SetStatusBarColor(0.80, 0.01, 0)

I tried various stuff like UnitIsEnemy(unit, 'player'), ('target', 'player') and the like, all to no avail. The "else" branch is always chosen and the bar is colored blue.

I'm feeling quite stumped at this, and I can't see any other parts of the code that may alter this behaviour.

edit: tried on the same mob:
/script if (UnitIsEnemy("target","player")) then SendChatMessage("%t is evil!","SAY"); end;
and the chat message is correctly spammed (but still, cast bar is coloured wrong).

edit 2: tried with if (false) then <set color1> else <set color2> end, and it always chooses color2; if (true) always chooses color1, so I'm quite assured that nothing else is interfering in the colouring process itself. It seems the problem rests in the condition itself. Tried UnitIsPlayer(unit) with no avail, it always goes down the "false" branch even when I'm targeting myself.