Help with creating a health tag.

Wimpface · 08-07-09, 02:15 AM

So, I've been unable to find any help regarding this for the last few days and I've not found it in any layout so far to take references from.

What I want is a tag that changes color (from green to red) based on the units health, I've tried a bit with oUF.ColorGradient but it has not worked out well for me. (i.e I've done something wrong.)

If anyone would be just as so kind to help me out with this, I'd appreciate it a lot.

Regards,
Rhiren.

Freebaser · 08-07-09, 02:24 AM

Originally Posted by Wimpface

So, I've been unable to find any help regarding this for the last few days and I've not found it in any layout so far to take references from.

What I want is a tag that changes color (from green to red) based on the units health, I've tried a bit with oUF.ColorGradient but it has not worked out well for me. (i.e I've done something wrong.)

If anyone would be just as so kind to help me out with this, I'd appreciate it a lot.

Regards,
Rhiren.

oUF_Freeb uses ColorGradient and you can glance at it here if it helps.

Wimpface · 08-07-09, 02:27 AM

Thanks, can't believe I overlooked it.

Cheers.

Freebaser · 08-07-09, 02:33 AM

Originally Posted by Wimpface

Thanks, can't believe I overlooked it.

Cheers.

Also, don't get confused in my updateHealth function. There are 2 different ColorGradients, r,g,b applies to text and x,y,z to the health bar.

Wimpface · 08-07-09, 02:37 AM

EDIT: I added "self" into the function, and now I get a different error. I'll paste the code/error below here.

Code:

oUF.Tags['[rhealth]'] = function(self, unit)
	local min, max = UnitHealth(unit), UnitHealthMax(unit)
	
	local status = not UnitIsConnected(unit) and 'Offline' or UnitIsGhost(unit) and 'Ghost' or UnitIsDead(unit) and 'Dead'
	if(max ~= 0) then
		r, g, b = self.ColorGradient(min/max, .69,.31,.31, .65,.63,.35, .33,.59,.33)
	end
	
	return status and status or min ~= max and ('%s'):format(shortVal(min), shortVal(max)) or max
end

oUF.TagEvents['[rhealth]'] = 'UNIT_HEALTH'

Code:

Message: Interface\AddOns\oUF_Rhiren\tags.lua:38: Usage: UnitHealth("unit")
Time: 08/07/09 10:53:01
Count: 1
Stack: [string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:18: in function <[string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:4>
[C]: ?
[C]: in function `UnitHealth'
Interface\AddOns\oUF_Rhiren\tags.lua:38: in function `func'
Interface\AddOns\oUF\elements\tags.lua:305: in function `UpdateTag'
Interface\AddOns\oUF\elements\tags.lua:178: in function `func'
Interface\AddOns\oUF\ouf.lua:484: in function <Interface\AddOns\oUF\ouf.lua:479>
(tail call): ?

Locals: (*temporary) = nil

Freebaser · 08-07-09, 02:53 AM

change self to oUF.ColorGradient

Edit: your return status needs some work, but I don't know a fix off the top of my head. *sleepy*

Wimpface · 08-07-09, 02:56 AM

Originally Posted by Freebaser

change self to oUF.ColorGradient

Cheers, however, it does not seem to do any coloring at all now but I don't get any errors. Could it be that I'm using a "short value" function?

Code:

oUF.Tags['[rhealth]'] = function(unit)
	local min, max = UnitHealth(unit), UnitHealthMax(unit)
	
	local status = not UnitIsConnected(unit) and 'Offline' or UnitIsGhost(unit) and 'Ghost' or UnitIsDead(unit) and 'Dead'
	if(max ~= 0) then
		r, g, b = oUF.ColorGradient(min/max, .69,.31,.31, .65,.63,.35, .33,.59,.33)
	end
	
	return status and status or min ~= max and ('%s'):format(shortVal(min), shortVal(max)) or max
end

Subere · 08-07-09, 04:02 PM

Originally Posted by Wimpface

Cheers, however, it does not seem to do any coloring at all now but I don't get any errors. Could it be that I'm using a "short value" function?

Code:

oUF.Tags['[rhealth]'] = function(unit)
	local min, max = UnitHealth(unit), UnitHealthMax(unit)
	
	local status = not UnitIsConnected(unit) and 'Offline' or UnitIsGhost(unit) and 'Ghost' or UnitIsDead(unit) and 'Dead'
	if(max ~= 0) then
		r, g, b = oUF.ColorGradient(min/max, .69,.31,.31, .65,.63,.35, .33,.59,.33)
	end
	
	return status and status or min ~= max and ('%s'):format(shortVal(min), shortVal(max)) or max
end

Just guessing it's because you're not actually doing anything with the color you're grabbing.

Something like below should work.

Code:

-- If you already have a function like this in your layout you don't need to add it.
local function Hex(r, g, b)
	if type(r) == 'table' then
		if r.r then r, g, b = r.r, r.g, r.b else r, g, b = unpack(r) end
	end
	
	return string.format('|cff%02x%02x%02x', r*255, g*255, b*255)
end

oUF.Tags['[rhealth]'] = function(unit)
	local min, max = UnitHealth(unit), UnitHealthMax(unit)
	local r, g, b
	
	local status = not UnitIsConnected(unit) and 'Offline' or UnitIsGhost(unit) and 'Ghost' or UnitIsDead(unit) and 'Dead'
	
	if(max ~= 0) then
		r, g, b = oUF.ColorGradient(min/max, .69,.31,.31, .65,.63,.35, .33,.59,.33)
	end
	
	return status and status or min ~= max and ('%s%s / %s|r'):format(Hex(r, g, b), shortVal(min), shortVal(max)) or ('%s%d|r'):format(Hex(r, g, b), max)
end

Waverian · 08-07-09, 06:16 PM

If you want green -> red you can just use oUF's predefined color table, smooth more specifically.

Code:

	if max ~= 0 then
		r, g, b = oUF.ColorGradient(min / max, unpack(oUF.colors.smooth))
	end
	
	return format("|cff%02x%02x%02x%s%s|r", r * 255, g * 255, b * 255, floor((min / max) * 100), "%")

That's hp percent obviously but the concept still applies.

Wimpface · 08-08-09, 02:38 AM

Cheers people, thanks for all the help.

Wimpface · 08-08-09, 02:53 AM

As said, cheers for all the help. It's deeply appreciated, however, now I get another error.
Either I'm a complete tard that should just stay away from coding or something just went wrong somewhere.

Code:

Message: Interface\AddOns\oUF_Rhiren\tags.lua:47: attempt to call global 'Hex' (a nil value)
Time: 08/08/09 10:50:12
Count: 1
Stack: [string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:18: in function <[string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:4>
[C]: in function `Hex'
Interface\AddOns\oUF_Rhiren\tags.lua:47: in function `func'
Interface\AddOns\oUF\elements\tags.lua:305: in function `UpdateTag'
Interface\AddOns\oUF\elements\tags.lua:178: in function `func'
Interface\AddOns\oUF\ouf.lua:484: in function <Interface\AddOns\oUF\ouf.lua:479>
(tail call): ?

Locals: unit = "player"
min = 15800
max = 15800
r = 0.33
g = 0.59
b = 0.33
status = nil
(*temporary) = <function> defined =[C]:-1
(*temporary) = "%s%d"
(*temporary) = nil
(*temporary) = 0.33
(*temporary) = 0.59
(*temporary) = 0.33
(*temporary) = "attempt to call global 'Hex' (a nil value)"
ColorGradient = <function> defined @Interface\AddOns\oUF\ouf.lua:489
shortVal = <function> defined @Interface\AddOns\oUF_Rhiren\tags.lua:20

Here's the pastey to my entire "tags.lua" file.
http://pastey.net/120369

Again, thanks for all the help.

Rostok · 08-08-09, 04:57 AM

Hi,
it seems that the function is case sensitive

Hex <> hex.

Regards.

Wimpface · 08-08-09, 02:43 PM

Originally Posted by Rostok

Hi,
it seems that the function is case sensitive

Hex <> hex.

Regards.

Cheers, /slapself for not seeing it.