Aardvark Cata

Walkerbo · 05-02-24, 12:38 AM

Hi all

I am the author of the Aardvark addon.

I am trying to update my addon to work in Cata.

It worked perfectly in Wrath and the code currently works in both Classic and Retail.

I have 3 bug reports;

Lua Code:

15x Aardvark/Aardvark.lua:3091: bad argument #1 to '?' (Usage: self:SetJustifyV(justifyV))
[string "=[C]"]: in function `?'
[string "@Aardvark/Aardvark.lua"]:3091: in main chunk
 
Locals:
(*temporary) = AardvarkSellOptionsPanelText {
 0 = <userdata>
}
(*temporary) = "RIGHT"

Lua Code:

161x Aardvark/Aardvark.lua:2397: attempt to index global 'AardvarkMagicButton' (a nil value)
[string "@Aardvark/Aardvark.lua"]:2397: in function <Aardvark/Aardvark.lua:2295>
 
Locals:
self = AardvarkMainFrame {
 0 = <userdata>
 Banner = AardvarkMainFrameBanner {
 }
 OnBackdropLoaded = <function> defined @Blizzard_SharedXML/Backdrop.lua:152
 CloseButton = AardvarkMainFrameCloseButton {
 }
 Center = Texture {
 }
 GetBackdropColor = <function> defined @Blizzard_SharedXML/Backdrop.lua:390
 SetupTextureCoordinates = <function> defined @Blizzard_SharedXML/Backdrop.lua:214
 OnBackdropSizeChanged = <function> defined @Blizzard_SharedXML/Backdrop.lua:182
 HasBackdropInfo = <function> defined @Blizzard_SharedXML/Backdrop.lua:278
 SetBackdropBorderColor = <function> defined @Blizzard_SharedXML/Backdrop.lua:422
 RightEdge = Texture {
 }
 backdropInfo = <table> {
 }
 BottomEdge = Texture {
 }
 GetEdgeSize = <function> defined @Blizzard_SharedXML/Backdrop.lua:188
 BottomLeftCorner = Texture {
 }
 BottomRightCorner = Texture {
 }
 TopEdge = Texture {
 }
 ApplyBackdrop = <function> defined @Blizzard_SharedXML/Backdrop.lua:294
 SetBackdrop = <function> defined @Blizzard_SharedXML/Backdrop.lua:329
 ClearBackdrop = <function> defined @Blizzard_SharedXML/Backdrop.lua:282
 TopRightCorner = Texture {
 }
 GetBackdropBorderColor = <function> defined @Blizzard_SharedXML/Backdrop.lua:409
 GetBackdrop = <function> defined @Blizzard_SharedXML/Backdrop.lua:347
 TopLeftCorner = Texture {
 }
 SetupPieceVisuals = <function> defined @Blizzard_SharedXML/Backdrop.lua:246
 SetBackdropColor = <function> defined @Blizzard_SharedXML/Backdrop.lua:399
 LeftEdge = Texture {
 }
 SetBorderBlendMode = <function> defined @Blizzard_SharedXML/Backdrop.lua:266
}
event = "ADDON_LOADED"
arg1 = "Aardvark"
(*temporary) = nil
(*temporary) = nil
(*temporary) = 1
(*temporary) = <userdata>
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'AardvarkMagicButton' (a nil value)"
TextList = <table> {
 avkKeybinds = "Keybinds:
 
Default keybinds have now been removed due to conflicts with some blizzard and other addon keybinds.
 
Keybinds are still enabled for players to set themselves.
 
You can set your own keybinds in Key Bindings UI."
 avkAboutAardvark = "There once was a little blue Aardvark that grew up in Azeroth.
 
He loved to farm, spending all day and half of the night digging up herbs, mining ore, weaving cloth and collecting little treasures.
 
After few years he started to develop RSI in his little paws as he was always clicking to sell items that he didn't want, dragging and dropping items that he couldn't sell and, in a lot of cases, deleting items just to clean out his bags ready to farm again.
 
One day after an extremely long day of farming he thought;|cff00ffff
"What if I could open my bags and have all the stuff I don't want just magically disappear?"|r 
 
With this thought he started to teach his little arthritic paws how to code.
His code is very messy, overly long and undoubtedly very inefficient but it does what he wants it to do.
 
Hopefully you can find it useful too."
 avkRepairOptions = "The |cffff00ffAardvark Repair|r function operates after the destroy function and prior to the
 sell function.
 
 Damaged items must
 be repaired before
 they can  be sold."
 avkBulkAddCharacter = "Add displayed items to your Character list.
Items with a value will be added your Character Sell List.
Items with no value will be added to your Character Destroy List."
 avkSlashCommands = "Slash Commands:
 
|cff00ffff/avk |r ~  Show/Hide Aardvark frame
|cff00ffff/avkdestroy |r ~  Destroy function
|cff00ffff/avkclear |r ~  Clear all lists
|cff00ffff/avkpos |r ~  Reset Aardvark frame and button positions
|cff00ffff/avkrsd |r ~  Reset all Aardvark settings to default
"
 avkMagicButton = "Drag&Drop/Click&Drop: Add Item to Character List
Drag&Drop/Click&Drop + Alt: Add Item to Global List
Drag&Drop/Click&Drop + Ctrl: Add Item to Global Protect List
Drag&Drop/Click&Drop + Shi

Lua Code:

7x Aardvark/Aardvark.lua:391: attempt to index field '?' (a nil value)
[string "@Aardvark/Aardvark.lua"]:391: in function <Aardvark/Aardvark.lua:326>
[string "@Aardvark/Aardvark.lua"]:2298: in function <Aardvark/Aardvark.lua:2295>
 
Locals:
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
 Destroy = <table> {
 }
 Aardvark = <table> {
 }
 Repair = <table> {
 }
 Sell = <table> {
 }
 Protect = <table> {
 }
 FrameScales = <table> {
 }
}
(for control) = "Destroy"
k = "Destroy"
v = <table> {
 dddm = true
 ded = true
 dlit = true
 dialsm = true
 dtdm = true
 dntdm = true
 dirlm = true
 dialfm = true
}
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
 dddm = true
 ded = true
 dlit = true
 dialsm = true
 dtdm = true
 dntdm = true
 dirlm = true
 dialfm = true
}
(for control) = "dddm"
a = "dddm"
b = true
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field '?' (a nil value)"
ColourList = <table> {
 textBlue = "|cff00ffff"
 rarityPoor = "|cff9d9d9d"
 textBluePrefix = "|cff00ffff [Aardvark]: "
 textGreen = "|cff00ff00"
 rarityCommon = "|cffffffff"
 rarityArtifact = "|cffe6cc80"
 rarityHeirloom = "|cff00ccff"
 rarityLegendary = "|cffff8000"
 textRed = "|cffff0000"
 textBluePrefixSuffix = "|cff00ffff [Aardvark]: |r"
 rarityOther = "|cff00ccff"
 rarityEpic = "|cffa335ee"
 textYellow = "|cfffffff0"
 rarityRare = "|cff0070dd"
 textPink = "|cffff00ff"
 textOrange = "|cffff8c00"
 rarityUncommon = "|cff1eff00"
}

I have been banging my head against a wall for hours now without success.
I can't understand why the code worked in Wrath without issue, (the same code currently works in Classic and Retail), yet can not find any changes that Cata made that could have broken my code.

Here is my current code

I am seeking help understanding what happened and how to fix it.

AcidWeb · 05-02-24, 12:44 AM

SetJustifyV("CENTER") -> SetJustifyV("MIDDLE")

Walkerbo · 05-02-24, 06:08 PM

Hi AcidWeb

MIDDLE is not a valid anchor designation, only TOP, BOTTOM, LEFT, RIGHT and CENTER are valid.
Even knowing this I did try it and still no go.

Fizzlemizz · 05-02-24, 07:17 PM

It is (always has been) for SetJustifyV on a FontString. Until now (Cata atm.), the game just accepted "CENTER" without complaining. SetJustfyH still uses "CENTER".

Walkerbo · 05-03-24, 05:47 PM

Hi Fizzlemizz

So does it mean that "MIDDLE" is acceptable for SetJustifyV() for text only?
I have tried bulk changing CENTER to MIDDLE without success.
I have tried bulk changing SetJustifyV("CENTER") to SetJustifyV("MIDDLE") without success.
I have manually gone through the code line by line and changed CENTER to MIDDLE only where it applies to text without success.

This one is twisting my mind in knots.

Fizzlemizz · 05-03-24, 06:36 PM

SetJustifyV is not for anchoring (SetPoint), it purely to set the vertical justification of the text inside a FontString (Think of the FontString as a container you anchor and the text inside as something separate that you control the look of based on the containers dimensions along with SetJustifyV/SetJustifyH).

For Cata (and presumably the other versions at some point) you can't use "CENTER" for SetJustifV, only "MIDDLE". Retail and Vanilla will sitll accept "CENTER" or "MIDDLE" for the time being but you may as well change those.

If you have saved any FontStrings SetJustifyV settings in your SavedVariables as "CENTER" then they will also cause an error and the SV entries will need to be updated to "MIDDLE".

Example:

Lua Code:

local Text = "This is text to test. [%s] "
 
local V = { "TOP", "MIDDLE", "BOTTOM" }
local H = { "LEFT", "CENTER", "RIGHT" }
 
local last
for i = 1, 3 do
    local t1 = UIParent:CreateFontString()
    t1:SetFontObject(GameFontNormal)
    t1:SetSize(55, 100)
    t1:SetPoint("TOP", last and last or UIParent, last and "BOTTOM" or nil)
    t1:SetJustifyV(V[i])
    t1:SetText(format(Text, V[i]))
    local x = UIParent:CreateTexture()
    x:SetAllPoints(t1)
    x:SetColorTexture(random(0, 255) / 255, random(0, 255) / 255, random(0, 255) / 255, 0.3)
 
    local t2 = UIParent:CreateFontString()
    t2:SetFontObject(GameFontNormal)
    t2:SetSize(250, 20)
    t2:SetPoint("LEFT", t1, "RIGHT", 10, 0)
    t2:SetJustifyH(H[i])
    t2:SetText(format(Text, H[i]))
    local x = UIParent:CreateTexture()
    x:SetAllPoints(t2)
    x:SetColorTexture(random(0, 255) / 255, random(0, 255) / 255, random(0, 255) / 255, 0.3)
 
    last = t1
end
-- add a no size FontString that will adjust to fit the text, JustifyV is "CENTER" by default
local t1 = UIParent:CreateFontString()
t1:SetFontObject(GameFontNormal)
--t1:SetSize(55, 100) 
t1:SetPoint("TOP", last, "BOTTOM", 0, -10)
--t1:SetJustifyV(V[i])
t1:SetText("NO SIZE\n" .. Text .. Text .."\n" .. Text .."\n" .. Text .. Text .. Text)
local x = UIParent:CreateTexture()
x:SetAllPoints(t1)
x:SetColorTexture(random(0, 255) / 255, random(0, 255) / 255, random(0, 255) / 255, 0.3)

If the FontString is too narrow for a word it should terminate with ...

Walkerbo · 05-03-24, 11:27 PM

Hii Fizzlemizz

Thanks for your detailed explanation; not only did I have :SetJustifyV("CENTER") I also had :SetJustifyH("BOTTOM"), so I was doubly screwed.

I have gone through the code and now it is working properly.

Thanks to you and AcidWeb for all of your help.