Remove player from guild on their right-click menu

[Walkerbo]

Hi all

I have created a button and submenu on the right-click menu on a player.

I want to be able to invite/add a player to the guild I am in.

Inviting works perfectly but the uninvite does not work.

Here is my code;

local function nameString(targetName, targetRealm)
       if targetRealm == nil then
              targetNameString = targetName
       else
              targetNameString = (targetName .. "-" .. targetRealm)
       end
       return targetNameString
end
 
local menuButton1 = Menu.ModifyMenu("MENU_UNIT_PLAYER", function(_, menuButton)
       menuButton:CreateDivider()
       submenu = menuButton:CreateButton("Guild Up")
 
       targetGuildName = GetGuildInfo("target")
       targetGuid = UnitGUID("target")
       playerGuildName = GetGuildInfo("player")
       playerIsInGuild = IsInGuild()
       playerCanInviteToGuild = CanGuildInvite()
       playerCanRemoveFromGuild = CanGuildRemove()
       targetName, targetRealm = UnitFullName("target")
 
       if playerIsInGuild and playerCanInviteToGuild then
              if targetGuildName == nil then
                     submenu:CreateButton(ColourList.greenText.."Invite Player To Guild", function(self)
                            C_GuildInfo.Invite(nameString(targetName, targetRealm))
                     end)
       elseif playerCanRemoveFromGuild and playerGuildName == targetGuildName then
                     submenu:CreateButton(ColourList.greenText.."Remove Player From Guild", function(self)
                            print(UnitName("target") .. " is in a guild " .. targetGuildName, playerGuildName) -- debug --
                            C_GuildInfo.RemoveFromGuild(targetGuid)-- debug --
                     end)
              end
       end

It seems that removal from a guild is a secure action.

Is there a way to add a secure template to the button, or any other way to make this work?

[SDPhantom]

The slash command is registered under the token GUILD_UNINVITE. You can try to use a SecureActionButtonTemplate to run the following macrotext. Omitting the player name argument defaults to your current target.

local SecureActionButton=CreateFrame("Button",nil,"SecureActionButtonTempalte");
SecureActionButton:SetAttribute("type","macro");
SecureActionButton:SetAttribute("macrotext",SLASH_GUILD_UNINVITE1);

You can swap SLASH_GUILD_UNINVITE1 with SLASH_GUILD_INVITE1 to effectively toggle between kick and invite.

[Walkerbo]

Hi SDPhantom

Sorry for the delayed response.

I have added a button to the right click drop-down of a targeted player.
I have added a submenu buttonto that button.

The issue is that the submenu:CreateButton doesn't seem able to add a template.

I have tried adding a hidden button with a secure button template and then using the submenu button to perform a button click but that just seems to break everything.

I am just stumped at this point.

[SDPhantom]

Looking at the code, the functions in submenu are pulled from MenuUtilPrivate.Inserters and MenuUtilPrivate.Utilities. Note MenuUtilPrivate is a local table.

There appears to be a sister function to submenu:CreateButton() called submenu:CreateTemplate(). This might be something to look into.

[Walkerbo]

Hi SDPhantom

Sorry for taking so long to reply.

Thanks for the links, however, I still have not cracked this nut, no matter what I tried.

Any further help would be greatly appreciated.

[Fizzlemizz]

As far as I got, there doesn't seem to be any way to create a menu item based on a template (the use of template in the menu system is not referring to XML templates). While this may be a oversight, my guessing is probably not so as to avoid the unwary spreading taint into their lovely new menu system.

[Walkerbo]

Hi Fizzlemizz

So there currently is no way to get this working, and as such I need to wait until Blizz implements a way to apply templates to the menu buttons.

Is there a way to raise such issues with Blizz?

[Fizzlemizz]

Feedback through the in-game system or or possibly the bug tracker.

I didn't get to the bottom of the rabbit hole so I might have missed something and as I said, it might be a deliberate omission that will never see the light of day.

Maybe your menu function could open a seperate frame with the required bits and buttons?

[Walkerbo]

Hi Fizzlemizz

I will submit a bug report, but I like your suggestion to use a button that activates when I click the menu button.

I have a very basic hidden secure button using code from SDPhantom;

local hiddenRemovePlayerFromGuildButton = CreateFrame("Button", nil, "SecureActionButtonTemplate")
hiddenRemovePlayerFromGuildButton:SetAttribute("type", "macro")
hiddenRemovePlayerFromGuildButton:SetAttribute("macrotext", "/kiss")

I trigger the button using;

hiddenRemovePlayerFromGuildButton:Click()

But I get an error;

1x BuddyUp/BuddyUp.lua:119: attempt to index global 'hiddenRemovePlayerFromGuildButton' (a nil value)
[string "@BuddyUp/BuddyUp.lua"]:119: in function <BuddyUp/BuddyUp.lua:116>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `securecallfunction'
[string "@Blizzard_Menu/Menu.lua"]:868: in function `Pick'
[string "@Blizzard_Menu/MenuTemplates.lua"]:74: in function <Blizzard_Menu/MenuTemplates.lua:68>

What am I doing wrong here?

[Fizzlemizz]

The error says it all, the click cant "see" the hiddenRemovePlayerFromGuildButton because it is out of scope. First step woujld be to remove the local in front of hiddenRemovePlayerFromGuildButton (or maybe the function is declared after the click code??)

Beyond that, I couldn't tell without seeing the code.

[Walkerbo]

Hi Fizzlemizz

Thanks for the speedy reply.

Yea, once again I know I should display all of my code it just feels like spamming;

-- ===========================         metrics, lists & variables          ===========================
 
local addonName = 'Buddy Up'
local versionNumber = '1.0.100200'
 
local stringInvite, stringRemove, stringIgnore, stringUnignore = "Invite Player To Guild", "Remove Player From Guild", "Add Player To Ignore List", "Remove Player From Ignore List"
 
local localLanguage = GetLocale()
if localLanguage == deDE then -- German
       stringInvite = "Spieler zur Gilde einladen"
       stringRemove = "Spieler aus der Gilde entfernen"
       stringIgnore = "Spieler zur Ignorierliste hinzufügen"
       stringUnignore = "Spieler aus der Ignorierliste entfernen"
elseif localLanguage == esES then -- Spanish (Spain)
       stringInvite = "Spieler zur Gilde einladen"
       stringRemove = "Eliminar jugador del gremio"
       stringIgnore = "Agregar jugador a la lista de ignorados"
       stringUnignore = "Eliminar jugador de la lista de ignorados"
elseif localLanguage == esMX then -- Spanish (Latin America)
       stringInvite = "Spieler zur Gilde einladen"
       stringRemove = "Eliminar jugador del gremio"
       stringIgnore = "Agregar jugador a la lista de ignorados"
       stringUnignore = "Eliminar jugador de la lista de ignorados"
elseif localLanguage == frFR then -- French
       stringInvite = "Inviter un joueur à la guilde"
       stringRemove = "Supprimer un joueur de la guilde"
       stringIgnore = "Ajouter un joueur à la liste des ignorés"
       stringUnignore = "Supprimer le joueur de la liste des ignorés"
elseif localLanguage == itIT then -- Italian
       stringInvite = "Invita il giocatore alla gilda"
       stringRemove = "Rimuovi giocatore dalla gilda"
       stringIgnore = "Aggiungi giocatore all'elenco degli ignorati"
       stringUnignore = "Rimuovi il giocatore dall'elenco ignorati"
elseif localLanguage == koKR then -- Korean
       stringInvite = "플레이어를 길드에 초대"
       stringRemove = "길드에서 플레이어 제거"
       stringIgnore = "무시 목록에 플레이어 추가"
       stringUnignore = "무시 목록에서 플레이어 제거"
elseif localLanguage == ptBR then -- Brazilian Portuguese
       stringInvite = "Convidar jogador para guilda"
       stringRemove = "Remover jogador da guilda"
       stringIgnore = "Adicionar jogador à lista de ignorados"
       stringUnignore = "Remover jogador da lista de ignorados"
elseif localLanguage == ruRU then -- Russian
       stringInvite = "Пригласить игрока в гильдию"
       stringRemove = "Удалить игрока из гильдии"
       stringIgnore = "Добавить игрока в список игнорируемых"
       stringUnignore = "Удалить игрока из списка игнорируемых"
elseif localLanguage == zhCN then -- Simplified Chinese
       stringInvite = "邀请玩家加入公会"
       stringRemove = "将玩家从公会中移除"
       stringIgnore = "将玩家添加到忽略列表"
       stringUnignore = "从忽略列表中删除玩家"
elseif localLanguage == zhTW then -- Traditional Chinese
       stringInvite = "邀請玩家加入公會"
       stringRemove = "從公會刪除玩家"
       stringIgnore = "將玩家加入忽略列表"
       stringUnignore = "從忽略清單中刪除玩家"
end
 
local ColourList = {
       greenText = "|cff40ff40", -- rgb(64, 255, 64),
       pinkText = "|cffff80ff", -- rgb( 255, 128, 255),
}
 
-- ===========================         functions          ===========================
 
local function nameString(targetName, targetRealm)
       if targetRealm == nil then
              targetNameString = targetName
       else
              targetNameString = (targetName .. "-" .. targetRealm)
       end
       return targetNameString
end
 
-- ===========================         context menu buttons          ===========================
 
local menuButton1 = Menu.ModifyMenu("MENU_UNIT_PLAYER", function(_, menuButton)
       menuButton:CreateDivider()
       submenu = menuButton:CreateButton("Guild Up")
 
       targetGuildName = GetGuildInfo("target")
       targetGuid = UnitGUID("target")
       playerGuildName = GetGuildInfo("player")
       guildInvitesEnabled = GetAutoDeclineGuildInvites() -- debug --
       playerIsInGuild = IsInGuild()
       playerCanInviteToGuild = CanGuildInvite()
       playerCanRemoveFromGuild = CanGuildRemove()
       targetName, targetRealm = UnitFullName("target")
 
       if playerIsInGuild and playerCanInviteToGuild then
              if targetGuildName == nil then
                     submenu:CreateButton(ColourList.greenText .. stringInvite, function(self)
                            C_GuildInfo.Invite(nameString(targetName, targetRealm))
                     end)
       elseif playerCanRemoveFromGuild and playerGuildName == targetGuildName then
                     submenu:CreateButton(ColourList.greenText .. stringRemove, function(self)
                            print(UnitName("target") .. " is in a guild " .. targetGuildName, playerGuildName) -- debug --
--                          C_GuildInfo.RemoveFromGuild(targetGuid)-- debug --
                            hiddenRemovePlayerFromGuildButton:Click() -- debug --
                     end)
              end
       end
 
       if C_FriendList.IsIgnored("target") then
              submenu:CreateButton(ColourList.pinkText .. stringUnignore, function(self)
                     C_FriendList.AddOrDelIgnore(nameString(targetName, targetRealm))
              end)
       else
              submenu:CreateButton(ColourList.pinkText .. stringIgnore, function(self)
                     C_FriendList.AddOrDelIgnore(nameString(targetName, targetRealm))
              end)
       end
end)
 
-- ===========================         button          ===========================
 
hiddenRemovePlayerFromGuildButton = CreateFrame("Button", "hiddenRemovePlayerFromGuildButton", UIParent, "SecureActionButtonTemplate")
hiddenRemovePlayerFromGuildButton:SetAttribute("type", "macro")
hiddenRemovePlayerFromGuildButton:SetAttribute("macrotext", "/kiss")

[Fizzlemizz]

You're declaring hiddenRemovePlayerFromGuildButton after the menu function so as a local

local hiddenRemovePlayerFromGuildButton = CreateFrame("Button", "hiddenRemovePlayerFromGuildButton", UIParent, "SecureActionButtonTemplate")

The menu function wouldn't be able to "see" it.

Move the button code above the menu:

 
local hiddenRemovePlayerFromGuildButton = CreateFrame("Button", "hiddenRemovePlayerFromGuildButton", UIParent, "SecureActionButtonTemplate")
hiddenRemovePlayerFromGuildButton:SetAttribute("type", "macro")
hiddenRemovePlayerFromGuildButton:SetAttribute("macrotext", "/kiss")

local menuButton1 = Menu.ModifyMenu("MENU_UNIT_PLAYER", function(_, menuButton)

[Fizzlemizz]

Instead of hiddenRemovePlayerFromGuildButton, have you tried something like:

local function RemovePlayerFromGuild(playername, playerguid)
    if playername and playerguid then
        local data = { name = playername, guid = playerguid, };
        StaticPopup_Show("REMOVE_GUILDMEMBER", nil, nil, data);
    end
end

and your menu function to remove from guild would call:

RemovePlayerFromGuild(targetName, targetGuid)

I don't have a guild member to remove so just a thought


... the RemovePlayerFromGuild code would still be above

local menuButton1 = Menu.ModifyMenu("MENU_UNIT_PLAYER", function(_, menuButton)

[Walkerbo]

Hi Fizzlemizz

Thanks for your explanation and code, it makes sense that the button should be placed above the code calling it.

However, moving the button did not result in the remove from guild function firing.

Your second code block does open the remove from guild button frame which is perfect, however when I click the remove button I get the "blocked from action only available to the Bizzard UI" frame giving me the option to disable or ignore frame.

[Fizzlemizz]

That's what I was afraid of but had no way of testing.

You wouldn't be able to button:Click() to remove a player from the guild. The user would have to click the button with the mouse as with the popup.

[Walkerbo]

Hi Fizzlemizz

Yes, when the confirmation to remove button frame shows I do click the remove button with a physical mouse click, that's why it is strange that the click brings up the disable/ignore frame.

[Fizzlemizz]

Originally Posted by Walkerbo it is strange that the click brings up the disable/ignore frame.

Does the error say the function is only available from the Blizzard UI? That would indicate it's not something we can use even in secure code.

I remember when they first nobbled guild kick it required a hardware event. Maybe it's been completely protected since then?

[Walkerbo]

Hi Fizzlemizz

The menu button leads to the confirm gkick frame;


Clicking yes takes me to the disable/ignore frame;

[SDPhantom]

This is what taint does. In the case of calling :click(), your addon is directly executing code that eventually tries to call a protected function. When otherwise secure code accesses a value you set, it inherits its taint and is blocked from calling future protected functions along with spreading your addon's taint to anything it writes to.

[Walkerbo]

Hi SDPhantom and Fizzlemizz

So this may not ever work unless Blizz steps in, damn.
I have submitted a suggestion with the faint hope that they look at this scenario and create a secure way to achieve my goal.
Yeah, I won't hold my breath.

Thanks to you both for your help and explanations.

Cheers