Trigger toys with click

GerlockADUS · 06-23-24, 08:49 AM

I am having trouble getting my addon to trigger the toy functionality with button clicks. I have tried UseToy, but that is restricted to the Blizzard UI. I am currently trying "macrotext", but that is not working and I read that is getting removed in 11.0.

What am I doing wrong here? Is it possible? Is there any other way to accomplish this, or is my addon effectively dead on arrival because of the removal of macrotext?

Any help is greatly appreciated.

Here is my current code for the toy button:

Code:

local function CreateToyButton(itemID, parent, index)
    local _, toyName, toyTexture = C_ToyBox.GetToyInfo(itemID)
    local button = CreateFrame("Button", "HearthToyButton"..index, parent, "SecureActionButtonTemplate")
    button:SetSize(TOY_BUTTON_SIZE, TOY_BUTTON_SIZE)
    button:SetNormalTexture(toyTexture or "Interface\\Icons\\INV_Misc_QuestionMark")
    button.itemID = itemID
    
    button:SetScript("OnEnter", function(self)
        GameTooltip:SetOwner(self, "ANCHOR_RIGHT")
        GameTooltip:SetToyByItemID(itemID)
        GameTooltip:Show()
        DebugPrint("Setting macrotext for " .. toyName .. ": /use item:" .. itemID)
    end)
    
    button:SetScript("OnLeave", function(self)
        GameTooltip:Hide()
    end)
    
    button:SetScript("OnClick", function(self)
        print("Clicked toy: " .. toyName .. " " .. itemID)
        print("Macrotext: " .. self:GetAttribute("macrotext1"))
    end)
    
    -- Set macrotext for using the toy
    button:SetAttribute("type", "macro")
    button:SetAttribute("macrotext1", "/use item:" .. itemID)
    button:SetMouseClickEnabled(true)
    button:RegisterForClicks("AnyUp", "AnyDown")
    
    return button
end

Xrystal · 06-23-24, 09:30 AM

Looking at this page there is a UseToy function

https://warcraft.wiki.gg/wiki/API_UseToy

You could then use this example to create a button that uses the secure environment to use the toy on click

https://warcraft.wiki.gg/wiki/Secure...rClickTemplate

I'm still learning the limits and how tos of the secure environment myself but hopefully the example will help you figure out what you need to do for your project.

Fizzlemizz · 06-23-24, 11:07 AM

Instead of using the macro type (see the "toy" type information SecureActionButtonTemplate)

Lua Code:

local f = CreateFrame("Button", "ClickAToyButton", UIParent, "UIPanelButtonTemplate, SecureActionButtonTemplate")
f:SetSize(90, 40)
f:SetPoint("CENTER", UIParent, "CENTER", 100, 0)
f:SetText("Click Me!")
f:RegisterForClicks("AnyUp")
f:SetAttribute("type", "toy")
f:SetAttribute("*toy1", 108634) -- Crashin' Thrashin' Mortar Controller

The macrotext removal is not to stop "basic" things but a giant sledgehammer to stop what they see as some malicious things that have crept into the game over time (although it's still "under discussion" apparently).

Xrystal · 06-23-24, 12:46 PM

Ah, I was hoping there would be a toy equivalent for the attribute setting.

GerlockADUS · 06-23-24, 02:26 PM

I really appreciate the responses, as this is getting super frustrating. I've spent way to much time trying to get this to work.

Unfortunately, the code you provided is not activating the toy. I don't know what else to do.

Fizzlemizz · 06-23-24, 02:49 PM

Originally Posted by GerlockADUS

I really appreciate the responses, as this is getting super frustrating. I've spent way to much time trying to get this to work.

Unfortunately, the code you provided is not activating the toy. I don't know what else to do.

As per the forum reply:

You’re probably wanting to use the spell that is cast when you click the toy, not the toy itself (different button attributes for toys, items, spells etc.).
Toy 54452
https://www.wowhead.com/wotlk/item=5...thereal-portal
should cast
spell 75136
https://www.wowhead.com/spell=75136/ethereal-portal

Lua Code:

local toyButton
 
local function CreateToyButton()
    local _, toyName, toyTexture = C_ToyBox.GetToyInfo(75136)  -- Example: Ethereal Portal
    
    toyButton = CreateFrame("Button", "HearthToyButton", UIParent, "SecureActionButtonTemplate")
    toyButton:SetSize(41, 41)
    toyButton:SetNormalTexture(toyTexture or "Interface\\Icons\\INV_Misc_QuestionMark")
    toyButton:SetPoint("CENTER", UIParent, "CENTER")
    
    toyButton:SetScript("OnEnter", function(self)
        GameTooltip:SetOwner(self, "ANCHOR_RIGHT")
        GameTooltip:SetSpellByID(75136)  -- Update with the correct toy item ID
        GameTooltip:Show()
    end)
    
    toyButton:SetScript("OnLeave", function(self)
        GameTooltip:Hide()
    end)
    toyButton:SetAttribute("type", "spell")
    toyButton:SetAttribute("*spell1", 75136)
end
 
local eventFrame = CreateFrame("Frame")
eventFrame:RegisterEvent("PLAYER_LOGIN")
eventFrame:SetScript("OnEvent", function(self, event, arg1)
    if event == "PLAYER_LOGIN" then
        CreateToyButton()
    end
end)

GerlockADUS · 06-23-24, 03:22 PM

You're awesome for offering the suggestion. I thought it might be the answer, but unfortunately it is not working. I plan on developing this further if I can ever get this basic functionality to work. Maybe it's impossible.

I kept the item number in place to handle the texture and GameTooltip, but I changed the number in the button attribute section for the spell. (I also tried changing all references to the item number, but that didn't work either.).

Here is what I have:

Code:

local toyButton

local function CreateToyButton()
    local _, toyName, toyTexture = C_ToyBox.GetToyInfo(54452)  -- Example: Ethereal Portal
    
    toyButton = CreateFrame("Button", "HearthToyButton", UIParent, "SecureActionButtonTemplate")
    toyButton:SetSize(41, 41)
    toyButton:SetNormalTexture(toyTexture or "Interface\\Icons\\INV_Misc_QuestionMark")
    toyButton:SetPoint("CENTER", UIParent, "CENTER")
    
    toyButton:SetScript("OnEnter", function(self)
        GameTooltip:SetOwner(self, "ANCHOR_RIGHT")
        GameTooltip:SetToyByItemID(54452)  -- Update with the correct toy item ID
        GameTooltip:Show()
    end)
    
    toyButton:SetScript("OnLeave", function(self)
        GameTooltip:Hide()
    end)
    
    toyButton:RegisterForClicks("AnyUp")
    toyButton:SetAttribute("type", "spell")
    toyButton:SetAttribute("*spell1", 75136)
end

local eventFrame = CreateFrame("Frame")
eventFrame:RegisterEvent("PLAYER_LOGIN")
eventFrame:SetScript("OnEvent", function(self, event, arg1)
    if event == "PLAYER_LOGIN" then
        CreateToyButton()
    end
end)

Fizzlemizz · 06-23-24, 03:28 PM

I don't have the portal, are you sure your character does/can use?

The Dalaran Hearthstone is considered a toy.

Code:

toyButton:SetAttribute("type", "toy")
toyButton:SetAttribute("*toy1", 140192)

Maybe get idTip to check the toy ID in the Toybox.

GerlockADUS · 06-23-24, 03:42 PM

I can use the Ethereal Portal from the Toy Box or from my action bar. If I plug in the numbers for the Dalaran Hearthstone, it doesn't work either. My plan is to make a button that will show/hide a frame with all of the hearthstone toys that the character has collected, so you can use different ones, so it doesn't have to be Ethereal Portal.

Did you try and have success with the Dalaran Hearthstone?

Fizzlemizz · 06-23-24, 03:50 PM

Originally Posted by GerlockADUS

I can use the Ethereal Portal from the Toy Box or from my action bar. If I plug in the numbers for the Dalaran Hearthstone, it doesn't work either. My plan is to make a button that will show/hide a frame with all of the hearthstone toys that the character has collected, so you can use different ones, so it doesn't have to be Ethereal Portal.

Did you try and have success with the Dalaran Hearthstone?

This works for me:

Lua Code:

local f = CreateFrame("Button", "ClickAToyButton", UIParent, "UIPanelButtonTemplate, SecureActionButtonTemplate")
f:SetSize(90, 40)
f:SetPoint("CENTER", UIParent, "CENTER", 100, 0)
f:SetText("Click Me!")
f:RegisterForClicks("AnyUp")
f:SetScript("OnEnter", function(self)
    GameTooltip:SetOwner(self, "ANCHOR_RIGHT")
    GameTooltip:SetToyByItemID(140192)  -- Update with the correct toy item ID
    GameTooltip:Show()
end)
f:SetScript("OnLeave", function(self)
    GameTooltip:Hide()
end)
f:SetAttribute("type", "toy")
f:SetAttribute("*toy1", 140192) -- Dalaran Hrarthstone

GerlockADUS · 06-23-24, 04:02 PM

Interesting. I wonder why it's not working for me. It's the only addon that I have enabled.
Thank you for your help. I don't want to be a bother. I think I'm at a dead end, for now at least.

Fizzlemizz · 06-23-24, 04:07 PM

It' try exiting and renaming the Interface folder and let the game create a new one then create a single addon with new .toc and .lua file in it.
You can delete the new folder and rename the old one back.

This also works for me

Lua Code:

local toyButton
 
local function CreateToyButton()
    local _, toyName, toyTexture = C_ToyBox.GetToyInfo(140192)  -- Example: Ethereal Portal
    
    toyButton = CreateFrame("Button", "HearthToyButton", UIParent, "SecureActionButtonTemplate")
    toyButton:SetSize(41, 41)
    toyButton:SetNormalTexture(toyTexture or "Interface\\Icons\\INV_Misc_QuestionMark")
    toyButton:SetPoint("CENTER", UIParent, "CENTER")
    
    toyButton:SetScript("OnEnter", function(self)
        GameTooltip:SetOwner(self, "ANCHOR_RIGHT")
        GameTooltip:SetToyByItemID(140192)  -- Update with the correct toy item ID
        GameTooltip:Show()
    end)
    
    toyButton:SetScript("OnLeave", function(self)
        GameTooltip:Hide()
    end)
    
    toyButton:RegisterForClicks("AnyUp")
    toyButton:SetAttribute("type", "toy")
    toyButton:SetAttribute("*toy1", 140192)
end
 
local eventFrame = CreateFrame("Frame")
eventFrame:RegisterEvent("PLAYER_LOGIN")
eventFrame:SetScript("OnEvent", function(self, event, arg1)
    if event == "PLAYER_LOGIN" then
        CreateToyButton()
    end
end)

Fizzlemizz · 06-23-24, 04:18 PM

You might also have the actionButtonUseyKeyDown CVar set (I keep forgetting that one).
Try replacing your RegisterForClicks with

Code:

toyButton:RegisterForClicks("AnyDown", "AnyUp")

GerlockADUS · 06-23-24, 05:20 PM

YYEEEEESSSSSS!!!!!! This was it! And I could have sworn that I tried that before!

THANK YOU!!