Can i check to see if a player has landed?

[Txeptsyip]

and also how can I check to see if a specific aura getting removed or added (druid flight form) is the one that just triggered the unit_aura event?

I'm basically trying to write an addon that plays the free bird solo when I cancel flight form in order to lose height quickly

here is what I have so far (the runnextframe is because otherwise you haven't had time to start falling when the isfalling check happens)

function freebird_onEvent (self, event, unit, info)
    Unit = unit
    
    RunNextFrame(function() freebird_dothing() end)
end
 
function freebird_dothing ()
    if Unit == "player" then
        if IsFalling() then
            print("falling")
            PlayMusic"Interface\\AddOns\\FreeBird\\freebird.mp3"
        else
            print("not falling")
            StopMusic()
        end
    end
end
 
local f = CreateFrame("Frame")
f:RegisterEvent("UNIT_AURA")
f:SetScript("OnEvent", freebird_onEvent)

I did find this https://wowpedia.fandom.com/wiki/UNIT_AURA and modifying part of the script it has an example I can get a message to print the spellID but I am unsure how I just directly access the spell ID (just going into.addedAuras.spellId does not appear to work)

[Fizzlemizz]

There's probably a better way but maybe something along the lines of:

local AuraInstanceID
local function TestFalling()
    if IsFalling() then
        PlayMusic("Interface\\AddOns\\FreeBird\\freebird.mp3")
    end
end
 
local function freebird_onEvent (self, event, unit, info)
    if info.addedAuras then
        for k, v in pairs(info.addedAuras) do
            if v.spellId == 783 then -- travel form
                AuraInstanceID = v.auraInstanceID
                StopMusic()
                break
            end
        end
    end
    if info.removedAuraInstanceIDs then
        for k, v in pairs(info.removedAuraInstanceIDs) do
            if v == AuraInstanceID then
                AuraInstanceID = nil
                RunNextFrame(TestFalling)
                break
            end
        end
    end
end
 
local f = CreateFrame("Frame")
f:RegisterUnitEvent("UNIT_AURA", "player")
f:SetScript("OnEvent", freebird_onEvent)

[Txeptsyip]

ah i see so i have to use that odd "in pairs" thing to access those values (I'm not entirely sure what that is doing i'm new to LUA and it does things in ways I don't like why can't I just use something nice like C#?)

anyway so I had a thought about the detecting if on ground thing and decided to try making a while loop that would check if falling and if not falling stop the music

as you can imagine that crashed my game and that's how I found out that a while loop in an addon will stop the entire game while it does its whiling

so I spun that off into its own function and did a recursive C_Timer.After as shown here https://wowpedia.fandom.com/wiki/API_C_Timer.After

this is the code I have now after taking what you did and adding my loop to it (this is for cata classic so the spellID has been changed to that and I remembered to take out my debug print statements this time)

I also added some slash commands under /fb1 (/fb1 original and /fb1 harmonica) and updated the .toc to make Music a saved variable

Music = "Interface\\AddOns\\FreeBird\\freebird.mp3"
 
local Falling
local function freeBird_Loop()
    if IsFalling() == false then
        StopMusic()
        Falling = false
    end
    if Falling then C_Timer.After(0.5, freeBird_Loop) end
end
 
local AuraInstanceID
local function testFalling()
    if IsFalling() then
        PlayMusic(Music)
        Falling = true
        freeBird_Loop()
    end
end
 
local function freeBird_onEvent(self, event, unit, info)
    if info.addedAuras then
        for _, v in pairs(info.addedAuras) do
            if v.spellId == 40120 then -- cata swift flight form
                AuraInstanceID = v.auraInstanceID
                StopMusic()
                break
            end
        end
    end
    if info.removedAuraInstanceIDs then
        for _, v in pairs(info.removedAuraInstanceIDs) do
            if v == AuraInstanceID then
                AuraInstanceID = nil
                RunNextFrame(testFalling)
                break
            end
        end
    end
end
 
SLASH_FREEBIRD1 = "/fb1"
SlashCmdList["FREEBIRD"] = function(msg)
    if msg == "original" then
        Music = "Interface\\AddOns\\FreeBird\\freebird.mp3"
    elseif msg == "harmonica" then
        Music = "Interface\\AddOns\\FreeBird\\FreeBirdHarmonica.mp3"
    else
        print("/fb1 original, /fb1 harmonica")
    end
end
 
local f = CreateFrame("Frame")
f:RegisterUnitEvent("UNIT_AURA", "player")
f:SetScript("OnEvent", freeBird_onEvent)

[SDPhantom]

Originally Posted by Txeptsyip ah i see so i have to use that odd "in pairs" thing to access those values (I'm not entirely sure what that is doing ...)

for ... in is a variant of for that loops through a given iterator to obtain one or more values.
pairs() returns an iterator that loops through a table, returning all of its key-value pairs.

The combination of these is the standard way to loop through tables.

For more information:
Lua 5.1 Reference Manual §2.4.5 - For Statement
Lua 5.1 Reference Manual - pairs()



On another note, you should choose a unique name for any global variables you create. The Lua environment is shared among the entire UI including other addons running and name collisions are a possibility. Common practice is to prefix your variable name with the name of your addon. For example, your SavedVariable should be named something like FreeBird_Music.

[Txeptsyip]

Originally Posted by SDPhantom On another note, you should choose a unique name for any global variables you create. The Lua environment is shared among the entire UI including other addons running and name collisions are a possibility. Common practice is to prefix your variable name with the name of your addon. For example, your SavedVariable should be named something like FreeBird_Music.

yes someone in my guild just pointed that out to me so I changed it to FreeBirdSavedMusic because its long and has more words