Extract "wow-update-12759.mpq"... meh!

[Ladik]

Originally Posted by Borlox Is there a way to open a patch archive for multiple mpqs? I'm trying to hack support for the wow-update-*.mpqs into the WoWModelViewer. My first idea was to open all the patch archives for each mpq, but that doesn't work, as they may be opened just one time. Does anybody have a better idea, or is anyone already working on this?

Is MPQ support in WoWModelViewer based on StormLib ?

[Borlox]

Originally Posted by Ladik Is MPQ support in WoWModelViewer based on StormLib ?

Yep.
As far as I understand the code all archives are opened at the beginning. To open a file the code goes through all of them and tries to open the file, storing the content and returning if successful.

[Ladik]

Originally Posted by Borlox Yep. As far as I understand the code all archives are opened at the beginning. To open a file the code goes through all of them and tries to open the file, storing the content and returning if successful.

I'll change it so when an MPQ is open for read only, it can be open multiple times.
Edit: it should be possible - MPQs are open with FILE_SHARE_READ, and GENERIC_READ if MPQ_OPEN_READ_ONLY is specified in SFileOpenArchive.

[Borlox]

Originally Posted by Ladik I'll change it so when an MPQ is open for read only, it can be open multiple times. Edit: it should be possible - MPQs are open with FILE_SHARE_READ, and GENERIC_READ if MPQ_OPEN_READ_ONLY is specified in SFileOpenArchive.

Here is a minimal test case.
Executed in Cataclysm\Data it always gives me

Failed to add patch archive for exp3: 32

Error code 32 is ERROR_SHARING_VIOLATION "The process cannot access the file because it is being used by another process."

All MPQs are opened with MPQ_OPEN_READ_ONLY.

[Ladik]

Ah, I see the problem now. Even if the base MPQs are open for read only, the patches are still opened for writing. It's a bug in StormLib, I'll fix that soon.

Also, I am going to change the patch interface a bit, I believe that it will be easier to use and more flexible. The point is that I remove SFileSetPatchPathPrefix, and the patch prefix will be parameter to SFileOpenPatchArchive instead. This will allow to have different patch prefix for each patch MPQ (perhaps this will be needed for future MPQs).

I believe it's better to do it now, when it's still early released (and BETA after all), than later, when loads of application will have to be recompiled.

[Borlox]

Originally Posted by Ladik Ah, I see the problem now. Even if the base MPQs are open for read only, the patches are still opened for writing. It's a bug in StormLib, I'll fix that soon. Also, I am going to change the patch interface a bit, I believe that it will be easier to use and more flexible. The point is that I remove SFileSetPatchPathPrefix, and the patch prefix will be parameter to SFileOpenPatchArchive instead. This will allow to have different patch prefix for each patch MPQ (perhaps this will be needed for future MPQs). I believe it's better to do it now, when it's still early released (and BETA after all), than later, when loads of application will have to be recompiled.

Great news

[silkfire]

Originally Posted by Ladik Is MPQ support in WoWModelViewer based on StormLib ?

Ladik every time you update the StormLib - chuanshing, wowmodelviewer's developer, updates the modelviewer so that it utilizes it.

Fresh update:
http://code.google.com/p/wowmodelvie...e/detail?r=368

http://code.google.com/p/wowmodelviewer/updates/list

[Ladik]

Originally Posted by silkfire Ladik every tome you update the StormLib chuanshing, wowmodelviewer's developer updates the modelviewer to use it.

Ah right, he sends me e-mails from time to time. Hi, Chuanshing :-)