1. You do not need to keep calling x:SetParent(f) when f is already the parent of x because you specified that in the CreateFrame call.
2a. I'd strongly suggest using descriptive variable names, so that when you are looking at this code weeks, months, or even years later you can immediately tell what's what instead of having to puzzle out what a single-letter variable like "g" means.
2b. Similarly, you should keep all of the code related to, for example, the border in the same place instead of putting half of it in one place, and the other half 20 lines later for no apparent reason. It might make sense *now* but will it still make sense 6 months from now? Will it make sense to people trying to help you identify and fix bugs, or add features to your code?
3. I'd recommend against giving every frame, texture, and font string a global name. The only real reasons to give anything a global name are (a) the object is a saved variable, or (b) the object is a top-level addon frame/table and you want it to be accessible to other addons or by in-game /run commands, or (c) you will be using Blizzard templates/functions that are designed to work with Blizzard UI objects with specific global names for their regions and children. Since none of those are the case here, global names aren't needed.
Lua Code:
-- Create a table to hold all of the units you want to add debuff icons to.
-- To add new units, simply add them to the table; no code modifications are required!
-- The keys in each unit's table define where to place the icons relative to the frame.
local debuffIcons = {
target = {
frame = "TargetFrame", pointA = "TOPLEFT", pointB = "BOTTOMLEFT", x = 30, y = 0, spacing = 7,
}
arena1 = {
frame = "ArenaEnemy1Frame", pointA = "TOPLEFT", pointB = "BOTTOMLEFT", x = 30, y = 0, spacing = ,
},
arena2 = {
frame = "ArenaEnemy2Frame", pointA = "TOPLEFT", pointB = "BOTTOMLEFT", x = 30, y = 0, spacing = 7,
},
}
for unit, unitTable in pairs(debuffIcons) do
local frameName = unitTable.frame
local frame = _G[frameName]
-- Attach the table to the frame so it's easier to access in-game
-- if you need to do that, eg. for testing with /run commands.
frame.debuffIcons = unitTable
for i = 1, 10 do
local f = CreateFrame("Button", frame, UIParent)
if i == 1 then
f:SetPoint(unitTable.pointA, frame, unitTable.pointB unitTable.x, unitTable.y)
else
f:SetPoint("LEFT", unitTable[i-1], "RIGHT", unitTable.spacing, 0)
end
f:SetWidth(20)
f:SetHeight(20)
f:Hide()
local cd = CreateFrame("Cooldown", nil, f)
cd:SetAllPoints(true)
cd:SetReverse(true)
cd:SetDrawEdge(true)
f.cd = cd
local count = f:CreateFontString(nil, "OVERLAY", "NumberFontNormalSmall")
count:SetPoint("BOTTOMRIGHT", 18, -10)
f.count = count
local icon = f:CreateTexture(nil, "ARTWORK")
icon:SetAllPoints(true)
icon:SetTexCoord(.08, .92, .08, .92)
f.icon = icon
local border = f:CreateTexture(nil, "OVERLAY")
border:SetPoint("CENTER")
border:SetHeight(25)
border:SetWidth(25)
border:SetTexture("Interface\\Buttons\\UI-Debuff-Overlays")
border:SetTexCoord(0.296875, 0.5703125, 0, 0.535625)
f.border = border
unitTable[i] = f
end
end
local eventFrame = CreateFrame("Frame")
eventFrame:RegisterEvent("UNIT_AURA")
eventFrame:SetScript("OnEvent", function(self, event, unit)
if not units[unit] then
-- We don't care about this unit. Quit.
return
end
-- Get the table containing the buttons for this unit.
local icons = units[unit]
for i = 1, 10 do
-- Get the button for this slot.
local button = icons[i]
-- Get information about the debuff in this slot, if any.
local name, _, icon, count, debuffType, duration, timeLeft = UnitDebuff("target", i)
if name then
-- There is a debuff in this slot.
-- Populate the button accordingly, and show it.
local color = debuffType and DebuffTypeColor[debuffType]
button.border:SetVertexColor(color.r, color.g, color.b)
if duration > 0 then
button.cd:Show()
CooldownFrame_SetTimer(button.cd, timeLeft - duration, duration, 1)
else
button.cd:Hide()
end
if count > 0 then
button.count:SetText(count)
button.count:Show()
button.count:SetDrawLayer("OVERLAY")
else
button.count:Hide()
end
button.icon:SetTexture(icon)
button:Show()
else
-- There is no debuff in this slot.
-- Clear the button, and hide it.
button.cd:Hide()
button.count:SetText("")
button.icon:SetTexture("")
button:Hide()
end
end
end)
Linear Mode
