Thread Tools Display Modes
04-19-12, 02:52 PM   #1
Phrequency-
A Murloc Raider
Join Date: Mar 2010
Posts: 4
Updating an addon?

Not sure if this is the right forum to post this but, how hard is it to go about updating an addon for the current patch/build?

There's this announce addon (http://wow.curseforge.com/addons/announce/) I used in WoTLK and it was the best announcing addon I've used.

EDIT:

I'm looking for someone who is willing to help me update it in order to get it fully functional so we can upload it once again.

Thank you!

Last edited by Phrequency- : 04-19-12 at 04:44 PM.
  Reply With Quote
04-19-12, 03:09 PM   #2
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,360
It's not too hard... maybe confusing for someone that's never looked at code before but you basically only need to modify this
Code:
function Announce:COMBAT_LOG_EVENT_UNFILTERED(_,timestamp,event,playerGUID,playerName,_,targetGUID,targetName,targetFlags,spellID,_,_,otherspellID)
at line 829 of Announce.lua
to match the proper number of arguments for WoW 4.x according to this page: COMBAT_LOG_EVENT_UNFILTERED

Insert throwaway variables _ where the new arguments have been added.

Edit:Try replacing the line I mentioned above (829 of Announce.lua) with this one
Code:
function Announce:COMBAT_LOG_EVENT_UNFILTERED(_,timestamp,event,_,playerGUID,playerName,_,_,targetGUID,targetName,targetFlags,_,spellID,_,_,otherspellID)
That should make it working but you might need to update some of the spells it's tracking if something was removed or added in the game.

Last edited by Dridzt : 04-19-12 at 03:19 PM.
  Reply With Quote
04-19-12, 03:28 PM   #3
Phrequency-
A Murloc Raider
Join Date: Mar 2010
Posts: 4
Yeah I got it. Thank a lot!

I'll work on updating the spells.
  Reply With Quote
04-19-12, 04:45 PM   #4
Phrequency-
A Murloc Raider
Join Date: Mar 2010
Posts: 4
Bump. Edited the first post. Looking for someone to update it with me.
  Reply With Quote
04-19-12, 06:57 PM   #5
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,961
there looks like a similar addon already working for 4.3 on this site already ... perhaps someone else had already done the reworking, who knows :

http://www.wowinterface.com/download...Announcer.html

Might be worth seeing how that works for you. Perhaps the programmer for that one will consider adding functionality into their version of the addon.
__________________


Characters:
Gwynedda - 70 - Demon Warlock
Galaviel - 65 - Resto Druid
Gamaliel - 61 - Disc Priest
Gwynytha - 60 - Survival Hunter
Lienae - 60 - Resto Shaman
Plus several others below level 60

Info Panel IDs : http://www.wowinterface.com/forums/s...818#post136818
  Reply With Quote
04-19-12, 07:00 PM   #6
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Mod
Featured
Join Date: Oct 2006
Posts: 10,860
According to that Curseforge page, the addon is:
License
All Rights Reserved
This means that you do not have permission (unless explicitly stated by the original author) to update/upload the addon.
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

  Reply With Quote
04-19-12, 07:03 PM   #7
Phrequency-
A Murloc Raider
Join Date: Mar 2010
Posts: 4
Oh well I'm dumb. I won't mess with it then.

Last edited by Phrequency- : 04-19-12 at 07:06 PM.
  Reply With Quote
04-20-12, 01:23 AM   #8
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Well, Curse (rightly) defaults to "All Rights Reserved" if the addon's author didn't specify a license, so that doesn't necessarily mean that the author is opposed to anyone fixing his addon. Have you tried sending him a PM and/or email through Curse asking for permission to update the addon? If he isn't working on it or playing WoW anymore, he probably won't mind, if you can get in touch with him.

Also, if you want to fix your locally installed copy that's fine, and that's how most of us got started writing addons. You just can't upload (distribute) it publicly without the original author's permission.

Last edited by Phanx : 04-20-12 at 01:27 AM.
  Reply With Quote

WoWInterface » Developer Discussions » General Authoring Discussion » Updating an addon?


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off