oUF Tags

[zork]

I just came back and wanted to try the latest oUF. But since December sth. in the tag system has changed or sth. At least this is giving me errors.

  oUF.Tags["[d3o2abshp]"] = function(unit) 
    local v = UnitHealth(unit)
    local string = ""
    if UnitIsDeadOrGhost(unit) == 1 then
      string = "dead"
    elseif UnitIsConnected(unit) == nil then
      string = "off"
    else
      string = do_format(v)
    end  
    return string
  end
  oUF.TagEvents["[d3o2abshp]"] = "UNIT_HEALTH"

Call

local targetframe_health_tag = "[d3o2abshp] / [perhp]%"
    local hpval = SetFontString(self.Health, d3font, 14, "THINOUTLINE")
    hpval:SetPoint("RIGHT", self.Health, "RIGHT", -2, 2)
    self:Tag(hpval, targetframe_health_tag)

Error


What do I need to change to make it work, I checked oUF.Tag function from other layouts and they seem to be the same as mine. No clue?

[v6o]

The only time I get that error is when I define a tag after the spawning of unitframe.
You sure your tags are loading before?

[zork]

Well they get defined in the code before I spawn any unit, so yes I think so.

[yj589794]

If you are using the bleeding edge oUF from Haste's GitHub repository, then how you define tags has slightly changed.

You no longer add the square braces within the tag name when you define it, but you still need them when assigning a tag to a fontstring.


I've updated my own unit frames to be compatible with the changes made to oUF, so you can check out the tags are used there :
http://github.com/Evilpaul/oUF_EP/



Also remembered this post by Haste detailing some of the changes in how tags are used:
http://www.wowinterface.com/forums/s...1&postcount=24

[zork]

Thanks, that seems reasonable. And yes I was using the github oUF master. The ComboPoint stuff seems to have changed aswell.

You are using

if showCombo then
  local cpoints = self:CreateFontString(nil, 'OVERLAY')
  cpoints:SetPoint('RIGHT', self, 'LEFT', -config.SPACING, 0)
  cpoints:SetFont(config.FONT, config.FONTSIZELARGE, config.FONTBORDER)
  cpoints:SetJustifyH('RIGHT')
  self:Tag(cpoints, '|cffffffff[cpoints]|r')
end

So I guess there is a CPoints Tag now. Gonna try it out.

[yj589794]

Yeah, for a text representation of combo points there is a new tag. The combo points module is now only for displaying an increasing number of icons based on how many combo points you have.

[haste]

You might want to note that the tag functions are given their own little proxy environment in 1.4. So I would recommend writing _TAGS.perhp and not oUF.Tags.perhp.

I have also renamed _CLASS_COLORS to just _COLORS, as it now exposes self.colors and not just self.colors.class.

I also plan on making some minor optimizations to tags, mainly making iteratorless functions for font strings containing only 1 to 3 tags. I haven't done any benchmarking of minor gains yet however.

[zork]

If you hand out examples on how to include your ideas no problem. Whatever floats your boat. (Damn I love BBT btw...)

[haste]

elements/tags.lua is built around the same restrictions that are imposed on external tags (unlike how it was in 1.3). It should serve as a decent example of how things should be written.

I'd love to write some proper docs on the wiki, but right now I barely have time to answer stuff on the forums here. The only reason I'm even posting so far this week is because I squeeze it in between other stuff while at work.

[Rostok]

I don't know if this is revelant but when i tried oUF 1.4 last day, i got errors similar.
The bracket around the name of the tag was the source of the error in the declaration :
i thought i was doing it wrong so i change
oUF.Tags["[sthg]"] to oUF.Tags["sthg"] and no more errors.

[haste]

Originally Posted by Rostok I don't know if this is revelant but when i tried oUF 1.4 last day, i got errors similar. The bracket around the name of the tag was the source of the error in the declaration : i thought i was doing it wrong so i change oUF.Tags["[sthg]"] to oUF.Tags["sthg"] and no more errors.

Yes, the brackets were removed from the table keys in 1.4. It was really something which was suppose to be done before a release with tags were made, but that was forgotten :P.

[Rostok]

Ok, I got it working so it's cool. Maybe zork's tags are also concerned by this change as they have the brackets.