pp tag not updating for focus, but focustarget fine?

[MoonWitch]

Hai ...

For some obscure reason --
My Focus' power tag doesn't seem to update as it should. It seems to not see depletion or replenishment until I cast an HP changing buff. (Heals have no effect). The powerbar (when enabled) shows up fine. Did I make an oopsie?

Funny note : The code is the same as Focustarget, which does work fine.

(Player, Target, ToT, FocusTarget, Pet all work fine.)

elseif unit == "focus" or unit == "focustarget" then
		self.Name = SetFontString(self.Health, font, fontSize+1, "LEFT", self.Health, "LEFT", 2, 0)
		self:Tag(self.Name, "[raidcolor][shortname] [dead]")
		
		self.Health.value = SetFontString(self.Health, font, fontSize+1, "RIGHT", self.Health, "RIGHT", -2, 0)
		self:Tag(self.Health.value, "[colorperpp]%|r | [perhp]%")

ANd the tags themselves -- credit to P3lim btw

oUF.Tags["[colorperpp]"] = function(unit)
	local _, str = UnitPowerType(unit)
	return ('%s%d'):format(hex(colors.power[str] or {1, 1, 1}), oUF.Tags['[perpp]'](unit) or '')
end

[haste]

Are you assigning any events to your tag?

You should also move that table outside the tag function.
It should also return nothing (nil) and not '' when it fails, which means you can't use the logic short cut.

[MoonWitch]

Uhm .... I copied from, p3lim and ...

oUF.Tags["[colorpp]"] = function(unit) -- from p3lim"s excellently coded layout
	local _, str = UnitPowerType(unit)
	return ('%s%d|r'):format(hex(colors.power[str] or {1, 1, 1}), oUF.Tags['[curpp]'](unit) or '')
end

oUF.Tags["[colorperpp]"] = function(unit)
	local _, str = UnitPowerType(unit)
	return ('%s%d'):format(hex(colors.power[str] or {1, 1, 1}), oUF.Tags['[perpp]'](unit) or '')

Those work fine. Also, focustarget uses the exact same code, and works fine.

[haste]

Originally Posted by MoonWitch Those work fine. Also, focustarget uses the exact same code, and works fine.

focustarget isn't a real unit, and has a completely different update path.

oUF.TagEvents["[colorpp]"] = oUF.TagEvents["[curpp]"]

Alternatively you could have [colorpp] just return the color and use [curpp] manually after it, which would make it piggyback ride on the [curpp] events.

Oh, and generic names are bad (even though the 1.3.x tag system kinda enforces them).

[MoonWitch]

Well, the update difference would explain it. I thought all units followed the same update method/timing.

Focustarget was always something iffy to me, but since I've been healing ICC it's handy :P As a disc priest, I gotta prep for incoming dmg, if I see anyone but the tanks targetted, I'll bubble em ahead of dmg

Anyhow :
I'll try it how you said it and change all tags to a line-up how you suggested.

oUF.Tags["[colorpp]"] = function(unit)
	local _, str = UnitPowerType(unit)
	local coloredmana = colors.power[str]
	return coloredmana and string.format("|cff%02x%02x%02x", coloredmana[1] * 255, coloredmana[2] * 255, coloredmana[3] * 255)
end

I'm assuming this is how you meant it? Can't recall where I got this, it's in an older layout of mine to resemble Caith's UI

Update :
Well, with the changes you proposed it worked!!! Thanks