KuiNameplates Quest Icon Modification

[dronerpine]

Hello, I could use some help from someone familiar with modifying KuiNameplates. I'm trying to change the Y position of the Quest Icon depending on whether the creature is attackable (basically if it has a healthbar, as I've turned HP bars off on Friendlies) or not.

Here is the code from KNP Core/create.lua. Most of it is default KuiNameplates code. QUEST_ICON_Y is set to 10, for comparison.

do
    local SHOW_QUEST_ICON,QUEST_ICON_SIZE,QUEST_ICON_POINT,
          QUEST_ICON_X,QUEST_ICON_Y
    local function Init(icon,frame)
        icon:ClearAllPoints()
        icon:SetSize(QUEST_ICON_SIZE,QUEST_ICON_SIZE)
 
       if not frame.state.attackable then
            icon:SetPoint(POINT_ASSOC[QUEST_ICON_POINT],
            QUEST_ICON_X,QUEST_ICON_Y)
        else
            icon:SetPoint(POINT_ASSOC[QUEST_ICON_POINT],
            QUEST_ICON_X,40)
        end
        
    end
    local function UpdateQuestIcon(frame)
        if SHOW_QUEST_ICON and frame.state.quest then
            frame.QuestIcon:Show()
        else
            frame.QuestIcon:Hide()
        end
    end
    function core:CreateQuestIcon(frame)
        local icon = frame:CreateTexture(nil,'ARTWORK',nil,6)
        icon:SetAtlas('QuestNormal')
        icon:Hide()
        Init(icon,frame)
 
        frame.QuestIcon = icon
        frame.UpdateQuestIcon = UpdateQuestIcon
    end
    function core:configChangedQuestIcon()
        SHOW_QUEST_ICON = self.profile.show_quest_icon
        QUEST_ICON_SIZE = self:Scale(self.profile.quest_icon_size)
        QUEST_ICON_POINT = self.profile.quest_icon_point
        QUEST_ICON_X = self:Scale(self.profile.quest_icon_x)
        QUEST_ICON_Y = self:Scale(self.profile.quest_icon_y) --This has been set to 10 in the settings, for comparison
 
        if SHOW_QUEST_ICON then
            --update existing icons...
            for _,f in addon:Frames() do
                if f.QuestIcon then
                    Init(f.QuestIcon,f)
                end
            end
        end
    end
end

Here's how it looks on mobs:

Notice that even though the enemy mob is attackable, it's tripping as not frame.state.attackable. The neutral mob is unattackable so it executed correctly for him.

Here's how it SHOULD look like for enemy mobs:


My suspicion is that me calling 'frame' into Init(icon, frame) is not passing the correct information. I can provide the original code for comparison, if necessary.

[dronerpine]

Got it working by creating separate functions that set the icon's points when Kui updates the icon rather than at creation. For some reason 'frame' returns nil for 'frame.state.attackable' and 'frame.IN_NAMEONLY' in the CreateQuestIcon function but returns actual values in the UpdateQuestIcon function. Maybe because CreateQuestIcon isn't self:.

I don't know if the code's optimal and I'm using numbers instead of config variables since it's just for my purposes, but here it is if anyone's interested:

do
    local SHOW_QUEST_ICON,QUEST_ICON_SIZE,QUEST_ICON_POINT,
          QUEST_ICON_X,QUEST_ICON_Y
    local function Init(icon)
        icon:ClearAllPoints()
        icon:SetSize(QUEST_ICON_SIZE,QUEST_ICON_SIZE)
        icon:SetPoint(POINT_ASSOC[QUEST_ICON_POINT],
            QUEST_ICON_X,QUEST_ICON_Y)
    end
    local function InitI(icon)
        icon:SetPoint(POINT_ASSOC[QUEST_ICON_POINT],
            QUEST_ICON_X,QUEST_ICON_Y)
    end
    local function InitF(icon)
        icon:SetPoint(POINT_ASSOC[QUEST_ICON_POINT],
            QUEST_ICON_X,45)
    end
    local function UpdateQuestIcon(frame)
        if SHOW_QUEST_ICON and frame.state.quest and frame.IN_NAMEONLY then
            InitI(frame.QuestIcon)
            frame.QuestIcon:Show()
        elseif SHOW_QUEST_ICON and frame.state.quest and not frame.IN_NAMEONLY then
            InitF(frame.QuestIcon)
            frame.QuestIcon:Show()
        else
            frame.QuestIcon:Hide()
        end
    end
    function core:CreateQuestIcon(frame)
        local icon = frame:CreateTexture(nil,'ARTWORK',nil,6)
        icon:SetAtlas('QuestNormal')
        icon:Hide()
        Init(icon)
                
        frame.QuestIcon = icon
        frame.UpdateQuestIcon = UpdateQuestIcon
    end
    function core:configChangedQuestIcon()
        SHOW_QUEST_ICON = self.profile.show_quest_icon
        QUEST_ICON_SIZE = self:Scale(self.profile.quest_icon_size)
        QUEST_ICON_POINT = self.profile.quest_icon_point
        QUEST_ICON_X = self:Scale(self.profile.quest_icon_x)
        QUEST_ICON_Y = self:Scale(self.profile.quest_icon_y)
 
        if SHOW_QUEST_ICON then
            -- update existing icons...
            for _,f in addon:Frames() do
                if f.QuestIcon then
                    Init(f.QuestIcon)
                end
            end
        end
    end
end