WoWInterface - Trying to move CompactRaidFrameManager

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Trying to move CompactRaidFrameManager (https://www.wowinterface.com/forums/showthread.php?t=48445)

Trying to move CompactRaidFrameManager

Hi and sorry if recently I have posted a lot. This is the last issue I have till my UI should be finished.

I want to move the CompactRaidFrameManager window on the left as its in the way of my chat box as I have it at the top left corner instead. To move it I used the following code:

Lua Code:

function eventHandlers.PLAYER_ENTERING_WORLD()
    if CompactRaidFrameManager:IsVisible() then
        local point, relativeTo, relativePoint, xOfs, yOfs = CompactRaidFrameManager:GetPoint()
        CompactRaidFrameManager:SetPoint(point, relativeTo, relativePoint, xOfs, -300)
    end
end
 
 
CompactRaidFrameManagerToggleButton:HookScript("OnClick", function()
    if CompactRaidFrameManager:IsVisible() then  
        local point, relativeTo, relativePoint, xOfs, yOfs = CompactRaidFrameManager:GetPoint()
        CompactRaidFrameManager:SetPoint(point, relativeTo, relativePoint, xOfs, -300)
    end
end)

This works however if you click the "CompactRaidFrameManagerToggleButton" Button while in combat it resets its position. I have been looking for a solution and found the code below but it doesn't do anything, most likely because I'm using it wrong and not sure what to do with it.

Lua Code:

if CompactRaidFrameManager.collapsed then    
        CompactRaidFrameManager:SetScript("OnUpdate", nil)
end

Thought I might as well ask for help in case someone has encountered this issue before and knows a fix. Greatly appreciated! Thank you for reading :)

I've tried using hooksecurefunction and hook script to try to get this to work but it all comes down to the issue where I'm in combat and I use the CompactRaidFrameManager button which then resets its position. I got fed up with this and used an OnUpdate handler (the code below) but even this will not work while I'm in combat which does not make any sense to me. Surely this OnUpdate function should work regardless of whether I'm in combat or not and then Blizzard Compact Raid Frame Manager code seems to mention nothing at all about being in combat so no idea whats blocking it.

Lua Code:

local e = 0
local CompactOnUpdate = CreateFrame("Frame")
CompactOnUpdate:SetScript('OnUpdate', function(self, elapsed)
    e = e + elapsed
    if e >= 2 then
        if CompactRaidFrameManager:IsVisible() then
        local point, relativeTo, relativePoint, xOfs, yOfs = CompactRaidFrameManager:GetPoint()
        CompactRaidFrameManager:SetPoint(point, relativeTo, relativePoint, xOfs, -300)
        end
        e = 0
    end
end)

I've managed to get it to work while out of combat and I've just made it so that you cannot click the ToggleButton while in combat. That avoids it from moving location on its own. Very odd that I cannot alter it at all while in combat but will just have to settle for it.

Quote:

Originally Posted by Mayron (Post 286617)

Very odd that I cannot alter it at all while in combat ...

It's not odd at all. You cannot programmatically move (or show, hide, resize, etc.) secure frames while in combat.

Quote:

Originally Posted by Phanx (Post 286626)

It's not odd at all. You cannot programmatically move (or show, hide, resize, etc.) secure frames while in combat.

Ah okay, was trying to find out how the default compact raid frame manager does it in combat but couldn't but ah well :/

Quote:

Originally Posted by Mayron (Post 286658)

Ah okay, was trying to find out how the default compact raid frame manager does it in combat but couldn't but ah well :/

The default (that is, Blizzard own) code is cheating. Simple as that.

Yep. Blizzard's code is not subject to the same restrictions as addons. That's why they can call CastSpellByName, even though addons have been forbidden from calling that function since TBC.

I also have been playing this recently:

Lua Code:

hooksecurefunc("CompactRaidFrameManager_Expand", function(self)
    if MovAny:IsModified(self) then
        MovAny:UnlockPoint(self)
        local point, relativeTo, relativePoint, xOfs, yOfs = self:GetPoint(1)
        self:ClearAllPoints()
        self:SetPoint("TOPLEFT", UIParent, "TOPLEFT", xOfs + 175, yOfs)
        MovAny:LockPoint(self)
    end
end)
hooksecurefunc("CompactRaidFrameManager_Collapse", function(self)
    if MovAny:IsModified(self) then
        MovAny:UnlockPoint(self)
        local point, relativeTo, relativePoint, xOfs, yOfs = self:GetPoint(1)
        self:ClearAllPoints()
        self:SetPoint("TOPLEFT", UIParent, "TOPLEFT", xOfs - 175, yOfs)
        MovAny:LockPoint(self)
    end
end)
-- Before you hide it to keep the raidframes:
if fn == "CompactRaidFrameManager" then
    if InCombatLockdown() or UnitAffectingCombat("player") then
        return
    end
    f:UnregisterAllEvents()
    CompactRaidFrameContainer:SetParent(UIParent)
end
-- Before you reshow it, reparent and repoint raidframe to it:
if fn == "CompactRaidFrameManager" then
    if InCombatLockdown() or UnitAffectingCombat("player") then
        return
    end
    f:RegisterEvent("DISPLAY_SIZE_CHANGED")
    f:RegisterEvent("UI_SCALE_CHANGED")
    f:RegisterEvent("GROUP_ROSTER_UPDATE")
    f:RegisterEvent("UNIT_FLAGS")
    f:RegisterEvent("PLAYER_FLAGS_CHANGED")
    f:RegisterEvent("PLAYER_ENTERING_WORLD")
    f:RegisterEvent("PARTY_LEADER_CHANGED")
    f:RegisterEvent("RAID_TARGET_UPDATE")
    f:RegisterEvent("PLAYER_TARGET_CHANGED")
    CompactRaidFrameContainer:ClearAllPoints()
    CompactRaidFrameContainer:SetParent(f)
    MovAny:UnlockPoint(CompactRaidFrameContainer)
    CompactRaidFrameContainer:SetPoint("TOPLEFT", CompactRaidFrameManagerContainerResizeFrame, "TOPLEFT", 4, - 7)
end
 
function MovAny:UnlockPoint(f)
    f.MAPoint = nil
end
 
function MovAny:LockPoint(f, opt)
    if not f.MAPoint then
        if f:GetName() and (MovAny.lForcedLock[f:GetName()] or (opt and opt.forcedLock))  then
            if not f.MASetPoint then
                f.MASetPoint = f.SetPoint
                f.SetPoint = MovAny.fVoid
            end
        else
            if not f.MALockPointHook then
                hooksecurefunc(f, "SetPoint", MovAny.hSetPoint)
                f.MALockPointHook = true
            end
            f.MAPoint = {f:GetPoint(1)}
        end
    end
end
 
fVoid = function() end

"MovAny:IsModified(self)" determines if the frame's position is modified or it's in the default position.

The moving functions should not be a problem, just don't let it move it in combat.

The advantage of this, when you move the Manager to another position the toggle panel button will work perfectly on that spot too.

long-standing issue, with the crumbs from this thread and DejaPRFader i've managed to consolidate the functionality.
for anyone interested, here it is.
https://legacy.curseforge.com/wow/ad...idframemanager

source code for people just wanting a quick understanding for their own implementations:

Lua Code:

-- ingame instructions
local enterColor = "|cFF"
local exitColor = "|r"
local colorOrange = "DF9F1F"
local colorRed = "FF3F1F"
local function MoveCRFM_instructions()
    print(enterColor .. colorOrange .. "Use /movecrfm followed by either the Y coordinate, or whether to fade it out on mouseover, or frame strata 1-8 (ascending priority)." .. exitColor)
    print(enterColor .. colorOrange .. "Example: " .. exitColor .. "/movecrfm -234.5")
    print(enterColor .. colorOrange .. "Example: " .. exitColor .. "/movecrfm yes")
    print(enterColor .. colorOrange .. "Example: " .. exitColor .. "/movecrfm strata 6")
end
 
-- strata database/array
local MoveCRFM_stratas = {
    [1] = "BACKGROUND",
    [2] = "LOW",
    [3] = "MEDIUM",
    [4] = "HIGH",
    [5] = "DIALOG",
    [6] = "FULLSCREEN",
    [7] = "FULLSCREEN_DIALOG",
    [8] = "TOOLTIP",
}
 
-- main functionality
local function MoveCRFM_move()
    local anchorMyselfAt, anchorTo, anchorToAt, coordX, coordY = CompactRaidFrameManager:GetPoint()
    CompactRaidFrameManager:SetPoint(anchorMyselfAt, anchorTo, anchorToAt, coordX, Move_CompactRaidFrameManager.y)
end
local function MoveCRFM_fade()
    if not Move_CompactRaidFrameManager or not Move_CompactRaidFrameManager.fade then
        CompactRaidFrameManager:SetAlpha(1)
    elseif CompactRaidFrameManager:IsMouseOver() or not CompactRaidFrameManager.collapsed then
        CompactRaidFrameManager:SetAlpha(1)
    else
        CompactRaidFrameManager:SetAlpha(0)
    end
end
local function MoveCRFM_strata()
    CompactRaidFrameManager:SetFrameStrata(MoveCRFM_stratas[Move_CompactRaidFrameManager.strata])
end
local function MoveCRFM_set()
    MoveCRFM_move()
    MoveCRFM_fade()
    MoveCRFM_strata()
end
 
-- persist through sessions functionality
local function MoveCRFM_loaded(self, event, arg1)
    if event == "ADDON_LOADED" and arg1 == "Move_CompactRaidFrameManager" then
        if not Move_CompactRaidFrameManager then
            MoveCRFM_instructions()
            Move_CompactRaidFrameManager = {
                y = -100,
                fade = false,
                strata = 4,
            }
        end
        MoveCRFM_set()
        -- append ourselves into blizzard's frames
        hooksecurefunc("CompactRaidFrameManager_Toggle", function()
            MoveCRFM_move()
            MoveCRFM_fade()
        end)
    end
end
 
-- event triggers
local MoveCRFM = CreateFrame("Frame")
MoveCRFM:RegisterEvent("ADDON_LOADED")
MoveCRFM:SetScript("OnEvent", MoveCRFM_loaded)
CompactRaidFrameManager:HookScript("OnShow", MoveCRFM_fade)
CompactRaidFrameManager:HookScript("OnEnter", MoveCRFM_fade)
CompactRaidFrameManager:HookScript("OnLeave", MoveCRFM_fade)
 
-- slash command functionality
SLASH_MOVECRFM1 = "/movecrfm"
function SlashCmdList.MOVECRFM(msg, editbox)
    local msgY = tonumber(string.match(msg, "^(-?%d+\.?%d?)$")) or nil
    local msgFade = (string.match(string.lower(msg), "^yes$") or string.match(string.lower(msg), "^no$")) or nil
    local msgStrata = tonumber(string.match(string.lower(msg), "^strata ([1-8])$")) or nil
    if msgY then
        Move_CompactRaidFrameManager.y = msgY
        MoveCRFM_move()
    elseif msgFade then
        if msgFade == "yes" then
            Move_CompactRaidFrameManager.fade = true
        else
            Move_CompactRaidFrameManager.fade = false
        end
        MoveCRFM_fade()
    elseif msgStrata then
        Move_CompactRaidFrameManager.strata = msgStrata
        MoveCRFM_strata()
    else
        print(enterColor .. colorRed .. "Incorrect usage of " .. exitColor .. "/movecrfm")
        MoveCRFM_instructions()
    end
end