WoWInterface - Save location via SavedVariables

WoWInterface (https://www.wowinterface.com/forums/index.php)

- AddOn Help/Support (https://www.wowinterface.com/forums/forumdisplay.php?f=3)

- - Save location via SavedVariables (https://www.wowinterface.com/forums/showthread.php?t=59800)

Hubb777

02-19-24 10:32 PM

Save location via SavedVariables

Code

Lua Code:

local addonName, addon = ...
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {item.announce[GetLocale()], item.icon, item.name})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...)
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetScript('OnDragStart', btn.StartMoving)
btn:SetScript('OnDragStop', btn.StopMovingOrSizing)
    if (button == "RightButton" and btn:IsVisible()) then
        btn:Hide()
    end
 
    updateData()
    updateList()
    f:Show()
end)
btn:RegisterForClicks("AnyUp")
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    updateData()
    updateList()
    f:Show()
end

A separate code is just a button

Lua Code:

btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...)
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetScript('OnDragStart', btn.StartMoving)
btn:SetScript('OnDragStop', btn.StopMovingOrSizing)
    if (button == "RightButton" and btn:IsVisible()) then
        btn:Hide()
    end
 
    updateData()
    updateList()
    f:Show()
end)
btn:RegisterForClicks("AnyUp")

At the moment, the button returns to the center when using the command /reload

Did I redo it correctly?

Lua Code:

btn:RegisterEvent("ADDON_LOADED")
btn:RegisterEvent("PLAYER_LOGOUT")
btn:SetScript("OnEvent", function(self, event, arg1)
    if event == "ADDON_LOADED" and arg1 == "HaveWeMet" then
end
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...)
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetScript('OnDragStart', btn.StartMoving)
btn:SetScript('OnDragStop', btn.StopMovingOrSizing)
    if (button == "RightButton" and btn:IsVisible()) then
        btn:Hide()
    end
 
    updateData()
    updateList()
    f:Show()
end)
btn:RegisterForClicks("AnyUp")

Fizzlemizz

02-19-24 10:40 PM

Blizz. will save the frame but if the user removes the addon for any reason, it will reset to the default location if they decide to install the addon again.

Lua Code:

btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...)
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetUserPlaced(true) -- Only works if the frame is created before the PLAYER_LOGIN event

Hubb777

02-19-24 10:51 PM

Quote:

Originally Posted by Fizzlemizz (Post 343369)

Blizz. will save the frame but if the user removes the addon for any reason, it will reset to the default location if they decide to install the addon again.

Lua Code:

btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...)
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetUserPlaced(true) -- Only works if the frame is created before the PLAYER_LOGIN event

after the /reload command, the button returns to its place. It doesn't work

Fizzlemizz

02-20-24 12:04 AM

I missed the CreateFrame code for btn in the original post

For Blizz to save the position, the frame has to have a unique name.

Lua Code:

local btn = CreateFrame("Button", addonName.."MovingButton", UIParent, "UIPanelButtonTemplate")

Hubb777

02-20-24 12:31 AM

Quote:

Originally Posted by Fizzlemizz (Post 343371)

I missed the CreateFrame code for btn in the original post

For Blizz to save the position, the frame has to have a unique name.

Lua Code:

local btn = CreateFrame("Button", addonName.."MovingButton", UIParent, "UIPanelButtonTemplate")

And it didn't work again. The button after /reload returned to the center

Lua Code:

local btn = CreateFrame("Button", addonName.."MovingButton", UIParent, "UIPanelButtonTemplate")
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...)
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetUserPlaced(true) -- Only works if the frame is created before the PLAYER_LOGIN event
btn:SetScript('OnDragStart', btn.StartMoving)
btn:SetScript('OnDragStop', btn.StopMovingOrSizing)
    if (button == "RightButton" and btn:IsVisible()) then
        btn:Hide()
    end
 
    updateData()
    updateList()
    f:Show()
end)
btn:RegisterForClicks("AnyUp")

Fizzlemizz

02-20-24 01:05 AM

I have no idea what code you're testing so, as a standalone example of a button that can be dragged and saved.

Lua Code:

local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate")
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...) print("I've been clicked!") end)
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetUserPlaced(true) -- Only works if the frame is created before the PLAYER_LOGIN event
btn:SetScript('OnDragStart', btn.StartMoving)
btn:SetScript('OnDragStop', btn.StopMovingOrSizing)
btn:RegisterForClicks("AnyUp")

You will have to move the pieces into your addon. Possibly just the btn:SetUserPlaced(true) and giving the button a name.

Hubb777

02-20-24 03:37 AM

Quote:

Originally Posted by Fizzlemizz (Post 343373)

I have no idea what code you're testing so, as a standalone example of a button that can be dragged and saved.

Lua Code:

local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate")
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...) print("I've been clicked!") end)
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetUserPlaced(true) -- Only works if the frame is created before the PLAYER_LOGIN event
btn:SetScript('OnDragStart', btn.StartMoving)
btn:SetScript('OnDragStop', btn.StopMovingOrSizing)
btn:RegisterForClicks("AnyUp")

You will have to move the pieces into your addon. Possibly just the btn:SetUserPlaced(true) and giving the button a name.

I tried to do this, but in the end the button disappeared from the screen. Below is the full code

Lua Code:

local addonName, addon = ...
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {item.announce[GetLocale()], item.icon, item.name})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...)
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', btn.StartMoving)
btn:SetScript('OnDragStop', btn.StopMovingOrSizing)
    if (button == "RightButton" and btn:IsVisible()) then
        btn:Hide()
    end
 
    updateData()
    updateList()
    f:Show()
end)
btn:RegisterForClicks("AnyUp")
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    updateData()
    updateList()
    f:Show()
end

Fizzlemizz

02-20-24 08:53 AM

Some of that code is completely broken so I assumed you were posting example code and would make changes to the real code. You should be getting errors from BugGrabber/Bugsack . Install them if you haven't yet.

Code:

btn:SetScript("OnClick:, function(self, button, ...)

Is an unfinished script handler, no end) .

Whereas

Code:

btn:SetScript('OnDragStop', btn.StopMovingOrSizing)

Is finished but then the next few lines look like they are supposed to be part of the OnDragStop script but end up being incomplete (it has an end with no function(...) to start the block and a ) after the end with no SetScript to start the bracket pair.

Here is the code with a print to fill in the OnClick, a fix that may or may not be what you intend for the OnDragStop script and I commented out the updateData() because addon.db isn't created in the code shown. Add it back if it is in another .lua file but the code as is should at least work for demonstrating the SetUserPlaced() saving the button position.

Lua Code:

local addonName, addon = ...
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData() --commented out because addon.db hasn't been created... in the code at least
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {item.announce[GetLocale()], item.icon, item.name})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...) print("Hi!") end)
 
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', btn.StartMoving)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    end
 
--      updateData()  --commented out because addon.db hasn't been created... in the code at least
    updateList()
    f:Show()
end)
btn:RegisterForClicks("AnyUp")
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    updateData()
    updateList()
    f:Show()
end

Hubb777

02-20-24 11:41 PM

Quote:

Originally Posted by Fizzlemizz (Post 343378)

Code:

btn:SetScript("OnClick:, function(self, button, ...)

Is an unfinished script handler, no end) .

Whereas

Code:

btn:SetScript('OnDragStop', btn.StopMovingOrSizing)

Just like I said before. I took your other advice (in another forum thread), but since my knowledge of LUA is low, I probably didn't copy everything.

Lua Code:

local addonName, addon = ...
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData() --commented out because addon.db hasn't been created... in the code at least
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {item.announce[GetLocale()], item.icon, item.name})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetScript("OnClick", function(self, button, ...)end)
 
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', btn.StartMoving)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    end
 
    updateData()
    updateList()
    f:Show()
end)
btn:RegisterForClicks("AnyUp")
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    updateData()
    updateList()
    f:Show()
end

This code almost works. It saves the position of the button
But the button does not display the table if I press the left mouse button. But if I press the left mouse button and shift and try to move the button, the table window turns on. What could be the problem?

Fizzlemizz

02-21-24 12:31 AM

Programs are stupid. You have to tell them exactly what you want. Maybe something like: (Left buton down, shift-key down = drag. right button = hide button. left button no shift-key toggle show/hide the frame (f))

Lua Code:

local addonName, addon = ...
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData() --commented out because addon.db hasn't been created... in the code at least
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {item.announce[GetLocale()], item.icon, item.name})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    updateData()
    updateList()
    f:Show()
end

You possibly want a way to get the button back after it's hidden other than a /reaload but may not, it's not clear?

Hubb777

02-21-24 12:42 AM

Yes, it worked. The code works completely as intended. Thank you very much. I couldn't have done it without you.

Quote:

Originally Posted by Fizzlemizz (Post 343387)

You possibly want a way to get the button back after it's hidden other than a /reaload but may not, it's not clear?

And how to do it?

If I solve the problem - how do I insert a link to an item in the text that is in the table, I will be able to make my first addon.
https://www.wowinterface.com/forums/...ad.php?t=59796

Fizzlemizz

02-21-24 10:26 AM

I've created this as an all-in-one example including an example addon.db where I've replaced the item name, icon and added the link for some random items (got rid of the icon texture in the frame as it's in the text, but but it's up to you how you organise the stuff).

Added two %s to each enUS string which gets replaced by the icon (size set to 20x20) and hyperlink when the text is set.

Again, Example Code so, how you get/display the information for your addon will depend on the what/when of the addons workings.

Added a check in the slash command so if you type /hubb btn it will toggle the button

Lua Code:

local addonName, addon = ...
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
-- name and icon (and link) set by LoadItem() when the item is cached.
addon.db = {
    {
--        name = "Emerald Mark of Mastery",
        questID = 75612,
--        icon = "interface/icons/inv_mushroom_11",
        item = 6218,
        announce = {
            enUS = "Awarded for outstanding service to Dragonkind. %s %s Bring it to Theozhaklos the Curious at the Wellspring Overlook in the Emerald Dream to receive powerful equipment for your efforts"
        }
    },
    {
--        name = "Emerald Mark of Mastery",
        questID = 75624,
--        icon = "interface/icons/inv_mushroom_11",
        item = 20897,
        announce = {
            enUS = "Awarded for outstanding service to Dragonkind. %s %s Bring it to Theozhaklos the Curious at the Wellspring Overlook in the Emerald Dream to receive powerful equipment for your efforts\n\nAwarded for outstanding service to (clickable link to the item) Dragonkind. Bring it to Theozhaklos the Curious at the Wellspring Overlook in the Emerald Dream to receive powerful equipment for your efforts"
        }
    },
    {
--        name = "Emerald Mark of Mastery",
        questID = 74352,
        item = 193440,
--        icon = "interface/icons/inv_mushroom_11",
        announce = {
            enUS = "Awarded for outstanding service to Dragonkind. %s %s Bring it to Theozhaklos the Curious at the Wellspring Overlook in the Emerald Dream to receive powerful equipment for your efforts"
        }
    }
} 
 
local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- function to print the link when clicked
    print("You just clickled:", text)
end
 
local function OnHyperlinkEnter(self, link, text, region, left, bottom, width, height) -- function to display the hyperlink on mouse over
    GameTooltip:SetOwner(self, "ANCHOR_CURSOR_RIGHT")
    GameTooltip:SetHyperlink(link)
    GameTooltip:Show()
end
 
local function OnHyperlinkLeave(self) -- function to hide the hyperlink on mouse exit
    GameTooltip:Hide()
end
 
local function LoadItem(item) -- adds the item to the bd overwriting the icon, name ans sedtting the itemlink keys
    addon.db[item.dbID].name = item:GetItemName() 
    addon.db[item.dbID].icon = "|T"..item:GetItemIcon()..":20:20|t" -- make icon size 20x20
    addon.db[item.dbID].itemlink = item:GetItemLink()
 
 
print(addon.db[item.dbID].name, addon.db[item.dbID].icon, addon.db[item.dbID].itemlink)
 
end
 
for i, v in ipairs(addon.db) do -- Get the item information and call LoadItem when it's returned from the server and cached
    local item = Item:CreateFromItemID(v.item) 
    item.dbID = i
    item:ContinueOnItemLoad(function() LoadItem(item) end)
end
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
f.Title = f:CreateFontString() 
f.Title:SetFontObject(GameFontNormal)
f.Title:SetPoint("TOP", 0, -5)
f.Title:SetText(addonName)
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData() --commented out because addon.db hasn't been created... in the code at least
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {text=item.announce[GetLocale()], icon=item.icon, name=item.name, link=item.itemlink})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button:SetHyperlinksEnabled(true) -- Setup hyperlinking for each row
            button:SetScript("OnHyperlinkClick", OnHyperlinkClick)
            button:SetScript("OnHyperlinkEnter", OnHyperlinkEnter)
            button:SetScript("OnHyperlinkLeave", OnHyperlinkLeave)
            
            button.columns = {}
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetJustifyH("LEFT")
            button.columns[1]:SetJustifyV("TOP")
--            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
            button.columns[1]:SetPoint("TOPLEFT")
            button.columns[1]:SetPoint("BOTTOMRIGHT", button, "BOTTOMLEFT", 140, 0)
 
-- Replaced the icon texture with the icon embedded in the description string.
--            button.columns[2] = button:CreateTexture()
--            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
--            button.columns[2]:SetPoint("LEFT", button.columns[1], "RIGHT")
 
            button.columns[2] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[2]:SetJustifyH("LEFT")
            button.columns[2]:SetJustifyV("TOP")
--            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
            button.columns[2]:SetPoint("TOPLEFT", button.columns[1], "TOPRIGHT", 5, 0)
            button.columns[2]:SetPoint("BOTTOMRIGHT", button)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i].name)
--        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[2]:SetText(format(data[i].text, data[i].icon, data[i].link)) -- insert the icon and hyperlink into the text
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

Hubb777

02-21-24 11:11 PM

Quote:

Originally Posted by Fizzlemizz (Post 343394)

Hi. I did it a little differently. But for some reason, the button and the slash command stopped being pressed.
table.lua

Lua Code:

local addonName, addon = ...
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData() --commented out because addon.db hasn't been created... in the code at least
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {format(item.announce[GetLocale()], GetItemLinkById(id)), item.icon, item.name})
    end
end
local function GetItemLinkById(id)
    local item = Item:CreateFromItemID(id)
    local itemLink = item:GetItemLink()
 
    return itemLink
end 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    updateData()
    updateList()
    f:Show()
end

db.lua

Lua Code:

local addonName, addon = ...
addon.db = {
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(200106))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194730))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    },
    {
 name = "Emerald Mark of Mastery",
  icon = "interface/icons/inv_mushroom_11",
  announce = {
    enUS = format("Awarded for outstanding service to Dragonkind %s Awarded for outstanding service to Dragonkind", GetItemLinkById(194701))
        }
    }
}

Fizzlemizz

02-21-24 11:30 PM

Quote:

But for some reason, the button and the slash command stopped being pressed.
table.lua

I'm not sure what you mean by "stopped being pressed", or the whole sentence really?.

You removed the option to show/hide the button from the slash command (or at least didn't copy the SlashCmdList["HUBB"] = function(msg) code from my example.

Your latest code contains a function GetItemLinkById I have no idea what it is or where it's from but it's not Blizz and it's not defined in anything you've posted so colour me confused that it works at all.

Hubb777

02-22-24 12:02 AM

Quote:

Originally Posted by Fizzlemizz (Post 343398)

Lua Code:

local addonName, addon = ...
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData() --commented out because addon.db hasn't been created... in the code at least
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {format(item.announce[GetLocale()], GetItemLink(id)), item.icon, item.name})
    end
end
local function GetItemLink(id)
    local item = Item:CreateFromItemID(id)
    local itemLink = item:GetItemLink()
 
    return itemLink
end 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

I was assured that it would work in GetItemLinkById. But it looks like we just didn't understand each other.

Lua Code:

local addonName, addon = ...
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
-- name and icon (and link) set by LoadItem() when the item is cached.
addon.db = {
    {
--        name = "Emerald Mark of Mastery",
        questID = 75612,
--        icon = "interface/icons/inv_mushroom_11",
        item = 6218,
        announce = {
            enUS = "Awarded for outstanding service to Dragonkind. %s %s Bring it to Theozhaklos the Curious at the Wellspring Overlook in the Emerald Dream to receive powerful equipment for your efforts"
        }
    },
    {
--        name = "Emerald Mark of Mastery",
        questID = 75624,
--        icon = "interface/icons/inv_mushroom_11",
        item = 20897,
        announce = {
            enUS = "Awarded for outstanding service to Dragonkind. %s %s Bring it to Theozhaklos the Curious at the Wellspring Overlook in the Emerald Dream to receive powerful equipment for your efforts\n\nAwarded for outstanding service to (clickable link to the item) Dragonkind. Bring it to Theozhaklos the Curious at the Wellspring Overlook in the Emerald Dream to receive powerful equipment for your efforts"
        }
    },
    {
--        name = "Emerald Mark of Mastery",
        questID = 74352,
        item = 193440,
--        icon = "interface/icons/inv_mushroom_11",
        announce = {
            enUS = "Awarded for outstanding service to Dragonkind. %s %s Bring it to Theozhaklos the Curious at the Wellspring Overlook in the Emerald Dream to receive powerful equipment for your efforts"
        }
    }
} 
 
local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- function to print the link when clicked
    print("You just clickled:", text)
end
 
local function OnHyperlinkEnter(self, link, text, region, left, bottom, width, height) -- function to display the hyperlink on mouse over
    GameTooltip:SetOwner(self, "ANCHOR_CURSOR_RIGHT")
    GameTooltip:SetHyperlink(link)
    GameTooltip:Show()
end
 
local function OnHyperlinkLeave(self) -- function to hide the hyperlink on mouse exit
    GameTooltip:Hide()
end
 
local function LoadItem(item) -- adds the item to the bd overwriting the icon, name ans sedtting the itemlink keys
    addon.db[item.dbID].name = item:GetItemName() 
    addon.db[item.dbID].icon = "|T"..item:GetItemIcon()..":20:20|t" -- make icon size 20x20
    addon.db[item.dbID].itemlink = item:GetItemLink()
 
 
print(addon.db[item.dbID].name, addon.db[item.dbID].icon, addon.db[item.dbID].itemlink)
 
end
 
for i, v in ipairs(addon.db) do -- Get the item information and call LoadItem when it's returned from the server and cached
    local item = Item:CreateFromItemID(v.item) 
    item.dbID = i
    item:ContinueOnItemLoad(function() LoadItem(item) end)
end
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
f.Title = f:CreateFontString() 
f.Title:SetFontObject(GameFontNormal)
f.Title:SetPoint("TOP", 0, -5)
f.Title:SetText(addonName)
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData() --commented out because addon.db hasn't been created... in the code at least
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {text=item.announce[GetLocale()], icon=item.icon, name=item.name, link=item.itemlink})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button:SetHyperlinksEnabled(true) -- Setup hyperlinking for each row
            button:SetScript("OnHyperlinkClick", OnHyperlinkClick)
            button:SetScript("OnHyperlinkEnter", OnHyperlinkEnter)
            button:SetScript("OnHyperlinkLeave", OnHyperlinkLeave)
            
            button.columns = {}
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetJustifyH("LEFT")
            button.columns[1]:SetJustifyV("TOP")
--            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
            button.columns[1]:SetPoint("TOPLEFT")
            button.columns[1]:SetPoint("BOTTOMRIGHT", button, "BOTTOMLEFT", 140, 0)
 
-- Replaced the icon texture with the icon embedded in the description string.
--            button.columns[2] = button:CreateTexture()
--            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
--            button.columns[2]:SetPoint("LEFT", button.columns[1], "RIGHT")
 
            button.columns[2] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[2]:SetJustifyH("LEFT")
            button.columns[2]:SetJustifyV("TOP")
--            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
            button.columns[2]:SetPoint("TOPLEFT", button.columns[1], "TOPRIGHT", 5, 0)
            button.columns[2]:SetPoint("BOTTOMRIGHT", button)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i].name)
--        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[2]:SetText(format(data[i].text, data[i].icon, data[i].link)) -- insert the icon and hyperlink into the text
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

Your code works 100%. But it displays the items in the chat, rather than displaying a table. And it is the table that I need.

An example where instead of {item:194701} there is a link to the item.

Fizzlemizz

02-22-24 12:43 AM

Quote:

I was assured that it would work in GetItemLinkById. But it looks like we just didn't understand each other.

Assured by who? If it's not a game function and it's not one of yours hidden somewher in other code then I don't know where it comes from.

Quote:

But it displays the items in the chat, rather than displaying a table. And it is the table that I need.

Still not sure what it is you want. Possibly just a custom tooltip?

Delete the lines

Lua Code:

button:SetScript("OnHyperlinkEnter", OnHyperlinkEnter)

(You can delete the OnHyperlinkEnter function as well)

Change the OnHyperlinkClick function to:

Lua Code:

Change the OnHyperlinkClick function to be
    GameTooltip:SetOwner(self, "ANCHOR_CURSOR_RIGHT")
    GameTooltip:AddText("Unlocks this customization option for the Renewed Proto-Drake at the Rostrum of Transformation")
    GameTooltip:Show()
end

Once again, just an example tooltip with fixed text (which you could (would) get the actual text from the addon.db table or some other source).

The other possabilty is you want the click to open the item tooltip rather than doing it OnEnter in which case, the the OnHyperlinkClick function would be:

Lua Code:

local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- Show the hyperling tooltip when clicked
    SetItemRef(link, text, button, self);
end

Hubb777

02-22-24 03:10 AM

Quote:

Originally Posted by Fizzlemizz (Post 343400)

Assured by who? If it's not a game function and it's not one of yours hidden somewher in other code then I don't know where it comes from.
Still not sure what it is you want. Possibly just a custom tooltip?

In this example, when I clicked a button, a table appeared. The table contained text and pictures.
https://www.wowinterface.com/forums/...ad.php?t=59796
Here is a table (picture 1)

I want to be able to add a link to an item in the description of the text, anywhere in the text.
I did this in photo editor GIMP (it turned out a little crooked)

Fizzlemizz

02-22-24 09:45 AM

You still don't say what you want to see when a link is clicked so, using the code you linked and guessing you just want to see the item tooltip when a link is clicked:

The item field added to each entry in addon.db is the (random because I don't know that acual) item ID that will be the link/tooltip (replacing the %s in each announce.enUS field).

db.lua file

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = "Emerald Mark of Mastery",
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        item = 210399,
        announce = {
            enUS = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts"
        }
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        item = 20897,
        announce = {
            enUS = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts"
        }
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 74352,
        icon = "interface/icons/inv_mushroom_11",
        item = 193440,
        announce = {
            enUS = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts"
        }
    }
}
---------------------------------------------------------------------------------------------------
-- Code to replace %s in announce texts with item links. Replaces the GetItemLinkById(...) function
local function LoadItem(item)
    for k, v in pairs(addon.db[item.dbID].announce) do -- replace the %s with the itemlink in eal locale in the .announce key
        addon.db[item.dbID].announce[k] = format(v, item:GetItemLink())
    end
end
for i, v in ipairs(addon.db) do
    local item = Item:CreateFromItemID(v.item) 
    item.dbID = i
    item:ContinueOnItemLoad(function() LoadItem(item) end)
end

Lua Code file:

Lua Code:

local addonName, addon = ...
 
-- function to show the item tooltip when a hyperlink is clicked
local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- Show the hyperling tooltip when clicked
    SetItemRef(link, text, nil, self);
end
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local function updateData() --commented out because addon.db hasn't been created... in the code at least
    wipe(data)
    for _, item in ipairs(addon.db) do
        tinsert(data, {item.announce[GetLocale()], item.icon, item.name})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
---------------------------------------------------------------------------------------------------
-- code to make item links work
            button:SetHyperlinksEnabled(true) -- Setup hyperlinking for each row
            button:SetScript("OnHyperlinkClick", OnHyperlinkClick) -- What to do when a link is clicked
---------------------------------------------------------------------------------------------------
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Click me")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

To show/hide the button:

Code:

/hubb btn

Hubb777

02-22-24 11:23 PM

Quote:

Originally Posted by Fizzlemizz (Post 343403)

Hello. Yes, that's perfect. This is exactly what I wanted. Thank you so much for your help. I have already started creating my first addon. Which I will definitely publish on https://www.wowinterface.com/.

I set the localization lines correctly, did I do everything right?

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = {
            enUS = "Herb-Infused Water",
            deDE = "Mit Kräutern aromatisiertes Wasser"
        },
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        item = 210399,
        announce = {
            deDE = "Die Grundlage eines jeden %s Getränks: Wasser! Aufgegossen mit ausgewählten Kräutern aus meinem Garten.",
             enUS = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts",
        }
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        item = 20897,
        announce = {
             enUS = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts"
        }
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 74352,
        icon = "interface/icons/inv_mushroom_11",
        item = 193440,
        announce = {
             enUS = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts"
        }
    }
}
---------------------------------------------------------------------------------------------------
-- Code to replace %s in announce texts with item links. Replaces the GetItemLinkById(...) function
local function LoadItem(item)
    for k, v in pairs(addon.db[item.dbID].announce) do -- replace the %s with the itemlink in eal locale in the .announce key
        addon.db[item.dbID].announce[k] = format(v, item:GetItemLink())
    end
end
for i, v in ipairs(addon.db) do
    local item = Item:CreateFromItemID(v.item) 
    item.dbID = i
    item:ContinueOnItemLoad(function() LoadItem(item) end)
end

Fizzlemizz

02-23-24 12:15 AM

That looks OK.

The only thing is that you have a deDE for a only one entry in addon.db where

Code:

tinsert(data, {item.announce[GetLocale()], item.icon, item.name})

will cause an error if the entry is missing in any single entry for the users locale return from GetLocale().

Have Fun!

Hubb777

02-23-24 12:24 AM

Quote:

Originally Posted by Fizzlemizz (Post 343409)

That looks OK.

The only thing is that you have a deDE for a only one entry in addon.db where

Code:

tinsert(data, {item.announce[GetLocale()], item.icon, item.name})

will cause an error if the entry is missing in any single entry for the users locale return from GetLocale().

Have Fun!

That is, if the player’s game client is in French, and my addon does not support lines with frFR, then the player will have an error?

Fizzlemizz

02-23-24 12:52 AM

If french (frFR) didn't exists then

Code:

tinsert(data, {item.announce[GetLocale()], item.icon, item.name})

would be the same as

Code:

tinsert(data, {item.announce["frFR"], item.icon, item.name})

which in the end would be

Code:

tinsert(data, {nil, item.icon, item.name})

Inserting nil will cause tinsert to error.

You could use something like the following that will test if the users locale announce field is in addon.db and if not, default to using the enUS text.

Lua Code:

local locale = GetLocale() -- get the current locale eg. "frFR"
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        local announceText = item.announce[locale] or item.announce.enUS -- default to enUS if the locale text doesn't exist.
        tinsert(data, {announceText, item.icon, item.name})
    end
end

This assumes there will be a enUS field in EVERY announce table.

You could of course, if you prefer, default to .frFR or .deDE whichever locale oocures in every entry.

Hubb777

02-23-24 10:37 PM

Quote:

Originally Posted by Fizzlemizz (Post 343411)

Lua Code:

local locale = GetLocale() -- get the current locale eg. "frFR"
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        local announceText = item.announce[locale] or item.announce.enUS -- default to enUS if the locale text doesn't exist.
        tinsert(data, {announceText, item.icon, item.name})
    end
end

Yes, this option is ideal (after all, I don’t know what languages the players who install the addon speak, but many speak English)

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = {
            enUS = "Herb-Infused Water",
            deDE = "Mit Kräutern aromatisiertes Wasser"
        },
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        item = 210399,
        item = 210400,
        item = 210401,
        item = 210402,
        item = 210403,
        item = 210404,
        announce = {
             enUS = "Awarded for %ss outstanding service %sss to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald %ssss Dream to receive powerful \nequipment for your efforts",
        }
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        item = 20897,
        announce = {
             enUS = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts"
        }
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 74352,
        icon = "interface/icons/inv_mushroom_11",
        item = 193440,
        announce = {
             enUS = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts"
        }
    }
}
---------------------------------------------------------------------------------------------------
-- Code to replace %s in announce texts with item links. Replaces the GetItemLinkById(...) function
local function LoadItem(item)
    for k, v in pairs(addon.db[item.dbID].announce) do -- replace the %s with the itemlink in eal locale in the .announce key
        addon.db[item.dbID].announce[k] = format(v, item:GetItemLink())
    end
end
for i, v in ipairs(addon.db) do
    local item = Item:CreateFromItemID(v.item) 
    item.dbID = i
    item:ContinueOnItemLoad(function() LoadItem(item) end)
end

During the creation of the addon, a question arose. One link to a item in the text is missing; you need to insert 2,3 or more links into one text. As I understand it, you need to set different variables, for example %ss or %sss or %d, so that each one is tied to a specific position of the link to the item.

Fizzlemizz

02-23-24 11:55 PM

Code:

/run print(format("%s %s %s", "Replace", "with", text"))

Each %s is replaced left-to-right with the corresponding argument after the text string ("Replace", "with", text"). There are tokens other than %s various data types/formatting see the docs for format for more information.

Hubb777

02-24-24 12:07 AM

Quote:

Originally Posted by Fizzlemizz (Post 343416)

Code:

/run print(format("%s %s %s", "Replace", "with", text"))

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = {
            enUS = "Herb-Infused Water",
        },
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        item = 210399, 210400, 210401,
        announce = {
             enUS = format("Awarded for %s outstanding service %s to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring"),
        }
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 74352, 
        icon = "interface/icons/inv_mushroom_11",
        item = 193440, 193441, 193442,
        announce = {
             enUS = format("Awarded for %s outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the %s Wellspring)"
        }
    }
}
---------------------------------------------------------------------------------------------------
-- Code to replace %s in announce texts with item links. Replaces the GetItemLinkById(...) function
local function LoadItem(item)
    for k, v in pairs(addon.db[item.dbID].announce) do -- replace the %s with the itemlink in eal locale in the .announce key
        addon.db[item.dbID].announce[k] = format(v, item:GetItemLink())
    end
end
for i, v in ipairs(addon.db) do
    local item = Item:CreateFromItemID(v.item) 
    item.dbID = i
    item:ContinueOnItemLoad(function() LoadItem(item) end)
end

I tried this but it didn't work

Fizzlemizz

02-24-24 01:15 AM

This makes it a bit more complicated as you're getting mutiple items for each row so you have to have them all cached before you can do the format().

I have to head out so I'll look at it in the morning.

Hubb777

02-24-24 01:37 AM

Quote:

Originally Posted by Fizzlemizz (Post 343418)

Thank you very much, good luck in your business. Maybe this code will help you

Lua Code:

local Item = Class('Item', Reward)
 
function Item:Initialize(attrs)
    Reward.Initialize(self, attrs)
 
    if not self.item then
        error('Item() reward requires an item id to be set')
    end
    self.itemLink = L['retrieving']
    self.itemIcon = 'Interface\\Icons\\Inv_misc_questionmark'
    local item = _G.Item:CreateFromItemID(self.item)
    if not item:IsItemEmpty() then
        item:ContinueOnItemLoad(function()
            self.itemLink = item:GetItemLink()
            self.itemIcon = item:GetItemIcon()
        end)
    end
end
 
function Item:Prepare() ns.PrepareLinks(self.note) end
 
function Item:IsObtained()
    if self.quest then return C_QuestLog.IsQuestFlaggedCompleted(self.quest) end
    if self.bag then return ns.PlayerHasItem(self.item) end
    return true
end
 
function Item:GetText()
    local text = self.itemLink
    if self.type then -- mount, pet, toy, etc
        text = text .. ' (' .. self.type .. ')'
    end
    if self.count then
        text = text .. string.format(' (%sx)', BreakUpLargeNumbers(self.count))
    end
    if self.note then -- additional info
        text = text .. ' (' .. ns.RenderLinks(self.note, true) .. ')'
    end
    return Icon(self.itemIcon) .. text
end
 
function Item:GetStatus()
    if self.bag then
        local collected = ns.PlayerHasItem(self.item)
        return collected and Green(L['completed']) or Red(L['incomplete'])
    elseif self.status then
        return format('(%s)', self.status)
    elseif self.quest then
        local completed = C_QuestLog.IsQuestFlaggedCompleted(self.quest)
        return completed and Green(L['completed']) or Red(L['incomplete'])
    elseif self.weekly then
        local completed = C_QuestLog.IsQuestFlaggedCompleted(self.weekly)
        return completed and Green(L['weekly']) or Red(L['weekly'])
    end
end

And an additional question. - https://www.wowinterface.com/forums/...t=59795&page=2

In the last topic you helped me make a timer.
I plan to make another addon in the future that also uses this timer. The problem is that if a player installs 2 of these addons, the timer will not work correctly. I thought it was enough to fix ZAMROTimer to ZAMRO1Timer, but it looks like something else needs to be done?

Xrystal

02-24-24 02:46 AM

Double check that you have no common non local functions or variables. These would overwrite each other and thus cause one to not work properly.

If you can't see anything like this in both addons then, perhaps you can describe what you are seeing happen ? And if you don't have bugsack or buggrabber installed to catch any errors it might be worth doing to help pinpoint where it's breaking.

Looking at the last code block Fizzle posted in that thread, just changing the frame name should be enough to make it work.

Hubb777

02-24-24 02:51 AM

Quote:

Originally Posted by Xrystal (Post 343420)

My second timer starts flickering periodically and at this moment data from the first timer appears there.

Xrystal

02-24-24 05:31 AM

Did you make sure that each display has it's own location ?

You will need to adjust the anchor if you want them both displayed at the same time.

If you notice in Fizzle's example code:

Lua Code:

f:SetPoint("CENTER",UIParent,"CENTER",frame_x,frame_y)

If both addons have the same anchor point their information will overlay each other on the screen.
If you notice there is a frame_x and frame_y value there. If you are using the same code for your addon you can have each addon have different frame_x/frame_y values so that the frame will not overlay each other.

Hubb777

02-24-24 07:02 AM

Quote:

Originally Posted by Xrystal (Post 343422)

Did you make sure that each display has it's own location ?

You will need to adjust the anchor if you want them both displayed at the same time.

If you notice in Fizzle's example code:

Lua Code:

f:SetPoint("CENTER",UIParent,"CENTER",frame_x,frame_y)

I'm a newbie so would appreciate a visual example based on my code

Lua Code:

local addonName, addon = ...
local Backdrop = {
    bgFile = "Interface\\DialogFrame\\UI-DialogBox-Background",
}
 
local frame_x = 0     
local frame_y = -200    
f = CreateFrame("Button", "ZAMTimer", UIParent, "BackdropTemplate")
f:SetWidth(255)                                          
f:SetHeight(30)
f:SetBackdrop(Backdrop)
f.text = f:CreateFontString(nil,"OVERLAY","GameTooltipText")
f.text:SetTextHeight(15)
f.text:SetPoint("CENTER")
f:SetClampedToScreen(true)
f:SetPoint("CENTER",UIParent,"CENTER",frame_x,frame_y)
f:EnableMouse(true)
f:SetMovable(true)
f:RegisterForDrag("LeftButton")
f:RegisterForClicks("AnyUp")
f:Show()
f:RegisterEvent("PLAYER_ENTERING_WORLD")
f:SetScript("OnDragStart",function(this) 
    this:StartMoving()
end)
f:SetScript("OnDragStop",function(this)  
    this:StopMovingOrSizing()
    frame_x,frame_y = this:GetRIGHT()
    frame_x = frame_x - GetScreenWidth() / 2
    frame_y = frame_y - GetScreenHeight() / 2
    this:ClearAllPoints()
    this:SetPoint("CENTER",UIParent,"CENTER",frame_x,frame_y)
end)
-- first %s is replaced by the color. The second is replaced by the time. |r resets the color back to default
local Localizations = {
    enUS = {
        Waiting = "|c1C7BCEFFResearchers Under Fire:\nbefore the start: %s%s|r",
        Running = "|cFF35BE21Researchers Under Fire:\n%s%s until completion|r",
    },
}
 
local locale = GetLocale()
local L = Localizations[locale] or Localizations.enUS -- Default to enUS if locale doesn't exist in the table
 
------------------------------------------------------------------------------------------------------ 
-- These might be converted to Saved Variables so each character can determine
-- wether or not to play a sound, the alert times and colors and sound to play.
-- If so then most of the code below will have to move into an event handler for 
-- the PLAYER_LOGIN or PLAYER_ENTERING_WORLD event.
local useColor = true
local useSound = true
local alert1 = 600 -- Alarm 1 set to 10 minutes before event
local alert1Color = "|cffffff00" -- Yellow
local alert2 = 300 -- Alarm 2 set to 5 minutes before event
local alert2Color = "|cffff0000" -- Red
local soundKit = 32585 -- Alarm sound
------------------------------------------------------------------------------------------------------ 
 
local function printTime(timetotrun, inevent)
    local hideSeconds = timetotrun >= 120
    local msg = L.Waiting
    local msgColor = "|cffffffff"
    if inevent then
        msg = L.Running
    else
        if useColor and timetotrun <= alert2 then
            msgColor = alert2Color
        elseif timetotrun <= alert1 then
            if useSound and not ZAMTimer.Alerted then
                ZAMTimer.Alerted = true
                PlaySound(soundKit, "Master")
            end
            if useColor then
                msgColor = alert1Color
            end
        end
    end
    f.text:SetText(format(msg, msgColor, SecondsToTime(timetotrun, hideSeconds)))
end
 
regionEventStartTime = {
    [1] = { -- eu
        starttime = 1708756200,
        eventDuration = 1500,
        eventIntervalInSeconds = 3600,
        enable = true,
        datablock = {}
    },
}
 
local inEvent, timeToRun
local eventTime = regionEventStartTime[1].eventDuration -- Time the event runs in seconds(15 mins)
local waitTime = regionEventStartTime[1].eventIntervalInSeconds -- Time between events in seconds (90 mins)
local startTime = regionEventStartTime[1].starttime -- Start time from the table
local serverTime = GetServerTime()
local timeToEvent = (startTime - serverTime) % waitTime -- Remaining time before next event starts
 
if timeToEvent > (waitTime - eventTime) then -- Is there between 1:15 and 1:30 to go? If so, we're in the event
    inEvent = true
    timeToRun = eventTime - (waitTime - timeToEvent)
else                    -- Otherwise, set the ticker timer to time to next event
    inEvent = false
    timeToRun = timeToEvent
end
local ticker = C_Timer.NewTicker(1, function() 
    if timeToRun > 0 then
        timeToRun = timeToRun - 1
        printTime(timeToRun, inEvent)
        return
    end
    ZAMTimer.Alerted = false
    if inEvent then -- The event just finished
        inEvent = false
        timeToRun = waitTime - eventTime -- Reset ticker timer to 90 minutes wait time minus 15 mins event time
    else  -- Waiting for the next event just expired
        inEvent = true
        timeToRun = eventTime -- And the event is running
    end
    printTime(timeToRun, inEvent)
end)
printTime(timeToRun, inEvent)

Xrystal

02-24-24 08:44 AM

Assuming you have the same file in each of the addons. Simply changing the frame name on line 8 as well as setting f to be local not global ( that would mess things up there ) and the frame_x and frame_y values on lines 6 and 7 might be all you need to do. Assuming the rest of the code does what the addon was designed to do.

So..

Addon 1

Lua Code:

local frame_x = 0     
local frame_y = -200    
local f = CreateFrame("Button", "ZAMTimer1", UIParent, "BackdropTemplate")

Addon 2

Lua Code:

local frame_x = 0     
local frame_y = -250    
local f = CreateFrame("Button", "ZAMTimer2", UIParent, "BackdropTemplate")

Although I see you have the frame dragging code set up to re-arrange as needed. So, the above should work well enough to make both frames separate and accessible and not overidden by the other one.

I think having the f - CreateFrame line not be local was the main issue.

Fizzlemizz

02-24-24 11:32 AM

Probably best to make separate threads for each question as the code is getting pretty messy even for just one (hopefully Xrystal has answered your timer question).

Having multiple item links and locales in your addon.db texts complicates things because the order you want the links to display might be different in german to the order displayed in french and might be different again for english.

This requires identifying the order each link needs to be in for every locale text. With that in mind, the structure of addon.db needs to change so this is one way you could do it (my german in non-existant so it didn't even try):

NOTE: the number if items in each itemOrder should be the same as the number of %s tokens that are in the corresponding text field.
(This is probably overkill as it's replacing all the locale texts and you probably only need the ones that will be actually be used but that depends on what the end addon requires so...)

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = {
            enUS = "Herb-Infused Water",
            deDE = "Mit Kräutern aromatisiertes Wasser"
        },
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
             enUS = { -- the text to display for english
                 text = "Awarded for %s outstanding service %s to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald %s Dream to receive powerful \nequipment for your efforts",
                 itemOrder = { -- the order to display the items in english
                     210399,
                     210400,
                     210401,
                     210402,
                 },
             },
             deDE = { -- the text to display for german
                 text = "The items %s might be %s in a different %s order of items %s in german",
                 itemOrder = { -- the order to display the items in german
                     210401,
                     210402,
                     210399,
                     210400,
                 },
             },
        },
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
            enUS = { -- the text to display for english
                text = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts",
                itemOrder = { -- the order to display the items in english
                    20897,
                },
            },
            deDE = { -- the text to display for german
                text = "Only one %s in this entry",
                itemOrder = { -- the order to display the items in german
                    20897,
                },
            },
        }
    },
}
---------------------------------------------------------------------------------------------------
-- Code to replace %s in announce texts with item links. Replaces the GetItemLinkById(...) function
 
local itemList = {} -- table to save the itsmID to
 
for index, v in ipairs(addon.db) do -- get/save every itmeID in addon.db announce 
   for k, itemID in pairs(v.announce.enUS.itemOrder) do -- assumes all announce entries will use all the same itemIDs
      if not itemList[itemID] then
         itemList[itemID] = true
      end
   end
end
 
local function FormatTexts() -- fill addon.db with the item links
   for index, v in ipairs(addon.db) do
      for locale, settings in pairs(v.announce) do
         local order = {}   
         for i, link in ipairs(settings.itemOrder) do -- get the links in order from addon.db
            order[i] = itemList[link] -- and save them into a tmporary table
         end
         settings.text = format(settings.text, unpack(order)) -- replace %s with the ordered item links (unpack(table) returns a number keyed tables entries in order eg. order[1], order[2], order[3] etc.)
      end
   end
 
end
 
local function LoadItem(item) -- Get the links for all the saved itemIDs
   if item then
      itemList[item:GetItemID()] = item:GetItemLink()
   end
   local key = next(itemList, item and item.Next or nil)
   if not key then -- when we have all the links for all the items
      FormatTexts() -- Run FormatTexts() to do the text replacements
      return
   end
   local nextItem = Item:CreateFromItemID(key)
   nextItem.Next = key
   nextItem:ContinueOnItemLoad(function() LoadItem(nextItem) end)
end
LoadItem()

Hubb777

02-24-24 10:21 PM

Quote:

Originally Posted by Fizzlemizz (Post 343428)

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = {
            enUS = "Herb-Infused Water",
            deDE = "Mit Kräutern aromatisiertes Wasser"
        },
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
             enUS = { -- the text to display for english
                 text = "Awarded for %s outstanding service %s to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald %s Dream to receive powerful \nequipment for your efforts",
                 itemOrder = { -- the order to display the items in english
                     210399,
                     210400,
                     210401,
                     210402,
                 },
             },
             deDE = { -- the text to display for german
                 text = "The items %s might be %s in a different %s order of items %s in german",
                 itemOrder = { -- the order to display the items in german
                     210401,
                     210402,
                     210399,
                     210400,
                 },
             },
        },
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
            enUS = { -- the text to display for english
                text = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts",
                itemOrder = { -- the order to display the items in english
                    20897,
                },
            },
            deDE = { -- the text to display for german
                text = "Only one %s in this entry",
                itemOrder = { -- the order to display the items in german
                    20897,
                },
            },
        }
    },
}
---------------------------------------------------------------------------------------------------
-- Code to replace %s in announce texts with item links. Replaces the GetItemLinkById(...) function
 
local itemList = {} -- table to save the itsmID to
 
for index, v in ipairs(addon.db) do -- get/save every itmeID in addon.db announce 
   for k, itemID in pairs(v.announce.enUS.itemOrder) do -- assumes all announce entries will use all the same itemIDs
      if not itemList[itemID] then
         itemList[itemID] = true
      end
   end
end
 
local function FormatTexts() -- fill addon.db with the item links
   for index, v in ipairs(addon.db) do
      for locale, settings in pairs(v.announce) do
         local order = {}   
         for i, link in ipairs(settings.itemOrder) do -- get the links in order from addon.db
            order[i] = itemList[link] -- and save them into a tmporary table
         end
         settings.text = format(settings.text, unpack(order)) -- replace %s with the ordered item links (unpack(table) returns a number keyed tables entries in order eg. order[1], order[2], order[3] etc.)
      end
   end
 
end
 
local function LoadItem(item) -- Get the links for all the saved itemIDs
   if item then
      itemList[item:GetItemID()] = item:GetItemLink()
   end
   local key = next(itemList, item and item.Next or nil)
   if not key then -- when we have all the links for all the items
      FormatTexts() -- Run FormatTexts() to do the text replacements
      return
   end
   local nextItem = Item:CreateFromItemID(key)
   nextItem.Next = key
   nextItem:ContinueOnItemLoad(function() LoadItem(nextItem) end)
end
LoadItem()

Hello thank you very much. After this, the table call button stopped working.

Lua Code:

local addonName, addon = ...
 
-- function to show the item tooltip when a hyperlink is clicked
local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- Show the hyperling tooltip when clicked
    SetItemRef(link, text, nil, self);
end
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local locale = GetLocale() -- get the current locale eg. "frFR"
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        local announceText = item.announce[locale] or item.announce.enUS -- default to enUS if the locale text doesn't exist.
        tinsert(data, {announceText, item.icon, item.name})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
---------------------------------------------------------------------------------------------------
-- code to make item links work
            button:SetHyperlinksEnabled(true) -- Setup hyperlinking for each row
            button:SetScript("OnHyperlinkClick", OnHyperlinkClick) -- What to do when a link is clicked
---------------------------------------------------------------------------------------------------
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("LEFT", (0) * CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Rewards")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

Fizzlemizz

02-25-24 12:16 AM

At some point along the line the addon .db table go messed up and the name field in the first first entry became a table instead of a string.

The 2 files

data (addon.db)

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = "Emerald Mark of Mastery",
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
             enUS = { -- the text to display for english
                 text = "Awarded for %s outstanding service %s to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald %s Dream to receive powerful \nequipment for your efforts",
                 itemOrder = { -- the order to display the items in english
                     210399,
                     210400,
                     210401,
                     210402,
                 },
             },
             deDE = { -- the text to display for german
                 text = "The items %s might be %s in a different %s order of items %s in german",
                 itemOrder = { -- the order to display the items in german
                     210401,
                     210402,
                     210399,
                     210400,
                 },
             },
        },
    },
    {
        name = "Emerald Mark of Mastery",
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
            enUS = { -- the text to display for english
                text = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts",
                itemOrder = { -- the order to display the items in english
                    20897,
                },
            },
            deDE = { -- the text to display for german
                text = "Only one %s in this entry",
                itemOrder = { -- the order to display the items in german
                    20897,
                },
            },
        }
    },
}
---------------------------------------------------------------------------------------------------
-- Code to replace %s in announce texts with item links. Replaces the GetItemLinkById(...) function
 
local itemList = {} -- table to save the itsmID to
 
for index, v in ipairs(addon.db) do -- get/save every itmeID in addon.db announce 
   for k, itemID in pairs(v.announce.enUS.itemOrder) do -- assumes all announce entries will use all the same itemIDs
      if not itemList[itemID] then
         itemList[itemID] = true
      end
   end
end
 
local function FormatTexts() -- fill addon.db with the item links
   for index, v in ipairs(addon.db) do
      for locale, settings in pairs(v.announce) do
         local order = {}   
         for i, link in ipairs(settings.itemOrder) do -- get the links in order from addon.db
            order[i] = itemList[link] -- and save them into a tmporary table
         end
         settings.text = format(settings.text, unpack(order)) -- replace %s with the ordered item links (unpack(table) returns a number keyed tables entries in order eg. order[1], order[2], order[3] etc.)
      end
   end
 
end
 
local function LoadItem(item) -- Get the links for all the saved itemIDs
   if item then
      itemList[item:GetItemID()] = item:GetItemLink()
   end
   local key = next(itemList, item and item.Next or nil)
   if not key then -- when we have all the links for all the items
      FormatTexts() -- Run FormatTexts() to do the text replacements
      return
   end
   local nextItem = Item:CreateFromItemID(key)
   nextItem.Next = key
   nextItem:ContinueOnItemLoad(function() LoadItem(nextItem) end)
end
LoadItem()

Code (everything else)

Lua Code:

local addonName, addon = ...
 
-- function to show the item tooltip when a hyperlink is clicked
local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- Show the hyperling tooltip when clicked
    SetItemRef(link, text, nil, self);
end
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local locale = GetLocale() -- get the current locale eg. "frFR"
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        local announceText = item.announce[locale].text or item.announce.enUS.text -- default to enUS if the locale text doesn't exist.
        tinsert(data, {announceText, item.icon, item.name})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
---------------------------------------------------------------------------------------------------
-- code to make item links work
            button:SetHyperlinksEnabled(true) -- Setup hyperlinking for each row
            button:SetScript("OnHyperlinkClick", OnHyperlinkClick) -- What to do when a link is clicked
---------------------------------------------------------------------------------------------------
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("TOPLEFT", (0) * CELL_WIDTH, 0)
            button.columns[1]:SetPoint("BOTTOMRIGHT", button, "BOTTOMLEFT", CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Rewards")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

Hubb777

02-25-24 12:27 AM

Yes it works. Thank you very much. And the last question (with your help I have already figured out a lot)
I replaced

Lua Code:

name = "Emerald Mark of Mastery",

Lua Code:

name = {
            enUS = "Herb-Infused Water",
            deDE = "Mit Kräutern aromatisiertes Wasser"
        },

and the button stopped working =(

Fizzlemizz

02-25-24 12:52 AM

Because the original table wasn't set up with localised names, we were just dealing with the announce texts.

To add localise names you woud have to convert ALL the name entried to tables:

Data

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = {
            enUS = "Emerald Mark of Mastery",
            deDE = "German for Emerald Mark of Mastery",
        }
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
             enUS = { -- the text to display for english
                 text = "Awarded for %s outstanding service %s to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald %s Dream to receive powerful \nequipment for your efforts",
                 itemOrder = { -- the order to display the items in english
                     210399,
                     210400,
                     210401,
                     210402,
                 },
             },
             deDE = { -- the text to display for german
                 text = "The items %s might be %s in a different %s order of items %s in german",
                 itemOrder = { -- the order to display the items in german
                     210401,
                     210402,
                     210399,
                     210400,
                 },
             },
        },
    },
    {
        name = {
            enUS = "Name number 2",
            deDE = "German for Name number 2",
        }
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
            enUS = { -- the text to display for english
                text = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts",
                itemOrder = { -- the order to display the items in english
                    20897,
                },
            },
            deDE = { -- the text to display for german
                text = "Only one %s in this entry",
                itemOrder = { -- the order to display the items in german
                    20897,
                },
            },
        }
    },
}

And change the tinsert line in the updateData() function to reflect the change

Code

Lua Code:

local addonName, addon = ...
 
-- function to show the item tooltip when a hyperlink is clicked
local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- Show the hyperling tooltip when clicked
    SetItemRef(link, text, nil, self);
end
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local locale = GetLocale() -- get the current locale eg. "frFR"
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        local announceText = item.announce[locale].text or item.announce.enUS.text -- default to enUS if the locale text doesn't exist.
        tinsert(data, {announceText, item.icon, item.name[locale] or item.name.enUS})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
---------------------------------------------------------------------------------------------------
-- code to make item links work
            button:SetHyperlinksEnabled(true) -- Setup hyperlinking for each row
            button:SetScript("OnHyperlinkClick", OnHyperlinkClick) -- What to do when a link is clicked
---------------------------------------------------------------------------------------------------
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("TOPLEFT", (0) * CELL_WIDTH, 0)
            button.columns[1]:SetPoint("BOTTOMRIGHT", button, "BOTTOMLEFT", CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Rewards")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

Hubb777

02-25-24 01:02 AM

Quote:

Originally Posted by Fizzlemizz (Post 343439)

Because the original table wasn't set up with localised names, we were just dealing with the announce texts.

To add localise names you woud have to convert ALL the name entried to tables:

Data

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = {
            enUS = "Emerald Mark of Mastery",
            deDE = "German for Emerald Mark of Mastery",
        }
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
             enUS = { -- the text to display for english
                 text = "Awarded for %s outstanding service %s to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald %s Dream to receive powerful \nequipment for your efforts",
                 itemOrder = { -- the order to display the items in english
                     210399,
                     210400,
                     210401,
                     210402,
                 },
             },
             deDE = { -- the text to display for german
                 text = "The items %s might be %s in a different %s order of items %s in german",
                 itemOrder = { -- the order to display the items in german
                     210401,
                     210402,
                     210399,
                     210400,
                 },
             },
        },
    },
    {
        name = {
            enUS = "Name number 2",
            deDE = "German for Name number 2",
        }
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
            enUS = { -- the text to display for english
                text = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts",
                itemOrder = { -- the order to display the items in english
                    20897,
                },
            },
            deDE = { -- the text to display for german
                text = "Only one %s in this entry",
                itemOrder = { -- the order to display the items in german
                    20897,
                },
            },
        }
    },
}

And change the tinsert line in the updateData() function to reflect the change

Code

Lua Code:

local addonName, addon = ...
 
-- function to show the item tooltip when a hyperlink is clicked
local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- Show the hyperling tooltip when clicked
    SetItemRef(link, text, nil, self);
end
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local locale = GetLocale() -- get the current locale eg. "frFR"
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        local announceText = item.announce[locale].text or item.announce.enUS.text -- default to enUS if the locale text doesn't exist.
        tinsert(data, {announceText, item.icon, item.name[locale] or item.name.enUS})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
---------------------------------------------------------------------------------------------------
-- code to make item links work
            button:SetHyperlinksEnabled(true) -- Setup hyperlinking for each row
            button:SetScript("OnHyperlinkClick", OnHyperlinkClick) -- What to do when a link is clicked
---------------------------------------------------------------------------------------------------
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("TOPLEFT", (0) * CELL_WIDTH, 0)
            button.columns[1]:SetPoint("BOTTOMRIGHT", button, "BOTTOMLEFT", CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Rewards")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

I used your example but it still didn't work

Fizzlemizz

02-25-24 01:19 AM

Missing commas, mayube this time.

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = {
            enUS = "Emerald Mark of Mastery",
            deDE = "German for Emerald Mark of Mastery",
        },
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
             enUS = { -- the text to display for english
                 text = "Awarded for %s outstanding service %s to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald %s Dream to receive powerful \nequipment for your efforts",
                 itemOrder = { -- the order to display the items in english
                     210399,
                     210400,
                     210401,
                     210402,
                 },
             },
             deDE = { -- the text to display for german
                 text = "The items %s might be %s in a different %s order of items %s in german",
                 itemOrder = { -- the order to display the items in german
                     210401,
                     210402,
                     210399,
                     210400,
                 },
             },
        },
    },
    {
        name = {
            enUS = "Name number 2",
            deDE = "German for Name number 2",
        },
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
            enUS = { -- the text to display for english
                text = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts",
                itemOrder = { -- the order to display the items in english
                    20897,
                },
            },
            deDE = { -- the text to display for german
                text = "Only one %s in this entry",
                itemOrder = { -- the order to display the items in german
                    20897,
                },
            },
        }
    },
}
    ---------------------------------------------------------------------------------------------------
-- Code to replace %s in announce texts with item links. Replaces the GetItemLinkById(...) function
 
local itemList = {} -- table to save the itsmID to
 
for index, v in ipairs(addon.db) do -- get/save every itmeID in addon.db announce 
   for k, itemID in pairs(v.announce.enUS.itemOrder) do -- assumes all announce entries will use all the same itemIDs
      if not itemList[itemID] then
         itemList[itemID] = true
      end
   end
end
 
local function FormatTexts() -- fill addon.db with the item links
   for index, v in ipairs(addon.db) do
      for locale, settings in pairs(v.announce) do
         local order = {}   
         for i, link in ipairs(settings.itemOrder) do -- get the links in order from addon.db
            order[i] = itemList[link] -- and save them into a tmporary table
         end
         settings.text = format(settings.text, unpack(order)) -- replace %s with the ordered item links (unpack(table) returns a number keyed tables entries in order eg. order[1], order[2], order[3] etc.)
      end
   end
 
end
 
local function LoadItem(item) -- Get the links for all the saved itemIDs
   if item then
      itemList[item:GetItemID()] = item:GetItemLink()
   end
   local key = next(itemList, item and item.Next or nil)
   if not key then -- when we have all the links for all the items
      FormatTexts() -- Run FormatTexts() to do the text replacements
      return
   end
   local nextItem = Item:CreateFromItemID(key)
   nextItem.Next = key
   nextItem:ContinueOnItemLoad(function() LoadItem(nextItem) end)
end
LoadItem()

Lua Code:

local addonName, addon = ...
 
-- function to show the item tooltip when a hyperlink is clicked
local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- Show the hyperling tooltip when clicked
    SetItemRef(link, text, nil, self);
end
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local locale = GetLocale() -- get the current locale eg. "frFR"
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        local announceText = item.announce[locale].text or item.announce.enUS.text -- default to enUS if the locale text doesn't exist.
        tinsert(data, {announceText, item.icon, item.name[locale] or item.name.enUS})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
---------------------------------------------------------------------------------------------------
-- code to make item links work
            button:SetHyperlinksEnabled(true) -- Setup hyperlinking for each row
            button:SetScript("OnHyperlinkClick", OnHyperlinkClick) -- What to do when a link is clicked
---------------------------------------------------------------------------------------------------
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("TOPLEFT", (0) * CELL_WIDTH, 0)
            button.columns[1]:SetPoint("BOTTOMRIGHT", button, "BOTTOMLEFT", CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Rewards")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

Hubb777

02-25-24 01:29 AM

Quote:

Originally Posted by Fizzlemizz (Post 343441)

Missing commas, mayube this time.

Lua Code:

local addonName, addon = ...
addon.db = {
    {
        name = {
            enUS = "Emerald Mark of Mastery",
            deDE = "German for Emerald Mark of Mastery",
        },
        questID = 75612,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
             enUS = { -- the text to display for english
                 text = "Awarded for %s outstanding service %s to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald %s Dream to receive powerful \nequipment for your efforts",
                 itemOrder = { -- the order to display the items in english
                     210399,
                     210400,
                     210401,
                     210402,
                 },
             },
             deDE = { -- the text to display for german
                 text = "The items %s might be %s in a different %s order of items %s in german",
                 itemOrder = { -- the order to display the items in german
                     210401,
                     210402,
                     210399,
                     210400,
                 },
             },
        },
    },
    {
        name = {
            enUS = "Name number 2",
            deDE = "German for Name number 2",
        },
        questID = 75624,
        icon = "interface/icons/inv_mushroom_11",
        announce = {
            enUS = { -- the text to display for english
                text = "Awarded for outstanding service to Dragonkind.\n%s\nBring it to Theozhaklos the Curious at the Wellspring \nOverlook in the Emerald Dream to receive powerful \nequipment for your efforts",
                itemOrder = { -- the order to display the items in english
                    20897,
                },
            },
            deDE = { -- the text to display for german
                text = "Only one %s in this entry",
                itemOrder = { -- the order to display the items in german
                    20897,
                },
            },
        }
    },
}
    ---------------------------------------------------------------------------------------------------
-- Code to replace %s in announce texts with item links. Replaces the GetItemLinkById(...) function
 
local itemList = {} -- table to save the itsmID to
 
for index, v in ipairs(addon.db) do -- get/save every itmeID in addon.db announce 
   for k, itemID in pairs(v.announce.enUS.itemOrder) do -- assumes all announce entries will use all the same itemIDs
      if not itemList[itemID] then
         itemList[itemID] = true
      end
   end
end
 
local function FormatTexts() -- fill addon.db with the item links
   for index, v in ipairs(addon.db) do
      for locale, settings in pairs(v.announce) do
         local order = {}   
         for i, link in ipairs(settings.itemOrder) do -- get the links in order from addon.db
            order[i] = itemList[link] -- and save them into a tmporary table
         end
         settings.text = format(settings.text, unpack(order)) -- replace %s with the ordered item links (unpack(table) returns a number keyed tables entries in order eg. order[1], order[2], order[3] etc.)
      end
   end
 
end
 
local function LoadItem(item) -- Get the links for all the saved itemIDs
   if item then
      itemList[item:GetItemID()] = item:GetItemLink()
   end
   local key = next(itemList, item and item.Next or nil)
   if not key then -- when we have all the links for all the items
      FormatTexts() -- Run FormatTexts() to do the text replacements
      return
   end
   local nextItem = Item:CreateFromItemID(key)
   nextItem.Next = key
   nextItem:ContinueOnItemLoad(function() LoadItem(nextItem) end)
end
LoadItem()

Lua Code:

local addonName, addon = ...
 
-- function to show the item tooltip when a hyperlink is clicked
local function OnHyperlinkClick(self, link, text, region, left, bottom, width, heigh) -- Show the hyperling tooltip when clicked
    SetItemRef(link, text, nil, self);
end
 
local CELL_WIDTH = 400
local CELL_HEIGHT = 80
local NUM_CELLS = 2
 
local data = {}
 
local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")
 
-- Create the button here
local btn = CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate")
 
local locale = GetLocale() -- get the current locale eg. "frFR"
local function updateData()
    wipe(data)
    for _, item in ipairs(addon.db) do
        local announceText = item.announce[locale].text or item.announce.enUS.text -- default to enUS if the locale text doesn't exist.
        tinsert(data, {announceText, item.icon, item.name[locale] or item.name.enUS})
    end
end
 
f:SetSize(CELL_WIDTH * NUM_CELLS + 80, 600)
f:SetPoint("CENTER")
f:Hide()
f:SetMovable(true)
f:SetScript("OnMouseDown", f.StartMoving)
f:SetScript("OnMouseUp", f.StopMovingOrSizing)
 
-- I added this OnHide script
f:SetScript("OnHide", function()
    btn:Show()
end)
 
f.scrollFrame = CreateFrame("ScrollFrame", nil, f, "UIPanelScrollFrameTemplate")
f.scrollFrame:SetPoint("TOPLEFT", 12, -32)
f.scrollFrame:SetPoint("BOTTOMRIGHT", -34, 8)
 
f.scrollFrame.scrollChild = CreateFrame("Frame", nil, f.scrollFrame)
f.scrollFrame.scrollChild:SetSize(100, 100)
f.scrollFrame.scrollChild:SetPoint("TOPLEFT", 5, -5)
f.scrollFrame:SetScrollChild(f.scrollFrame.scrollChild)
 
local content = f.scrollFrame.scrollChild
content.rows = {}
 
local function updateList()
    for i = 1, #data do
        if not content.rows[i] then
            local button = CreateFrame("Button", nil, content)
            button:SetSize(CELL_WIDTH * NUM_CELLS, CELL_HEIGHT)
            button:SetPoint("TOPLEFT", 0, -(i - 1) * CELL_HEIGHT)
            button.columns = {}
 
---------------------------------------------------------------------------------------------------
-- code to make item links work
            button:SetHyperlinksEnabled(true) -- Setup hyperlinking for each row
            button:SetScript("OnHyperlinkClick", OnHyperlinkClick) -- What to do when a link is clicked
---------------------------------------------------------------------------------------------------
 
            button.columns[1] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[1]:SetPoint("TOPLEFT", (0) * CELL_WIDTH, 0)
            button.columns[1]:SetPoint("BOTTOMRIGHT", button, "BOTTOMLEFT", CELL_WIDTH, 0)
 
            button.columns[2] = button:CreateTexture()
            button.columns[2]:SetPoint("LEFT", 410, 0, (1) * CELL_WIDTH, 0)
 
            button.columns[3] = button:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
            button.columns[3]:SetPoint("LEFT", 480, 0, (2) * CELL_WIDTH, 0)
 
            content.rows[i] = button
        end
 
        content.rows[i].columns[1]:SetText(data[i][1])
        content.rows[i].columns[2]:SetTexture(data[i][2])
        content.rows[i].columns[3]:SetText(data[i][3])
 
        content.rows[i]:Show()
    end
 
    for i = #data + 1, #content.rows do
        content.rows[i]:Hide()
    end
end
 
 
-- Set your button options here
local btn = CreateFrame("Button", "Hubb777MovingButton", UIParent, "UIPanelButtonTemplate") 
btn:SetPoint("CENTER")
btn:SetSize(100, 40)
btn:SetText("Rewards")
btn:SetMovable(true)
btn:RegisterForDrag('LeftButton')
btn:RegisterForClicks("AnyDown", "AnyUp")
btn:SetUserPlaced(true)
btn:SetScript('OnDragStart', function(self, button, down)
    if button == "LeftButton" and IsShiftKeyDown() then
        self:StartMoving()
    end
end)
btn:SetScript('OnDragStop', function(self)
    self:StopMovingOrSizing()
end)
btn:SetScript("OnMouseUp", function(self, button, ...)
    if (button == "RightButton" and self:IsVisible()) then
        self:Hide()
    elseif button == "LeftButton" and not IsShiftKeyDown() then
        updateData()
        updateList()
        f:Show()
    end
end)
 
SLASH_HUBB1 = "/hubb"
SlashCmdList["HUBB"] = function(msg)
    if strupper(strtrim(msg)) == "BTN" then -- toggle the shown state of the button if the type /hubb btn
        btn:SetShown(not btn:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    f:Show()
end

It also didn't work. The button is not pressed.

Lua Code:

1x ZamTEST/table.lua:78: bad argument #1 to 'SetText' (Usage: self:SetText([text]))
[string "=[C]"]: in function `SetText'
[string "@ZamTEST/table.lua"]:78: in function <ZamTEST/table.lua:52>
[string "@ZamTEST/table.lua"]:113: in function <ZamTEST/table.lua:108>
 
Locals:
(*temporary) = FontString {
 0 = <userdata>
}
(*temporary) = <table> {
 itemOrder = <table> {
 }
 text = "Awarded for %s outstanding service %s to Dragonkind.
%s
Bring it to Theozhaklos the Curious at the Wellspring 
Overlook in the Emerald %s Dream to receive powerful 
equipment for your efforts"
}

Fizzlemizz

02-25-24 01:40 AM

Then you're using different code. Line 78 in the code I posted (and you re-posted) is either and end or a blank line so, nothing to do with self:SetText()

I can't diagnose what I can't see.

My best guess is you didn't use the updateData() function from my code in whatever your using.

Hubb777

02-25-24 01:55 AM

Quote:

Originally Posted by Fizzlemizz (Post 343443)

Yes, indeed, I made changes to another file. It's my mistake, sorry. And a couple more questions (I understand that I just bombarded you with questions) these will be the last.

1. If I want to make a similar addon, as I understand it, I will need to change (the code below) to which one?

Lua Code:

local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")

2. how do I add a table title (in different languages)

Fizzlemizz

02-25-24 02:12 AM

Both

Lua Code:

local f = CreateFrame("Frame", "Addon_1_Name_Frame", UIParent, "BasicFrameTemplateWithInset")

Lua Code:

local f = CreateFrame("Frame", "Addon_2_Name_Frame", UIParent, "BasicFrameTemplateWithInset")

Probably not a lot of point changing the addon title language unless you are going to post it in language specific sites under different names. If you are just hosting it on WowInterace/Curse/Wago people will find it using the single addon name which would be the same in any language so may as well be the title.

To add a title, after:

Lua Code:

local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")

add:

Lua Code:

f.Title = f:CreateFontstring(nil, "ARTWORK", "GameFontNormal")
f.Title:SetPoint("TOP", 0, -4)
f.Title:SetText("Your Addon Name")

Hubb777

02-25-24 02:17 AM

Quote:

Originally Posted by Fizzlemizz (Post 343445)

Both

Lua Code:

local f = CreateFrame("Frame", "Addon_1_Name_Frame", UIParent, "BasicFrameTemplateWithInset")

Lua Code:

local f = CreateFrame("Frame", "Addon_2_Name_Frame", UIParent, "BasicFrameTemplateWithInset")

Lua Code:

local f = CreateFrame("Frame", "SimpleScrollFrameTableDemo", UIParent, "BasicFrameTemplateWithInset")

add:

Lua Code:

f.Title = f:CreateFontstring(nil, "ARTWORK", "GameFontNormal")
f.Title:SetPoint("TOP", 0, -4)
f.Title:SetText("Your Addon Name")

It looks like the problem with different languages has played a cruel joke again. Not the addon name, but my table name. For example, I will name the table “Possible rewards” or “List of pets”, I would like this inscription to also have a translation.

Fizzlemizz

02-25-24 02:41 AM

Quote:

Originally Posted by Hubb777 (Post 343446)

Create a table for your texts (1 sub-table for each with text you want on screen that contains the localised version of the title/whatever. eg.

Lua Code:

addon.Texts = {
    Rewards = {
        enUS = "Possible Rewards",
        deDE = "German for Possible Rewards",
    },
    Pets = {
        enUS = "List of pets",
        deDE = "German List of pets",
    },
}

You can then create FontStrings and set their texts using (set Rewards text):

Lua Code:

xxx:SetText(addon.Texts.Rewards[GetLocal()] or addon.Texts.Rewards.enUS) -- enUS being the default is the GetLocale() entry doesn't exist.

xxx being the variable used when creating the FontString.

You might want to see the wiki on localisation if it gets more complicated.

Hubb777

02-25-24 02:59 AM

Should I create a new lua file tablename.lua? With

Lua Code:

addon.Texts = {
    Rewards = {
        enUS = "Possible Rewards",
        deDE = "German for Possible Rewards",
    },
    Pets = {
        enUS = "List of pets",
        deDE = "German List of pets",
    },
}

And add this file to table.lua

Lua Code:

Pets:SetText(addon.Texts.Rewards[GetLocal()] or addon.Texts.Rewards.enUS) -- enUS being the default is the GetLocale() entry doesn't exist.

Fizzlemizz

02-25-24 08:32 AM

addon.Texts can go in the same file as addon.db as that seems to be where you're putting "data". Assuming that this file is listed in the .TOC file above the other (table.lua) file so it loads first.

Lua Code:

Pets:SetText(addon.Texts.Rewards[GetLocal()] or addon.Texts.Rewards.enUS) -- enUS being the default is the GetLocale() entry doesn't exist.

Goes after you've:

Lua Code:

local Pets = someframe:CreateFontString(nil, somedrawlayer, somefont)

You can't fontstring:SetText(...) on a FontString that doesn't exist.

Hubb777

02-25-24 10:55 PM

Quote:

Originally Posted by Fizzlemizz (Post 343449)

Lua Code:

Pets:SetText(addon.Texts.Rewards[GetLocal()] or addon.Texts.Rewards.enUS) -- enUS being the default is the GetLocale() entry doesn't exist.

Goes after you've:

Lua Code:

local Pets = someframe:CreateFontString(nil, somedrawlayer, somefont)

You can't fontstring:SetText(...) on a FontString that doesn't exist.

This is the code I got

Lua Code:

local Pets = someframe:CreateFontString(nil, somedrawlayer, somefont)
Pets:SetText(addon.Texts.Rewards[GetLocal()] or addon.Texts.Rewards.enUS)
addon.Texts = {
    Rewards = {
        enUS = "Possible Rewards",
        deDE = "German for Possible Rewards",
    },
    Pets = {
        enUS = "List of pets",
        deDE = "German List of pets",
    },
}

Wherever I insert it, either the button disappears or it cannot be pressed. And if everything is pressed, there is no result.

Fizzlemizz

02-26-24 08:59 AM

Because you refuse to read and consider what has been written. In the last post, not even considered what was asked.

Most parts of an addon are created, positioned, formatted etc. in relation to something else depending on what you want your addon to do and how you want it to look and work. Not being a mind reader (and I can't read you screen), I'm not about to decide that for you, all I can do is offer suggestions on how you might do things. It's up to you work that information (if you think it might be useful) into your addon.

With that in mind, not every code block is literal, someframe, somedrawlayer, somefont are for you to replace with whatever works for you and your addon.

Hubb777

02-26-24 10:28 PM

Quote:

Originally Posted by Fizzlemizz (Post 343458)

Hello. Sorry for the misunderstanding. It’s just that English is not my native language (I’m writing from the Czech Republic). For some of the text I have to use Google Translate (which makes it even more difficult to understand).

I'll try to figure out the issue again.
As I understand it, I can place this part of the code in the code file db.lua

Lua Code:

addon.Texts = {
    Rewards = {
        enUS = "Possible Rewards",
        deDE = "German for Possible Rewards",
    },
    Pets = {
        enUS = "List of pets",
        deDE = "German List of pets",
    },
}

And this part in code table.lua

Lua Code:

local Pets = someframe:CreateFontString(nil, somedrawlayer, somefont)
Pets:SetText(addon.Texts.Rewards[GetLocal()] or addon.Texts.Rewards.enUS)

Fizzlemizz

02-27-24 09:33 AM

Correct,

Lua Code:

local Pets = someframe:CreateFontString(nil, somedrawlayer, somefont)

Replace someframe with the frame you want to be the parent of the new FontString
The parent will effect the Fonstrings scale and when it's, shown/hidden etc.

Replace somedrawlayer and somefont with the relevent information depending on where in the layer stack you want the string displayed and the font/size you want the text to be displayed in. See the docs for CreateFontString and see this page for some of the in-game fonts configurations ie. GameFontNormal, GameFontHighlight etc. etc. etc.

You can't use someframe (whichever that frame is) to create the FontString until after the frame itself has been created (The order that code is placed (runs) matters).

Hubb777

03-02-24 11:56 PM

Quote:

Originally Posted by Fizzlemizz (Post 343464)

Correct,

Lua Code:

local Pets = someframe:CreateFontString(nil, somedrawlayer, somefont)

Hello. After several days I still couldn't figure it out (I'm stupid). I made the addon without these changes, it turned out pretty good.
https://www.wowinterface.com/downloa...o.php?id=26699

Fizzlemizz

03-03-24 11:13 AM

Congratulations:banana:

The more you play with it, the more you'll learn. Have Fun!

All times are GMT -6. The time now is 06:34 AM.