Multishot (Screenshot)
 

Hello and welcome to Multishot - a tiny addon that automatically takes screenshots of memorable events in your World of Warcraft career. It's a photo diary of everything you come across in Azeroth, Outland, Northend and Pandaria.

This thread contains some technical information about Multishot and hopefully lots of comments, feature requests & bug reports.

Multishot uses LibBossIDs to detect boss kills. On every instanced monster's death Multishot checks its unique Id and takes a screenshot if it's a boss. Additional to that we've created our own database with all rare/rare-elite mobs and some blacklist/whitelist stuff.

Features

• level-ups and guild level-ups
• achievements and guild achievements
• challenge mode medals
• reputation changes
• trade window transactions
• any rare/rare-elite mob kills
• timeline; take a screenshot every x minutes (configurable)
• keybind; take a custom screenshot on demand

Anyone who has contributed: I really appreciate your help! Thanks for improving Multishot by adding new features to the source code, reporting & fixing bugs, and so on. Keep it going!

:banana:

Just noticed that the delay doesn't seem to click in for boss kills, but works for the achievements.

Any chance you can time things like big critical hits or does that happen to fast?

Also a way to set the threshold so it only would go off on big pvp hits?

when I turn off shots for boss kills but leave on achievements it doesn't seem to work. but if I have boss kills on then it takes pics of achievements.

Dear Tondef and skarrde,

I couldn't reproduce your problems, worked fine for me. Please update to Multishot 1.4 and post again if anything is not working as intented.

dlui

I had same problem as Skarrde. I changed bit of your code, and it seems problem is solved.

function Multishot:COMBAT_LOG_EVENT_UNFILTERED() in Multishot.lua:

Thank you. Please update to Multishot 1.5! :eek:

Feature request:

Can you make an option so that the addon shows text when I level (Such as in the middle of the screen "Congradulations for reaching level 65" for example) and take a screenshot WHILE that text is being displayed?

http://www.wowinterface.com/download...elUpGrats.html does that :)

Maybe add a feature to take a Screenshot when you are Exalted with a Reputation? :D

The author just needs to delay the shot by like 1 second I believe.

That's already build in.

I don't know a nice way to take screenshots on reputation level ups, any ideas on how to implement that?

Sample Code (tested in a mini-addon):
1. In function Multishot:OnEnable() add
2. Create a capture pattern from the global rep standing change formatstring:
This will make your capture pattern locale independent.

3. In your CHAT_MSG_SYSTEM event handler:
Check arg1 (the first argument of the event is the actual message)
against your capture pattern.
4. If you catch a relevant system message and newstanding is not nil:
Compare it with the global standing labels (this will also work locale independent)
This would only screenshot if you just gained Exalted status.
To check for other rep standings or make it screenshot on any major rep change,
you'd need to check against FACTION_STANDING_LABELx or FACTION_STANDING_LABELx_FEMALE
where x is 1 to 8 and corresponds to Hated, Hostile, Unfriendly, Neutral, Friendly, Honored, Revered, Exalted.

Hope it helps :)

Making it a bit simpler.

The modified Multishot.lua can be found on this pastey.
The modified config.lua on this one.

Tested and working.

Wow - that's cool, thanks! I've updated Multishot with your changes.

Multishot, now with screenshots for reputation levels - thanks to Dridzt!

Since 3.3 I've not been getting any screenshots on boss kills in 10/25 man instances - specifically Icecrown and ToC. It seems to work fine still in Naxxramas and for achievements/rep increases, but I'm not getting anything in the new raid instances. This might be a problem with the library?

That's correct.

Until dlui posts a repack you can manually update with the latest LibBossID library from here:
http://www.wowace.com/addons/libbossids-1-0/files/

Get the topmost file and extract it inside Multishot folder.

Problem with Multishot r34 in WoW 3.3 (using with the latest LibBossIDs-1.0 r36 from Dec. 9/09).

Its consistently taking screenshots of certain trash mob deaths in the new Pit of Saron 5-man instance. Specifically: Ymirjar Flamebearers, Ymirjar Flamebearers and/or Ymirjar Wrathbringers.

No, its not connected to any reputation level gains or anything else. Have yet kill the first mob group up the path after the Krick & Ick boss without it taking an unwanted screenshot.

(First posted a month ago on the addon thread. Problem is still occurring with Multishot r36, as is to be expected).

I have been updating LibBossID diligently and have run the 3 new heroics numerous times.

Going back in my screenshots folder a month+ I can find several killshots of bosses but not even 1 false positive involving that trash.

(I just did a hPoS run again tonight couple hours before posting and Multishot works as expected).

The only screenshots of trash I can find is related to reputation gains.

Any chance you have moved reputations messages to another chatframe,
or you were gaining reputation for factions you have moved to "inactive"?
"Inactive" marked reps will not switch the repbar (if you have an autoswitch addon and rely on that to notice rep gains).

Considering you are the only one reporting this "problem" I'd start looking at conflicts or other explanations because I don't think there's any problem with Multishot.

A few more IDs for your blacklist that lead to false positives.

Not Multishot's fault, LibBossID has them in to accomodate bossmods
(since it's 'trash' linked to the outcome of raid encounters).

Whatever the reason it leads to Multishot taking some unwanted screenies.
-- Naxxramas
[16803] = true, -- DeathKnight Understudy: Razuvious "adds"
[15930] = true, -- Feugen (Thaddius pre-event)
[15929] = true, -- Stalagg (Thaddius pre-event)
-- Ulduar
[32933] = true, -- Left Arm (Kologarn's arms)
[32934] = true, -- Right Arm (Kologarn's arms)
-- Icecrown Citadel
[37217] = true, -- Precious (Festergut/Rotface "pets")
[37025] = true, -- Stinky (Festergut/Rotface "pets")

Regards.

Rares?
 

Would it be possible to add the ability to take a screenshot when you kill a rare? Paparazzi has this, and I find its about the only thing I can think of that I'd like this to do. Thanks for a great addon and keep up the great work!

It's definitely possible but there is a bit of deliberation involved.

There's 2 ways of doing this:
- Use a list of rares (by mining wowhead) similarly to how the addon uses a list of bosses (provided by LibBossID)
- Use API to determine if the mob killed was a rare.

There's pros and cons to both methods.
List pretty much ensures you will not miss a rare screenshot (if your list is complete)
but you can end up with screenshots when others (in combatlog distance) kill a rare.

I'm testing a method that doesn't rely in a hardcoded list but it is a bit hard to find rares on demand :)

Anyway I'll probably post some code tomorrow or the next day for both methods and dlui can decide if and which he'd like to use :)

Changed files (against Multishot r39.1) for:

Method A (rares determined by API)
-----------------------------------
Multishot.lua http://www.pastey.net/131911
Config.lua http://www.pastey.net/131912
This will catch any rare or rare elite that you kill provided it was your target at the time of death.
Pros: no need for a hardcoded list and "auto updates" if new rares are added to the game.
Cons: you can lose a screenshot if somehow the mob is not targetted when it dies.

Method B (rares determined by a list of IDs)
------------------------------------------
A new file added to the addon folder...
Rares.lua http://www.pastey.net/131915
and to Multishot.toc http://www.pastey.net/131916
Multishot.lua http://www.pastey.net/131913
Config.lua http://www.pastey.net/131912 (same as above)
Pros: Will catch any rare killed that's included in the list regardless if it was targetted.
Cons: The included list will need updates if new rares are added / discovered.
It will take screenshots when a rare is killed in combatlog range regardless if it was the player's kill.

Great Work. Thanks. :banana:

But which of the two solutions should I add? :confused:

Does UnitClassification("target") work? Isn't the target cleared on killing a mob?

Maybe combining these two methods: if UnitClassification isn't a match let's ask our inbuild db? :o

UnitClassification works and the target is cleared but after UNIT_DIED fires.
So if you had the mob targetted as it died the screenshot is taken as expected.

I can't think of a way to combine the 2 so that they complement each other.
The list will catch all rare kills included in it.
Trying to qualify it by checking that it was your target as it died (weeding out false positives: other peoples kills in the vicinity)
will effectively be the same as if you didn't use a list at all and only used the classification+target method.
What might make some sense is check classification after checking the list ('or' logic) to catch a rare that isn't included in the list (was recently put in game, or hasn't been encountered/datamined by wowhead or the list of ids included in the addon is incomplete).
I imagine this to be an extremely rare occurrence.

Flipping a coin would be an idea :p

Edit: Maybe go with the more 'catch all' (safer) approach of the list.
A false positive here and there shouldn't be an issue for the majority of users.

I've uploaded the second solution. Thanks again! :banana:

Hello! Love the mod. I'm having a problem with it since I updated it to the latest version that was released on 1/31. Every time I kill a boss it takes a screen shot, and I have it disabled because I don't want a screen shot of every boss I kill. Anyway to fix this? I only want the mod to take a screen shot of achievements I get. Thanks!

I have to take the blame for that one. :o

It is a side-effect of the code added to support rares.

dlui's previous version was only monitoring the combatlog for deaths when the option to take screenshots in party or raid was selected.

As a temporary workaround you can uncheck the rares option and the addon will revert to the previous behavior.

For a proper fix a minor edit is necessary.

This should fix that glitch and allow both bosskill and rare kill options to work independently.

Multishot.lua (off 39.2)
http://www.pastey.net/132597

As per my Dec. 17/09 post in the Multishot comments:

This problem is still occurring on every run of PoS heroic in WoW 3.3.2 live with Multishot r42. Have also seen it occur in other instances/raids.

User chicknlil25 debugged this.
Answer is in comment section.

Short version:
Addon takes a screenshot when Jaina/Tyranus Roleplay finishes and Ick is killed.

This has been fixed in r42a. Thanks for reporting.

:banana:

Multishot r44b is out with tons of new features! :banana:

The sad part is I'm almost sure that I messed up something. So if anybody please could have a look at the source code if I made a mistake?

Please report bugs as soon as possible!

Bug Report! :D


Multishot-r44b\Locales\Locale-deDE.lua:2: attempt to index local 'L' (a nil value)

but deDE is German, right? I'm not German, and neither is my client... dunno if that's important :D

Thank you. Could it be that you did not restart WoW after updating?

nope, I always log out to install addons... that said, I do have rather a lot, so in all likelyhood, it's not yours that is causing the problem.

Even then, it's not really a problem, it doesn't seem to break anything. I deleted Locale-deDE.lua and removed the reference to it from Locales.xml, which has stopped the bug from showing up :)

robthedude: fixed, thank you.

Could you add the option to open the character window when taking the screenshot?

I like to take a screenshot of my character at every level, to see how their appearance changes over the levels.

Thx for the addon!

Hi xzbbzx. Thanks for the suggestion. I'll think of a way to implement that.

Toggling off UI when taking a auto screen shot
 

would be nice if the addon had a option to toggle off UI when taking a screen shot for clean guild kill screen shots for guild web sites i tend to forget to take screen shot so i love this addon the bad part is you can see all my crap in the screen shots so was wondering if you can add a funtion to toggle off ui when it taks the screen shot

dear Nitearrow01,

as far as i know there is no clean way for an addon to hide the ui while in combat.

sorry.

Try this dlui.

Wow! Thats cool! I'll try to implement it.

Thanks! You are great.

Tested changes:

• Multishot.lua + diff to r44d
• Config.lua + diff (also corrected a typo in the defaults, close menus var was listed as 'hide' instead of 'close')
• Locale-enUS.lua + diff (deDE would need the addition too)

Dridzt, you seriously are a real mastermind!

I've uploaded your changes.

Fantastic!

Thanks again! You are great!

:banana:

Don't be too fast to thank me :p

Running with it there are some "side-effects" :o

The way the setting works now is like a global switch, but some screenshots are not served well from hiding the UI.
For example trade/achievement shots as the achievement/trade frame is also hidden.

I guess it should be made a little "smarter" so it only hides the UI for killshots.

Since you're passing the originating event to the screenshot function a way to make it more intuitive
would probably be to check that it's coming from PLAYER_REGEN_ENABLED and not another event.
eg.
It's good as proof of concept anyway, since it does simulate Alt+z
without running against protected status or causing taint.

Loving the mod. Just a question and a request:

1)Which JPEG quality setting matches the default screenshot one?

2)Would it be possible to add an option to take a screenshot after a certain time delay from boss fight start? I'm just trying to get some nice action shots of my UI and killshots don't really work well for that. Of course remembering to take a screenshot manually during fight is also beyond my capabilities.

Dear Dridzt, yes, I thought about that after uploading, too. I will upload the line you proposed. Nice idea, thank you. What only would I do without your help!

And EricT, GetCVar("screenshotQuality") is 3 for me so that should be the default quality?

Yes, infight screenshots would be possible. Idea: taking a screenshot of every 20% boss hp loss? How would you like that?

Is there any chance you could add a random timer screenshot? Something to take a screenshot every 30 minutes or so?

The addon called AutoScreenShot (http://www.wowinterface.com/download...creenshot.html) use to do it. There is a minor issue with the use of code that isn't used anymore (this.something). Sadly I don't know enough about xml to make the needed changes.

I love Multishot and use it. I also loved the above mod as well but am unable to fix it. It seems like it would be a good fit as an option in Multishot though and could be simple to add given the previous work that has been done already.

ScrapBook will do what you want. The only reason I linked that: please don't add that feature to MultiShot.

Thanks for the link to that. It looks like it will do exactly what I am looking for assuming I can hide the watermaro. I had been searching for mode using the word screenshot and screenshot and kept coming up with nothing relevant.

Out of curiosity, why wouldn't you want this as an option in multoshot?

Trade Bug
 

I ran across a nasty bug that's made me disable multishot until we can resolve it. D:

For some reason every time I try to trade with someone, after a moment multishot closes the window and takes a screencap. The same thing happens if I manage to keep it open long enough to press the 'trade' button on the bottom, it immediately closes the trade without swapping anything so it can take a picture. D:

What's going on? T_T

Thanks for the report Kittenykat. This has been fixed.

oy.. yeah I figured it out, hopefully you did too ¬_¬;;

So yeah, if you go and leave the 'take pictures of trade windows' on like it is by default, when you click 'close ui windows' at the bottom it kinda creates this conflict. xD

I feel silly now. :o

Yes, exactly, but don't worry, it's fixed now no matter what options have bin enabled/disabled. Thanks for the report! ;)

Big thanks to Dridzt for keeping the addon updated!

:banana:

Add an option to screenshot Battleground / Arena losses as well.


Who's to say losing a AB by 1 point doing 20m damage and 30kb's isn't screenshot worthy? :D

WoW Classic
 

Anyone figured out how to make this work in WoW Classic yet?