Rares?
 

Would it be possible to add the ability to take a screenshot when you kill a rare? Paparazzi has this, and I find its about the only thing I can think of that I'd like this to do. Thanks for a great addon and keep up the great work!

It's definitely possible but there is a bit of deliberation involved.

There's 2 ways of doing this:
- Use a list of rares (by mining wowhead) similarly to how the addon uses a list of bosses (provided by LibBossID)
- Use API to determine if the mob killed was a rare.

There's pros and cons to both methods.
List pretty much ensures you will not miss a rare screenshot (if your list is complete)
but you can end up with screenshots when others (in combatlog distance) kill a rare.

I'm testing a method that doesn't rely in a hardcoded list but it is a bit hard to find rares on demand :)

Anyway I'll probably post some code tomorrow or the next day for both methods and dlui can decide if and which he'd like to use :)

Changed files (against Multishot r39.1) for:

Method A (rares determined by API)
-----------------------------------
Multishot.lua http://www.pastey.net/131911
Config.lua http://www.pastey.net/131912
This will catch any rare or rare elite that you kill provided it was your target at the time of death.
Pros: no need for a hardcoded list and "auto updates" if new rares are added to the game.
Cons: you can lose a screenshot if somehow the mob is not targetted when it dies.

Method B (rares determined by a list of IDs)
------------------------------------------
A new file added to the addon folder...
Rares.lua http://www.pastey.net/131915
and to Multishot.toc http://www.pastey.net/131916
Multishot.lua http://www.pastey.net/131913
Config.lua http://www.pastey.net/131912 (same as above)
Pros: Will catch any rare killed that's included in the list regardless if it was targetted.
Cons: The included list will need updates if new rares are added / discovered.
It will take screenshots when a rare is killed in combatlog range regardless if it was the player's kill.

Great Work. Thanks. :banana:

But which of the two solutions should I add? :confused:

Does UnitClassification("target") work? Isn't the target cleared on killing a mob?

Maybe combining these two methods: if UnitClassification isn't a match let's ask our inbuild db? :o

UnitClassification works and the target is cleared but after UNIT_DIED fires.
So if you had the mob targetted as it died the screenshot is taken as expected.

I can't think of a way to combine the 2 so that they complement each other.
The list will catch all rare kills included in it.
Trying to qualify it by checking that it was your target as it died (weeding out false positives: other peoples kills in the vicinity)
will effectively be the same as if you didn't use a list at all and only used the classification+target method.
What might make some sense is check classification after checking the list ('or' logic) to catch a rare that isn't included in the list (was recently put in game, or hasn't been encountered/datamined by wowhead or the list of ids included in the addon is incomplete).
I imagine this to be an extremely rare occurrence.

Flipping a coin would be an idea :p

Edit: Maybe go with the more 'catch all' (safer) approach of the list.
A false positive here and there shouldn't be an issue for the majority of users.

I've uploaded the second solution. Thanks again! :banana:

Hello! Love the mod. I'm having a problem with it since I updated it to the latest version that was released on 1/31. Every time I kill a boss it takes a screen shot, and I have it disabled because I don't want a screen shot of every boss I kill. Anyway to fix this? I only want the mod to take a screen shot of achievements I get. Thanks!

I have to take the blame for that one. :o

It is a side-effect of the code added to support rares.

dlui's previous version was only monitoring the combatlog for deaths when the option to take screenshots in party or raid was selected.

As a temporary workaround you can uncheck the rares option and the addon will revert to the previous behavior.

For a proper fix a minor edit is necessary.

This should fix that glitch and allow both bosskill and rare kill options to work independently.

Multishot.lua (off 39.2)
http://www.pastey.net/132597

As per my Dec. 17/09 post in the Multishot comments:

This problem is still occurring on every run of PoS heroic in WoW 3.3.2 live with Multishot r42. Have also seen it occur in other instances/raids.

User chicknlil25 debugged this.
Answer is in comment section.

Short version:
Addon takes a screenshot when Jaina/Tyranus Roleplay finishes and Ick is killed.

This has been fixed in r42a. Thanks for reporting.

:banana:

Multishot r44b is out with tons of new features! :banana:

The sad part is I'm almost sure that I messed up something. So if anybody please could have a look at the source code if I made a mistake?

Please report bugs as soon as possible!

Bug Report! :D


Multishot-r44b\Locales\Locale-deDE.lua:2: attempt to index local 'L' (a nil value)

but deDE is German, right? I'm not German, and neither is my client... dunno if that's important :D

Thank you. Could it be that you did not restart WoW after updating?

nope, I always log out to install addons... that said, I do have rather a lot, so in all likelyhood, it's not yours that is causing the problem.

Even then, it's not really a problem, it doesn't seem to break anything. I deleted Locale-deDE.lua and removed the reference to it from Locales.xml, which has stopped the bug from showing up :)

robthedude: fixed, thank you.

Could you add the option to open the character window when taking the screenshot?

I like to take a screenshot of my character at every level, to see how their appearance changes over the levels.

Thx for the addon!

Hi xzbbzx. Thanks for the suggestion. I'll think of a way to implement that.

Toggling off UI when taking a auto screen shot
 

would be nice if the addon had a option to toggle off UI when taking a screen shot for clean guild kill screen shots for guild web sites i tend to forget to take screen shot so i love this addon the bad part is you can see all my crap in the screen shots so was wondering if you can add a funtion to toggle off ui when it taks the screen shot