Go to Page... |
Updated: | 07-14-09 04:41 AM |
Created: | 06-23-09 06:53 AM |
Downloads: | 3,189 |
Favorites: | 25 |
MD5: |
Comment Options |
10-03-10, 02:58 PM | |
|
Thanks for the code; used it, has fixed the ammo issue.
Something else that may (or may not) be insignificant as Cataclysm/4.x fast approaches. The confirmation box quantity math is off a fair bit in various circumstances. Started leveling the hunter (that had the previous ammo problem) as well as a Paladin in the past couple of months. On the hunter, added the following item to buy with GetReagents at vendors: Pungent Seal Whey x60. Have it set to bring up the confirmation box (as always). Every time the box comes up, it states that its going to buy "200" of those items. The cost of the 60 (or however many needed to stack) items is shown correctly, but the quantity never is. It always shows "200" in the confirm box. Regardless of that, it still buys the proper quantity, as reflected in the given cost in the confirm box. But its a somewhat distracting seeing a quantity its not buying (and you haven't set it to) displayed. Similar problem on the Paladin. Have it set to buy (with conformation) Symbol of Kings x300. Any time the existing quantity on the character is 200 or more and you open a vendor window, the confirm box displays both the proper quantity & the cost. But drop below 200 Symbol of Kings on the character when opening a vendor, the quantity in the confirm box switches strangely to "2000". The cost shown is appropriate, but not the quantity. Like the Hunter water above, though, it always buys the correct amount. It just displays the wrong quantity when dropping below 200 on the character when opening the vendor. This behavior is consistent on both characters on vendor window openings. Hope its a simple fix |
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
Recluse |
View Public Profile |
Send a private message to Recluse |
Visit Recluse's homepage! |
Find More Posts by Recluse |
Add Recluse to Your Buddy List |
03-21-10, 01:44 AM | |
|
Sorry to see that you won't be updating/fixing this anymore in conjunction with your new, limited feature GetReagents-Lite. Purchase confirmation (unavailable in GetReagents-Lite) is the main reason I have been using it.
Anyway, sorry to see it abandoned. It does have a bug in a certain scenario, if you ever want to pick it up again. On a mid-level hunter, WoW 3.3.2.11403 live, USEnglish client/server. Set 2000 Impact Shots to be bought. Head to Thurman Mullby, an Alliance "General Goods" vendor who carries those bullets (on page 3 of 4 of his items). Open the vendor, an error is thrown up. Also get a chat warning that I "don't have enough money" (which is false, there is 80+ gold on that test character) and nothing is bought (and the confirm box does not appear): Code:
["message"] = "GetReagents\\GetReagents.lua:194: attempt to compare string with number\nGetReagents\\GetReagents.lua:24: in function `?'\nGetReagents\\GetReagents.lua:27: in function <Interface\\AddOns\\GetReagents\\GetReagents.lua:27>\n\nLocals:|r\nself = GetReagents {\n VARIABLES_LOADED = <function> defined @Interface\\AddOns\\GetReagents\\GetReagents.lua:26\n 0 = <userdata>\n UpdateSettings = <function> defined @Interface\\AddOns\\GetReagents\\GetReagents.lua:225\n MERCHANT_SHOW = <function> defined @Interface\\AddOns\\GetReagents\\GetReagents.lua:24\n MERCHANT_CLOSED = <function> defined @Interface\\AddOns\\GetReagents\\GetReagents.lua:25\n}\nHasReagents = <function> defined @Interface\\AddOns\\GetReagents\\GetReagents.lua:37\nConfirmPurchase = <function> defined @Interface\\AddOns\\GetReagents\\GetReagents.lua:191\n\n ---", ["type"] = "error", ["session"] = 1399, ["counter"] = 5, }, -- [477] |
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Visit Zidomo's homepage! |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
10-21-09, 06:43 AM | |
|
r217 has been working reliably for months without issues, so haven't really thought about it too much again. But more guild members here I have recommended it to and they brought up the issue I described to you earlier. The confirmation box is still too dark & transparent.
I assume that the color & transparency are set by lines 167 & so on in the GetReagents.lua file. By default, if you could change the transparency (first) to completely go away and the color (second) to not be so dark for users other than me who don't edit LUA files, it would improve this mod from being great to being perfect . |
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Visit Zidomo's homepage! |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
07-14-09, 05:11 AM | ||
|
Re: Login Spam, Load On Event
__________________
if (sizeof(workload) > sizeof(brain_capacity)) { die('System Overload'); }
Last edited by Caellian : 07-14-09 at 05:12 AM.
|
|
|
Caellian |
View Public Profile |
Send a private message to Caellian |
Visit Caellian's homepage! |
Find More Posts by Caellian |
Add Caellian to Your Buddy List |
07-14-09, 05:02 AM | ||||
|
Login Spam, Load On Event
I do plan on moving the creation of the confirmation dialog to a more proper place, which will prevent it from using the few kb the dialog eats until it wants to buy stuff, but haven't gotten around to it yet. The options dialog however, doesn't truly load until you open the GUI currently.
__________________
We'd be together, but only diamonds last forever...
Last edited by Recluse : 07-14-09 at 05:04 AM.
|
|||
|
Recluse |
View Public Profile |
Send a private message to Recluse |
Visit Recluse's homepage! |
Find More Posts by Recluse |
Add Recluse to Your Buddy List |
07-14-09, 04:44 AM | |
|
Few suggestions:
1. not have the slash commands message every login 2. have the addon only load OnEvent, for example with MERCHANT_SHOW so that the addon isn't loaded unless you visit a vendor. OH and, damn nice addon
__________________
if (sizeof(workload) > sizeof(brain_capacity)) { die('System Overload'); }
Last edited by Caellian : 07-14-09 at 04:46 AM.
|
|
Caellian |
View Public Profile |
Send a private message to Caellian |
Visit Caellian's homepage! |
Find More Posts by Caellian |
Add Caellian to Your Buddy List |
07-14-09, 04:39 AM | ||
|
Naughty itemIDs
EDIT: r217 should fix this issue.
__________________
We'd be together, but only diamonds last forever...
Last edited by Recluse : 07-14-09 at 04:44 AM.
|
|
|
Recluse |
View Public Profile |
Send a private message to Recluse |
Visit Recluse's homepage! |
Find More Posts by Recluse |
Add Recluse to Your Buddy List |
07-14-09, 04:33 AM | |
|
Until now StealYourCarbon did a fine job but i'll give this one a try.
One bug: If you misstype an ItemID and add it, from that point you can't use tha addon anymore, everything you do trigger this error: Code:
12:31 GetReagents_Options\Options.lua:76: attempt to concatenate a nil value
__________________
if (sizeof(workload) > sizeof(brain_capacity)) { die('System Overload'); }
Last edited by Caellian : 07-14-09 at 04:44 AM.
|
|
Caellian |
View Public Profile |
Send a private message to Caellian |
Visit Caellian's homepage! |
Find More Posts by Caellian |
Add Caellian to Your Buddy List |
07-14-09, 04:01 AM | |
|
r216 Release
Alright, I submitted the new revision. I hope you all enjoy it.
The changes are a bit extensive, and I did cover most of it in my last post (just before this one ). Have a look over the Change Log if you are interested in all of the changes. I've also updated the description page, as well as the screenshots here on WoWInterface, so that will probably shed a lot of light on the changes as well. Briefly (notably): - Option for detailed confirmation box. - Option for changing confirmation box background color/alpha. - Purchase list drop-down shows current quantities. - No cap on quantities entered by users.
__________________
We'd be together, but only diamonds last forever... |
|
Recluse |
View Public Profile |
Send a private message to Recluse |
Visit Recluse's homepage! |
Find More Posts by Recluse |
Add Recluse to Your Buddy List |
07-11-09, 12:06 AM | |
|
Preview Screens of Next Release
These are just previews of where I'm at with everything at the moment. These are not in the released version just yet, but will be soon if all goes as planned.
- I've added a color picker box which you can click on to set the color of the confirmation box's background color, as well as it's opacity. - There is also a new option for adding detail to the confirmation box, which you can see in action in the second screenshot below. - Both of these options are hidden from view if you have the purchase confirmation unselected, since there is no reason to change their values in that state. - The top confirmation box is the current one, and is the one you will continue to see if you have confirmation detail UNchecked. - In the second frame, you can see how the confirmation detail option modifies the purchase confirmation frame. It adds each reagent's name, how many it wants to purchase, and the cost of doing so. Think of it as a receipt, in a sense . - I've also decided to include individual buttons for each reagent, so that they may be purchased individually (in case you did not want to restock everything). There is still a button to just buy everything, however. - In the third frame, you can see how the frame changes if you buy an individual reagent. The button will disable itself, and the text will dim, indicating that the reagent has been purchased. The total purchase value at the top will also change to reflect the new total cost if you were to push the Buy All button. - Clicking Buy All after buying an individual reagent will NOT buy that reagent a second time. - If you purchase all of the reagents individually, the frame will close, signifying that everything has been purchased, and GetReagents has no more work to do. The frame still closes as before if you click the Buy All button. I have yet to implement any sort of cap removal/increase on reagent purchases, but I hope to get around to them soon. I should have enough time this weekend, I think. Hopefully, this will address some of the requests or concerns anyone has had since the last release.
__________________
We'd be together, but only diamonds last forever... |
|
Recluse |
View Public Profile |
Send a private message to Recluse |
Visit Recluse's homepage! |
Find More Posts by Recluse |
Add Recluse to Your Buddy List |
07-09-09, 02:57 PM | ||||
|
Thanks very much for your reply .
One is yet another confirmation dialogue once someone enters numbers/the slider past the point the author (you) feels comfortable letting people buy. For example, pop up a confirmation box (i.e. "Do you really want to buy 700?, Yes/No") once someone enters a number past 200 for Devout Candles. Or hunter bullets past 5000, etc.. Another way is to do it exactly how BuyDropper did it. Instead of just accepting a number when the user presses ENTER as it is now (which has a chance of typos), have the quantity selection--whether a white space entry or a slider--in a "yes"/"no" frame. The user has to click a "Yes" button after entering a selected amount in order for it to be set. That way, the user has to choose & confirm that they want to keep that amount in stock and there is much less chance of typos. And then there is your suggestion of "...let the user define the maximum amount of stacks for each item as a safety mechanism." As long as you don't limit those stacks. Basically, with other ways to prevent mistakes, please do not arbitrarily limit a person's wanted, confirmed choice.
Allowing "overstocking" (completely different from the above), though, can add flexibility. Bringing up BuyDropper again with how it gave an overstock option: "Toggles whether to overstock items that come in preset stacks like food or water. For example, say you are tracking Ice Cold Milk × 20 and you have 17 in your inventory and you open a vendor who sells Ice Cold Milk. With overstock enabled, you will buy a bundle of 5 to bring your total to 22." Not something I ever used, but I know a few people using that mod that have.
Last edited by Zidomo : 07-10-09 at 06:43 AM.
|
|||
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Visit Zidomo's homepage! |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
07-08-09, 04:26 PM | ||
|
Confirm alpha, Restock limit
With the restocking limits, I felt they were well higher than anyone would desire, and I mentioned that its presence is fairly loose on the description page (there in the red footnote). It does make a bit of sense that those candles might be needing a higher cap on them, as they are used for multiple spells, whereas most are only used for a single spell. One of the things that I wanted to put in these caps in for was just so someone did not accidently type in some insane number like 200, when they meant to only type 20. Now, since adding in the purchase confirmation dialog, it isn't quite as important to have the cap in place, as I'm sure they'll wonder why GetReagents is asking for permission to spend 20g or something. In some ways I'd like to leave the cap in place, and simply raise the caps as needed, which will protect those who do not use the purchase confirmation dialog. Perhaps even let the user define the maximum amount of stacks for each item as a safety mechanism. For now, I believe this opttion may be the best course of action until a future time when I feel better about allowing it to be freely edited, or get more requests for it. It will likely be another week or two before I push the next release revision, so things may change between now and then. As for the overstocking, I ensured that it does not happen, and while some addons offered the option to toggle overstocking, I wasn't really sure if it was even really a desired option.
__________________
We'd be together, but only diamonds last forever...
Last edited by Recluse : 07-08-09 at 06:40 PM.
|
|
|
Recluse |
View Public Profile |
Send a private message to Recluse |
Visit Recluse's homepage! |
Find More Posts by Recluse |
Add Recluse to Your Buddy List |
07-08-09, 10:29 AM | |
|
r202 is very nice. Reliable (so far) & lightweight. Except for two things .
--The confiirmation popup box's frame alpha is set way too low. Its quite difficult to see at a glance when it pops up. Something like BuyDropper provides (a frame set to a "full" alpha/1.0) would work better for many people. --The arbitratry limits you have set for buying certain reagents (tested so far) are not good. The limit on Devout Candles--for both the slider and the input box--is 80. Well, what if I want to restock 100? Have to manually go in and buy an extra 20, defeating the point of the mod. Should allow people to enter any amount they want for any reagent. With protection, of course, against the mod mistakenly overbuying more than what someone has set (a serious problem the new FactionDiscount AutoStock had when I tried it). Don't even really need a slider as you have now, a plain text entry box works fine. |
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Visit Zidomo's homepage! |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
06-30-09, 11:55 AM | ||
|
Restock Listing
__________________
We'd be together, but only diamonds last forever...
Last edited by Recluse : 07-02-09 at 03:19 AM.
|
|
|
Recluse |
View Public Profile |
Send a private message to Recluse |
Visit Recluse's homepage! |
Find More Posts by Recluse |
Add Recluse to Your Buddy List |
You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.