Download
(398Kb)
Download
Updated: 10-20-10 02:57 PM
Pictures
File Info
Updated:10-20-10 02:57 PM
Created:10-19-10 03:16 AM
Downloads:2,446
Favorites:19
MD5:

nQuestLog Fan Update

Version: 4.0.1r1
by: silentdave [More]

nQuestLog Fixed for 4.0.1

nQuestlog is questing minion designed to replace the default blizzard quest log, it provides efficient onscreen information regarding you quests and sorts the into their relevent zones. These zones auto-collapse/expand based on where the player is, individual quests will also be bak-lighted to indicate that the player is either in the zone where the quest is to be completed or where the quest is to be handed in. nQuestLog also links with Lightheaded (search this site for that) to provide further information on quests and uses MobMap mob data to modify mob-tooltips with additional quest related data such as kills needed, drop chance for quest items etc.

Fixes I've done:

Mass conversion of 'this' to 'self' (even the code-comments got hit by this).
Fixed up the main XML mouse click code so that the correct info is passed.
Corrected a simple yet nasty global call in the main mouse-click handling code (this caused a huge pile of "field - nil" errors and minion hangs).
Defensive code for blank zone names and blank (nil) quest objectives in Quixote.
Defaulted quests with no Zone name into a generic zone called "Unknown" (this is not localised, see below for further info).
Blank Quest Objectives are classified as 0/0 thus done, these are not displayed in the minion but are displayed in the tooltip.
Achievement Tracker - Hides/shows correctly altough it requires a small degree of care (see change log)

Things that are still buggy/dead:

Item hover info in Lightheaded quest panel produces syntax error within nQuestlog code
Mob-Tooltip - shows 0/0 objectives (from above) gonna have a look at hiding these completely
Waterfall config - the whole library has issues with 4.0.1, probably needs a rewrite but it still works... kindof.
FuBar plugin config - dead when used with LDB type displays (I use fortress with fubar2broker) dont know what its like with FuBar.
Quest Giver info insertion into default quest log (BlizzardFrames module) - 1 or 2 errors in there, again, I dont use the default log so I aint bothered about it.
AceComm (Ace2) - these are probably party/raid sync features.. again , I'm not bothered about these (this would need that whole side of things and other stuff porting to Ace3 anyway).

So what's the condition of the addon?

The minion does exactly what it should and did ie it works fine. It links fine to lightheaded and modifies tooltips with kills needed etc etc, all the auto-collapsing/expanding works as does the manual collapse expand, ability to hide quests/objectives works as it should, the FuBar plugin responds to all mouse clicks and updates properly (but cannot be configured), the errors occur in the ancillery stuff (primarily in the config code)

Just to make things clear - I fixed this up enough such that it would work for personal use only, so, if it doesn't work for you then sorry as I wont be trying to fix it for ya.

For those using a lanugage other than English and want to change the name of that fall-back zone ("Unknown" - see screenshot) then open nQuestLog/libs/Quixote-1.0/Quixote-1.0.lua and goto line 258 (this reads zoneIndex = "Unknown" ) do NOT change the one on line 247

4.0.1r1 - Achievement Tracker fixed (users of mobmap be sure to collapse the tracker 1st if you intend to hide it)
Optional Files (0)


Post A Reply Comment Options
Unread 08-14-11, 01:59 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
Originally posted by silentdave
Yeah I'm aware of that, thing is, even with the latest release of the, now defunct, Ace2 libs the same errors still popup on minimal UI load, yet on a full load its just 2 minor errors, so its either custom version(s) of the ace2 libs, (the last offical release was June-ish this year) so thats unlikely but possible, or its some other interaction(s) thats quelling the problem.
Don't know if you are still working on this or not but for information, its a single Ace2 library causing the bugouts. Not just on this mod, but any mod that uses it: AceComm-2.0.

That particular library is 100% incompatible with WoW 4.x. Get rid of it/delete it and you won't have any Ace2-related errors in WoW 4.2. For the time being at least. For this mod, it may not be as simple as just deleting it and possibly losing comm functionality because of it. The obsolete Quixote-1.0 also uses that library. Quixote is currently updated & supported, but only in its 2.0 version.

As to the other obsolete libraries this uses, have yet to encounter a single error related to them, with the possible exception of Waterfall-1.0 (used for option access). Don't remember the results of my last testing of that last year.

Still, with the wide assortment of updated, supported quest minion replacements, there is no need to be using one that uses the unsupported Ace2, etc. libraries and doesn't seem to be in development anymore. My favorite: BetterQuest. But still hope nQuestLog continues; if not, oh well.
Report comment to moderator  
Reply With Quote
Unread 10-21-10, 04:16 AM  
silentdave
A Defias Bandit
 
silentdave's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 40
Uploads: 2
Originally posted by alayane
More than likely when you you only load the bare bones the libs are throwing the errors. In a more customized ui wow only loads the newest version of libs so that duplicates aren't loaded.
Yeah I'm aware of that, thing is, even with the latest release of the, now defunct, Ace2 libs the same errors still popup on minimal UI load, yet on a full load its just 2 minor errors, so its either custom version(s) of the ace2 libs, (the last offical release was June-ish this year) so thats unlikely but possible, or its some other interaction(s) thats quelling the problem.

In any case, I'm gonna have a look at possibly porting the whole thing to Ace3 and then see where that leaves everything (probably a mega job to do)
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 08:13 PM  
alayane
A Murloc Raider

Forum posts: 7
File comments: 3
Uploads: 0
More than likely when you you only load the bare bones the libs are throwing the errors. In a more customized ui wow only loads the newest version of libs so that duplicates aren't loaded.
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 05:14 PM  
silentdave
A Defias Bandit
 
silentdave's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 40
Uploads: 2
Accidently unchecked archive older versions when uploading 4.0.1r1, sorry about that, hopefully r1 will be approved soon
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 02:47 PM  
silentdave
A Defias Bandit
 
silentdave's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 40
Uploads: 2
Still working on a few more fixes (Fixed the achievement tracker window problem).

Incidently.. loading nQuestlog up on its own or with the bare minimum ie fortress fuber2broker and nquestlog causes just about every single library within nquestlog to throw up tons of errors, lord knows why, but with a more heavily customised UI these errors get neutralised, I know the answer is probably very simple but.. its a long while since I did any coding at a reasonable level.

The achievement tracker fix that I've done does have some limitations - example: users of mobmap will notice that mobmap places its little "m" next to each quest objective in the tracker, if you "hide" the tracker with the code I have, the little "m"s persist, if you collapse the tracker before hiding it then its fine. IMO it's probably best not to hide the tracker, as perma-hiding then hides any quest timers for those rare timed quests. aside from that niggle the tracker works fine as far as I can test atm.

Currently looking at the quest giver insertion code into the default questlog and then i'll have a look at the errors in the waterfall config (I have some spare time atm)
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 03:10 AM  
silentdave
A Defias Bandit
 
silentdave's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 40
Uploads: 2
Just to make it clear.. for some people nQuestLog will work, for others it won't, that's just how it is sadly.

Like I said on Curse, I don't have the time nor the expertise to go fixing/rewriting this addon completely, I just really prefer this addon over all the others thus I looked into fixing it and took it 1 step at a time based on the errors I was getting with my UI.

As akgis has shown.. the thing is full of outdated code and defunct libraries, many of which are semi/fully incompatible with how the current API works and these will determine the likelyhood of whether or not nQuestLog works for you.

A couple of people have asked if they can have a copy for testing.. well.. download this one and go for it, its not my project, I just did a one-off fix for 4.0.1 for personal use and felt it best to share that update. Anyone registered can upload optional files (updates of any kind to nQuestLog to this area) so if someone fixes something else then upload it n give me a pm here and I'll superseed the current available version.

With regards to errors like what akgis is getting.. DewDrop lib, I believe, is the config lib for the FuBar Plugin
Report comment to moderator  
Reply With Quote
Unread 10-19-10, 06:44 AM  
akgis
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 29
File comments: 80
Uploads: 4
The addon dont work for me getting errors after errors

Message: ...ce\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:621: attempt to index field 'level' (a nil value)
Time: 10/19/10 13:43:47
Count: 9
Stack: ...ce\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:621: in function <...ce\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:614>

Locals: (*temporary) = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:3008
(*temporary) = <table> {
Unregister = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2955
Register = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2906
AddSeparator = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:3051
OnTooltipHide = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:3376
KEY_BUTTON2 = "Right Mouse"
argCheck = <function> defined @Interface\AddOns\nQuestLog\libs\AceLibrary\AceLibrary.lua:129
hookedTooltip = true
AddLine = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:3064
pcall = <function> defined @Interface\AddOns\nQuestLog\libs\AceLibrary\AceLibrary.lua:167
GetLibraryVersion = <function> defined @Interface\AddOns\nQuestLog\libs\AceLibrary\AceLibrary.lua:585
IsOpen = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2729
GetOpenedParent = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2734
onceRegistered = <table> {
}
IsRegistered = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2901
Refresh = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:1901
InjectAceOptionsTable = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:3312
registry = <table> {
}
KEY_BUTTON1 = "Left Mouse"
error = <function> defined @Interface\AddOns\nQuestLog\libs\AceLibrary\AceLibrary.lua:75
FeedTable = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:1784
Close = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:3008
Open = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2960
frame = <unnamed> {
}
EncodeKeybinding = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2669
FeedAceOptionsTable = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:1283
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'level' (a nil value)"
sliderFrame = nil
self = <table> {
Unregister = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2955
Register = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2906
AddSeparator = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:3051
OnTooltipHide = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:3376
KEY_BUTTON2 = "Right Mouse"
argCheck = <function> defined @Interface\AddOns\nQuestLog\libs\AceLibrary\AceLibrary.lua:129
hookedTooltip = true
AddLine = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:3064
pcall = <function> defined @Interface\AddOns\nQuestLog\libs\AceLibrary\AceLibrary.lua:167
GetLibraryVersion = <function> defined @Interface\AddOns\nQuestLog\libs\AceLibrary\AceLibrary.lua:585
IsOpen = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2729
GetOpenedParent = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2734
onceRegistered = <table> {
}
IsRegistered = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2901
Refresh = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-2.0\Dewdrop-2.0.lua:1901
InjectAceOptionsTable = <function> defined @Interface\AddOns\nQuestLog\libs\Dewdrop-
__________________
Report comment to moderator  
Reply With Quote
Unread 10-19-10, 04:18 AM  
Kamikaze_Ice
A Murloc Raider

Forum posts: 9
File comments: 19
Uploads: 0
Indeed!

I tried fixing this mod myself, but I failed since I can only do basic lua editing.
Thank you very much for making this mod usable with cata changes.

Best quest tracker/minion out in my eyes.
Report comment to moderator  
Reply With Quote
Unread 10-19-10, 04:03 AM  
bazelle
A Kobold Labourer
 
bazelle's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 25
Uploads: 3
Thanks silentdave for keepn this alive and fuctional, a great quest tracker!
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: