Quantcast
Download
(89 Kb)
Download
Updated: 12-02-11 03:04 PM
Patch for:
ItemRack.
Pictures
File Info
Updated:12-02-11 03:04 PM
Created:10-17-10 10:40 AM
Downloads:18,795
Favorites:116
MD5:

ItemRack - Cataclysm  Popular! (More than 5000 hits)

Version: 2.73
by: Kharthus, Yewbacca

This fixes ItemRack to work with Cataclysm and contains important bug fixes and improvements.

Original version is here: ItemRack

12/9/11: All future updates will be back on the main addon page.

__ New in 2.73 - By Kharthus __

* TOC update for WoW 4.3.0
* Fixed GetNumMacroIcons error in 4.3

__ New in 2.72 - By Kharthus __

* TOC update for WoW 4.2.0

__ New in 2.71 - By Kharthus __

* TOC update for WoW 4.1.0

__ New in 2.7 - By Yewbacca __

* Created new consolidated patterns for ItemLink/ItemString-to-ItemRackStyleID, ItemRackStyleID-to-BaseID, ItemLink/ItemString-to-BaseID
* Created new functions that use those patterns, and various other new helper functions, in order to consolidate all ItemString-handling in one place
* Replaced all old-style handling of itemIDs (string.gsub/find/match) and made everything use the new functions instead, for more robust handling as well as easy updates in the future
* Replaced GUI drawing code with references to new functions, to get icons and tooltips to work in the GUI
* Updated the GUI code so that it always draws item tooltips using the player's current level, which ensures that mousing over heirlooms in saved sets will actually show their stats for your CURRENT level (the old code set all levels to 0 which made it so the stats were shown incorrectly as level 1)
* Improved the two functions that actually LOCATE the stored equipment set items inside the player's inventory/equipment/bank (whether it's for equipping, or simply displaying a tooltip), by making sure those functions pass the INCOMING ID through the new level updater (UpdateIRString) to ensure all old Item IDs are up to date, thus fixing the bug where leveling up would cause ItemRack to fail strict item search on all saved sets and resort to any-item-with-the-same-baseID; this injection point was chosen because it fixes the problem completely throughout the board, since everything that locates items relies on the item finding functions
* Updated the functions for getting info for an item (GetInfoByID), posting an itemlink to the chatbox when shift clicking an item in ItemRack's GUI (ChatLinkID), and the function for showing an item in a tooltip, so that they all pass the incoming ID through the level updater (UpdateIRString) in order to work with up-to-date information, since it's important that stats are correct whether it's for posting chat links or looking at a tooltip's stats
* Commented and cleaned up terrible code here and there, as I untangled the messy code (minor changes)

__ New in 2.65 - By Kharthus __

* Reverted gear swap code to 2.243 version

__ New in 2.64 - By Kharthus __

* Fixed slash commands

__ New in 2.63 - By Kharthus __

* Replaced all getglobal calls with _G
* Fixed Titan's Grip and Shaman off-hand

__ New in 2.62 - By Kharthus __

* Fixed lua errors caused by chat links
* Fixed issues with clicking on Dockable Buttons
* Fixed event code
* Fixed icon updates on gear swaps

__ New in 2.61 - By Kiki __

* Fixed lua errors caused by tooltips

__ New in 2.60 - By Kiki __

* Fixed for WoW 4.0
Post A Reply Comment Options
Unread 10-17-10, 03:05 PM  
Oddible
A Murloc Raider

Forum posts: 6
File comments: 28
Uploads: 0
Thanks for doing this! I get an error when I type /itemrack:

Date: 2010-10-17 14:04:03
ID: 5
Error occured in: Global
Count: 1
Message: ..\AddOns\ItemRack\ItemRack.lua line 1841:
bad argument #1 to 'match' (string expected, got table)
Debug:
(tail call): ?
[C]: ?
[C]: match()
ItemRack\ItemRack.lua:1841: value()
..\FrameXML\ChatFrame.lua:4127:
..\FrameXML\ChatFrame.lua:4054
[C]: ChatEdit_ParseText()
..\FrameXML\ChatFrame.lua:3717: ChatEdit_SendText()
..\FrameXML\ChatFrame.lua:3755: ChatEdit_OnEnterPressed()
[string "*:OnEnterPressed"]:1:
[string "*:OnEnterPressed"]:1
Last edited by Oddible : 10-17-10 at 03:10 PM.
Report comment to moderator  
Reply With Quote
Unread 10-17-10, 03:37 PM  
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 275
Uploads: 9
Oops, got a little overzealous with search and replace. Fixed.
Report comment to moderator  
Reply With Quote
Unread 10-17-10, 09:36 PM  
Briandre
A Kobold Labourer

Forum posts: 0
File comments: 14
Uploads: 0
Thanks for the update -- seems to work well -- it does a few things equipment manager can't, like allowing you to wear a hat on one outfit or removing it when it's a really ugly hat!
Report comment to moderator  
Reply With Quote
Unread 10-17-10, 10:51 PM  
WereBear
A Kobold Labourer

Forum posts: 0
File comments: 23
Uploads: 0
Hey glad someone updated it was going to look at it but never got around to it ;-). I did notice a problem that has been a ItemRack problem for a while swapping of items with prismatic/jc gems. I put in some code from a jc version of itemrack and commented out a block of code that i have been using since i noticed it a ways back. It must of got lost in the shuffle at some point, the comment references people for some of the fixes including Gello and a reference to wowinterface. Who did the orig code I am not sure. I'll test it out some more but if you want the lua to include it with the next version just let me know.
Last edited by WereBear : 10-17-10 at 10:53 PM.
Report comment to moderator  
Reply With Quote
Unread 10-18-10, 12:44 AM  
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 275
Uploads: 9
Originally posted by WereBear
Hey glad someone updated it was going to look at it but never got around to it ;-). I did notice a problem that has been a ItemRack problem for a while swapping of items with prismatic/jc gems. I put in some code from a jc version of itemrack and commented out a block of code that i have been using since i noticed it a ways back. It must of got lost in the shuffle at some point, the comment references people for some of the fixes including Gello and a reference to wowinterface. Who did the orig code I am not sure. I'll test it out some more but if you want the lua to include it with the next version just let me know.
Yeah, let me know and I'll take a look.
Report comment to moderator  
Reply With Quote
Unread 10-18-10, 01:06 AM  
bikikitty
A Kobold Labourer

Forum posts: 0
File comments: 38
Uploads: 0
It works perfectly on my WOW.
Thanks so much!
Report comment to moderator  
Reply With Quote
Unread 10-18-10, 02:58 AM  
kiki
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 14
Uploads: 1
Nice, I've updated my download page to point here, thanks
Report comment to moderator  
Reply With Quote
Unread 10-18-10, 12:00 PM  
Shakool
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Hi thanks for the update !
I've an issue where my boots doesn't equip when i change of set. I must reequip the set to equip the boot or equip them manually.

Itemrack display this message in chat : Swap stopped. Another swap is in progress.

I noticed that it only happen when i try to equi the pvp set.
Report comment to moderator  
Reply With Quote
Unread 10-18-10, 02:06 PM  
liquidf
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
Thanks a lot for updating this mod. Didnt know what i was going to do otherwise...

I found 2 problems that I wanted to let you know about.

1. I am also getting the 'Swap stopped. Another swap is in progress.' error. It seems like the addon first unequips items with dragon's eyes in them, and then equips the new items. This causes 2 problems: First of all, your gear gets scattered all over your bags. And second of all, it often stops with that error, leaving a few items unequipped.
So it would be nice to at least have an option to turn off this behavior.
(an alternative fix for the dragons eyes problem could just be to have the addons try equpping the set twice, that should do it)

2. The /itemrack toggle command is bugged. It does equip the set if you're not wearing it, but it doesn't unequip it when youre wearing it. So right now there is no way to unequip a set.
Report comment to moderator  
Reply With Quote
Unread 10-18-10, 09:55 PM  
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 275
Uploads: 9
WereBear is working on a patch for the JC issues. I tried out a few of the JC patches from the old comments and none of them seemed to keep the bags cleaned. They all throw gear all over the place. I don't have JC gems in two sets so it's hard for me to test if any of them are any better than others.

Did it work with the 2.243 version for people? The 2.25 patch is where I started having problems with gear being moved around.

/itemrack toggle works fine for me. Could this be related to the first error where it dies during the gear swap?
Last edited by Kharthus : 10-18-10 at 10:55 PM.
Report comment to moderator  
Reply With Quote
Unread 10-19-10, 06:24 AM  
LonghornsER
A Defias Bandit
 
LonghornsER's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 14
Uploads: 1
Lightbulb Beld/Neck Problem

The "Swap Stoped" msg, is properly something about the swapping from beld and neck... somehow he will not swap items in both slots. If i let the "neck" being what it is, then the next item will swapped instead of the beld : Shoulders.

So i guess there is a problem on the swapping of the beld's

Regards
Longhorns, Earthen Ring
Report comment to moderator  
Reply With Quote
Unread 10-19-10, 12:09 PM  
liquidf
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
You are right, unequipping with toggle does actually work for me if it doesnt fail when equipping.

About the JC issues, 2.243 worked fine for me. I never upgraded past that until we got patch 4.

I'd say the correct way to swap items is to first take all items that doesnt have more dragons eyes than what is currently equipped, and then the rest after. That way you will never have too many dragons eyes equipped, and you dont have to unequip stuff first.
Report comment to moderator  
Reply With Quote
Unread 10-19-10, 07:52 PM  
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 275
Uploads: 9
I'm tempted to revert the equip code to the 2.243 version and see how that goes. There's been a few attempts at JC versions and they all seem to have issues.
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 04:03 AM  
Sporeo
A Kobold Labourer

Forum posts: 0
File comments: 5
Uploads: 0
Thank-you so much for updating this! I haven't noticed any issues with the patch. I HAD to find an update to this after doing icc 25 hm's last night with a darn 'rp' offhand equipped by accident XD I'm so reliant on this addon >_<
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 09:46 AM  
liquidf
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
I agree that you should remove the part that unequips items first, at least until you have a version that can handle JC gems well.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: