Quantcast
Download
(28 Kb)
Download
Updated: 10-16-20 03:11 AM
Pictures
File Info
Compatibility:
Shadowlands pre-patch (9.0.1)
Updated:10-16-20 03:11 AM
Created:09-19-14 07:56 AM
Downloads:18,222
Favorites:90
MD5:
9.0.1

Classic Quest Log  Popular! (More than 5000 hits)

Version: 2.0.2
by: Gello [More]

This addon restores the old quest log with the familiar list of quests on the left and details on the right.

Note:[list][*]This addon is not for Classic WoW. Classic WoW already has the classic quest log. This addon is for retail Shadowlands servers to restore the "classic" style of quest log.

This addon's initial behavior is to commandeer your quest log key binding and micro button to toggle the new log. It should be a familiar enough experience once you log in.

If you decide you want to keep using the new default log alongside this addon, you can:

  • Open the map via key binding (M is default key) will display the new map+quest log hybrid.
  • Click 'Show Map' in the upper right of the Classic Quest Log, it will jump to the map of the quest's zone with the attached new style quest log.
  • If that's not enough and you only want to use the Classic Quest Log occasionally, go into Key Bindings -> AddOns -> Classic Quest Log and set a binding to toggle this addon's window. Once a binding is set, it will revert the behavior of the default quest log binding and quest micro button to its map+quest default behavior.

There are a few minor changes from the true old quest log:
  • Instead of saying (Completed) or (Daily) beside each quest name, they are now represented by icons just like the new log.
  • Instead of adhering to the "panel" rules, it can be anywhere on the screen and dragged around.
  • There's a toggle at the bottom of the window to show quest levels.
  • There's also a toggle to show tooltips of the quests. If you don't know what the quest icons mean, the tooltip will tell you.

2.0.2 10/16/2020
- Code changes to make this addon easier for others to skin.

2.0.1 10/14/2020
- Fix for shift+click of a quest in the log throwing a lua error and not tracking/untracking a quest as intended.

2.0.0 10/13/2020
- Rewritten for Shadowlands to support newer questing features and take advantage of the new quest API.
- Campaign quest headers are now collapsible and styled to be closer to the map's campaign headers.
- Chapter progress is displayed on campaign quest headers.
- Mouseover of campaign quest headers will now display the campaign tooltip.
- If a campaign has lore built up, mouseover of campaign quest headers will also display a Lore book button; when clicked it will display the "story so far..." in the details panel.
- The log can now contain multiple campaigns.
- Quests with special backgrounds/themes will now use those special backgrounds in the detail panel.
- Added a Party Sync button that appears when party syncing is possible or ongoing.
- Options have moved into the details panel instead of a little popup window.
- Added option 'Show From Objective Tracker' (enabled by default) to open Classic Quest Log rather than the map when you click an objective listed beneath the minimap.
- Dark Background option now uses a dark marble texture that should still achieve the high contrast effect of the previous solid/flat dark texture.
- Improved handling when there are no quests in the log.
- For easier maintenance, code is broken out to separate files.
- The automatic skinning for ElvUI/Aurora are removed.

1.4.7 03/14/2020
- Fix for quest portrait models not appearing on quests that have them.
- Updated toc for 8.3.

1.4.6 10/12/2019
- On Classic WoW clients a popup dialog will warn that this addon is not for Classic WoW.
- Fix for lua error about QuestNPCModel.

1.4.5 08/29/2019
- Clicking an objective will not summon both the quest log and map: out of combat, it will summon the quest log; in combat it will summon the map.

1.4.4 07/06/2019
- More temporary workarounds while a more substantial rework is in the works.
- The Undock Window option is always enabled and can't be turned off for now.

1.4.3 07/04/2019
- Fix for many SetPoint issues. (Likely not all; a more durable fix is in the works.)
- Updated toc for 8.2.

1.4.2 12/24/2018
- Added a header above war campaign quests in the left pane of the quest log.
- Updated toc for 8.1.

1.4.1 07/07/2018
- Fix for Lua error when attempting to display quest portraits.

1.4.0 06/09/2018
- Update for Battle for Azeroth client.

1.3.4 08/29/2017
- Fix for PlaySound when sharing a quest in 7.3.
- toc updated for 7.3.

1.3.3 08/07/2017
- Fix for coming 7.3 PlaySound change

1.3.2 05/25/2017
- Quest NPC portraits will now display when a quest with a portrait is selected.

1.3.1 05/13/2017
- While using ElvUI or Aurora, a new option "Use Classic Skin" is available to prevent skinning for those UIs.
- Reworked internal quest selection/update process.
- Fix for the abandon quest dialog dismissing without an obvious reason.
- Fix for quest detail pane scrolling to top without an obvious reason.

1.3.0 05/12/2017
- The Solid Background option changed to Dark Background. It now makes the details portion light text on a dark background.
- ElvUI skin is applied if ElvUI is enabled.
- Aurora skin is applied if Aurora is enabled.

1.2.11 04/12/2017
- When shift+clicking a quest on the objective tracker to stop tracking it will no longer summon the quest log.

1.2.10 04/09/2017
- Clicking an objective in the objective tracker will summon the quest log instead of the world map.

1.2.9 03/28/2017
- toc update for 7.2 patch

1.2.8 12/01/2016
- Fix for +/- buttons on quest headers not properly indicating if the header is collapsed.

1.2.7 10/27/2016
- Fix for quests not linking to chat.
- Fix for "missing header!" and extra quests:
- Quests flagged as hidden will now be hidden.
- Headers that contain only hidden quests will be hidden also.

1.2.6 10/24/2016
- toc update for 7.1 patch.

1.2.5 09/18/2016
- Added open and close sound to the window.

1.2.4 09/09/2016
- Fix for hitting "Close" button breaking the "panel-ness" of the window.
- Fix for number of groupmates on a quest remaining when a quest category is collapsed.

1.2.3 08/05/2016
- If the default quest frame is up while summoning Classic Quest Log, the default quest frame will be hidden.

1.2.2 07/19/2016
- 7.0 release

1.2.1 07/14/2016
- Added option "Solid Background" to make the background behind text solid to improve readability.
- Hitting ESCape while the little options window is open will close options without closing the whole quest log.
- Fix for opening map or details window from another source sometimes breaking Classic Quest Log's panel behavior.

1.2.0 06/10/2016
- Like the original quest window, the default behavior of the Classic Quest Log is now to dock on the left and move over as default UI panels appear.
- Added Options button to bottom of the window with the following options:
- Undock Window: This will allow dragging the window around the screen.
- Lock Window Position: While the window is undocked, this will prevent moving the window unless Shift is held.
- Show Resize Grip: This will allow resizing the height of the quest window.
- Show Quest Levels: This is the old option to show levels alongside listed quests.
- Show Quest Tooltips: This is the old option to show tooltips when you mouseover listed quests.

1.1.1 05/28/2016
- Quest tooltips are more complete.

1.1.0 05/12/2016
- toc update for 7.0 Legion beta
- Fix for lua error at QuestInfo.lua:45

1.0.6 06/23/2015
- toc udpate for 6.2 patch

1.0.5 02/24/2015
- toc update for 6.1 patch

1.0.4 02/21/2015
- Headers are collapsable.
- Expand/Collapse All button.
- Fix for bug where a separate key binding is defined but addon is still overriding default key/button.
- Multiple quest update events within one frame will update the log once instead of for each event.

1.0.3 10/14/2014 fix for error when grouped
1.0.2 10/12/2014 fix for blank reward icons, log hides when default standalone quest panel shows, 6.0 patch
1.0.1 09/19/2014 initial release
Optional Files (1)
File Name
Version
Size
Author
Date
Type
1.4.6-Classic
17kB
09-26-19 10:31 AM
Patch


Archived Files (30)
File Name
Version
Size
Author
Date
2.0.1
28kB
Gello
10-14-20 03:35 PM
2.0.0
28kB
Gello
10-13-20 03:20 PM
1.4.7
17kB
Gello
03-14-20 08:39 PM
1.4.6
17kB
Gello
10-12-19 07:07 PM
1.4.5
17kB
Gello
08-29-19 03:54 AM
1.4.4
17kB
Gello
07-05-19 11:03 PM
1.4.3
17kB
Gello
07-04-19 04:40 PM
1.4.2
17kB
Gello
12-24-18 04:05 PM
1.4.1
16kB
Gello
07-17-18 10:06 AM
1.3.4
16kB
Gello
08-29-17 04:48 AM
1.3.3
16kB
Gello
08-07-17 09:56 AM
1.3.2
16kB
Gello
05-25-17 06:00 PM
1.3.1
16kB
Gello
05-13-17 11:15 AM
1.3.0
15kB
Gello
05-11-17 11:21 PM
1.2.11
14kB
Gello
04-12-17 08:36 AM
1.2.10
14kB
Gello
04-09-17 09:51 AM
1.2.9
13kB
Gello
03-28-17 09:33 AM
1.2.8
13kB
Gello
12-01-16 08:38 PM
1.2.7
13kB
Gello
10-27-16 07:14 PM
1.2.6
13kB
Gello
10-25-16 06:09 AM
1.2.5
13kB
Gello
09-18-16 10:02 AM
1.2.4
13kB
Gello
09-09-16 08:18 AM
1.2.3
12kB
Gello
08-05-16 05:49 AM
1.2.2
12kB
Gello
07-19-16 08:31 AM
1.0.6
10kB
Gello
06-23-15 07:47 AM
1.0.5
10kB
Gello
02-24-15 06:16 AM
1.0.4
10kB
Gello
02-21-15 08:15 AM
1.0.3
9kB
Gello
10-14-14 07:20 PM
1.0.2
9kB
Gello
10-12-14 08:27 PM
1.0.1
8kB
Gello
09-19-14 07:56 AM


Post A Reply Comment Options
Unread 10-19-20, 03:38 AM  
fuba
A Murloc Raider

Forum posts: 6
File comments: 18
Uploads: 0
Originally Posted by Gello
Originally Posted by fuba
But i found another Bug that is from Classic Quest Log -> everything else disabled now ^^

Collapse a Tracked Quest and click "this" quest at the Quest Tracker will open the "default" Quest Log instead of Classic Quest Log!
Oh yeah that one is a legitimate bug. I'll get that fixed thanks.
Thank you
Report comment to moderator  
Reply With Quote
Unread 10-18-20, 04:31 AM  
Gello
A Firelord
AddOn Author - Click to view AddOns

Forum posts: 492
File comments: 543
Uploads: 64
Originally Posted by fuba
But i found another Bug that is from Classic Quest Log -> everything else disabled now ^^

Collapse a Tracked Quest and click "this" quest at the Quest Tracker will open the "default" Quest Log instead of Classic Quest Log!
Oh yeah that one is a legitimate bug. I'll get that fixed thanks.
Report comment to moderator  
Reply With Quote
Unread 10-17-20, 08:08 PM  
fuba
A Murloc Raider

Forum posts: 6
File comments: 18
Uploads: 0
Originally Posted by Gello
If you turn off all other addons besides this one, you'll probably see the behavior stop.

There are addons out there like ConsLegion that aren't content to loop through the quest log to get information, but they actually select each quest in the log as it loops through. I don't know if it's a belief that they need to do this to get information, copy-paste of bad code, or what. But I do know it means the last quest in the log will always be selected after a quest-related event and I get blamed for it lol.
nah it's not a blame at all, was just a question
But you are right it is NOT Classic Quest Log, im sorry for that!

But i found another Bug that is from Classic Quest Log -> everything else disabled now ^^

Collapse a Tracked Quest and click "this" quest at the Quest Tracker will open the "default" Quest Log instead of Classic Quest Log!

Easy to reproduce:
Track ANY Quest -> Collapse ALL Quests in Classic Quest Log -> Click ANY Quest on the Quest Tracker -> see the result.

Edit:
Found the addon that loops through all the Quests...
It is "ProjectAzilroka" :/
I'll report it to him, thanks for the clue of the loop, this way it was easier to find
Last edited by fuba : 10-17-20 at 08:24 PM.
Report comment to moderator  
Reply With Quote
Unread 10-16-20, 09:10 PM  
Gello
A Firelord
AddOn Author - Click to view AddOns

Forum posts: 492
File comments: 543
Uploads: 64
Originally Posted by fuba
Here a little Video where you can see the Quest Selection seems bugged:
The Selected Quest will always be the "last" quest in the log and also Click a Quest from the Quest Watch Frame does not jump to the right quest, always the "last" in quest log.

https://youtu.be/uVSa_XPd4b0

maybe you can take a look into it?
If you turn off all other addons besides this one, you'll probably see the behavior stop.

There are addons out there like ConsLegion that aren't content to loop through the quest log to get information, but they actually select each quest in the log as it loops through. I don't know if it's a belief that they need to do this to get information, copy-paste of bad code, or what. But I do know it means the last quest in the log will always be selected after a quest-related event and I get blamed for it lol.
Report comment to moderator  
Reply With Quote
Unread 10-16-20, 06:13 PM  
fuba
A Murloc Raider

Forum posts: 6
File comments: 18
Uploads: 0
Here a little Video where you can see the Quest Selection seems bugged:
The Selected Quest will always be the "last" quest in the log and also Click a Quest from the Quest Watch Frame does not jump to the right quest, always the "last" in quest log.

https://youtu.be/uVSa_XPd4b0

maybe you can take a look into it?
Report comment to moderator  
Reply With Quote
Unread 10-15-20, 07:07 PM  
fuba
A Murloc Raider

Forum posts: 6
File comments: 18
Uploads: 0
Re: Re: Re: Re: ElvUI Skin for Shadowlands Version

Originally Posted by Gello
You can hook cql:PLAYER_LOGIN with ClassicQuestLog.PLAYER_LOGIN; but you need to catch it between when this addon loads and before PLAYER_LOGIN. Possibly you can hook the OnShow of ClassicQuestLog and if flag isn't set then do one-time stuff and set a flag?

I've named ClassicQuestLogOptionsScrollFrame and ClassicQuestLogLoreScrollFrame (the latter isn't evident if you're not on a campaign, but may require skinning if you haven't seen it yet).

If you'd like you can name them in your copy, or PM me an email address and I can email you this.
Ok, im done with that now.
The whole Skin now is a "Standalone" Addon with a Dependencie of "Classic Quest Log"

Best way is you release or send me your new Version with XML files changed and i will take a look into it!

by the way, i found a strange bug but it's hard to describe...
sometimes if i expand any quest header and mouseover or click a quest from another header after, the LAST quest in the questlog will get selected automatically!

also it seems the TOC
Lua Code:
  1. ## Dependencies:
does not allow spaces because it will get split in "Classic", "Quest", "Log" by the Wow Client :/

greetings
Last edited by fuba : 10-15-20 at 07:36 PM.
Report comment to moderator  
Reply With Quote
Unread 10-15-20, 06:10 PM  
Gello
A Firelord
AddOn Author - Click to view AddOns

Forum posts: 492
File comments: 543
Uploads: 64
Re: Re: Re: ElvUI Skin for Shadowlands Version

Originally Posted by fuba
the "spaces" seems not the Problem!
I already tried this but i can not hook your "cql:PLAYER_LOGIN()" function becasue of ... reasons :/

Also to "name" the options scroll frame in the xml is important it seems, else it can not be skinned because of ... another reasons -> i dont know? :P

But i will try it later!
You can hook cql:PLAYER_LOGIN with ClassicQuestLog.PLAYER_LOGIN; but you need to catch it between when this addon loads and before PLAYER_LOGIN. Possibly you can hook the OnShow of ClassicQuestLog and if flag isn't set then do one-time stuff and set a flag?

I've named ClassicQuestLogOptionsScrollFrame and ClassicQuestLogLoreScrollFrame (the latter isn't evident if you're not on a campaign, but may require skinning if you haven't seen it yet).

If you'd like you can name them in your copy, or PM me an email address and I can email you this.
Report comment to moderator  
Reply With Quote
Unread 10-15-20, 05:41 PM  
fuba
A Murloc Raider

Forum posts: 6
File comments: 18
Uploads: 0
Re: Re: ElvUI Skin for Shadowlands Version

Originally Posted by Gello
Originally Posted by fuba
hi there,

i've done the ElvUI skin for the Shadowlands version of your Classic Quest Log
Thanks for doing this.

I'm more than willing to add those BackdropTemplates to the xml. Do you know of any other changes that would have to happen for you to make this a separate addon?

I know one of the issues with this addon is the spaces in the name make it awful to work with as a dependency. I was considering changing its name to Old Quest Log (or OldQuestLog as its AddOn name). Would it help to accelerate that plan?
the "spaces" seems not the Problem!
I already tried this but i can not hook your "cql:PLAYER_LOGIN()" function becasue of ... reasons :/

Also to "name" the options scroll frame in the xml is important it seems, else it can not be skinned because of ... another reasons -> i dont know? :P

But i will try it later!
Last edited by fuba : 10-15-20 at 05:42 PM.
Report comment to moderator  
Reply With Quote
Unread 10-15-20, 03:35 PM  
Gello
A Firelord
AddOn Author - Click to view AddOns

Forum posts: 492
File comments: 543
Uploads: 64
Re: ElvUI Skin for Shadowlands Version

Originally Posted by fuba
hi there,

i've done the ElvUI skin for the Shadowlands version of your Classic Quest Log
Thanks for doing this.

I'm more than willing to add those BackdropTemplates to the xml. Do you know of any other changes that would have to happen for you to make this a separate addon?

I know one of the issues with this addon is the spaces in the name make it awful to work with as a dependency. I was considering changing its name to Old Quest Log (or OldQuestLog as its AddOn name). Would it help to accelerate that plan?
Report comment to moderator  
Reply With Quote
Unread 10-15-20, 10:51 AM  
fuba
A Murloc Raider

Forum posts: 6
File comments: 18
Uploads: 0
ElvUI Skin for Shadowlands Version

hi there,

i've done the ElvUI skin for the Shadowlands version of your Classic Quest Log

but there is a little to do (really not much!)

change in "options.xml" this:
Lua Code:
  1. <ScrollFrame parentKey="options" parent="ClassicQuestLog" inherits="UIPanelScrollFrameTemplate" hidden="true">
to this:
Lua Code:
  1. <ScrollFrame name="ClassicQuestLogOptionsScrollFrame" parentKey="options" parent="ClassicQuestLog" inherits="UIPanelScrollFrameTemplate, BackdropTemplate" hidden="true">

change in "main.xml" this:
Lua Code:
  1. <Frame name="ClassicQuestLog" parent="UIParent" toplevel="true" clampedToScreen="true" enableMouse="true" movable="true" resizable="true" inherits="ButtonFrameTemplate" hidden="true">
to this:
Lua Code:
  1. <Frame name="ClassicQuestLog" parent="UIParent" toplevel="true" clampedToScreen="true" enableMouse="true" movable="true" resizable="true" inherits="ButtonFrameTemplate, BackdropTemplate" hidden="true">

change in "chrome.xml" this:
Lua Code:
  1. <Frame parentKey="countFrame" inherits="InsetFrameTemplate3">
to this:
Lua Code:
  1. <Frame parentKey="countFrame" inherits="InsetFrameTemplate3, BackdropTemplate">

and add a new file, i called it simply "ElvUISkin.lua" and add the following:
Lua Code:
  1. local cql = ClassicQuestLog
  2.  
  3. function cql:SkinForElvUI()
  4.   local E, L, P, G = unpack(ElvUI)
  5.   local S = E:GetModule("Skins")
  6.  
  7.   cql:StripTextures()
  8.   cql:SetTemplate("Transparent")
  9.  
  10.   S:HandleCloseButton(cql.CloseButton)
  11.  
  12.   for k,v in pairs({"abandonButton","pushButton","trackButton","closeButton","optionsButton","syncButton"}) do
  13.     if cql.chrome[v] then
  14.       S:HandleButton(cql.chrome[v])
  15.     end
  16.   end
  17.  
  18.   ClassicQuestLogScrollFrame:StripTextures()
  19.   S:HandleScrollBar(ClassicQuestLogScrollFrameScrollBar)
  20.  
  21.   ClassicQuestLogDetailScrollFrame:StripTextures()
  22.   S:HandleScrollBar(ClassicQuestLogDetailScrollFrameScrollBar)
  23.  
  24.   cql.options:StripTextures()
  25.   ClassicQuestLogOptionsScrollFrame:SetTemplate("Transparent")
  26.   ClassicQuestLogOptionsScrollFrame:SetBackdropColor(0,0,0,a)
  27.   S:HandleScrollBar(ClassicQuestLogOptionsScrollFrameScrollBar)
  28.  
  29.   for k,v in pairs({"LockWindow","ShowResizeGrip","ShowLevels","ShowTooltips","SolidBackground","ShowFromObjectiveTracker"}) do
  30.     local cb = ClassicQuestLogOptionsScrollFrame.content[v].check
  31.     if cb then S:HandleCheckBox(cb) end
  32.   end
  33.  
  34.   cql.chrome.countFrame:StripTextures()
  35.   cql.chrome.countFrame:SetTemplate(nil, true)
  36.   cql.chrome.countFrame.isSkinned = true
  37.  
  38.   ClassicQuestLogScrollFrame.expandAll:StripTextures()
  39.   ClassicQuestLogScrollFrame.expandAll:ClearAllPoints()
  40.   ClassicQuestLogScrollFrame.expandAll:SetPoint('BOTTOMLEFT', cql, 'TOPLEFT', -1, -50)
  41.  
  42.   hooksecurefunc(ClassicQuestLogScrollFrame, "UpdateListButton", function(self, button, info)
  43.     if ((not button) or (not info) or (type(info)~="table")) then return end
  44.  
  45.     if info.isHeader then
  46.       local isCollapsed = ClassicQuestLogCollapsedHeaders[info.title]
  47.       button:SetNormalTexture(isCollapsed and E.Media.Textures.PlusButton or E.Media.Textures.MinusButton)
  48.     end
  49.   end)
  50.  
  51.   hooksecurefunc(ClassicQuestLogScrollFrame, "UpdateLog", function(self)
  52.     local quests = cql.log.quests
  53.     local numEntries = #quests
  54.  
  55.     if numEntries ~= 0 then
  56.       cql.log.expandAll:SetNormalTexture(cql.log.somethingExpanded and E.Media.Textures.MinusButton or E.Media.Textures.PlusButton)
  57.     end
  58.   end)
  59.  
  60.   -- i personally like the "default" close button more then the ElvUI Skinned Close Button at this Position!
  61.   --S:HandleCloseButton(ClassicQuestLogOptionsScrollFrame.content.close)
  62. end

Preview #1:



Preview #2:



Preview #3:




This should make an ElvUI Skin without touching the Original files, except the changes in the XML files are needed because of missing inherits for "BackdropTemplate" and one name was missing!

hopefully i don't forgot anything!

maybe the Quest Count Text needs a little adjustment?!
hmm..

AHH and OFC you need to load it...
i totally foregot about to add
Lua Code:
  1. if IsAddOnLoaded("ElvUI") then cql:SkinForElvUI() end
in your "main.lua" in -> function cql:PLAYER_LOGIN()

and also add the "ElvUISkin.lua" in your TOC, but i'm sure you aware of it ^^

greetings, fuba
Last edited by fuba : 10-15-20 at 01:55 PM.
Report comment to moderator  
Reply With Quote
Unread 10-14-20, 03:11 PM  
Gello
A Firelord
AddOn Author - Click to view AddOns

Forum posts: 492
File comments: 543
Uploads: 64
Originally Posted by MysticalOS
This is triggered when trying to shift click a quest to untrack it. the untrack button works, so it just seems the shift click was overlooked
3x Classic Quest Log\log.lua:267: attempt to call method 'ToggleWatch' (a nil value)
[string "@Classic Quest Log\log.lua"]:267: in function `ListButtonOnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>
Thanks for the report! I'll take a look.
Report comment to moderator  
Reply With Quote
Unread 10-14-20, 10:40 AM  
MysticalOS
A Wyrmkin Dreamwalker
 
MysticalOS's Avatar
AddOn Author - Click to view AddOns

Forum posts: 54
File comments: 323
Uploads: 8
This is triggered when trying to shift click a quest to untrack it. the untrack button works, so it just seems the shift click was overlooked
3x Classic Quest Log\log.lua:267: attempt to call method 'ToggleWatch' (a nil value)
[string "@Classic Quest Log\log.lua"]:267: in function `ListButtonOnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>
Report comment to moderator  
Reply With Quote
Unread 09-09-20, 03:21 PM  
Gello
A Firelord
AddOn Author - Click to view AddOns

Forum posts: 492
File comments: 543
Uploads: 64
The PTR is the Shadowlands client. All Shadowlands addons can run in the PTR.
Report comment to moderator  
Reply With Quote
Unread 09-09-20, 01:22 PM  
fuba
A Murloc Raider

Forum posts: 6
File comments: 18
Uploads: 0
Originally Posted by Gello
Originally Posted by fuba
Here a little fix and some design optimization for your ElvUI Skin funktion:
Hey thanks. In rewriting the Shadowlands version (https://www.wowinterface.com/downloa...wlandsBeta.htm) I dropped that ElvUI skinning because I wasn't sure it was working and installing ElvUI to test stuff just wrecks my cvars and makes me unreasonably angry. This may make me revisit it.
I've now also skinned the Collapse/Expand Buttons for ElvUI if you're interested, but this need 6 lines outside of the function cql:SkinForElvUI() becasue this buttons are re-skinned after click

All the Quest Expand/Collapse Buttons:
After this line:
Lua Code:
  1. button:SetNormalTexture(isCollapsed and "Interface\\Buttons\\UI-PlusButton-Up" or "Interface\\Buttons\\UI-MinusButton-Up")
just add this:
Lua Code:
  1. if ElvUI then button:SetNormalTexture(isCollapsed and ElvUI[1].Media.Textures.PlusButton or ElvUI[1].Media.Textures.MinusButton) end
Your ExpandAll Button:
and after this line:
Lua Code:
  1. cql.scrollFrame.expandAll:SetNormalTexture(cql.expanded and "Interface\\Buttons\\UI-MinusButton-Up" or "Interface\\Buttons\\UI-PlusButton-Up")
add this:
Lua Code:
  1. if ElvUI then cql.scrollFrame.expandAll:SetNormalTexture(cql.expanded and ElvUI[1].Media.Textures.MinusButton or ElvUI[1].Media.Textures.PlusButton) end
Again a Little fix (just 1 pixel):
It is a VERY little positioning fix
just replace:
Lua Code:
  1. cql.scrollFrame.expandAll:SetPoint('BOTTOMLEFT', cql, 'TOPLEFT', 0, -50)
with this:
Lua Code:
  1. cql.scrollFrame.expandAll:SetPoint('BOTTOMLEFT', cql, 'TOPLEFT', -1, -50)
i know just -1 pixel is not that bad, but... it's perfection! :P
Haha

Sadly i dont have Beta Access for Shadowlands i can not test you're Shadowlands version

Anyways after prepatch i will still use your AddOn i think and i also will take a look into the ElvUI skin then!

just a question:
You have a GitHub project for your AddOns?
So i simply could Pull Request changes and you can (or not) merge it with one click ^^
Report comment to moderator  
Reply With Quote
Unread 09-05-20, 02:52 PM  
Gello
A Firelord
AddOn Author - Click to view AddOns

Forum posts: 492
File comments: 543
Uploads: 64
Originally Posted by fuba
Here a little fix and some design optimization for your ElvUI Skin funktion:
Hey thanks. In rewriting the Shadowlands version (https://www.wowinterface.com/downloa...wlandsBeta.htm) I dropped that ElvUI skinning because I wasn't sure it was working and installing ElvUI to test stuff just wrecks my cvars and makes me unreasonably angry. This may make me revisit it.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: