Quantcast
Download
(42 MB)
Download
Updated: 05-05-20 11:46 AM
Pictures
File Info
Compatibility:
Visions of N'Zoth (8.3.0)
Updated:05-05-20 11:46 AM
Created:unknown
Downloads:5,565,347
Favorites:7,704
MD5:

LightHeaded  Popular! (More than 5000 hits)

Version: v80200-1.0.0-2020-05-01
by: Cladhaire [More]

Now updated for Classic, check "Other Files" and download the most recent 11302 version!


LightHeaded is a very simple addon that displays quest information and comments from http://www.wowhead.com in game, eliminating the need to Alt-Tab when you get stuck on quest. This addon was inspired by qcomments and wowhead_quests, which both serve a similar purpose. Data is only loaded when you first request it, so you can be sure you're not using more memory than you need to.

I HIGHLY suggest using this addon with TomTom, another one of my addons (http://www.wowinterface.com/download...32-TomTom.html ). This allows you to simply click any coordinate in LightHeaded to add it to your map as a waypoint.

The following slash commands are valid:
  • /lh attach - Attaches the frame to the quest log
  • /lh detach - Detaches the frame, allows you to resize and move it
  • /lh sound - Toggles the open/close sound
  • /lh page - Toggles showing all comments on one page, or with multiple pages
  • /lh bgalpha <0.0-1.0> - Changes the alpha of the LH window background textures, so you can see the world.
  • /lh debug - Enables or disabled debug messages when loading quest databases
  • /lh config - Opens the LightHeaded configuration window
  • /lh autodetails - Toggle automatic opening of the Lightheaded window when clicking a quest in the objective tracker

LightHeaded now includes the English descriptions and introductory text for most of the quests in the game. This is disabled by default, but can be enabled for those players that are not playing in their native locale.

LightHeaded supports sending coordinates to TomTom, MapNotes, Cartographer2 and Cartographer3.

IMPORTANT: Addon authors that wish to use this API and data should
include the wowhead logo in the frame that displays this information.
They are kind enough to let me continue parsing their database, and we
owe them at least that much. Thank you.

Thanks for using my addons!

commit 55faafeb8d07e59b5cd92ac037cebdc7e13a8ba4
Author: Jim Whitehead <[email protected]>
Date: Tue May 5 19:35:27 2020 +0200

Update parse 2020-05-01

commit 66224f5042077f8b7f2e26aaa0921eec05e0b316
Author: Jim Whitehead <[email protected]>
Date: Tue Jul 23 20:26:11 2019 +0200

Update version 8.2

commit 006538ef02235c65cf8585e449a791447f4ff909
Author: Jim Whitehead <[email protected]>
Date: Sun Jul 7 21:18:08 2019 +0200

Update parse 2019-07-06

commit 4ed5675a7c686999245672bd91c629b29fd286e7
Author: Jim Whitehead <[email protected]>
Date: Sun Jun 2 21:55:35 2019 +0200

Comments updated 2019-06-02

commit 4a742b8fda452edbdba7fae656a0cc42aeac500d
Author: Jim Whitehead <[email protected]>
Date: Sat Feb 16 10:39:43 2019 +0100

Updated parse 2019-02-11

commit 1d6adea69ea045e3a441cedcc810c53e5646ba22
Author: Jim Whitehead <[email protected]>
Date: Tue Dec 18 23:06:50 2018 +0100

Update 2018-12-16

commit 5b4078e37876493b0166fd73a087f40079a59c72
Author: Jim Whitehead <[email protected]>
Date: Mon Dec 10 22:21:35 2018 +0100

Update comments 2018-12-01

commit ab6d14bc2a0e203eb3378aaea9c74339345d9061
Author: Jim Whitehead <[email protected]>
Date: Wed Oct 17 09:17:44 2018 +0200

Update comments for BfA quests

commit 3a57485bab1b4208ff02f200ddebae3549494945
Author: Jim Whitehead <[email protected]>
Date: Wed Sep 12 22:53:46 2018 +0200

Updated comments parsed 2018-09-10

commit 431924fbfa61c71c439a51550afbc57c6d21d51f
Author: Jim Whitehead <[email protected]>
Date: Tue Aug 21 22:41:52 2018 +0200

Updated comment parse.

Thanks again Lunar <3

commit 91dfec5dbc302522d4532b12925196b8e6711b83
Author: Jim Whitehead <[email protected]>
Date: Fri Jul 20 11:53:01 2018 +0200

Update for 8.0

This disables POI clicking integration, that will need to be fixed by finding
the correct function to hook to intercept. Searching and manually opening
works.

commit 1d5341b58abf22b22afd42d4b92cc8bf5dac73d1
Author: Jim Whitehead <[email protected]>
Date: Wed Jan 3 08:38:41 2018 +0100

Updated comment parse

commit fa679bd2c64bf225d806f07ef2268faf26f67056
Author: Jim Whitehead <[email protected]>
Date: Thu Aug 10 09:29:43 2017 +0200

Update comments parsed 31-July

commit 698a623a85db30dd1dc7edca2ac0584afb29cbfb
Author: Jim Whitehead <[email protected]>
Date: Thu Apr 6 18:59:49 2017 +0200

Update TOC for 7.2

commit 0b4a204bd4db9388266c9700e5cde4ed226321a5
Author: Jim Whitehead <[email protected]>
Date: Thu Apr 6 18:56:33 2017 +0200

Updated comment parse

commit ddba7c19eaca80dc207b7bccfd9f8c096d991aed
Author: Jim Whitehead <[email protected]>
Date: Thu Jan 12 21:23:29 2017 +0100

Add new parse, update integration, update toc.

Thanks to lunarwtr for the fixes

commit 547b33546eb69dccb662beffda2625d74bf11b74
Author: Jim Whitehead <[email protected]>
Date: Thu Oct 27 22:39:13 2016 +0200

Update for 7.1

commit ea5dd596d578663a34044137a34b04b42ff1a4ac
Author: Jim Whitehead <[email protected]>
Date: Wed Sep 7 15:35:26 2016 +0200

Disable auto-popup on SelectQuestLogEntry

commit c3e67123f3233e8e0abd1eb74562f74b1e005209
Author: Jim Whitehead <[email protected]>
Date: Mon Sep 5 14:54:46 2016 +0200

Update TOC for 70000

commit 14d8721ebb51a801b04f4bd7229a57ec5470412e
Author: Jim Whitehead <[email protected]>
Date: Mon Sep 5 14:52:45 2016 +0200

Update for new parsing script

Thanks to lunarwtr we're able to parse again, since I didn't have time
to fix the previous parser. This required some changes to the addon, but
this should get things back up and working.

commit f4a0f7d143c67eb1768662ca73073b103e9e861d
Author: Jim Whitehead <[email protected]>
Date: Sat Jan 31 15:35:53 2015 +0100

Remove dead code

commit 61d0d2ab136d5f79be4edc62e6ae3cbc2964431c
Author: Jim Whitehead <[email protected]>
Date: Sat Jan 31 15:27:56 2015 +0100

Fix LH waypoint set integration

- We now are able to properly reverse WowHead mapFileIds to the in-game
areaIds, so waypoints should be set in the correct zone.
- We don't know how to set a waypoint in an instanced zone, so we just
put those in the current zone
- Integration with MapNotes, Cartographer and friends always set in the
current zone.

commit ce35e8b832925ec497af58a9d53c70c9d387816a
Author: Jim Whitehead <[email protected]>
Date: Sat Jan 31 10:17:44 2015 +0100

Use new API to set waypoint in current zone
Beta Files (6)
File Name
Version
Hits
Size
Author
Date
v11302-1.0.0-2020-05-01
554
10MB
Cladhaire
05-05-20 11:47 AM
v11302-1.1.0
1,313
10MB
Cladhaire
10-04-19 11:26 AM
v11302-1.0.0
1,459
10MB
Cladhaire
09-05-19 12:16 AM
v70100-1.1.0-2016-12-29
291
30MB
Cladhaire
01-12-17 02:27 PM
v70000-1.0.0-beta
302
27MB
Cladhaire
09-05-16 07:11 AM
v60000-0.1.0
1,004
22MB
Cladhaire
10-20-14 02:50 PM


Archived Files (31)
File Name
Version
Size
Author
Date
v80200-1.0.0-2019-07-06
44MB
Cladhaire
07-07-19 01:32 PM
v80100-1.3.0-2019-06-02
40MB
Cladhaire
06-02-19 02:15 PM
v80100-1.1.0-2019-02-11
37MB
Cladhaire
02-16-19 03:44 AM
v80100-1.0.0-2018-12-16
37MB
Cladhaire
12-18-18 04:08 PM
v80000-1.4.0-2018-12-01
36MB
Cladhaire
12-10-18 03:25 PM
v80000-1.3.0-2018-10-15
36MB
Cladhaire
10-17-18 01:20 AM
v80000-1.2.0
36MB
Cladhaire
09-12-18 02:56 PM
v80000-1.1.0
35MB
Cladhaire
08-21-18 02:44 PM
v80000-1.0.0
32MB
Cladhaire
07-20-18 03:55 AM
v70300-1.0.0-2017-12-19
32MB
Cladhaire
01-03-18 01:41 AM
v70200-1.0.0-20
32MB
Cladhaire
08-10-17 01:43 AM
v70200-1.0.0-20
30MB
Cladhaire
04-06-17 11:02 AM
v70100-1.1.0-20
30MB
Cladhaire
01-27-17 01:34 AM
v70100-1.0.0-20
29MB
Cladhaire
10-27-16 02:58 PM
v70000-1.1.0-20
27MB
Cladhaire
09-07-16 07:39 AM
v60000-1.2.0-20
22MB
Cladhaire
12-21-14 10:28 AM
v60000-1.1.0-20
21MB
Cladhaire
12-13-14 05:13 AM
v60000-1.0.0-20
21MB
Cladhaire
10-26-14 10:37 AM
v60000-1.0.0
22MB
Cladhaire
10-14-14 02:01 PM
v50400-2014-07-
22MB
Cladhaire
07-26-14 04:14 AM
v50400-2014-01-
21MB
Cladhaire
01-05-14 12:42 PM
v50300-2013-06-
20MB
Cladhaire
06-18-13 11:35 PM
v50100-2013-03-
19MB
Cladhaire
03-24-13 01:54 PM
v50100-2013-03-
19MB
Cladhaire
03-24-13 09:59 AM
v50100-2013-02-
15MB
Cladhaire
02-18-13 02:37 PM
v50100-2012-10-
18MB
Cladhaire
11-28-12 02:22 PM
v50001-2012-10-
18MB
Cladhaire
10-10-12 11:45 PM
v50001-2012-09-
18MB
Cladhaire
09-29-12 02:39 PM
v50001-r352
17MB
Cladhaire
09-10-12 12:02 AM
v50001-r151
16MB
Cladhaire
09-09-12 02:56 AM
r344
16MB
Cladhaire
01-24-12 02:52 AM


Post A Reply Comment Options
Unread Yesterday, 03:42 PM  
snichols1122
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 132
Uploads: 10
Originally Posted by Cladhaire
Originally Posted by lloska
Originally Posted by snichols1122
has anyone found a way to make this addon work for shadowlands until the author puts out an update
from my part nay

This addon should not be discontinued but... give it to an another author to proper update.
LightHeaded seems to function just fine in Shadowlands, although the quests for the expansion obviously aren't included within.

What in particular isn't working for you?
i didnt realize you had to code the quests in individually you covered what it was the shadowlands quests showing blanks
Report comment to moderator  
Reply With Quote
Unread Yesterday, 05:51 AM  
Cladhaire
Salad!
 
Cladhaire's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 1935
File comments: 4799
Uploads: 19
Originally Posted by Gello
I'm making a fix in ClassicQuestLog to work around this, but for the issue:

In the 9.0 client on retail servers today and since the pre-patch, the following are no longer defined:

These were pretty central to the pre-9.0 quest API. (It's a testament to how well LightHeaded was written that it works at all with the above two functions are nil!)

Complicating this, the addon ClassicQuestLog was rewritten to use the new quest API so the hook it makes to ClassicQuestLog:SelectQuestIndex(index) no longer exists. (I wasn't aware LightHeaded was hooking this.) This causes the error at line 96 in LightHeaded.lua.

However, adding an empty function call and calling it with an index (ClassicQuestLog selects quests by questID now, not log index), will trigger an error on line 97 in LightHeader.lua because GetQuestLogTitle was deprecated in the 9.0 client.

So for the interim, until LightHeaded is fixed, I'm adding two functions to ClassicQuestLog:

Lua Code:
  1. -- to make it easier for outside programs to hook quests being selected
  2. function cql.log:SelectQuestID(questID)
  3.     C_QuestLog.SetSelectedQuest(questID)
  4.     cql:SetMode("detail")
  5.     -- for LightHeaded (or anything else that calls the old 1.x function that was removed)
  6.     cql:SelectQuestIndex(C_QuestLog.GetLogIndexForQuestID(questID))
  7. end
  8.  
  9. -- fix for lightheaded which hooks this deprecated function and calls deprecated GetQuestLogTitle and GetQuestLogSelection
  10. function cql:SelectQuestIndex(index)
  11.     if IsAddOnLoaded("LightHeaded") then
  12.         -- this defines GetQuestLogTitle which is replaced by C_QuestLog.GetInfo in the 9.0 client
  13.         if not GetQuestLogTitle then
  14.             GetQuestLogTitle = function(index)
  15.                 local info = C_QuestLog.GetInfo(index)
  16.                 return info.title, info.level, info.suggestedGroup, info.isHeader, info.isCollapsed, info.isComplete, info.frequency, info.questID
  17.             end
  18.         end
  19.         -- this defines GetQuestLogTitle which is replaced by C_QuestLog.GetSelectedQuest in the 9.0 client
  20.         if not GetQuestLogSelection then
  21.             GetQuestLogSelection = C_QuestLog.GetSelectedQuest
  22.         end
  23.     end
  24. end

I'm posting my updates later tonight. When LightHeaded is next updated, I recommend changing this in LightHeaded.lua:

Lua Code:
  1. hooksecurefunc(ClassicQuestLog,"SelectQuestIndex", function(cql, index)
  2.     local title, level, suggestedGroup, isHeader, isCollapsed, isComplete, frequency, questID = GetQuestLogTitle(index);
  3.     self:OpenQuestID(questID)
  4. end)

to this:
Lua Code:
  1. hooksecurefunc(ClassicQuestLog.log,"SelectQuestID", function(cql, questID)
  2.     self:OpenQuestID(questID)
  3. end)

One LightHeaded is updated, I'll remove the cql:SelectQuestIndex() above if it's no longer called.
Thanks Gello, this came at a weird time for me and slipped through my cracks. You can always reach out to me directly as well if there's something like this. I'll see what I can do.
__________________
"There's only one thing that I know how to do well and I've often been told that you only can do what you know how to do well, and that's be you-- be what you're like-- be like yourself. And so I'm having a wonderful time, but I'd rather be whistling in the dark..."
Report comment to moderator  
Reply With Quote
Unread Yesterday, 05:50 AM  
Cladhaire
Salad!
 
Cladhaire's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 1935
File comments: 4799
Uploads: 19
Originally Posted by lloska
Originally Posted by snichols1122
has anyone found a way to make this addon work for shadowlands until the author puts out an update
from my part nay

This addon should not be discontinued but... give it to an another author to proper update.
LightHeaded seems to function just fine in Shadowlands, although the quests for the expansion obviously aren't included within.

What in particular isn't working for you?
__________________
"There's only one thing that I know how to do well and I've often been told that you only can do what you know how to do well, and that's be you-- be what you're like-- be like yourself. And so I'm having a wonderful time, but I'd rather be whistling in the dark..."
Report comment to moderator  
Reply With Quote
Unread Yesterday, 02:07 AM  
lloska
A Kobold Labourer
 
lloska's Avatar

Forum posts: 0
File comments: 11
Uploads: 0
Originally Posted by snichols1122
has anyone found a way to make this addon work for shadowlands until the author puts out an update
from my part nay

This addon should not be discontinued but... give it to an another author to proper update.
__________________
Salu2 y a portarse bien.
JOSÉ CARLOS PÉREZ CARREÑO.
Report comment to moderator  
Reply With Quote
Unread 12-01-20, 03:54 PM  
snichols1122
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 132
Uploads: 10
has anyone found a way to make this addon work for shadowlands until the author puts out an update
Report comment to moderator  
Reply With Quote
Unread 11-18-20, 03:11 AM  
lloska
A Kobold Labourer
 
lloska's Avatar

Forum posts: 0
File comments: 11
Uploads: 0
Originally Posted by barlar
Originally Posted by Cladhaire
I'll be working on it but it will take a bit of time, I'm down and out with a cold this week and needed to prioritize the other addons that are a bit more crucial. Will get around to updating though, I promise.
We appreciate you greatly!
200%
__________________
Salu2 y a portarse bien.
JOSÉ CARLOS PÉREZ CARREÑO.
Report comment to moderator  
Reply With Quote
Unread 11-17-20, 02:10 AM  
barlar
A Kobold Labourer

Forum posts: 0
File comments: 9
Uploads: 0
Originally Posted by Cladhaire
I'll be working on it but it will take a bit of time, I'm down and out with a cold this week and needed to prioritize the other addons that are a bit more crucial. Will get around to updating though, I promise.
We appreciate you greatly!
Report comment to moderator  
Reply With Quote
Unread 11-01-20, 08:57 AM  
Radoznali
A Deviate Faerie Dragon
 
Radoznali's Avatar

Forum posts: 11
File comments: 146
Uploads: 0
Bug

Error occured in: Global
Count: 1
Message: ..\AddOns\LightHeaded\LightHeaded.lua line 162:
attempt to call global 'GetQuestLogSelection' (a nil value)
Debug:
[string "=[C]"]: GetQuestLogSelection()
[string "@LightHeaded\LightHeaded.lua"]:162: GetCurrentQID()
[string "@LightHeaded\LightHeaded.lua"]:275: SelectQuestLogEntry()
[string "@LightHeaded\LightHeaded.lua"]:269: OpenQuestID()
[string "@LightHeaded\LightHeaded.lua"]:58:
LightHeaded\LightHeaded.lua:57
[string "=[C]"]: OnBlockHeaderClick()
[string "@Blizzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua"]:686:
...zzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua:684
Report comment to moderator  
Reply With Quote
Unread 10-25-20, 09:13 AM  
snichols1122
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 132
Uploads: 10
LUA

24x LightHeaded\LightHeaded-v80200-1.0.0-2020-05-01.lua:162: attempt to call global 'GetQuestLogSelection' (a nil value)
[string "@LightHeaded\LightHeaded-v80200-1.0.0-2020-05-01.lua"]:162: in function `GetCurrentQID'
[string "@LightHeaded\LightHeaded-v80200-1.0.0-2020-05-01.lua"]:275: in function `SelectQuestLogEntry'
[string "@LightHeaded\LightHeaded-v80200-1.0.0-2020-05-01.lua"]:269: in function `OpenQuestID'
[string "@LightHeaded\LightHeaded-v80200-1.0.0-2020-05-01.lua"]:58: in function <LightHeaded\LightHeaded.lua:57>
[string "=[C]"]: in function `OnBlockHeaderClick'
[string "@Blizzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua"]:686: in function <...zzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua:684>

Locals:
self = <table> {
defaults = <table> {
}
EnableDebug = <function> defined @LightHeaded\Dongle.lua:618
IterateQuestComments = <function> defined @LightHeaded\LightHeaded.lua:399
QUEST_LOG_UPDATE = <function> defined @LightHeaded\LightHeaded.lua:157
CancelTimer = <function> defined @LightHeaded\Dongle.lua:605
ChangeFontSize = <function> defined @LightHeaded\LightHeaded.lua:1705
GetQIDOffsets = <function> defined @LightHeaded\LightHeaded.lua:219
LoadNames = <function> defined @LightHeaded\LightHeaded.lua:170
OnHyperlinkEnter = <function> defined @LightHeaded\LightHeaded.lua:1108
SavePosition = <function> defined @LightHeaded\LightHeaded.lua:1611
quest_clicked = true
OnHyperlinkClick = <function> defined @LightHeaded\LightHeaded.lua:885
GetQuestName = <function> defined @LightHeaded\LightHeaded.lua:195
ScheduleTimer = <function> defined @LightHeaded\Dongle.lua:558
LockUnlockFrame = <function> defined @LightHeaded\LightHeaded.lua:1589
GetCurrentQID = <function> defined @LightHeaded\LightHeaded.lua:161
RestorePosition = <function> defined @LightHeaded\LightHeaded.lua:1629
RegisterMessage = <function> defined @LightHeaded\Dongle.lua:412
UnregisterMessage = <function> defined @LightHeaded\Dongle.lua:426
IterateNPCLocs = <function> defined @LightHeaded\LightHeaded.lua:428
db = <table> {
}
uihistory = <table> {
}
TogglePages = <function> defined @LightHeaded\LightHeaded.lua:1676
IterateModules = <function> defined @LightHeaded\Dongle.lua:316
ToggleDebug = <function> defined @LightHeaded\LightHeaded.lua:1741
SelectQuestLogEntry = <function> defined @LightHeaded\LightHeaded.lua:272
GetCoordText = <function> defined @LightHeaded\LightHeaded.lua:491
IsMessageRegistered = <function> defined @LightHeaded\Dongle.lua:467
TriggerMessage = <function> defined @LightHeaded\Dongle.lua:450
Enable = <function> defined @LightHeaded\LightHeaded.lua:31
IsEventRegistered = <function> defined @LightHeaded\Dongle.lua:396
Echo = <function> defined @LightHeaded\Dongle.lua:696
ChangeBGAlpha = <function> defined @LightHeaded\LightHeaded.lua:1712
ToggleSound = <function> defined @LightHeaded\LightHeaded.lua:1666
GetNumQuestComments = <function> defined @LightHeaded\LightHeaded.lua:370
ScheduleRepeatingTimer = <function> defined @LightHeaded\Dongle.lua:589
UpdateFrame = <function> defined @LightHeaded\LightHeaded.lua:793
PrintF = <function> defined @LightHeaded\Dongle.lua:689
SearchQuests = <function> defined @LightHeaded\LightHeaded.lua:1754
GetQIDDescription = <function> defined @LightHeaded\LightHeaded.lua:244
version = "v80200-1.0.0-2020-05-01"
GetQuestData = <function> defined @LightHeaded\LightHeaded.lua:317
InitializeSlashCommand = <function> defined @LightHeaded\Dongle.lua:1175
GetQuestComment = <function> defined @LightHeaded\LightHeaded.lua:377
bad_select = 0
Print = <function> defined @LightHeaded\Dongle.lua:682
cmd = <table> {
}
GetMapIdFromWowheadZone = <function> defined @LightHeaded\LightHeaded.lua:1810
GetPageText = <function> defined @LightHeaded\LightHeaded.lua:567
ToggleAutoDetails = <function> defined @LightHeaded\LightHeaded.lua:1694
HasModule = <function> defined @LightHeaded\Dongle.lua:298
IsTimerScheduled = <function> defined @LightHeaded\Dongle.lua:594
NewModule = <function> defined @LightHeaded\Dongle.lua:283

if you try to click on quest in quest tracker this shows up no way around it thats with no other quest addons active
Last edited by snichols1122 : 10-26-20 at 02:55 PM.
Report comment to moderator  
Reply With Quote
Unread 10-24-20, 03:51 PM  
Gello
A Firelord
AddOn Author - Click to view AddOns

Forum posts: 492
File comments: 544
Uploads: 64
I'm making a fix in ClassicQuestLog to work around this, but for the issue:

In the 9.0 client on retail servers today and since the pre-patch, the following are no longer defined:

These were pretty central to the pre-9.0 quest API. (It's a testament to how well LightHeaded was written that it works at all with the above two functions are nil!)

Complicating this, the addon ClassicQuestLog was rewritten to use the new quest API so the hook it makes to ClassicQuestLog:SelectQuestIndex(index) no longer exists. (I wasn't aware LightHeaded was hooking this.) This causes the error at line 96 in LightHeaded.lua.

However, adding an empty function call and calling it with an index (ClassicQuestLog selects quests by questID now, not log index), will trigger an error on line 97 in LightHeader.lua because GetQuestLogTitle was deprecated in the 9.0 client.

So for the interim, until LightHeaded is fixed, I'm adding two functions to ClassicQuestLog:

Lua Code:
  1. -- to make it easier for outside programs to hook quests being selected
  2. function cql.log:SelectQuestID(questID)
  3.     C_QuestLog.SetSelectedQuest(questID)
  4.     cql:SetMode("detail")
  5.     -- for LightHeaded (or anything else that calls the old 1.x function that was removed)
  6.     cql:SelectQuestIndex(C_QuestLog.GetLogIndexForQuestID(questID))
  7. end
  8.  
  9. -- fix for lightheaded which hooks this deprecated function and calls deprecated GetQuestLogTitle and GetQuestLogSelection
  10. function cql:SelectQuestIndex(index)
  11.     if IsAddOnLoaded("LightHeaded") then
  12.         -- this defines GetQuestLogTitle which is replaced by C_QuestLog.GetInfo in the 9.0 client
  13.         if not GetQuestLogTitle then
  14.             GetQuestLogTitle = function(index)
  15.                 local info = C_QuestLog.GetInfo(index)
  16.                 return info.title, info.level, info.suggestedGroup, info.isHeader, info.isCollapsed, info.isComplete, info.frequency, info.questID
  17.             end
  18.         end
  19.         -- this defines GetQuestLogTitle which is replaced by C_QuestLog.GetSelectedQuest in the 9.0 client
  20.         if not GetQuestLogSelection then
  21.             GetQuestLogSelection = C_QuestLog.GetSelectedQuest
  22.         end
  23.     end
  24. end

I'm posting my updates later tonight. When LightHeaded is next updated, I recommend changing this in LightHeaded.lua:

Lua Code:
  1. hooksecurefunc(ClassicQuestLog,"SelectQuestIndex", function(cql, index)
  2.     local title, level, suggestedGroup, isHeader, isCollapsed, isComplete, frequency, questID = GetQuestLogTitle(index);
  3.     self:OpenQuestID(questID)
  4. end)

to this:
Lua Code:
  1. hooksecurefunc(ClassicQuestLog.log,"SelectQuestID", function(cql, questID)
  2.     self:OpenQuestID(questID)
  3. end)

One LightHeaded is updated, I'll remove the cql:SelectQuestIndex() above if it's no longer called.
Report comment to moderator  
Reply With Quote
Unread 10-24-20, 12:08 PM  
tazrulezall
A Kobold Labourer

Forum posts: 0
File comments: 9
Uploads: 0
If I have Classic Quest Log disabled, Lightheaded has no problem. If I re-enable Classic Quest Log, I get the following error on login:

Code:
1x LightHeaded\LightHeaded-v80200-1.0.0-2020-05-01.lua:96: hooksecurefunc(): SelectQuestIndex is not a function
[string "@LightHeaded\Dongle.lua"]:1316: in function <LightHeaded\Dongle.lua:1308>
[string "@LightHeaded\Dongle.lua"]:1338: in function <LightHeaded\Dongle.lua:1325>
[string "=[C]"]: in function `pcall'
[string "@LightHeaded\Dongle.lua"]:246: in function <LightHeaded\Dongle.lua:245>
[string "@LightHeaded\Dongle.lua"]:336: in function <LightHeaded\Dongle.lua:327>
[string "=[C]"]: in function `LoadAddOn'
[string "@FrameXML\UIParent.lua"]:495: in function `UIParentLoadAddOn'
[string "@FrameXML\UIParent.lua"]:618: in function `TimeManager_LoadUI'
[string "@FrameXML\UIParent.lua"]:1373: in function <FrameXML\UIParent.lua:1258>
[string "=[C]"]: ?
Report comment to moderator  
Reply With Quote
Unread 10-21-20, 03:01 PM  
snichols1122
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 132
Uploads: 10
its only when someone clicks the quests it does that for me as well it has something to do with when it connects to wowhead when i login ill confirm its the same lua error or not
Last edited by snichols1122 : 10-21-20 at 03:02 PM.
Report comment to moderator  
Reply With Quote
Unread 10-19-20, 09:26 AM  
Cladhaire
Salad!
 
Cladhaire's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 1935
File comments: 4799
Uploads: 19
No idea why this is happening. Do you have a ClassicQuestLog addon enabled? That code shouldn't be active on live, and I can't reproduce this error at the moment.

Originally Posted by Ookami.kun
Receiving the following error upon logging in to the game after the update to 9.0.1. Thanks,

Code:
4x LightHeaded\LightHeaded-v80200-1.0.0-2020-05-01.lua:96: hooksecurefunc(): SelectQuestIndex is not a function
[string "@Auditor3\Libs\Dongle.lua"]:1316: in function <Auditor3\Libs\Dongle.lua:1308>
[string "@Auditor3\Libs\Dongle.lua"]:1338: in function <Auditor3\Libs\Dongle.lua:1325>
[string "=[C]"]: in function `pcall'
[string "@Auditor3\Libs\Dongle.lua"]:246: in function <Auditor3\Libs\Dongle.lua:245>
[string "@Auditor3\Libs\Dongle.lua"]:336: in function <Auditor3\Libs\Dongle.lua:327>
[string "=[C]"]: in function `LoadAddOn'
[string "@FrameXML\UIParent.lua"]:495: in function `UIParentLoadAddOn'
[string "@FrameXML\UIParent.lua"]:542: in function `CombatLog_LoadUI'
[string "@FrameXML\UIParent.lua"]:1375: in function <FrameXML\UIParent.lua:1258>
__________________
"There's only one thing that I know how to do well and I've often been told that you only can do what you know how to do well, and that's be you-- be what you're like-- be like yourself. And so I'm having a wonderful time, but I'd rather be whistling in the dark..."
Report comment to moderator  
Reply With Quote
Unread 10-19-20, 09:20 AM  
Cladhaire
Salad!
 
Cladhaire's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 1935
File comments: 4799
Uploads: 19
I'll be working on it but it will take a bit of time, I'm down and out with a cold this week and needed to prioritize the other addons that are a bit more crucial. Will get around to updating though, I promise.
__________________
"There's only one thing that I know how to do well and I've often been told that you only can do what you know how to do well, and that's be you-- be what you're like-- be like yourself. And so I'm having a wonderful time, but I'd rather be whistling in the dark..."
Report comment to moderator  
Reply With Quote
Unread 10-18-20, 06:39 PM  
internetking
A Defias Bandit

Forum posts: 2
File comments: 1
Uploads: 0
sl update

will there be update on this for sl soon?
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: