Quantcast
Download
(297 Kb)
Download
Updated: 10-31-10 05:29 PM
Pictures
File Info
Updated:10-31-10 05:29 PM
Created:unknown
Downloads:22,570
Favorites:134
MD5:

WeaponRebuff 3.4  Popular! (More than 5000 hits)

Version: 3.4f.02
by: VincentSDSH [More]

**** NOTE ****
This version has been modified to work with 4.0 and add support for buffing thrown weapons however this is not the re-write. I was expecting to have another few weeks and RL is what it is.

WeaponRebuff itself is free of issues in the testing I've been been able to do but it must be noted that it resides on other libraries, namely Waterfall 1.0, Ace 2.0 and Fubar 2.0 -- not all of these are being actively maintained so I've removed the errors I could reproduce but others may crop up. Please PM regarding errors.

Hopefully RL will relent a bit and I'll be able to push the rewrite further along before Cataclysm hits the shelves.
**************

WeaponRebuff is a small, light-weight mod that makes buffing weapons (and keeping them buffed) simple and easy. Rebuffing a weapon is a mouse-click away and with warnings for timed buffs, charge-based buffs, and low-item-count for buff items (e.g. poisons, sharpening stones, fishing lures, etc) you'll never be caught unintentionally unbuffed again.

How to Use

  • left mouse-click rebuffs your weapon with the last known charge/spell
  • right click opens a buff selector of available buffs and charges for your weapons
    • left-click the buff for Main Hand application; right-click for Off Hand application; shift-right-click for thrown weapon (rogues)

Supports
  • rogue poisons
  • sharpening and weight stones
  • spell-based weapon buffs for shamans/druids
  • wizard & mana oils
  • fishing lures
  • and user defined spells and items

Features
  • Rebuff Buttons and Data Display
    • show/hide buff text (for the minimalists)
    • vertical or side-by-side icon display
    • hide/show off-hand
    • hide/show for thrown
    • strata control (move it above or behind those pesky windows)
    • dual-buffing for spell-based buffs: since these type spells cast only on the main hand, buffs can be "applied" to the off-hand shield allowing both buffs to be available
  • Buff Selector
    • text or icon selector buttons (w/ re-sizable fonts)
    • different combat / non-combat selector configurations
    • a range of buff selector layouts to help fit into any UI layout
    • option to auto-show buff selector menu when combat starts
      • for when you may want to change the buff you're using mid-combat in a raid
      • or during that pesky PvP 5-sec combat cooldown
      • or perhaps you've added other items/spells to the Buff Selector (see User Configurability)
  • Alerts and Warnings
    • sound options and text options for when your buffs '''are''' fading
    • sound options and text options for when your buffs '''have''' faded
    • text warning options when you are running out of buffing-items (poisons, etc)
    • option to set the warning threshold from 1 to 60seconds
    • automatic alert suppression for WindFury
  • Buff Information Colors
    • Blue: Active Buff
    • Yellow: Buff in last 60 secons
    • Red: Unbuffed
    • Green: Windfury (Windfury is a max of 9 seconds pulsing buff which shouldn't be consideed "about to drop" as this can be more than a bit confusing)
  • Alert Sound Options
    • sounds from in-game
    • sounds registered via SharedMediaLib from other mods
    • your custom sounds: replace the two included .wav files
      • as a bonus, since these files are registered with SharedMediaLib, you can use them in other mods using SharedMedia

User Configurability
  • FuBar / MiniMap
    • configurable FuBar/MiniMap Button click-modes (click/shift-click/ctrl-click) for convenience
  • Buffing Items / Spells
    • a default list of many buffing items and spells is included; however, each list is user-editable to add and remove items as the user sees fit
      • The list of spells is small and contained in one Spell Category
      • Buffing Items are numerous and are broken down into 5 categories: '''Poisons''', '''Wizard/Mana Oils''', '''Weight/Sharpening Stones''', '''Fishing Lures''', '''Miscellaneous''' (the latter contains no items by default)
        • Each category may be enabled or disabled for performance

      This flexibility allows a great deal of personalization and can lead to some strange setups when combined with other options: a paladin jokingly (I ''hope'') made this declaration: I've setup the buff selector to show when combat starts and I added a spell and item to the buff lists so now when I get in combat I have my sharpening stone, bubble, and hearth all lined up and ready to go!

Additional Buffing Modes
  • 2-buff Mode
    • 2-Buff Mode option (hides after two buff selections instead of one)
    • One-time "2-Buff Mode" when Shift-RightClicking (when you don't want it as a constant feature)
  • Fishing Mode
    • "Fishing Mode" toggle is available from the FuBar/MiniMap button click events
    • when active an "F" will display in the FuBar caption (instead of "m/o") and only fishing lures will display as buffing options.
    • "Fishing Mode" buffs are remembered separately so there is no need to 'reset' them when entering/leaving "Fishing Mode"

Slash Commands
WeaponRebuff uses the typical Ace2 Options table so all of the configuration dialog features are available via slash commands
  • Getting Started
    • /wr - options, help, and additional commands
  • Frequently Used Slash Commands
    • /wr lock - toggles window movement on/off
    • /wr config - opens the configuration menu
    • /wr position {left/center/right} - FuBar placement options (for folks with crowded FuBar setups)

Custom Sound Options
Two .wav files (warning.wav and lost.wav) are included. You can replace them with your own .wav files, just name them "warning.wav" and "lost.wav" respectively

Localizations
  • English
  • French
  • German
TRANSLATION HELP REQUESTED: The German and French translations could use additional assistance.

Credits
Opt: Original Author

-------------------------------------------------------
Requests under consideration but NOT on the to-do list

* Keybinds for buffing
* Keybinds for buff selector
* Movable buff selector
* Repositional text (i.e. text in separate window)
* Apply buff but do not make it default
* Temp bars to show time remaining
* Buff Item/Spell icon instead of text
* Show *default* buff no matter what buff currently on

Some of these are over the top; however, if they can be done in modules ( you can choose not to use those features ) I might be talked into them, time allowing.
-------------------------------------------------------

3.4c...
* Only rogues should now have the ability to buff slot 18
* Spell-based buffs should now record, tooltip, and operate properly
* Tooltips for main window corrected
* 'Disable Thrown' option now available for rogues (this is auto-set off and disabled for non-rogues)

3.4d...
* Should address the change (reduction) in the # of poisons and validation and not require you to kill your saved var file.

3.4e...
* Hopefully a final solution to the damned validate problem that crops up in some saved var files
* Rogue Class detection corrected for all localizations

3.4f...
* Corrected class and profile issues (let's hope f stands for finally got it all working)

3.4f.01...
* Minor fix to variable call to reference char not profile

..02...
* oops, missed a profile-to-char reference
Post A Reply Comment Options
Unread 01-30-12, 03:35 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
Re: Loses rememberd poisons between sessions

Originally Posted by Mareid
2. WoW Interface addons does not see WR it its list of addons
Many addons--including many that have much newer code than this one--are not designed to show an options header in Interface/Addons. Its just the way it is.

You have to access its options through either left-clicking the DataBroker (LDB) feed or entering in chat: "/wr config".

Originally Posted by Mareid
2. Chocolate Bar does not see WR in its list of addons and removing the icon from the minimap does not force it to chocolate bar.
I use the StatBlockCore and have no problems seeing the WeaponRebuff feed. Might be a ChocolateBar problem; its had a number of issues over time.

If you don't want to switch to a different LDB display mod (I recommend Bazooka instead for a "bar type" display), try the latest alpha version of ChocolateBar at this link.

As to the rogue issue, my test characters are not rogues; sorry, can't help.

It doesn't look like WeaponRebuff is going to be updated anytime soon. It uses obsolete libraries that are not going to be updated (and probably won't work in the next expansion) and is in serious need of a rewrite. My recommendation for a good, reliable, modern alternative--it handles all sorts of buffs as well as weapon ones--is SmartBuff.
Report comment to moderator  
Reply With Quote
Unread 09-29-11, 08:26 AM  
Mareid
A Defias Bandit

Forum posts: 3
File comments: 3
Uploads: 0
Loses rememberd poisons between sessions

Dear Vincent...

I have used this addon since I started a rogue many years ago, and there's nothing like it. At one point, it was working perfectly, and I was able to move the button from the minimap and see it on Chocolate Bar. I'm now having some issues, and I can't decide if they are related to WoW or my setup, so here is what I did to make as clean an install as possible.

I completely removed WTF, Cache and Addons directories. I then updated WoW and installed only ACP and WR (3.4f.02) At this point I was still having the following problems.

1. WR "forgets" the poisons on all 3 of my weapons between login sessions.
2. WoW Interface addons does not see WR it its list of addons

I then installed Chocolate Bar
1. Above two problems still exist
2. Chocolate Bar does not see WR in its list of addons and removing the icon from the minimap does not force it to chocolate bar.

Please let me know if I am doing something wrong, or if there is something I could try to fix this...I love this little addon and I hate to see it go away.

Regards

Mareid

If you can
Report comment to moderator  
Reply With Quote
Unread 02-22-11, 10:00 AM  
tehKD
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 4
Uploads: 4
just got the idea for some outline or shadow for better visibility... only thing i ever missed
Report comment to moderator  
Reply With Quote
Unread 02-13-11, 10:28 PM  
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view AddOns

Forum posts: 350
File comments: 257
Uploads: 12
Originally posted by Movarrin
First, time and again the addon loses my thrown weapon on my rogue.

Second, for some reason, after a reinstall it absolutely refuses to remember my offhand weapon poison. This eliminates the 1-click rebuff feature because WR can't remember what to apply.

Third, clicking around the menu often causes a waterfall error.
I get none of these problems on my rogue. Without specific error messages, debugging is...well, basically impossible.

Originally posted by Movarrin
Fifth, there is no way to configure the broker display. All I want is the icon nothing else. The vestigal fubar code has is completely screwed the broker options. Bazooka won't even recognize it.
The native WR display will go to icons-only... And the way the broker data-block is designed, you can hide label or text or both (assuming your broker client offers the options) so not sure what you're looking for there -- then again, I never use Broker for WR

Originally posted by Movarrin
Sixth, two-buff mode is nice, but now it's time for 3 buff mode.
OK, ya got me there. Though, in truth, I've never swapped all 3 on-the-run like that so never noticed it.

Originally posted by Movarrin
Once again, thank you for all your effort. I'll be keeping this favorited and hoping to see a new version in future. When it's right, it is the best weapon buff addon there is. I hope to see it regain that title again.
I've had a re-write in the works before Cata-beta, then had to alter it for Cata, then RL hit like a train-wreck (as you can see from the relative date of replies) and, as it's been working well on my rogue when I get to play.

New version is coming.
__________________
AddonsExecutive Assistant User Configurable To-Do ListLegible Mail Choose the Font for Your Mail
Report comment to moderator  
Reply With Quote
Unread 01-16-11, 04:25 PM  
Movarrin
Premium Member
Premium Member

Forum posts: 12
File comments: 74
Uploads: 0
I know maintaining an addon is a great deal of work. I appreciate everything you've put into this addon for the last few years. It has greatly enhanced my gameplay. Thank you.

Sadly, I'm going to have to stop using it. It just has too many issues in it's current form. I've tried uninstalling and reinstalling with the latest version but the errors persist.

First, time and again the addon loses my thrown weapon on my rogue.

Second, for some reason, after a reinstall it absolutely refuses to remember my offhand weapon poison. This eliminates the 1-click rebuff feature because WR can't remember what to apply.

Third, clicking around the menu often causes a waterfall error.

Fourth, the "Do you want to replace" message is still present. If you need an idea how to get around this, check Ara_Broker_WeaponBuffer.

Fifth, there is no way to configure the broker display. All I want is the icon nothing else. The vestigal fubar code has is completely screwed the broker options. Bazooka won't even recognize it.

Sixth, two-buff mode is nice, but now it's time for 3 buff mode.

Once again, thank you for all your effort. I'll be keeping this favorited and hoping to see a new version in future. When it's right, it is the best weapon buff addon there is. I hope to see it regain that title again.
Report comment to moderator  
Reply With Quote
Unread 10-31-10, 05:31 PM  
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view AddOns

Forum posts: 350
File comments: 257
Uploads: 12
Search and Replace...how thee has failed me...

Originally posted by bsmorgan
One more isRogue patch
Oh, Search and Replace, how thee has failed me!

Corrected and posted; thanks for the catch.
Report comment to moderator  
Reply With Quote
Unread 10-31-10, 04:50 PM  
bsmorgan
A Chromatic Dragonspawn
AddOn Author - Click to view AddOns

Forum posts: 191
File comments: 144
Uploads: 3
One more isRogue patch

Code:
--- WeaponRebuff-RebuffWindow.lua	Mon Jan 19 15:26:36 1970
+++ WeaponRebuff-RebuffWindow.lua	Mon Jan 19 15:26:36 1970
@@ -171,7 +171,7 @@
 	
 		wrRememberedBuffsTooltipTextLeft2:SetFontObject("GameFontHighlightSmall")
 
-		if WeaponRebuff.db.profile.isRogue then
+		if WeaponRebuff.db.char.isRogue then
 			wrRememberedBuffsTooltip:AddLine(wrColor.powderblue.."Main: "..wrColor.gold..RememberBuff[16].BuffName.."\n"..wrColor.powderblue.."Off: "..wrColor.copper..RememberBuff[17].BuffName.."\n"..wrColor.powderblue.."Thrown: "..wrColor.silver..RememberBuff[18].BuffName, 1,1,1	);
 		else
 			wrRememberedBuffsTooltip:AddLine(wrColor.powderblue.."Main: "..wrColor.gold..RememberBuff[16].BuffName.."\n"..wrColor.powderblue.."Off: "..wrColor.copper..RememberBuff[17].BuffName, 1,1,1	);
Report comment to moderator  
Reply With Quote
Unread 10-30-10, 07:27 PM  
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view AddOns

Forum posts: 350
File comments: 257
Uploads: 12
Re: isRogue test correct?

Originally posted by bsmorgan
In WeaponRebuff-BuffSelector.lua (see code below) stp is defined as WeaponRebuff.db.profile but the variable isRogue isn't in the profile, its in some other table (WeaponRebuff.db.char)?

I believe this is a bug. I think there may be one other isRogue bug in WeaponRebuff-RebuffWindow.lua.
Yes, it's a bug. At one point I had it in the stupidest of locations (I shouldn't code at 3am) and eventually moved it to char where it belongs. I knew something was bugging me about WR, scurrying around in the back of my mind: now I know what it was.

I'll see if I can get it fixed quickly.
Report comment to moderator  
Reply With Quote
Unread 10-30-10, 06:44 PM  
bsmorgan
A Chromatic Dragonspawn
AddOn Author - Click to view AddOns

Forum posts: 191
File comments: 144
Uploads: 3
isRogue test correct?

In WeaponRebuff-BuffSelector.lua (see code below) stp is defined as WeaponRebuff.db.profile but the variable isRogue isn't in the profile, its in some other table (WeaponRebuff.db.char)?

I believe this is a bug. I think there may be one other isRogue bug in WeaponRebuff-RebuffWindow.lua.

line 415:
Code:
function WeaponRebuff_ShowWeaponRebuffTooltip(buttonName, itemName)
	local anchor = _G[buttonName]
	local sdp = WeaponRebuff.db.profile
line 436:
Code:
	if sdp.isRogue then
		wrBuffSelectorTooltip:AddLine(wrColor.gold..T["WEAPONREBUFF_TOOLTIP_LEFTMOUSE"].."\n"..wrColor.copper..T["WEAPONREBUFF_TOOLTIP_RIGHTMOUSE"].."\n"..wrColor.copper..T["WEAPONREBUFF_TOOLTIP_SHIFTRIGHTMOUSE"], 
			1,1,1
		);
	else
		wrBuffSelectorTooltip:AddLine(wrColor.gold..T["WEAPONREBUFF_TOOLTIP_LEFTMOUSE"].."\n"..wrColor.copper..T["WEAPONREBUFF_TOOLTIP_RIGHTMOUSE"], 
			1,1,1
		);
	end
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 05:53 PM  
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view AddOns

Forum posts: 350
File comments: 257
Uploads: 12
For your Wednesday Evening's Entertainment...

3.4f is up. It should finally resolve the class/profile issues and eliminate the crossing buffs.
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 12:13 PM  
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view AddOns

Forum posts: 350
File comments: 257
Uploads: 12
...

Originally posted by bsmorgan
Almost there...

I'm happy with the position of the buttons being global across all characters so I'd like to keep just the one profile, but I don't want the third button on anything but the rogue which I believe is the way 3.4d worked.
It's not a localization problem (now) since I'm pulling the universal from the second parameter (localizedClass, EngClass = UnitClass([unit])) : isRogue = ( ( select( 2, UnitClass("player") ) == "ROGUE" ) and true or false )

The problem is I did this at 2am in the frickin' morning and assigned the thing to the *default* *profile* (two mistakes for the price of one!) not the *character* so it's a tad confused. Unfortunately, I'm only getting scraps of time test with so I'm missing stupid little things I shouldn't and wouldn't normally miss.

Once that's moved over to the char-level, it should straighten itself out and behave properly.
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 11:49 AM  
bsmorgan
A Chromatic Dragonspawn
AddOn Author - Click to view AddOns

Forum posts: 191
File comments: 144
Uploads: 3
You might consider saving the locale in the SavedVariables file. I had to do that in my PvPLog addon so that I didn't have to keep asking everytime someone submitted a bug report (I required the savedvarialbles file(s) with the bug reports).

Regards,

Brad
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 11:45 AM  
bsmorgan
A Chromatic Dragonspawn
AddOn Author - Click to view AddOns

Forum posts: 191
File comments: 144
Uploads: 3
Almost there...

1) Installed 3.4e, renamed old savedvariables file to WeaponRebuff1.lua.

2) Logged in on my Rogue, repositioned window, enabled Thrown Button.

2a) The third button didn't display immediately so I logged out and logged in and now the button shows.

3) Logged out on the Rogue, logged in on the Warlock.

3a) The third button shows on my Warlock. <-- BUG!? (locale enUS)

4) Exit WoW, here's the WeaponRebuff.lua:

Code:
WeaponRebuffDB_Schema3x = {
	["profiles"] = {
		["Default"] = {
			["detachedTooltip"] = {
			},
			["pos"] = {
				["rebuffwindow"] = {
					["rel"] = "BOTTOMLEFT",
					["py"] = 113.1753733082141,
					["px"] = -2.87878633456786,
				},
			},
			["wrDisableThrownButton"] = 0,
		},
	},
}
I'm happy with the position of the buttons being global across all characters so I'd like to keep just the one profile, but I don't want the third button on anything but the rogue which I believe is the way 3.4d worked.

Regards,

Brad
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 04:32 AM  
Xamael
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 27
Uploads: 1
Fully functional, thank you
Report comment to moderator  
Reply With Quote
Unread 10-20-10, 01:46 AM  
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view AddOns

Forum posts: 350
File comments: 257
Uploads: 12
Originally posted by Xamael
Ok, works for me now (but I still had to delete the old savedvars manually with version 3.4d).

On my rogue tho, the 'Disable Thrown' option is auto-set off and disabled. I can not enable it at all.

This is under DEde... a localisation problem?
Yep, localization problem...I'm such an idiot, I didn't even think of that. I quickly pulled some code and methodology out of my personal UI and didn't think about what was being pulled back. It's pulling "Rogue" (localized) not "ROGUE" (universal). Easy enough to fix, just need to take the 2nd parameter not the 1st.

Fixing the other problem is more intractable. Resetting the DB var would seem to be the solution (given that the data-handling method has been updated) but it seems to basically wreck everything. Only way around it is resetting everything...which, if you have an old enough version of WR, is needed anyway, given how Ace changed the handling procedures for data so that the saved var file is far smaller.

3.4e coming up...
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: