(10Kb)

Updated: 06-08-09 12:18 AM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Updated:	06-08-09 12:18 AM
Created:	unknown
Downloads:	36,260
Favorites:	325
MD5:

ImprovedMerchant

Version: 3.6x5

by: Macniel [More]

Warning
if you depend on item scaling and spacing between items do not upgrade and use version 3.6a instead, this update is not necessary if the previous version (3.6a) is working fine on your computer.

Installation

You install this AddOn like any other, just unpack the downloaded zip into your /Interface/AddOns folder.

Summary
Hello and welcome back to another helpful AddOn which will improves your daily shopping-adventures with merchants.

Okay what did this AddOn do to your merchantframe ? It replaces the paged item display with a scrollable and more informative list which can also be filtered by available item types. It use the same purchase protection like the default merchantframe when buying an item which requires honor-,arena-points or specific items.

Features

Filter: you can filter items from a vendor out. You can setup a filter to show only trainable, usable, purchasable items or just items from a specific type (or subtype)
Searchcraft: you can search item descriptions for certain a or multiple (seperated by an colon ;) keywords and filter those out which does not include your keywords
Scrollable List: you can now scroll through the merchant shop instead of the paged view
Autorepair: as a request you can now check a button on a merchant frame to enable autorepair.

Credits
Thanks again to Dridzt who have uploaded a fixed version here http://www.wowinterface.com/downloads/info12206.html while I was not available. Thanks and kudos to you!

Thanks to Seebs for GetOpt which handels slashcommands / parameterized Inputs

Need some localization help!
If you use a french, spanish, russian, korean, chinese client please provide me with a correct localization for "Recipe"

Thanks.

bugfixes in v3.6x5 :
a bug that prevents items from being clicked has drycoded out.
see changes.txt for more details

bugfixes in v3.6x4 :
A bug that prevents the item list to populate properbly after selecting the filter "nothing" in the dropdown menu has been eliminated.
A cosmetic "feature" has been added that preselect visually the "nothing" filter item in the dropdown menu when this filter is active.
see changes.txt for more details

changes in v3.6x3 :
Reenabled the Trainable filter function
Added file changes.txt for more code specific changes

bugfixes in v3.6x2 :
Localization enGB / enUS are now corrected (mass find/replace is evil!)

changes in v3.6x (xml) :
Rewrote lua Frame definitions into XML Definitions
Heavily improved Memory consumption and CPU Time consumption

bugfixes in v3.6c :
Fixed a call that caused an error message when selling something (this only applies to 3.6b)

changes in v3.6b :
Removed Options (consider v3.6a if you need item scaling and spacing)
Improved performance
- removed 2 functions as they were not necessary to determine if an item is usable
- change the way the functions and variables were accessed (they are now no longer members of an UIObject)

bugfixes in v3.6a :
Reassigned constants properbly so the filter affordable, usable and trainable works again

changes in v3.6 :
Added Autorepair option
Adjust itemcost a bit to appear more stream lined

changes in v3.5d :
Added Count and StockCount fontstrings into XML

changes in v3.5b :
Switched to XML based item definition and stress tested this for the OSP Bug, and it has not occure.

bugfixes in v3.5 :
I do not know what I had done but the OSP Bug does not appear to me anymore

bugfixes in v3.4j :
Fixed a minor bug (try to index local texture a nil value)

bugfixes in v3.4i :
An hidden visibility error has been found (by Dridzt) and eliminated

bugfixes in v3.4h :
Reverted a fix in g and replaced it with another fix - now this shall work

bugfixes in v3.4g :
On-Screen-Printing (sounds cool to me) bug should no longer occure
Fixed a function that hide everything if the filter is set to "NOTHING" (it should not display nothing but filter out nothing!)
Skipped minor version f for unkown reason

bugfixes in v3.4e :
Changed the encoding format of localization.lua to utf-8 so this can be accessed probably (again)

bugfixes in v3.4d :
An error that says there is no filter types available should no longer occure
Added a bunch of comments

bugfixes in v3.4c :
Combinated filter are now working again!

bugfixes in v3.4b :
Removed a ClearAllPoints() that caused to disalign some elements

bugfixes in v3.4a :
Changed a variable name so the count of an stacked item (for example water) will show up again

changes in v3.4 :
Implemented support for Recipe-Book (and similiar AddOns)
Changed lots of code, so it should work now performantly
Fixed filter and search craft when they are used together (they will not longer disable each other)

known bugs:
there is not yet a localization frFR, enES, koKR, zhCN, zhTW and ruRU clients so the Trainable Filter wont work for these Clients (please provide me with a proper translation for the itemtype "recipe")

changes in v2.1 :
Bugfix with stock based Items (they will now properly decreased); new Trainable Filter

changes in v2.0 :
itemcost + money will not longer result in a graphical glitch

changes in v1.9 :
switched to ItemButtonTemplate to enable AddOns to skin the item texture

changes in v1.8 :
improved Searchengine which allows more than one keyword to search for, bugfix which prevented to show every required itemtype to purchase an item (like a pvp mount)

changes in v1.7 :
new affordable filter, filter are hidden on default

changes in v1.6 :
many bugfixes

changes in v1.5 :
click handler are removed, the default click handler are used instead, localization completed by yaroot (thank you very much)

changes in v1.3 :
list is now redesigned for improved experience, major fix in left/rightclick handling, buybackitem will now show probably in the buy frame

changes in v1.1 :
Some designtweaks were applied

changes in v1.06:
Compare Tooltips was added, Dressup function was added

changes in v1.04:
Currency display was changed, Localization should now work probably

bugfix in v1.01:
SplitStack should now work probably

Optional Files (0)

Comment Options

Page 4 of 15

« First

Last »

05-17-09, 07:35 PM

Hevanus

A Deviate Faerie Dragon

Forum posts: 15

File comments: 199

Uploads: 0

Re: Re: Latest version...

Seeing this in 3.4g:

Code:

[2009/05/17 18:19:53-5740-x1]: ImprovedMerchant-3.4c\itemClass.lua:261: attempt to compare number with nil
ImprovedMerchant-3.4c\ImprovedMerchant.lua:275: in function `PopulateList'
ImprovedMerchant-3.4c\ImprovedMerchant.lua:314: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:291>

  ---

05-17-09, 06:10 PM

joshwill80

A Murloc Raider

Forum posts: 5

File comments: 144

Uploads: 0

Re: Latest version...

Originally posted by VincentSDSH
Interface\AddOns\ImprovedMerchant\itemClass.lua:261: attempt to compare number with nil
Count: 2

Call Stack:
[C]: ?
Interface\AddOns\ImprovedMerchant\itemClass.lua:261: in function `CreateMerchantItem'
...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:275: in function `PopulateList'
...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:314: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:291>

I'm also seeing multiple errors with 3.4g, all involving line 261 in itemClass.lua. ImprovedMerchant 3.4g is totally broke for me, and nothing appears in the merchant window at all. Reverting to 3.4b for now.

05-17-09, 05:02 PM
VincentSDSH Non-Canadian Luzer! Forum posts: 350 File comments: 257 Uploads: 12	Latest version... Interface\AddOns\ImprovedMerchant\itemClass.lua:261: attempt to compare number with nil Count: 2 Call Stack: [C]: ? Interface\AddOns\ImprovedMerchant\itemClass.lua:261: in function `CreateMerchantItem' ...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:275: in function `PopulateList' ...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:314: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:291>

05-17-09, 03:44 PM
AlicanC A Kobold Labourer Forum posts: 0 File comments: 21 Uploads: 0	Wow that was fast. I'll try it asap

05-17-09, 02:14 PM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Originally posted by Fonjask
I had exactly the same problem with 3.4d, bought something at the Argent Quartermaster and the champion's seals were printed ON TOP of my recount, even got a screenshot:

Okay I have located the bug, I had thought that 0 (zero, not nil/null) is equal to false (in a if ... then control flow) but it is not equal. So this bug should be eliminated.

05-17-09, 12:14 PM

Fonjask

A Fallenroot Satyr

Forum posts: 25

File comments: 266

Uploads: 2

Originally posted by AlicanC
Today I had a problem while visiting PvP stuff vendors at The Underbelly. First I saw that prices of some items were missing. (Not for the stuff I wanted to buy...) After I looked at the items I closed the windows and started to walk and saw that some prices are floating over my UI. There were numbers and icons of the prices. It was like those price tags were printed directly on the UI instead of the frame.

I was using 3.4c and I couldn't find a way to reproduce it...

I had exactly the same problem with 3.4d, bought something at the Argent Quartermaster and the champion's seals were printed ON TOP of my recount, even got a screenshot:

EDIT: I updated ImpMer from 3.1 to 3.4d, and didn't have this error in 3.1.
Seeing as AlicanC had this problem in 3.4c it's probably a bug added in 3.4(a,b, or c).
Keep us up to date

__________________
~~~~~~~~~~~~

Last edited by Fonjask : 05-17-09 at 12:16 PM.

05-17-09, 12:10 PM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Originally posted by AlicanC
Today I had a problem while visiting PvP stuff vendors at The Underbelly. First I saw that prices of some items were missing. (Not for the stuff I wanted to buy...) After I looked at the items I closed the windows and started to walk and saw that some prices are floating over my UI. There were numbers and icons of the prices. It was like those price tags were printed directly on the UI instead of the frame.

I was using 3.4c and I couldn't find a way to reproduce it...

a very very strange bug, I hope I will stumble upon it and can get it fixed then.

05-17-09, 11:29 AM
AlicanC A Kobold Labourer Forum posts: 0 File comments: 21 Uploads: 0	Today I had a problem while visiting PvP stuff vendors at The Underbelly. First I saw that prices of some items were missing. (Not for the stuff I wanted to buy...) After I looked at the items I closed the windows and started to walk and saw that some prices are floating over my UI. There were numbers and icons of the prices. It was like those price tags were printed directly on the UI instead of the frame. I was using 3.4c and I couldn't find a way to reproduce it...

05-17-09, 10:02 AM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Originally posted by Sparanoid
I'm going to translate it but i think the encoding of that language file is wrong, i cannot open it currectly with my text editor

Oh I had forgotten to set the encoding to utf-8 (is fixed in v3.4e), and thank you for your support

05-17-09, 09:44 AM
Sparanoid A Defias Bandit Forum posts: 3 File comments: 57 Uploads: 0	I'm going to translate it but i think the encoding of that language file is wrong, i cannot open it correctly with my text editor Last edited by Sparanoid : 05-17-09 at 12:00 PM.

05-17-09, 07:30 AM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Originally posted by Dridzt
I have a new problem with 3.4c.

The filter drop-down is actually a "drop-up"

It grows upwards out of the screen.

Edit: Screenie of the problem

strange , maybe the dropdown is too height to drop below the frame.

05-17-09, 07:00 AM
Dridzt A Pyroguard Emberseer Forum posts: 1360 File comments: 829 Uploads: 56	I have a new problem with 3.4c. The filter drop-down is actually a "drop-up" It grows upwards out of the screen. Edit: Screenie of the problem Last edited by Dridzt : 05-17-09 at 07:04 AM.

05-17-09, 01:19 AM

joshwill80

A Murloc Raider

Forum posts: 5

File comments: 144

Uploads: 0

Error

I'm seeing this from time to time since upgrading to 3.4c:

Code:

ImprovedMerchant-3.4c\\ImprovedMerchant.lua:773: bad argument #1 to 'pairs' (table expected, got nil)\nImprovedMerchant-3.4c\\ImprovedMerchant.lua:773: in function `initFunction'\nInterface\\FrameXML\\UIDropDownMenu.lua:69: in function `UIDropDownMenu_Initialize':\nImprovedMerchant-3.4c\\ImprovedMerchant.lua:725: in function <...terface\\AddOns\\ImprovedMerchant\\ImprovedMerchant.lua:687

The error seems to break filtering completely when it occurs.

05-16-09, 10:28 AM
Dridzt A Pyroguard Emberseer Forum posts: 1360 File comments: 829 Uploads: 56	Thanks, I can verify that 3.4.0b does not have the problem.

05-16-09, 04:45 AM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Originally posted by Dridzt
v3.4.0a

At the vendors in Wintergrasp with the stone keeper currency, currency column doesn't appear inside the merchant frame and does not scroll.

Instead it shows as a separate frame that stays on screen even after closing the merchant frame.

Reverted back to previous version for now.

Could you please post a screenshot? The Items in Wintergrasp only require stone keeper currency (not money) or am I wrong?

EDIT:
so this bug has been (hopefully) fixed now

Thank you Dridzt

Last edited by Macniel : 05-16-09 at 08:54 AM.

Page 4 of 15

« First

Last »

Report this File

Category Jump: