(10Kb)

Updated: 06-08-09 12:18 AM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Updated:	06-08-09 12:18 AM
Created:	unknown
Downloads:	36,258
Favorites:	325
MD5:

ImprovedMerchant

Version: 3.6x5

by: Macniel [More]

Warning
if you depend on item scaling and spacing between items do not upgrade and use version 3.6a instead, this update is not necessary if the previous version (3.6a) is working fine on your computer.

Installation

You install this AddOn like any other, just unpack the downloaded zip into your /Interface/AddOns folder.

Summary
Hello and welcome back to another helpful AddOn which will improves your daily shopping-adventures with merchants.

Okay what did this AddOn do to your merchantframe ? It replaces the paged item display with a scrollable and more informative list which can also be filtered by available item types. It use the same purchase protection like the default merchantframe when buying an item which requires honor-,arena-points or specific items.

Features

Filter: you can filter items from a vendor out. You can setup a filter to show only trainable, usable, purchasable items or just items from a specific type (or subtype)
Searchcraft: you can search item descriptions for certain a or multiple (seperated by an colon ;) keywords and filter those out which does not include your keywords
Scrollable List: you can now scroll through the merchant shop instead of the paged view
Autorepair: as a request you can now check a button on a merchant frame to enable autorepair.

Credits
Thanks again to Dridzt who have uploaded a fixed version here http://www.wowinterface.com/downloads/info12206.html while I was not available. Thanks and kudos to you!

Thanks to Seebs for GetOpt which handels slashcommands / parameterized Inputs

Need some localization help!
If you use a french, spanish, russian, korean, chinese client please provide me with a correct localization for "Recipe"

Thanks.

bugfixes in v3.6x5 :
a bug that prevents items from being clicked has drycoded out.
see changes.txt for more details

bugfixes in v3.6x4 :
A bug that prevents the item list to populate properbly after selecting the filter "nothing" in the dropdown menu has been eliminated.
A cosmetic "feature" has been added that preselect visually the "nothing" filter item in the dropdown menu when this filter is active.
see changes.txt for more details

changes in v3.6x3 :
Reenabled the Trainable filter function
Added file changes.txt for more code specific changes

bugfixes in v3.6x2 :
Localization enGB / enUS are now corrected (mass find/replace is evil!)

changes in v3.6x (xml) :
Rewrote lua Frame definitions into XML Definitions
Heavily improved Memory consumption and CPU Time consumption

bugfixes in v3.6c :
Fixed a call that caused an error message when selling something (this only applies to 3.6b)

changes in v3.6b :
Removed Options (consider v3.6a if you need item scaling and spacing)
Improved performance
- removed 2 functions as they were not necessary to determine if an item is usable
- change the way the functions and variables were accessed (they are now no longer members of an UIObject)

bugfixes in v3.6a :
Reassigned constants properbly so the filter affordable, usable and trainable works again

changes in v3.6 :
Added Autorepair option
Adjust itemcost a bit to appear more stream lined

changes in v3.5d :
Added Count and StockCount fontstrings into XML

changes in v3.5b :
Switched to XML based item definition and stress tested this for the OSP Bug, and it has not occure.

bugfixes in v3.5 :
I do not know what I had done but the OSP Bug does not appear to me anymore

bugfixes in v3.4j :
Fixed a minor bug (try to index local texture a nil value)

bugfixes in v3.4i :
An hidden visibility error has been found (by Dridzt) and eliminated

bugfixes in v3.4h :
Reverted a fix in g and replaced it with another fix - now this shall work

bugfixes in v3.4g :
On-Screen-Printing (sounds cool to me) bug should no longer occure
Fixed a function that hide everything if the filter is set to "NOTHING" (it should not display nothing but filter out nothing!)
Skipped minor version f for unkown reason

bugfixes in v3.4e :
Changed the encoding format of localization.lua to utf-8 so this can be accessed probably (again)

bugfixes in v3.4d :
An error that says there is no filter types available should no longer occure
Added a bunch of comments

bugfixes in v3.4c :
Combinated filter are now working again!

bugfixes in v3.4b :
Removed a ClearAllPoints() that caused to disalign some elements

bugfixes in v3.4a :
Changed a variable name so the count of an stacked item (for example water) will show up again

changes in v3.4 :
Implemented support for Recipe-Book (and similiar AddOns)
Changed lots of code, so it should work now performantly
Fixed filter and search craft when they are used together (they will not longer disable each other)

known bugs:
there is not yet a localization frFR, enES, koKR, zhCN, zhTW and ruRU clients so the Trainable Filter wont work for these Clients (please provide me with a proper translation for the itemtype "recipe")

changes in v2.1 :
Bugfix with stock based Items (they will now properly decreased); new Trainable Filter

changes in v2.0 :
itemcost + money will not longer result in a graphical glitch

changes in v1.9 :
switched to ItemButtonTemplate to enable AddOns to skin the item texture

changes in v1.8 :
improved Searchengine which allows more than one keyword to search for, bugfix which prevented to show every required itemtype to purchase an item (like a pvp mount)

changes in v1.7 :
new affordable filter, filter are hidden on default

changes in v1.6 :
many bugfixes

changes in v1.5 :
click handler are removed, the default click handler are used instead, localization completed by yaroot (thank you very much)

changes in v1.3 :
list is now redesigned for improved experience, major fix in left/rightclick handling, buybackitem will now show probably in the buy frame

changes in v1.1 :
Some designtweaks were applied

changes in v1.06:
Compare Tooltips was added, Dressup function was added

changes in v1.04:
Currency display was changed, Localization should now work probably

bugfix in v1.01:
SplitStack should now work probably

Optional Files (0)

Comment Options

Page 3 of 15

Last »

05-23-09, 08:09 AM
Moose789 A Kobold Labourer Forum posts: 0 File comments: 1 Uploads: 0	ADD AUTO-SELL JUNK!!! you should consider adding a button to automatically sell all grey-quality items at once

05-22-09, 06:39 AM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Re: Re: Re: Lewal's Error

Originally posted by ezarra
3.5a still does not work right witht eh Tournament vendors. Some items are not shown at all and the prices are not in frame.

I have terminated my solution in favour of XML, and it worked now. I had tested every merchant for this bug and it does not occure at any time.

05-22-09, 12:58 AM

ezarra

A Flamescale Wyrmkin

Forum posts: 123

File comments: 47

Uploads: 2

Re: Re: Lewal's Error

Originally posted by ichik
Thanks.

3.5a still does not work right witht eh Tournament vendors. Some items are not shown at all and the prices are not in frame.

05-21-09, 11:02 PM

ichik

A Murloc Raider

Forum posts: 5

File comments: 263

Uploads: 5

Re: Lewal's Error

Originally posted by Zavar
I was having the same error as Lewal so I took a look at the code, I tried a very simple change and it seems to have worked perfectly. I am not exactly sure why it works as I'm not sure what was broken in the first place but here it is if anyone with the error wants to try it out.

Change line 39 from: if texture then
to: if texture ~= nil then

Hope it helps

Thanks.

05-21-09, 11:18 AM
Zavar A Kobold Labourer Forum posts: 0 File comments: 1 Uploads: 0	Lewal's Error I was having the same error as Lewal so I took a look at the code, I tried a very simple change and it seems to have worked perfectly. I am not exactly sure why it works as I'm not sure what was broken in the first place but here it is if anyone with the error wants to try it out. Change line 39 from: if texture then to: if texture ~= nil then Hope it helps

05-21-09, 04:49 AM
lewal A Kobold Labourer Forum posts: 0 File comments: 153 Uploads: 0	error j this happened yesterday when going to valor or any of the other token venders nothing showed up in there window and got this error went back to i and all is cool and aDate: 2009-05-20 18:23:40 ID: -36 Error occured in: Global Count: 18 Message: ..\AddOns\ImprovedMerchant\itemClass.lua line 40: attempt to index field 'texture' (a nil value) Debug: [C]: ? ImprovedMerchant\itemClass.lua:40: SetItemCostInfo() ImprovedMerchant\itemClass.lua:159: CreateMerchantItem() ...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:274: PopulateList() ...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:298: ...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:290 AddOns: Swatter, v3.1.13 (<%codename%>) Corpse, v3.1.0.4 Ace2, v ActionButtonColors, v1.3 AlarBGHelper, v3.5.10 r48 AlphaMap, v3.63.30100 AlphaMapBattlegrounds, v AlphaMapExteriors, v AlphaMapInstances, v AlphaMapPOIFlightMasters, v AlphaMapPOIInstances, v AlphaMapPOITravelAgents, v AlphaMapPOIUtilities, v AlphaMapWorldBosses, v ArenaCalculator, v1.6.3 Atlas, v1.14.1 AtlasBattlegrounds, v1.14.1 AtlasDungeonLocs, v1.14.1 AtlasOutdoorRaids, v1.14.1 AtlasTransportation, v1.14.1 AtlasWorld, vv3.1.1.11 AucAdvanced, v5.4.4157 (WallabyII) AucFilterBasic, v5.4.4157 (WallabyII) AucFilterOutlier, v5.4.4157.2531 AucMatchUndercut, v5.4.4157.2531 AucScanData, v5.4.4157 (WallabyII) AucStatClassic, v5.4.4157 (WallabyII) AucStatHistogram, v5.4.4157 (WallabyII) AucStatiLevel, v5.4.4157 (WallabyII) AucStatPurchased, v5.4.4157 (WallabyII) AucStatSales, v5.4.4157.2842 AucStatSimple, v5.4.4157 (WallabyII) AucStatStdDev, v5.4.4157 (WallabyII) AucStatWOWEcon, v5.4.4157.2530 AucUtilAHWindowControl, v5.4.4157.3311 AucUtilAppraiser, v5.4.4157.2530 AucUtilAskPrice, v5.4.4157.3175 AucUtilAutoMagic, v5.4.4157.3142 AucUtilCompactUI, v5.4.4157.2530 AucUtilEasyBuyout, v5.4.4157.3583 AucUtilItemSuggest, v5.4.4157.3108 AucUtilPriceLevel, v5.4.4157.2545 AucUtilScanButton, v5.4.4157.2530 AucUtilScanFinish, v5.4.4157.2530 AucUtilScanProgress, v5.4.4157.2530 AucUtilSearchUI, v5.4.4157.3655 AucUtilSimpleAuction, v5.4.4157.0 AucUtilVendMarkup, v5.4.4157.2530 AwesomePlayerPortrait, v1.1 azHideSpam, v1.2 Babylonian, v5.1.DEV.130 BeanCounter, v5.4.4157 (WallabyII) BonusScanner, v4.9 BrokerHitCrit, v2.7.3-release BUFX, v1.09 BuyEmAll, v CashStash, v1.2.1 CattleProd, v2.3.0 ComeHere, v1.6 Comix, v1.7 beta Configator, v5.1.DEV.130 DBMCore, v DBMRaidLeadTools, v DBMVictorySound, v DeathDealer, v1.2 DebugLib, v5.1.DEV.130 DepositBox, v30000.2 Dominos, v1.9.4 DominosBuff, v DominosCast, v DominosRoll, v DominosXP, v Doomed, v1.0.1 ElkBuffBars, v2.2.4-149 Enchantrix, v5.4.4157 (WallabyII) EnchantrixBarker, v5.4.4157 (WallabyII) EnhTooltip, v5.1.3715 (SnaggleTooth) EquipCompare, v2.16 EWOlsonGetItemInfo, v EWOlsonGetSellValue, v EWOlsonPointsOfInterest, v Examiner, v09.05.10 Fizzle, vv1.3.1 FlightMap, v FocusFrame, v2.5.1 FuBarPlugin20, v2.0 $Revision: 66634 $ Gatherer, v3.1.13 GearDPS, v0.77b GearScore, v2.0.03 GemQuota, v$Revison$ GetOpt, v ImprovedMerchant, v3.4c Informant, v5.4.4157 (WallabyII) InspectEquip, v1.3.0 Intel, v0.42 ItemInfo, v ItemRack, v JebusMail, v2.4b LanguageCycle, v LastWords, v2.0.10 LevelDisplay, v4 LifePercent, v1.0 LightHeaded, v288 LightHeadedDataC, v288 LightHeadedDataQIDNames, v288 MagicRunes, v1.0.61 MagicRunesIconDisplay, v1.0.61 MagicRunesRuneBars, v1.0.61 MagicTargets, v2.0.88 MapNotes, v5.16.30100 MapNotesBrowser, vv1.00.30100 MapNotesForAtlas, v1.00.30100 MapNotesIconLib, v1.04.30100 MapNotesIconLibFancy, v MapNotesIconLibLegacy, v MapNotesIconLibNeptunia, v MapNotesIconLibNumbers, v MinimapButtonFrame, v2.4 MinimapButtonFrameSkinPack, v2.1 MinimapButtonFrameTitanPlugin, v2.2 MovableBags, v MozzFullWorldMap, v3.35.30100 MrDamage, vr813 naiStats, v Omen, v3.0.6 Pawn, v1.1.9 PoMTracker, v2.1 Postal, v3.1.1 PVPtimer, v0.1 QuickMountEquip, v RatingBuster, v Rebar, v Recount, v Redeemer, v sct, v6.2 sctd, v3.1 SharedMedia, v3.0 SlideBar, v3.1.13 (<%codename%>) Stackpack, v2.4 StealYourCarbon, v3.0.3.16 Stubby, v5.4.4157 (WallabyII) Talented, v2.2 TalentedLoader, v talentedspectabs, v TankPoints, v Titan, v4.2.2.30100 - Revision 239 TitanClock, v4.2.2.30100 TitanCoords, v4.2.2.30100 TitanItemBonuses, v4.1.6.30000 TitanMail, v3.0-r1 TitanMount, v1.00.30000 TitanPerformance, v4.2.2.30100 TitanRecZone, v3.0.2 TitanRegen, v4.2.2.30100 TitanRepair, v4.2.2.30100 TitanRider, v3.0 r2 TitanVolume, v4.2.2.30100 TitanWG, v0.0.3.30100 UrbanAchiever, v WhereToNow, v1.6 (ck=1017)

05-20-09, 02:30 PM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Re: Re: Re: Argent Toru

Originally posted by IndigoDreams
When I open a Horde faction (the ones selling the mounts, pets, tabards etc.), Argent Tournament Merchant window the items show up but are missing the Champion Seal amounts required to purchase them. The gold price is in the window for the 1 mount that cost 400g but no champion seal icons or the required numbers appear in the window.

I then close the window and the Champion Seal amounts and icons are located on my screen where the window would have been when it was open. It is almost as if these "prices" are appearing under the window when you open it. These icons will remain on the screen until I reload my UI to remove them.

hope that helps

OKAY, now I got it. I had associate wrong variables for those extended item cost buttons - so they were anchored to nil. this will be fixed in 3.5

05-20-09, 12:21 PM

IndigoDreams

A Kobold Labourer

Forum posts: 1

File comments: 3

Uploads: 0

Re: Re: Argent Toru

Originally posted by Macniel
I can in no ways reconstruct those errors. Please for the next time write down every merchant interaction during a session where this error occure.

When I open a Horde faction (the ones selling the mounts, pets, tabards etc.), Argent Tournament Merchant window the items show up but are missing the Champion Seal amounts required to purchase them. The gold price is in the window for the 1 mount that cost 400g but no champion seal icons or the required numbers appear in the window.

I then close the window and the Champion Seal amounts and icons are located on my screen where the window would have been when it was open. It is almost as if these "prices" are appearing under the window when you open it. These icons will remain on the screen until I reload my UI to remove them.

hope that helps

05-20-09, 11:11 AM
Jerricka An Aku'mai Servant Forum posts: 30 File comments: 178 Uploads: 0	This does not work if you have the rare pet from the WoW Card Game, the Ethereal Soul Trader. It won't show its vendor page!

05-20-09, 08:50 AM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Re: Argent Toru

Originally posted by DaemonSambe
This remains bugged for Argent Tournament faction vendors. When i scroll thru the list, the item prices, notably the Champion Seals, continue to scroll up the window, and remain there, when i leave the merchant.

I can in no ways reconstruct those errors. Please for the next time write down every merchant interaction during a session where this error occure.

05-19-09, 07:34 PM
DaemonSambe A Kobold Labourer Forum posts: 0 File comments: 169 Uploads: 2	Argent Toru This remains bugged for Argent Tournament faction vendors. When i scroll thru the list, the item prices, notably the Champion Seals, continue to scroll up the window, and remain there, when i leave the merchant. Last edited by DaemonSambe : 05-19-09 at 07:34 PM.

05-18-09, 04:47 AM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Originally posted by Dridzt
Just in case my edit in comment was unnoticed.
I had an error related to a chat output line (debug code for the tooltip scanning routine).
I commented out that line and it's good.

I am also getting this error when using the searchbox
(with no filter selected in the dropdown: "nothing")

Code:

ImprovedMerchant-3.4c\ImprovedMerchant.lua:126: attempt to index global 'LOCALE' (a nil value)

Code:

ImprovedMerchant-3.4c\ImprovedMerchant.lua:184: in function `PopulateList'
ImprovedMerchant-3.4c\ImprovedMerchant.lua:435: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:431>

Bugfix for this one is replacing ImprovedMerchant.lua: 126 with

Code:

if text and string.find(text, ImprovedMerchant_GetLocaleString("RATINGBUSTER")) then

hmm, this visibilty related issue has been fixed, thank you very much Dridzt! (also the debug line has been deleted)

05-18-09, 04:08 AM
Dridzt A Pyroguard Emberseer Forum posts: 1360 File comments: 829 Uploads: 56	Just in case my edit in comment was unnoticed. I had an error related to a chat output line (debug code for the tooltip scanning routine). I commented out that line and it's good. I am also getting this error when using the searchbox (with no filter selected in the dropdown: "nothing") Code: ImprovedMerchant-3.4c\ImprovedMerchant.lua:126: attempt to index global 'LOCALE' (a nil value) ImprovedMerchant-3.4c\ImprovedMerchant.lua:184: in function `PopulateList' ImprovedMerchant-3.4c\ImprovedMerchant.lua:435: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:431> Bugfix for this one is replacing ImprovedMerchant.lua: 126 with Code: if text and string.find(text, ImprovedMerchant_GetLocaleString("RATINGBUSTER")) then Last edited by Dridzt : 05-18-09 at 04:10 AM.

05-18-09, 03:32 AM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 113

Uploads: 8

Re: 3.4h

Originally posted by Dridzt
3.4h looks good.

I couldn't reproduce any of the bugs in previous 3.4 versions.

Only aesthetic detail I noticed is that when there's not enough items in the merchantframe to scroll they're all greyed-out.

It's only visual I can still buy them normally.

that is a problem of my actual implementation to reflect the vertex color of the itembuttons; this is my only idea how to use AddOns like Recipe Book in this AddOn.

05-18-09, 03:25 AM
Dridzt A Pyroguard Emberseer Forum posts: 1360 File comments: 829 Uploads: 56	3.4h 3.4h looks good. I couldn't reproduce any of the bugs in previous 3.4 versions. Only aesthetic detail I noticed is that when there's not enough items in the merchantframe to scroll they're all greyed-out. It's only visual I can still buy them normally. Edit: I spoke too soon. Still getting errors with some filters. Code: ImprovedMerchant-3.4c\ImprovedMerchant.lua:78: in function `SearchForRedLines' ImprovedMerchant-3.4c\ImprovedMerchant.lua:210: in function `PopulateList' ImprovedMerchant-3.4c\filterDropDown.lua:36: in function `func' Interface\FrameXML\UIDropDownMenu.lua:563: in function `UIDropDownMenuButton_OnClick': <string>:":OnClick":1: in function <[string ":OnClick"]:1> That's trying to set filter "usable". Edit in edit: That seems like a debug line left in for chat output, not functional to the addon. Last edited by Dridzt : 05-18-09 at 03:36 AM.

Page 3 of 15

Last »

Report this File

Category Jump: