BuffEnough 

Ok, i see the file, and have to edit it with "edit", because it look strange under "notepad" (i suppose you use a unix like system ?).
But there's a prolem : buffenough seem to be broken since last update (who look very cool, only disturb the lazy buffers is better than upset the whole raid with missing buffs), so i can't test it right now. Will try again this night (raids buffs, perfect time to see if everything is ok).
Is this thread a good place to report (suposed) bugs, btw ?

Simple error in latest version r75976 off of files.wowace.com:

[2008/06/04 12:16:05-4306-x1]: BuffEnough-1.0\Locales\Locale-enUS.lua:112: '=' expected near 'L'

---

Stupid typo is stupid. Sorry about that, that's what I get for checking stuff in at 2 AM. I uploaded a fixed version here; I'll check in the fix to the wowace SVN when I get home from work.

@Bifidus:
Yes, this thread is good for bug reports, feature requests, name calling, whatever. I try to check it as often as I can.

@Footrot:
It's on my list, but it's unfortunately not as easy as it might seem. Blizzard's API for checking a player's buff is separate and different from checking buffs on any other type of unit, including pets. So checking pet buffs on the same scale as BuffEnough currently checks player buffs would require quite a bit of additional implementation. I did add a check for the pet food buff, though, as a quick hit.

UnitBuff() works fine on both pets and players, doesn't it?

It works only in a limited fashion. UnitBuff() does not, for example, provide any duration/remaining time information for buffs that are on you ("player"), but which you did not cast. For that, you need to use GetPlayerBuffTimeLeft(), and like all the other GetPlayerBuff...() APIs, the buff index that it uses is not, for some reason, the same as the buffId that UnitBuff() uses.

All of these things are true, sadly. But all is not lost...

You can always abstract the difference away in a function that makes the appropriate call, for example, if we're willing to accept the limitations of interrogating pet buffs (no timers)...

... and so on for the other couple of buff query APIs. From there, the remainder of your code can simply work with indexes (not IDs as GetPlayerBuffXXXX prefers), and away you go - now we care not that the APIs are different, because we developed a small function set that makes them the same regardless of the unit.

Just a thought, an idea. Up to you of course.

EDIT:

On a different topic, the pet Phase Shift is working weirdly for me. If I ensure that my imp is not phase-shifted (and hence also not on auto-cast), then do a check, BE doesn't cry about it, no matter how much I ask it to check. If I then, for example, cancel my Fel Armor buff, BE will complain as it should - about both the phase-shift AND the Fel Armor. Then, if I reapply Fel Armor, only then will BE report phase-shift by itself. It seems I have to twiddle with my own buffs to get BE to recognize the phase-shift state.

Yep, that's a good suggestion, something I'll probably do. But the different APIs was just one example of the complication. There's also tracking a separate power type, and potentially additional configuration for different prioritization of paladin buffs. It's not impossible, just a bit more implementation work than one might think. Of course, with the time we've spent talking about it now, I probably could have just done it.

With regards to phase shift, this is due to the fact that BuffEnough only does an "auto" check on certain events, like the group changing or the player's buffs being added or removed. The imp losing his phase shift doesn't trigger any of those events, so BuffEnough doesn't automatically detect it. However, if you simply left-click the frame, you can force BuffEnough to do a manual check, and it should see that phase shift is missing at that time. One of the (many) things on my to do list is to make it smarter about things that should prompt a recheck via the combat log (since it's already checking the combat log to track who's casting the buffs now anyway).

Nah - I'm left-clicking to force the re-check, but BE will not detect the phase-shift state correctly. I'm most definitely not relying on auto-detect, since that was the first thing that crossed my mind. A forced manual check of the buffs doesn't seem to correctly check the pet for phase shift.

Also, doesn't UNIT_AURA trigger when the pet gets (or loses) phase shift? If not, yeah, the combat log will catch it. SPELL_AURA_APPLIED and SPELL_AURA_REMOVED/DISPELLED will see to that.

Hrm, that's strange. I just checked it on my warlock. When I took his phase shift off and turns the auto-cast off, and triggered a manual check, it properly detected it...

"Strange things are afoot at the Circle-K."

I used the currently posted version, stood in Shattrath (Scryer's Bank to be precise) and switched phase-shift off auto-cast and switched it off altogether, and left-click BE and nada - it still told me things were fine.

I'll switch off all other mods when I get home tonight and try it all again and let you know how I got on.

So, i try to translate different things in the "buff" part of Locale-enUS.lua (just a test with "Battle Elixir" translate to "Elixir de bataille", and "of Shattrath" to "de Shattrath").
But nothing change.
Maybe i missing something... no idea.
Here some screenshots, if it can help (the red square near buffs is BuffEnough):

Please add an option to only show the frame in a raid. Also, please make a forum thread on Wowace under ''General Addons'' so i can give you bug reports and/or requests if i should find any. Thanks, nice addon.

You'll want to put your translations into a separate file called Locale-frFR.lua in the same Locale directory, and also add the new file to the Locales.xml file.

In Locale-enUS.lua, the entry looks like:
L["Battle Elixir"] = true

In Locale-frFR.lua, the entry should look like:
L["Battle Elixir"] = "Elixir de bataille"

I try again, with this file, but no sucess (first time i let "enUS" inside, with same result).
My total lack of knowledge about coding don't help a lot, i'm afraid.

Tell you what. If you feel inclined to do the translations, I'll make sure it gets integrated properly into the addon. Appreciate the help and effort!