Download
(2Kb)
Download
Updated: 09-01-12 07:25 PM
Pictures
File Info
Updated:09-01-12 07:25 PM
Created:unknown
Downloads:42,897
Favorites:452
MD5:

TradeTabs  Popular! (More than 5000 hits)

Version: 1.8.1
by: tardmrr [More]

TradeTabs is a small addon to add spellbook-like tabs to the TradeSkillFrame. It will add one for each of your professions and one for each of the profession "suppliment" abilities (cookfire, disenchant, milling, etc)

It should work in any locale but has only been tested in enUS.


Known Issues:
When the player learns a new profession, TradeTabs does not add a tab for it right away. This is because TradeTabs only populates the list of professions when it loads. The next time you load your interface (/console reloadui) or log into the game, the tab will appear.

v 1.8.1 (2012-8-31)
* Updated for WoW 5.0


v 1.7 (2009-2-19)
* Added support for Prospecting, Milling, Disenchanting and Basic Campfire
* Added redundancy to the loading process to keep from missing being initialized.

v 1.6 (2008-11-24)
* Added support for Runeforging

v 1.5.1 (2008-10-22)
* Fixed Folder structure

v 1.5 (2008-10-21)
* Removed Rogue Poisons since they're gone as well

v 1.5-beta (2008-10-21)
* Drycode update for 3.0

v 1.4 (2008-5-03)
* Added support for Skillet

v 1.3 (2008-4-26)
* Changed the spell detection system to use spell IDs so that localization is now automatic
* Added support for Enchanting and Beast Training

v 1.2 (2007-11-26)

* Fixed a bug that caused no tabs to appear if TradeTabs was loaded before PLAYER_LOGIN or while in combat (or both).
* Added zhTW localization

v 1.1 (2007-11-12)

* Updated for patch 2.3
* Includes a probably broken Korean Localization because I'm 90% sure my text editor hates me.
Beta Files (1)
File Name
Version
Hits
Size
Author
Date
1.5
1,526
2kB
tardmrr
10-21-08 06:44 PM


Optional Files (0)


Post A Reply Comment Options
Unread 03-03-07, 12:44 AM  
tardmrr
Lua Ninja
AddOn Author - Click to view AddOns

Forum posts: 133
File comments: 134
Uploads: 12
Originally posted by sayclub
koKR localization

["연금술"] = true,
["대장기술"] = true,
["요리"] = true,
["기계공학"] = true,
["응급 치료"] = true,
["보석세공"] = true,
["가죽세공"] = true,
["독 조제"] = true,
["제련술"] = true,
["재봉술"] = true,
Thanks! I'll add it into the next version.
Report comment to moderator  
Reply With Quote
Unread 03-03-07, 12:41 AM  
tardmrr
Lua Ninja
AddOn Author - Click to view AddOns

Forum posts: 133
File comments: 134
Uploads: 12
Re: no buttons

Originally posted by mythrilgolem
using enUS and have no new buttons visible. made sure mod enabled, other tradeskill mods disabled etc and no go. ideas?
Is sounds like you either have an addon conflicting with it (this is the most likely choice) or you've only tested while you were in combat. Could you PM me a screenshot of your addon directory or a list of addons? I'd like to figure out any incompatibilities to see what can be done.
Last edited by tardmrr : 03-03-07 at 12:56 AM.
Report comment to moderator  
Reply With Quote
Unread 03-02-07, 11:16 PM  
mythrilgolem
A Kobold Labourer

Forum posts: 1
File comments: 34
Uploads: 0
no buttons

using enUS and have no new buttons visible. made sure mod enabled, other tradeskill mods disabled etc and no go. ideas?
Report comment to moderator  
Reply With Quote
Unread 03-02-07, 08:25 PM  
sayclub
A Kobold Labourer

Forum posts: 0
File comments: 31
Uploads: 0
koKR localization

["연금술"] = true,
["대장기술"] = true,
["요리"] = true,
["기계공학"] = true,
["응급 치료"] = true,
["보석세공"] = true,
["가죽세공"] = true,
["독 조제"] = true,
["제련술"] = true,
["재봉술"] = true,
Report comment to moderator  
Reply With Quote
Unread 03-02-07, 07:36 PM  
CrashCat
A Kobold Labourer

Forum posts: 0
File comments: 9
Uploads: 0
Cool idea, maybe you can add an option to put tabs on the left side instead sometime? I'd love to try this but I have TTCraftAddict that already expands on the right and would probably be in the way or be obscured partly by it.
Report comment to moderator  
Reply With Quote
Unread 03-02-07, 02:41 PM  
Shirik
Blasphemer!
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 818
File comments: 40
Uploads: 13
Originally posted by Dridzt
That's one more great idea I expect Blizzard to rip off sooner or later.

Edit: Seems to be causing ADDON_BLOCKED errors due to tainting for some people.

I don't see them myself because I use a modified version of MoveAnything that prevents tradeskill windows from showing in combat,
but others I suggested it to, told me they get errors.
You do realize that MoveAnything prevents the tradeskill windows from showing because it causes taints, right? MoveAnything is, as someone else put it, "a wrecking ball of taints."

Also note, most taints cause taint chains which means the addon being reported is typically not the addon that caused the taint. In 2.1.0, we get an API to specifically identify the addon causing the taint, but until then, it's all about disabling addons until you find the root of the chain. The last addon you disable is the cause of the problem.

1) Some other addon you have has tainted the frame management code that shows the tradeskillframe. This would cause addon blocked messages on the base UI if it tried to show the TradeSkillFrame while in combat. I've thought of a way to get around this issue, but it's sorta hacky and it makes the tabs go away until you leave combat. I'm still thinking on whether it would be worth the effort to implement it. What do you guys think?
In my opinion, "hacky" code is usually more trouble than it's worth. Perhaps prevent the tradeskill window from being opened if it hasn't been initialized yet? I doubt there are many uses for opening the tradeskill window mid-combat, especially if it's the first time it's been opened since login. That fixes your problem. Honestly, it's not really your "job" to be fixing other addons' problems... but of course that's your own prerogative if you want to try to work around it.
Last edited by Shirik : 03-02-07 at 02:48 PM.
Report comment to moderator  
Reply With Quote
Unread 03-02-07, 12:28 PM  
tardmrr
Lua Ninja
AddOn Author - Click to view AddOns

Forum posts: 133
File comments: 134
Uploads: 12
Originally posted by Dridzt
That's one more great idea I expect Blizzard to rip off sooner or later.

Edit: Seems to be causing ADDON_BLOCKED errors due to tainting for some people.

I don't see them myself because I use a modified version of MoveAnything that prevents tradeskill windows from showing in combat,
but others I suggested it to, told me they get errors.
TradeTabs by itself should have no problems (except for case 2 below). It is careful not to taint anything, and as long as you don't have other taint issues, you shouldn't have any problems with TradeTabs. That being said, there are 2 ways that you'd get ADDON_BLOCKED messages "because" of TradeTabs:

1) Some other addon you have has tainted the frame management code that shows the tradeskillframe. This would cause addon blocked messages on the base UI if it tried to show the TradeSkillFrame while in combat. I've thought of a way to get around this issue, but it's sorta hacky and it makes the tabs go away until you leave combat. I'm still thinking on whether it would be worth the effort to implement it. What do you guys think?

2) If you open the TradeSkillFrame for the first time while you are in combat, TradeTabs will fail to setup the tabs, and you'd get 3 addon blocked messages per tab. This is mostly an oversight by me, but it's such a corner case that when I realized it last night, I wasn't going to worry about it. However, if I end up doing anything about the other issue, this one becomes trivial to fix.
Last edited by tardmrr : 03-02-07 at 12:37 PM.
Report comment to moderator  
Reply With Quote
Unread 03-02-07, 06:36 AM  
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1360
File comments: 829
Uploads: 56
That's one more great idea I expect Blizzard to rip off sooner or later.

Edit: Seems to be causing ADDON_BLOCKED errors due to tainting for some people.

I don't see them myself because I use a modified version of MoveAnything that prevents tradeskill windows from showing in combat,
but others I suggested it to, told me they get errors.
Last edited by Dridzt : 03-02-07 at 08:30 AM.
Report comment to moderator  
Reply With Quote
Unread 03-02-07, 03:21 AM  
Depherios
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 9
Uploads: 1
Great Idea. Flawless Execution.

Works perfectly, and is now saving me 3+ buttons on my bars on my characters.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: