Download
(171Kb)
Download
Updated: 12-14-06 05:15 PM
Addon for:
FuBar 3.6.5.
Pictures
File Info
Updated:12-14-06 05:15 PM
Created:unknown
Downloads:38,753
Favorites:301
MD5:

FuBar - GarbageFu  Popular! (More than 5000 hits)

Version: 2.0.20634
by: wmrojer [More]

New beta version available at http://files.wowace.com/FuBar_GarbageFu/

Short Description:

FuBar - GarbageFu is a plugin to FuBar 2.0 that helps you clean your bags of Garbage by letting you drop the least valuable item/s. Or if you are at a merchant you can simply select to sell all your Garbage to him by pressing a button.

Feedback and feature requests are needed.

Features:

Drop least valuable item.
Shows all items that can be dropped along with there total value in a tooltip.
Sell all that are shown in the tooltip or all grey items to a vendor with the press of a button.
Select what to drop and what to keep by Sets, Type, Items and Quality threshold.
Supports several addons for retrieval of price information, including it's own.
Select sets of items to use auction price for instead of vendor price.
Select item quality threshold for when to use auction price instead of vendor price.
Supports Autioneer, KC_Items and WoWEcon for Auction prices.
Display total/free/used bag slots on the toolbar.
Toggle bags display.

Long Description:

Selection of what items to drop are made in the following way. (By decreasing priority)

  • Keep Items List.
    Select to keep an item that would otherwise be dropped.
  • Drop Items List.
    Select to drop an item that would otherwise not be dropped.
  • Keep Type list.
    Select types of items to keep.
  • Keep Sets List.
    Select sets of items to keep.
  • Drop Type List.
    Select types of items to drop.
  • Drop Sets List.
    Select sets of items to drop.
  • Quality Drop Threshold.
    Set the default quality threshold for what items to drop. Default is poor quality item.s

Types are based on WoW internal item types. (From GetItemInfo)
Examples:
Armor
Weapons
Bag
Key
Recipie
Quest

Some type also have subtypes.
Armor has
Cloth, Leather, Mail, Plate, Shield....
Weapons as
Dagger, 1H Sword, 2H Sword, 1H Axe........

Included in type are also Bind types.
Soulbound, Quest, Bind on Pickup, Bind on Equip/Use.

Sets are made up of different types of items.
Examples:
Food, Water, Tradeskill, Gathered, Bandages, Scrolls .......

Several sets also have subsets that you can select if you need greater detail
Examples:
Food has
Normal Food, Bonus Food, Stat Food, Conjured Bread, Raw Food, Bread, Fish....
Water has
Normal Water, Percent Water, Conjured Water.

Tooltip that shows all the items in your inventory that can be dropped with the current selections.

By Left Clicking the mouse while holding down shift on the toolbar will drop the item on the top of the list, or sell it if you have a merchant window open. You can also left click the mouse while holding down shift on the Tooltip to drop or sell a specific item in the list.

By left clicking the mouse while holding down control on the toolbar or the tooltip will add that item to the keep items list, those preventing that item from being dropped or sold.

When you have a merchant window open you also have the ability to sell all the items that are shown in the tooltip by either selecting 'Sell All Garbage Items' in the drop down menu, or by clicking the 'Sell All Garbage Item' button on the merchant window. Button on the merchant window can be turned off. You can also select to only sell grey items.

Item values are collected from Auctioneer/Informat, KC_Items, PriceMaster, Ludwig_SellValue (courtesy of Kergoth), WoWEcon, ItemSync (courtesy of kirson), ColaLight and it's own GarbageFu - Prices. Currently GarbageFu will NOT drop any items above grey(poor) quality without price information.

Auction values are collected from Auctioneer, KC_Items or WoWEcon. For Auctioneer you have two way, either directly or cached. Directly requires that Auctioneer is loaded at all time, while cached only requires Auctioneer to be loaded when you want to update what items you want auction values for or when have scanned the auction house to update with updated values. GarbageFu will automaticaly update item values after you scanned the auction house. (WoWEcon don't have a auction house scan. Personal opinion on WoWEcon is that it sucks big time)

You can select what items to use auction prices for by Sets, per item and by quality threshold. If there is no auction value available the vendor price will be used.

You can change in which order GarbageFu will ask both the vendor price addons and auction house addons. Example: You have both Auctineer/Informat and KC_Items loaded and you want vendor prices from KC_Items but auction prices from Auctioneer, just set it up so KC_Items is higher in the list for 'Vendor Addons' option and Auctioneer is higher then in the 'Auction Addons' options. It will then get vendor prices first from KC_Items, and only if it dosn't exist there it will look in Informat/Auctioneer. You can also select to not use a vendor/auction addon by setting it below 'Don't use addons below' in the 'Vendor Addons'/'Auction Addons' in the options. Only addons loaded will be shown in the options. Addons are added when they are loaded (even on demand).

You also have the ability to enter your own price for an item. That price will then override any price gotten from other sources. Price overrides are stored per account, so you only need to enter them once.

Settings are store per profile, so you can choose to have different settings for different chars/classes.

Optional information in the tooltip about where the price came from.
VI = Informat vendor price.
VK = KC_Items vendor price.
VW = WoWEcon vendor price.
VL = Ludwig_SellValue vendor price.
VS = ItemSync vendor price.
VT = GarbageFU_Prices vendor price.
VP = PriceMaster vendor price.
VC = ColaLight vendor price.
AA = Auctioneer auction price.
AC = Cached Auctioneer auction price.
AK = KC_Items auction price.
AW = WoWEcon auction price.

Optional display of Total/Free/Used bag slots. Does not include any ignored special bags. (Ammo, herb soulstone, enchanting).

Double-click to toggle bags. (Does not toggle any ignored special bags)

Sets functionality uses PeriodicTable by Tekkub.
Some code borrowed from ItemizedDeduction by Tekkub.

There are currently no Auto-drop functionality. If it is requested it will be added later.

Installation:

Just unpack in your Interface/AddOns/ folder. No dependancies, all required libraries are embeded.

In the works:
Nothing. Working on some new projects

Know issues:

Auction quailty threshold dosn't work for caching auctioneer.

Patch notes:

2.0.20634
More debug code to try and catch the wrong item error. Warning, special debug build. Will do a complete item check every 60 seconds. May cause lag.
Added check to "Sell All Buttom" that I had missed the last time.

2.0.20111
Hopefully fixed the problem with GarbageFu getting out of sync with what's actually in your inventory. Extra checks still in place.

2.0.19988
Added extra checks that it's the right item that is dropped/sold. Will warn if it detects an inconsistancy in it's data and refuse to drop/sell the item if it dosn't match what it thinks should be in that bagslot.
Fixed the nil,nil,nil prints. (Was an api change in AceConsole-2.0)

2.0.19420
Removed the use of Compost. Not needed since we have lua 5.1.
Fixed a small typo that showed up when Compost was no longer functional.

2.0.19164
Updated toc for WoW 2.0

2.0.16966
Upgraded to AceLocal-2.2 and AceHook-2.1. Fixed TBC compatibility.
Note: You need to remove the embeded Ace2 libs and install the Ace2 TBC standalone version and update the .toc to interface 20000 to get it to work in the TBC beta

2.0.16125
Minor bug fix. (sorry, no Bagnon support)

2.0.14033
Fixed nil error on reloadui. (tekkub)
Now properly updates auction prices OnFullyInitialized (tekkub)
Shorter German translation of 'No items to drop'.

2.0.13718
Fixed problem with vendor and auction price addons loading after GarbageFu. Checking is now done after AceEvent_FullyInitialized.
Added French translation by Culhag.

2.0.13301
Fixed bug where sell grey items sold grey items that is marked to keep.
Added Auction quality threshold.

2.0.11917
Fixed nil error in call to Abacus.

2.0.11684
Changed startup sequence. Addons wasn't always initialized.
Downgraded Ace2 lib's to 10851.

2.0.11635
Added recipes as auction set.
Removed Ammo from drop/keep set since it's available in keep/drop type (that is faster to check).
Updated for lua 5.1
Added bag slots display (Total/Used/Free).
Double-click to open bags.
Fixed issue with settings not being saved in the right profile. (Was an issue with FuBar not setting the profile for a new addon)
Added German translation. German translation by Dermott <Azeroths Plage>

2.0.11023
Added support for Auction prices. Supported addons Auctioneer, KC_Items and WoWEcon.
Added Item types base on information from GetItemInfo itemType and itemSubType. (return param 5 and 6)
Vendor price and Auction price addon priority changable.
Price addons detected even when loaded on demand.

1.0.10349
Added support for ItemSync.
Fixed Sell All Items button to only show when there are items to sell.
Added total value of items to sell to the tooltip of sell all items button.

1.0.9990 First non beta release.
Support for more vendor price addons. Including it's own.
Use of Item icon on the toolbar instead of recycle bin.
Option to only autosell grey items to vendor.
Reverted back to AceLocal-2.0 (Since it appears to be faster now)

0.1.9690 First public beta version.

Post A Reply Comment Options
Unread 10-12-06, 10:03 AM  
Geforz
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
german localisation

can you change
["No items to drop"] = "Keine Gegenst\195\164nde zu zerst\195\182ren",
to
["No items to drop"] = "Nichts zu zerst\195\182ren",
because the second string is much smaller and the "no items" sting is so long in my fubar ^^
Report comment to moderator  
Reply With Quote
Unread 10-12-06, 07:23 PM  
DSanai
A Wyrmkin Dreamwalker
 
DSanai's Avatar
AddOn Author - Click to view AddOns

Forum posts: 50
File comments: 110
Uploads: 3
Requested Feature:

Would it be possible to add a type/category for keeping that will only keep water/food within 9 or 10 levels (below) of the character?

For instance, I have low-level mages who use, for instance, the vendor-available water usable by level 15's -- they do not need to keep water for a level 5 anymore, and I would like to toss them when I pick them up as loot (since they aren't worth much).

Currently, I list the specific item in the Keep list, but that means my level 60 character *also* must keep level 15 water, which should be a toss item for him.

The old ItemDed kept the keep list(s) separated by character. While I generally prefer the combined method GarbageFu employs (who wants to have to mark every type of cloth for every character, for instace), in the case of level-specific bonus/recharge food, I'd like to see some way to address the issue of widely differing character levels.

Thanks for your time managing this awesome mod. It has more than filled the hole in my heart ItemDed left so long ago. It's become one of my top-10 must-have's.
__________________
Dsanai - nElf Hunter
Glacialfox - nElf Death Knight
Evilianti - Gnome Warlock
Report comment to moderator  
Reply With Quote
Unread 10-13-06, 09:03 AM  
wmrojer
A Deviate Faerie Dragon
 
wmrojer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 73
Uploads: 3
@DSanai:

Settings are store in profiles. Profile can be set in FuBar to be default, class or char. So your lvl 60 should not have to keep the lvl 15 water.

About your feature request.
I'll see if WoW returns the correct level information about water. But I don't see any easy way to implement this, so no promises. If I implement it for water, then there is food, potions, scrolls, armor, weapons.... You get the picture.
Report comment to moderator  
Reply With Quote
Unread 10-18-06, 11:24 AM  
Jaim Sandar
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 357
Uploads: 1
14033 or 13718?

The new version posted today and identified as 2.0.14033 appears to be r13718.
Report comment to moderator  
Reply With Quote
Unread 10-18-06, 06:08 PM  
DSanai
A Wyrmkin Dreamwalker
 
DSanai's Avatar
AddOn Author - Click to view AddOns

Forum posts: 50
File comments: 110
Uploads: 3
Yeah, the ZIP contains r13718.
__________________
Dsanai - nElf Hunter
Glacialfox - nElf Death Knight
Evilianti - Gnome Warlock
Report comment to moderator  
Reply With Quote
Unread 10-19-06, 04:38 AM  
wmrojer
A Deviate Faerie Dragon
 
wmrojer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 73
Uploads: 3
2.0.14033 again

Uploaded 2.0.14033 again. Lets see if it make it to the site this time.
Report comment to moderator  
Reply With Quote
Unread 10-19-06, 07:24 PM  
DSanai
A Wyrmkin Dreamwalker
 
DSanai's Avatar
AddOn Author - Click to view AddOns

Forum posts: 50
File comments: 110
Uploads: 3
Good to go. Danke.
__________________
Dsanai - nElf Hunter
Glacialfox - nElf Death Knight
Evilianti - Gnome Warlock
Report comment to moderator  
Reply With Quote
Unread 10-19-06, 10:28 PM  
Lichbane
A Deviate Faerie Dragon
 
Lichbane's Avatar

Forum posts: 16
File comments: 83
Uploads: 0
It seems all version since 2.0.13301 are giving me errors with other ACE addons:

Error: AceModuleCore-2.0: OnInstanceInit cannot be called twice
AddOn: FuBar_FriendsFu
File: AceOO-2.0.lua
Line: 733
Count: 1
--------------------------------------------------
Error: attempt to index field `totalModules' (a nil value)
File: ...procket\Libs\AceModuleCore-2.0\AceModuleCore-2.0.lua
Line: 186
Count: 11
--------------------------------------------------
Error: attempt to compare number with nil
AddOn: FuBar_GroupFu
File: GroupFu.lua
Line: 462
Count: 1
--------------------------------------------------
Error: attempt to index field `METHODS' (a nil value)
AddOn: FuBar_TransporterFu
File: TransporterFu.lua
Line: 147
Count: 1

Version 2.0.11917 on the other hand still works fine. Reverting back to it .....
Report comment to moderator  
Reply With Quote
Unread 10-20-06, 01:04 PM  
wmrojer
A Deviate Faerie Dragon
 
wmrojer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 73
Uploads: 3
I can't say for sure what the problem is with just the information you have provided. But it looks like you are useing some mode that use AceModuleCore-2.0 that is of a very old revision. (Addon ***procket). And that it isn't fully compatible with the latest releases of ace2. The latest versions FuBar_FriendsFu and GarbageFu are using the exact same revisions of ace2, and neither FuBar_GarbageFu, FuBar_FriendsFu or FuBar_TransporterFu use AceModuleCore-2.0.

I have posted a question about this on the WoWace forum.

Could you try to install BugGrabber and BugSack and post the errors with full stack trace.
http://www.wowace.com/files/index.ph...%21BugGrabber/
http://www.wowace.com/files/index.php?path=BugSack/

Originally posted by Lichbane
It seems all version since 2.0.13301 are giving me errors with other ACE addons:

Error: AceModuleCore-2.0: OnInstanceInit cannot be called twice
AddOn: FuBar_FriendsFu
File: AceOO-2.0.lua
Line: 733
Count: 1
--------------------------------------------------
Error: attempt to index field `totalModules' (a nil value)
File: ...procket\Libs\AceModuleCore-2.0\AceModuleCore-2.0.lua
Line: 186
Count: 11
--------------------------------------------------
Error: attempt to compare number with nil
AddOn: FuBar_GroupFu
File: GroupFu.lua
Line: 462
Count: 1
--------------------------------------------------
Error: attempt to index field `METHODS' (a nil value)
AddOn: FuBar_TransporterFu
File: TransporterFu.lua
Line: 147
Count: 1

Version 2.0.11917 on the other hand still works fine. Reverting back to it .....
Report comment to moderator  
Reply With Quote
Unread 10-20-06, 03:37 PM  
Lichbane
A Deviate Faerie Dragon
 
Lichbane's Avatar

Forum posts: 16
File comments: 83
Uploads: 0
After a bit of stuffing about, it seems to be an incompatability with Sprocket:

["errors"] = {
[1] = {
["message"] = "[2006/10/21 07:18:57-1]: FishingBuddy\\localization.de.lua:17: attempt to concatenate global `NAME' (a table value)\nFishingBuddy\\localization.de.lua:17: in main chunk\n\n ---",
["time"] = "2006/10/21 07:18:57",
["session"] = 1,
},
[2] = {
["message"] = "[2006/10/21 07:19:07-1]: AceOO\\AceOO-2.0.lua:733: AceModuleCore-2.0: OnInstanceInit cannot be called twice\n<in C code>: in function `error'\nAceLibrary\\AceLibrary.lua:117: in function `error'\nAceModuleCore-2.0\\AceModuleCore-2.0.lua:374: in function `OnManualEmbed'\nAceOO\\AceOO-2.0.lua:733: in function `embed'\nAceOO\\AceOO-2.0.lua:750: in function `activate'\nAceModuleCore-2.0\\AceModuleCore-2.0.lua:387: in function `activateFunc'\nAceLibrary\\AceLibrary.lua:672: in function `Register'\nAceModuleCore-2.0\\AceModuleCore-2.0.lua:403: in main chunk\n\n ---",
["time"] = "2006/10/21 07:19:07",
["session"] = 1,
},
[3] = {
["message"] = "[2006/10/21 07:19:18-1]: AceModuleCore-2.0\\AceModuleCore-2.0.lua:186: attempt to index field `totalModules' (a nil value)\nAceModuleCore-2.0\\AceModuleCore-2.0.lua:186: in function `IsModule'\nAceAddon\\AceAddon-2.0.lua:450: in function `obj_method'\nAceEvent\\AceEvent-2.0.lua:244: in function `TriggerEvent'\nAceEvent\\AceEvent-2.0.lua:894: in function <...erface\\AddOns\\BugSack\\Libs\\AceEvent\\AceEvent-2.0.lua:886>\n\n ---",
["time"] = "2006/10/21 07:19:18",
["session"] = 1,
},
[4] = {
["message"] = "[2006/10/21 07:19:19-1]: AceModuleCore-2.0\\AceModuleCore-2.0.lua:186: attempt to index field `totalModules' (a nil value)\nAceModuleCore-2.0\\AceModuleCore-2.0.lua:186: in function `IsModule'\nAceAddon\\AceAddon-2.0.lua:272: in function <...erface\\AddOns\\BugSack\\Libs\\AceAddon\\AceAddon-2.0.lua:266>\nAceAddon\\AceAddon-2.0.lua:384: in function `InitializeAddon'\nAceAddon\\AceAddon-2.0.lua:262: in function `obj_method'\nAceEvent\\AceEvent-2.0.lua:244: in function `TriggerEvent'\nAceEvent\\AceEvent-2.0.lua:894: in function <...erface\\AddOns\\BugSack\\Libs\\AceEvent\\AceEvent-2.0.lua:886>\n<in C code>: in function `LoadAddOn'\n<in C code>: in function `pcall'\nFuBar\\FuBar.lua:646: in function <Interface\\AddOns\\FuBar\\FuBar.lua:642>\nFuBar\\FuBar.lua:913: in function `LoadPlugin'\nFuBar\\FuBar.lua:1032: in function `event'\nAceEvent\\AceEvent-2.0.lua:422: in function <...erface\\AddOns\\BugSack\\Libs\\AceEvent\\AceEvent-2.0.lua:402>\n\n ---",
["time"] = "2006/10/21 07:19:19",
["session"] = 1,
},
[5] = {
["message"] = "[2006/10/21 07:19:20-1]: last message repeated 2 times\n ---",
["time"] = "2006/10/21 07:19:20",
["session"] = 1,
},
[6] = {
["message"] = "[2006/10/21 07:19:20-1]: FuBar_GroupFu\\GroupFu.lua:462: attempt to compare number with nil\nFuBar_GroupFu\\GroupFu.lua:462: in function `OnDataUpdate'\nFuBarPlugin\\FuBarPlugin-2.0.lua:264: in function `UpdateData'\nFuBarPlugin\\FuBarPlugin-2.0.lua:251: in function `Update'\nFuBarPlugin\\FuBarPlugin-2.0.lua:385: in function `Show'\nFuBar\\FuBar.lua:924: in function `LoadPlugin'\nFuBar\\FuBar.lua:1032: in function `event'\nAceEvent\\AceEvent-2.0.lua:422: in function <...erface\\AddOns\\BugSack\\Libs\\AceEvent\\AceEvent-2.0.lua:402>\n\n ---",
["time"] = "2006/10/21 07:19:20",
["session"] = 1,
},
[7] = {
["message"] = "[2006/10/21 07:19:21-1]: AceModuleCore-2.0\\AceModuleCore-2.0.lua:186: attempt to index field `totalModules' (a nil value)\nAceModuleCore-2.0\\AceModuleCore-2.0.lua:186: in function `IsModule'\nAceAddon\\AceAddon-2.0.lua:272: in function <...erface\\AddOns\\BugSack\\Libs\\AceAddon\\AceAddon-2.0.lua:266>\nAceAddon\\AceAddon-2.0.lua:384: in function `InitializeAddon'\nAceAddon\\AceAddon-2.0.lua:262: in function `obj_method'\nAceEvent\\AceEvent-2.0.lua:244: in function `TriggerEvent'\nAceEvent\\AceEvent-2.0.lua:894: in function <...erface\\AddOns\\BugSack\\Libs\\AceEvent\\AceEvent-2.0.lua:886>\n<in C code>: in function `LoadAddOn'\n<in C code>: in function `pcall'\nFuBar\\FuBar.lua:646: in function <Interface\\AddOns\\FuBar\\FuBar.lua:642>\nFuBar\\FuBar.lua:913: in function `LoadPlugin'\nFuBar\\FuBar.lua:1032: in function `event'\nAceEvent\\AceEvent-2.0.lua:422: in function <...erface\\AddOns\\BugSack\\Libs\\AceEvent\\AceEvent-2.0.lua:402>\n\n ---",
["time"] = "2006/10/21 07:19:21",
["session"] = 1,
},
[8] = {
["message"] = "[2006/10/21 07:19:22-1]: last message repeated 6 times\n ---",
["time"] = "2006/10/21 07:19:22",
["session"] = 1,
},
[9] = {
["message"] = "[2006/10/21 07:19:22-1]: FuBar_TransporterFu\\TransporterFu.lua:147: attempt to index field `METHODS' (a nil value)\nFuBar_TransporterFu\\TransporterFu.lua:147: in function `UpdateText'\nFuBarPlugin\\FuBarPlugin-2.0.lua:252: in function `Update'\nFuBarPlugin\\FuBarPlugin-2.0.lua:385: in function `Show'\nFuBar\\FuBar.lua:924: in function `LoadPlugin'\nFuBar\\FuBar.lua:1032: in function `event'\nAceEvent\\AceEvent-2.0.lua:422: in function <...erface\\AddOns\\BugSack\\Libs\\AceEvent\\AceEvent-2.0.lua:402>\n\n ---",
["time"] = "2006/10/21 07:19:22",
["session"] = 1,
},
},

Disable sprocket and all I get is the first error ....

As I use sprocket extensively, do you have any suggestions (apart from contact the sprocket's author?).

Adjunct: I copied the latest versions of the ACE2 libraries to the Sprocket libs and I still get the error. However, sprocket still works when I disable GarbageFu, Buggrabber and Bugsack. It doesn't seem to be an incompatability with ACE, but other add-ons using ACE.

No comprende ......
Last edited by Lichbane : 10-20-06 at 04:06 PM.
Report comment to moderator  
Reply With Quote
Unread 10-21-06, 01:53 AM  
wmrojer
A Deviate Faerie Dragon
 
wmrojer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 73
Uploads: 3
Sprocket

@Lichbane:

I installed Sprocket, but I didn't get any errors on startup. I did get some errors when using Sprocket, but those all seemed to be Sprocket internal errors. I checked the Sprocket thread, and there seems like the latest version of Sprocket is incompatible with most FuBar plugins, so I would imagine it's a Sprocket problem. Just hope he/she will fix it soon.
Report comment to moderator  
Reply With Quote
Unread 10-22-06, 06:25 PM  
Lichbane
A Deviate Faerie Dragon
 
Lichbane's Avatar

Forum posts: 16
File comments: 83
Uploads: 0
Re: Sprocket

Originally posted by wmrojer
@Lichbane:

I installed Sprocket, but I didn't get any errors on startup. I did get some errors when using Sprocket, but those all seemed to be Sprocket internal errors. I checked the Sprocket thread, and there seems like the latest version of Sprocket is incompatible with most FuBar plugins, so I would imagine it's a Sprocket problem. Just hope he/she will fix it soon.
Thanks wmrojer.

I guess I'm lucky in that it's only GarbageFu that's causing my problem. I'll hang back a couple of versions and hope for a new version of Sprocket to come out sooner rather than later.
Report comment to moderator  
Reply With Quote
Unread 10-23-06, 07:22 AM  
Noyl
A Kobold Labourer

Forum posts: 0
File comments: 16
Uploads: 4
GarbageFu and Bagnon

Ran into a problem with the double-click to open feature in GarbageFu not working when using the Bagnon plugnin. To fix this I replace the following code in GarabageFu;
Code:
	if not ContainerFrame1:IsShown() then
		ToggleBackpack()
		for i = 1, 4 do
			if not self.vars.bags[i].ignore and self.vars.bags[i].numSlots > 0 then
				if not getglobal("ContainerFrame" .. (i + 1)):IsShown() then
					ToggleBag(i)
				end
			end
		end
	else
		for i = 0, 4 do
			if getglobal("ContainerFrame" .. (i + 1)):IsShown() then
				getglobal("ContainerFrame" .. (i + 1)):Hide()
			end
		end
	end
With the following which I took from BagFu ;
Code:
		if ContainerFrame1:IsShown() then
			for i = 1, 4 do
				local link = GetInventoryItemLink("player", ContainerIDToInventoryID(i))
				if link ~= nil then
					local itemId = tonumber(string.gsub(link, "|cff%x%x%x%x%x%x|Hitem:(%d+):%d+:%d+:%d+|h.*", "%1") or 0)
					local _,_,_,_,_,subtype = GetItemInfo(itemId)
					local usable = true
					if not self.db.profile.includeAmmo and (subtype == L["Soul Bag"] or subtype == L["Ammo Pouch"] or subtype == L["Quiver"]) then
						usable = false
					elseif not self.db.profile.includeProfession and (subtype == L["Enchanting Bag"] or subtype == L["Herb Bag"] or subtype == L["Engineering Bag"]) then
						usable = false
					end
					if usable then
						ToggleBag(i)
					end
				end
			end
		end
This works for Bagnon, but when bagnon is not enabled errors on these lines;
Code:
              if not self.db.profile.includeAmmo and (subtype == L["Soul Bag"] or subtype == L["Ammo Pouch"] or subtype == L["Quiver"]) then
			usable = false
              elseif not self.db.profile.includeProfession and (subtype == L["Enchanting Bag"] or subtype == L["Herb Bag"] or subtype == L["Engineering Bag"]) then
			usable = false
		end
I'm not much of a coder, just enough to know basically what I'm looking at and be extremely dangerous to myself. Hope this helps. Great Addon! Thanks.
Last edited by Noyl : 11-03-06 at 05:35 PM.
Report comment to moderator  
Reply With Quote
Unread 10-31-06, 07:00 PM  
wmrojer
A Deviate Faerie Dragon
 
wmrojer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 73
Uploads: 3
@Noyl: Please define "Not working"

I've never used BagNon since I'm satisfied with the normal bag view.

I can't see how the new code you took from BagFu would work at all, since it dosn't do anything unless there is already at least one bag open. And all that checking of bagtypes isn't needed since GarbageFu already knows what bags to ignore.

You could try this code instead. Not that I think that it would work very well. But it's what the code you took from BagFu does (minus the bag type checking).
Code:
if ContainerFrame1:IsShown() then
  for i = 1, 4 do
    if not self.vars.bags[i].ignore and self.vars.bags[i].numSlots > 0 then
      ToggleBag(i)
    end
  end
end
Report comment to moderator  
Reply With Quote
Unread 11-03-06, 05:34 PM  
Noyl
A Kobold Labourer

Forum posts: 0
File comments: 16
Uploads: 4
Thanks

@wmrojer: That code works great with bagnon and without, thanks a lot!!

I apologize for being ambiguous about "not working." What was happening was that when I double-clicked on GarbageFu in the bar I would hear the bag opening sound, but my bag(s) did not open.

I have a small feature request also. (I know. I'm a pain in the butt) I'd like to be able to show the bag slots used/total without having to show the other text.

Again, Great Addon! Thanks for all the help.
Last edited by Noyl : 11-03-06 at 05:40 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: