Quantcast
Download
(89 Kb)
Download
Updated: 12-02-11 03:04 PM
Patch for:
ItemRack.
Pictures
File Info
Updated:12-02-11 03:04 PM
Created:10-17-10 10:40 AM
Downloads:18,792
Favorites:116
MD5:

ItemRack - Cataclysm  Popular! (More than 5000 hits)

Version: 2.73
by: Kharthus, Yewbacca

This fixes ItemRack to work with Cataclysm and contains important bug fixes and improvements.

Original version is here: ItemRack

12/9/11: All future updates will be back on the main addon page.

__ New in 2.73 - By Kharthus __

* TOC update for WoW 4.3.0
* Fixed GetNumMacroIcons error in 4.3

__ New in 2.72 - By Kharthus __

* TOC update for WoW 4.2.0

__ New in 2.71 - By Kharthus __

* TOC update for WoW 4.1.0

__ New in 2.7 - By Yewbacca __

* Created new consolidated patterns for ItemLink/ItemString-to-ItemRackStyleID, ItemRackStyleID-to-BaseID, ItemLink/ItemString-to-BaseID
* Created new functions that use those patterns, and various other new helper functions, in order to consolidate all ItemString-handling in one place
* Replaced all old-style handling of itemIDs (string.gsub/find/match) and made everything use the new functions instead, for more robust handling as well as easy updates in the future
* Replaced GUI drawing code with references to new functions, to get icons and tooltips to work in the GUI
* Updated the GUI code so that it always draws item tooltips using the player's current level, which ensures that mousing over heirlooms in saved sets will actually show their stats for your CURRENT level (the old code set all levels to 0 which made it so the stats were shown incorrectly as level 1)
* Improved the two functions that actually LOCATE the stored equipment set items inside the player's inventory/equipment/bank (whether it's for equipping, or simply displaying a tooltip), by making sure those functions pass the INCOMING ID through the new level updater (UpdateIRString) to ensure all old Item IDs are up to date, thus fixing the bug where leveling up would cause ItemRack to fail strict item search on all saved sets and resort to any-item-with-the-same-baseID; this injection point was chosen because it fixes the problem completely throughout the board, since everything that locates items relies on the item finding functions
* Updated the functions for getting info for an item (GetInfoByID), posting an itemlink to the chatbox when shift clicking an item in ItemRack's GUI (ChatLinkID), and the function for showing an item in a tooltip, so that they all pass the incoming ID through the level updater (UpdateIRString) in order to work with up-to-date information, since it's important that stats are correct whether it's for posting chat links or looking at a tooltip's stats
* Commented and cleaned up terrible code here and there, as I untangled the messy code (minor changes)

__ New in 2.65 - By Kharthus __

* Reverted gear swap code to 2.243 version

__ New in 2.64 - By Kharthus __

* Fixed slash commands

__ New in 2.63 - By Kharthus __

* Replaced all getglobal calls with _G
* Fixed Titan's Grip and Shaman off-hand

__ New in 2.62 - By Kharthus __

* Fixed lua errors caused by chat links
* Fixed issues with clicking on Dockable Buttons
* Fixed event code
* Fixed icon updates on gear swaps

__ New in 2.61 - By Kiki __

* Fixed lua errors caused by tooltips

__ New in 2.60 - By Kiki __

* Fixed for WoW 4.0
Post A Reply Comment Options
Unread 11-09-10, 03:43 AM  
jerry.a1128
A Kobold Labourer
 
jerry.a1128's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 2
Uploads: 1
Originally posted by jerry.a1128
Thanks for the patch
I have a problem in 4.0.1 with Login Incombat.

When I was in combat when the server is disconnected and then re-login
It's show an error for ActionButton(CreateFrame).then ActionButton Can not be used in the combat. Must be disabled the ItemRack
This is what I remember a small part of the error message.I Forget to copy error message
Sorry.My English is not good
Error: CreateFrame: Can't create 'Button' now
Count: Infinite
[C]: ?
[C]: ?
[C]: in function `CreateFrame'
Interface\AddOns\ItemRack\ItemRack.lua:1820: in function `SetSetBindings'
Interface\AddOns\ItemRack\ItemRack.lua:373: in function `InitCore'
Interface\AddOns\ItemRack\ItemRack.lua:183: in function `func'
Interface\AddOns\ItemRack\ItemRack.lua:796: in function `OnUpdate'
[string "*:OnUpdate"]:1: in function <[string "*:OnUpdate"]:1>

--------------------------------------------------
Error: C stack overflow
Count: 1
[C]: ?
[C]: ?
[C]: ?
[C]: ?
[C]: ?
...
[C]: ?
[C]: ?
[C]: in function `UseAction'
Interface\FrameXML\SecureTemplates.lua:274: in function `handler'
Interface\FrameXML\SecureTemplates.lua:540: in function <Interface\FrameXML\SecureTemplates.lua:488>
Report comment to moderator  
Reply With Quote
Unread 11-04-10, 10:13 PM  
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 275
Uploads: 9
That's already been fixed. Gello is trying to make it so addons (other than the default equip manager) can once again swap weapons in combat.
Report comment to moderator  
Reply With Quote
Unread 11-04-10, 03:23 PM  
Yewbacca
A Murloc Raider

Forum posts: 6
File comments: 34
Uploads: 0
Originally posted by DartWyllt
or simply rename it something like GearRack 0.xxx telling to consider this like a continuation of ItemRack ...

P.S. somewhere on this site, under comments of another gello's addon, i saw somwething like gello is trying to fix the incombat weapon swap, blocked in 3.2 or 3.3 patch, but didn't found any other news about itemrack from gello, btwn i tank u alot for the fix.
As far as I know (long time ago I checked ItemRack's source and do not feel like digging it up), ItemRack has a queue. Basically when you click a set, it either equips each item, OR it adds them to a queue. The queue is used if you are in combat and some other cases. The code currently says:
"if in combat, equip weapons, add everything else to queue."

The fix is as simple as changing it to "if in combat, add everything to queue".

It's a very easy fix.
Report comment to moderator  
Reply With Quote
Unread 11-01-10, 08:20 PM  
DartWyllt
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
or simply rename it something like GearRack 0.xxx telling to consider this like a continuation of ItemRack ...

P.S. somewhere on this site, under comments of another gello's addon, i saw somwething like gello is trying to fix the incombat weapon swap, blocked in 3.2 or 3.3 patch, but didn't found any other news about itemrack from gello, btwn i tank u alot for the fix.
Last edited by DartWyllt : 11-01-10 at 08:24 PM.
Report comment to moderator  
Reply With Quote
Unread 10-28-10, 03:22 PM  
Yewbacca
A Murloc Raider

Forum posts: 6
File comments: 34
Uploads: 0
Ahh good old "All Rights Reserved"; great if you want to prevent code thieves or assholes like Wowmatrix, but horrible if you just leave the project without a maintainer.

How about renaming "ItemRack - 4.0.1 patch" to "ItemRack (Cataclysm)"? It would give this continuation a future-proof name at least. Maybe also change the version system from "2.65" to something drastically "newer" such as "401.1", where 401 = wow patch and .1 = current revision. So if you release a new revision it would be 401.2, and if there is a new patch and revision it would be 403.1, and so on... Alternatively at least consider changing the major version to 4 to follow along with the major WoW patch, because 2.65 sounds far too similar to all the various outdated versions of ItemRack.
Last edited by Yewbacca : 10-28-10 at 03:25 PM.
Report comment to moderator  
Reply With Quote
Unread 10-28-10, 08:12 AM  
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 275
Uploads: 9
I sent him a message too, hopefully he'll respond.
Report comment to moderator  
Reply With Quote
Unread 10-28-10, 05:49 AM  
kiki
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 14
Uploads: 1
Well... we didnt' talk. I talked, and I'm still waiting an answer.

Site administrators can't add us as authors, since Gello's projects are "all rights reserved" :x
Report comment to moderator  
Reply With Quote
Unread 10-27-10, 10:42 AM  
Yewbacca
A Murloc Raider

Forum posts: 6
File comments: 34
Uploads: 0
Originally posted by Kharthus
I believe kiki talked to Gello, but not sure when/if he's going to return.
Okay see if you can be added as co-author of ItemRack so you can update the official version directly?
Report comment to moderator  
Reply With Quote
Unread 10-27-10, 07:57 AM  
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 275
Uploads: 9
I believe kiki talked to Gello, but not sure when/if he's going to return.
Report comment to moderator  
Reply With Quote
Unread 10-27-10, 04:11 AM  
Yewbacca
A Murloc Raider

Forum posts: 6
File comments: 34
Uploads: 0
Thanks for updating ItemRack. I've known and loved Khartus's Hunter Timers for years and have full confidence that you're up to the task. Is Gello reachable? Then you can merge this with the official version and he can add you as co-author so that you can directly update the real version instead of people having to find this project.
Report comment to moderator  
Reply With Quote
Unread 10-26-10, 09:37 PM  
tutrulee
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
I looked but didn't see it in this thread and maybe I missed it. I was using ItemRack version 2.43 previously, and when I installed the update, the swapping function wasn't working for me properly. Getting rid of the ItemRack.lua files in the WTF/SavedVariables folders fixed it for me. Just wanted to put that out there. Of course I had to rebuild my sets, but a small price to pay to get it to work again. Thanks for updating the mod.
Report comment to moderator  
Reply With Quote
Unread 10-25-10, 07:26 PM  
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 275
Uploads: 9
Originally posted by jerry.a1128
Thanks for the patch
I have a problem in 4.0.1 with Login Incombat.

When I was in combat when the server is disconnected and then re-login
It's show an error for ActionButton(CreateFrame).then ActionButton Can not be used in the combat. Must be disabled the ItemRack
This is what I remember a small part of the error message.I Forget to copy error message
Sorry.My English is not good
Try to capture the error message. That's really the only way I'll have any chance of seeing how to fix it.
Report comment to moderator  
Reply With Quote
Unread 10-25-10, 10:10 AM  
jerry.a1128
A Kobold Labourer
 
jerry.a1128's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 2
Uploads: 1
Thanks for the patch
I have a problem in 4.0.1 with Login Incombat.

When I was in combat when the server is disconnected and then re-login
It's show an error for ActionButton(CreateFrame).then ActionButton Can not be used in the combat. Must be disabled the ItemRack
This is what I remember a small part of the error message.I Forget to copy error message
Sorry.My English is not good
Last edited by jerry.a1128 : 10-25-10 at 10:13 AM.
Report comment to moderator  
Reply With Quote
Unread 10-24-10, 11:08 AM  
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 275
Uploads: 9
Re: Ark inventory

Originally posted by gandhy
Hi,

I have a problem since 4.0.1 with the interaction of Ark Inventory with ItemRack

ArkInventory provides rules API to sort all kind of stuff in bags, especially sorting sets from ItemRack/Outfitter/equipment manager/... in dedicated spaces.
It works fine with Outfitter and equipment manager, nut not anymore with ItemRack.

To determine wich addon has broken this functionality, i'd like to know if your patch of 4.0.1 has changed the way sets are saved (var names/structure/... ?)

If you can highlight me about this issue, it would be awesome

Thanks!
Afaik, nothing has changed. All the changes were to fix stuff that broke in 4.0.1.
Report comment to moderator  
Reply With Quote
Unread 10-23-10, 11:26 AM  
Xeddicus
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 32
Uploads: 1
Just wanted to say thanks for the patch.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: