(10Kb)

Updated: 01-30-11 08:24 PM

Add Favorite

Install Help

Pictures

File Info

Updated:	01-30-11 08:24 PM
Created:	07-05-10 12:40 AM
Downloads:	4,154
Favorites:	44
MD5:

QuestSpamFilter

Version: v12

by: Mortilus [More]

By Myrilandell of Lothar

QuestSpamFilter was chosen as a "Pick of the Week" on WoWInterface! This is a huge honor, thank you!

QuestSpamFilter is an addon that consolidates the "quest sharing" information from 20 lines of quest sharing spam into condensed summaries. In other words, QuestSpamFilter turns this
Sharing quest with Person1...
Person2 has completed that quest.
Person3 is already on that quest.
Person4 is not eligible for that quest.
Person5's quest log is full.
Person6 is already on that quest.
Sharing quest with Person7...
Person8 is already on that quest.
Person9 has completed that quest.

into this
2 Completed: Person2, Person9
1 Not Eligible: Person4
1 Questlog Full: Person5
3 Already On: Person3, Person6, Person8
2 Sharing ...: Person1, Person7

QuestSpamFilter is localized for all languages (English (enUS), British English (enGB), Spanish (esES), Latin American Spanish (esMX), German (deDE), French (frFR), Russian (ruRU), Chinese (zhCN), Traditional Chinese (zhTW), and Korean (koKR)), though some are better than others, due to feedback . If your localization isn't perfect, give me a better translation (located in qsf_translations.lua).

Fixed an issue where the code checking for false positives was unnecessarily inefficient.
Separated the translations into their own file, so users can more easily make and share changes for their language.

Updated ToC for beta. Otherwise QSF seems to work just fine.
Fixed a bug where the initial state was not "single line".

Added Global Strings which could be incorrectly filtered by QuestSpamFilter. This should fix the filtered "X Busy: Player right now." message gotten when a player is busy and you try to trade with them.

Fixed the interface number in the toc file, it was incorrectly 30500 (should be 30300)
Fixed a missed special character in the frFR "Questlog Full" title. Thanks oXid_FoX!
Fixed a bug introduced in v8 where I'd undone stuff when creating strings for matching. This only affected non-english localizations.

Updated French translations for "Questlog Full", "Already On", and "Too Far Away". Thanks oXid_FoX!
Moved locale-specific stuff to a new file: qsf_translations.lua. This should make it easier for people to find and provide better localizations.
Encoded special characters (such as à, è, ì, ò, ù) using Lua escape sequences. That's a fancy way of saying "They should work now". Thanks to oXid_FoX for pointing this out.
Changed the code to makeFragments a bit, shouldn't change anything.
Fixed a potential bug with the "Colorize" option, where non-English clients would have incorrect output.
Changed the code wiping the tables a bit, shouldn't change anything.

Fixed the ugly code from v2.
Fixed an improperly-matching pattern in German.

Localization! The patterns I am using are the Global Strings in World of Warcraft, so I need feedback on how well this works, if it does at all (for your localization). Works fine for English and German (rather, "it *seems* to work now" :P).

Added the option to color player names in the summaries based on their class.

Added a GUI.
Added the option to add yourself to the "Already On" table. This way, if you're the kind of person that thinks, "There's 7 people in the raid, but I only shared it with 6 people ... ?", then this is the option for you!
Added the option to make the name lists begin on the same line as the consolidated title. I didn't expect to like this option nearly as much as I do. It is now the default display option.
Added the option to change the result consolidation pause duration.

Removed a debugging printout which (left in) defeated the point of the mod, or caused errors.

Fixed a bug where everything was broken. Apparently the "." character is a wildcard, so I was removing all but 2 letters in people's names. This is now fixed in an ugly but (most important) working manner.

Initial Release.

Comment Options

Page 2 of 3

08-09-10, 03:11 PM
Asteague A Kobold Labourer Forum posts: 0 File comments: 3 Uploads: 0	Code: function QSF_addon.addBetterStuff(in_string) local toReturn, numsubs = string.gsub(in_string, "%%1$s", "(%%S+)"); toReturn = string.gsub(in_string, "%%s", "(%%S+)"); return toReturn; end Could it be that you forgot to change in_string in the 3rd line to toReturn? Otherwise, the 2nd line in the code above would never really matter... Additionally it fixes the problem of not substituting "%1$s" in patterns, e.g. for the german locale.

08-08-10, 09:43 PM
Mortilus A Deviate Faerie Dragon Forum posts: 12 File comments: 207 Uploads: 7	Re: Re: Re: FR update QuestSpamFilter ought to be cata-ready, but the beta doesn't currently allow addons. Once addons are allowed on the beta i'll see how well it works and I should be able to get it working quickly. I just assumed that with patch 3.5 out, the toc also changed to 30500. I'll double check that tomorrow the ê is fixed on my end, i'll update again soon (mon or tues). Thanks for catching that oXid_FoX

08-08-10, 04:24 PM

oXid_FoX

A Deviate Faerie Dragon

Forum posts: 18

File comments: 147

Uploads: 1

Re: Re: FR update

Originally posted by Mortilus
okay, so that's why the special characters are screwy looking?

yep.

Originally posted by Mortilus So, in order to print "Terminé" correctly, I need to write it as "Termin\195\169", is that correct? é is \195\169.[/b]

correct !
either you keep special chars as they are and so you need save your file in UTF-8, either you encode them with "\195\169" and so on.
The better choice is keeping special chars: you can give strings to someone who don't know at all programming, (s)he can do the translation correctly (without encoding). And it's so much more handy when we need to reread.

edit: comments about v8 :

Code:

["frFR"] = "Journal de quêtes plein",

you forgot the accent here:
ê = \195\170

Attention about the TOC version... current live servers are on 30300, not 30500 (don't know this one. maybe the cataclysm beta?). If your addon is ready to the beta, mention it in the description page, it's a good point

Last edited by oXid_FoX : 08-08-10 at 04:51 PM.

08-08-10, 03:05 PM
Mortilus A Deviate Faerie Dragon Forum posts: 12 File comments: 207 Uploads: 7	Version 8 is out! Updated French translations for "Questlog Full", "Already On", and "Too Far Away". Thanks oXid_FoX! Moved locale-specific stuff to a new file: qsf_translations.lua. This should make it easier for people to find and provide better localizations. Encoded special characters (such as à, è, ì, ò, ù) using Lua escape sequences. That's a fancy way of saying "They should work now". Thanks to oXid_FoX for pointing this out. Changed the code to makeFragments a bit, shouldn't change anything. Fixed a potential bug with the "Colorize" option, where non-English clients would have incorrect output. Changed the code wiping the tables a bit, shouldn't change anything. I'm not positive that the special character encoding works properly, let me know of any mistakes I made.

08-04-10, 09:32 AM

Mortilus

A Deviate Faerie Dragon

Forum posts: 12

File comments: 207

Uploads: 7

Re: FR update

Originally posted by oXid_FoX
FR corrections:

Code:

["Questlog Full"] =  {	["frFR"] = "Journal de quêtes plein",
["Already On"] =  {	["frFR"] = "Déjà dessus",
["Too Far Away"] =  {	["frFR"] = "Trop loin",

Thanks for the translations

furthermore, you NEED to save files where are locales in UTF-8 otherwise special chars will not be displayed correctly. If you don't want, please at least encode them.

okay, so that's why the special characters are screwy looking?

So, in order to print "Terminé" correctly, I need to write it as "Termin\195\169", is that correct? é is \195\169. Having very quickly tested it, I think that is correct. I will be releasing v8 soon, assuming I didn't break anything with the changes.

Last edited by Mortilus : 08-04-10 at 10:28 AM.

08-04-10, 05:55 AM
oXid_FoX A Deviate Faerie Dragon Forum posts: 18 File comments: 147 Uploads: 1	FR update I suggest you to put locales out, in a separate file. FR corrections: Code: ["Questlog Full"] = { ["frFR"] = "Journal de quêtes plein", ["Already On"] = { ["frFR"] = "Déjà dessus", ["Too Far Away"] = { ["frFR"] = "Trop loin", furthermore, you NEED to save files where are locales in UTF-8 otherwise special chars will not be displayed correctly. If you don't want, please at least encode them.

07-26-10, 01:07 PM
Mortilus A Deviate Faerie Dragon Forum posts: 12 File comments: 207 Uploads: 7	Version 7 is out! Fixed the ugly code from v2. Fixed an improperly-matching pattern in German. This should fix the problem in German in v6. As always, let me know of any bugs in your localization

07-21-10, 12:05 PM
Mortilus A Deviate Faerie Dragon Forum posts: 12 File comments: 207 Uploads: 7	Version 6 is out! Localization! The patterns I am using are the Global Strings in World of Warcraft, so I need feedback on how well this works, if it does at all (for your localization). Works fine for English and German (rather, "it seems to work now" :P). This version should work for any language WoW is localized for. A big thanks to Wolf936 for all his help debugging in German!

07-16-10, 03:22 AM

Wolf936

Guest

Join Date: Not Yet

Forum posts: 0

File comments: 0

Uploads: 0

Originally posted by Mortilus
if you want to share your modifications with me, I can add them to the official release

I don't think that the global strings route will work out very well ...

I'll share them when I've tested all messages

Questlog full message doesn't work because of the german format

Last edited by : 07-17-10 at 02:42 PM.

07-15-10, 12:48 PM
excitor A Murloc Raider Forum posts: 5 File comments: 40 Uploads: 1	Bug Report Alot of text that doesn't make sence appears when someone is busy and you try to open trade with them, It's caused by this addon.

07-15-10, 10:33 AM
Mortilus A Deviate Faerie Dragon Forum posts: 12 File comments: 207 Uploads: 7	Version 5 is out! Added the option to color player names in the summaries based on their class. The only thing I can think to add to this addon is localization. If you wish to contribute a localization, please say which region the localization is for, and then provide translations for the QSF_addon.patterns and QSF_addon.title tables in questspamfilter.lua. If you have a localization, suggestion, comment, bug report, or whatever, please feel free to share it! Last edited by Mortilus : 07-15-10 at 10:34 AM.

07-15-10, 10:27 AM

Mortilus

A Deviate Faerie Dragon

Forum posts: 12

File comments: 207

Uploads: 7

Originally posted by Wolf936
Works great, thank you

if you want to share your modifications with me, I can add them to the official release

I don't think that the global strings route will work out very well ...

07-15-10, 09:16 AM

Wolf936

Guest

Join Date: Not Yet

Forum posts: 0

File comments: 0

Uploads: 0

Originally posted by Mortilus
Nope, only works for the English Client I'm working on figuring out how to use the global system messages. In the meantime, you could modify the code yourself, you should only need to open up questspamfilter.lua and then modify the QSF_addon.patterns and QSF_addon.title tables.
[...]

Works great, thank you

07-14-10, 10:02 AM

Mortilus

A Deviate Faerie Dragon

Forum posts: 12

File comments: 207

Uploads: 7

Originally posted by Wolf936
Seems not to work for the german client, but great idea

Nope, only works for the English Client

I'm working on figuring out how to use the global system messages. In the meantime, you could modify the code yourself, you should only need to open up questspamfilter.lua and then modify the QSF_addon.patterns and QSF_addon.title tables.

I can add localization options soon, right now i'm working on adding the option to color-code players in the summary (have it working with one person in party, I just want to test on a raid so I can see if it works with 10-25 people)

Last edited by Mortilus : 07-14-10 at 10:23 AM.

07-14-10, 07:10 AM
Wolf936 Guest Join Date: Not Yet Forum posts: 0 File comments: 0 Uploads: 0	Seems not to work for the german client, but great idea

Page 2 of 3

Report this File

Category Jump: