(137Kb)

Updated: 09-24-12 05:37 AM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Updated:	09-24-12 05:37 AM
Created:	12-29-09 11:31 AM
Downloads:	18,369
Favorites:	186
MD5:
Categories:	Data Broker, Auction House & Vendors, Bags, Bank, Inventory

Broker Garbage

Version: 5.0v2

by: ckaotik [More]

Have you ever been in a situation where you just can't turn in a quest because your inventory is full? Trying to figure out an item to delete that's cheap and won't make you loose much gold?
This is one of the many situations where Broker_Garbage makes your life easier.

What is it?

Broker_Garbage shows your cheapest item(s) for easily freeing bag space. It uses your auction addon of choice for pricing, including disenchant prices if available. And if you don't want to throw away that [Broken I.W.I.N. Button], put it on your Exclude List and Broker_Garbage will keep it. Forever. Really! And those [Shiny Fish Scales]? Just put them on your Include List.

This addon works as-is but you will only see the text and tooltip if you use an LDB display addon. Some are Bagnon, DockingStation, Bazooka.

Basic Features - all features can be disabled if you don't want to use them

sells junk & chosen items to vendors
repairs your items if possible
sells equipment you can't use nor trade/mail
sells equipment you're not interested in (e.g. cloth on a warrior)
supports auction values from: Auctionator, Auctioneer+Enchantrix (Auc-Advandced), AuctionLite, WoWecon
auto-detect disenchantable items
disenchant items directly from the LDB tooltip!
manage your items - Never drop, always drop, use vendor price, auto sell - using easily configurable lists (shared or character specific)
lists support single items or categories (LibPeriodicTable support)
limit items such as Light Feather
keeps statistics of gains & losses
show cheap items in LDB tooltip & customize the display text
temporarily disable the whole addon with a single button
localized in English, German and Simple Chinese (partially), works in any language

Loot Manager Features

entirely optional plugin
uses your Broker_Garbage lists
intelligent autoloot - ignore cheap items if you have no bag space
clear skinnable mobs, loot when pickpocketing and/or fishing
option to autodestroy items to loot more valuable ones
option to destroy items over their limit
restack your inventory if needed
warn for unopened clams & containers
localized in Englis, German and Simple Chinese (partially), some features might not work in other locales

Support
Do you enjoy Broker_Garbage? So do I! But keeping it up to date and supporting it takes quite a bit of time. If you feel like treating me to a steaming hot chocolate (YUM!), have a loot at the donations page

As with any addon: I provide no warranty but it should do The Right Thing(tm).
If it does not do The Right Thing(tm) or something doesn't feel right, leave me a note containing as much information on your problem as possible, so I can try to fix it.

If you have any suggestions for new features, just write a comment and I'll think about it.
Likewise, if you speak a language currently not supported please feel free to help me localize Broker_Garbage - either send a PM or simply use Curse.com.

For cutting edge updates, find Broker_Garbage on github.com. Files released there are considered 'beta' status but might yield new features or bugfixes.
Broker_Garbage @github Broker_Garbage-LootManager @github

Hints

If you temporarily want to disable Broker_Garbage, just hold down the disable key (SHIFT by default) when adressing the merchant/opening the loot window! If you never want to, just uncheck the options in the options frame.
If you don't ever want to use the Loot Manager, you can disable it in the Addon List.

If you want to quickly add an item to the "Force Vendor Price" list, simply ALT-click on it in the tooltip.
To add a category to your lists, right-click on the corresponding 'plus' icon and choose the one you want.
To set a limit for an item, put it on your Include List and use your mousewheel to set the number.

If you see a question mark icon on any of your lists, it is probably a seasonal item the server hasn't seen yet. There's nothing I can do about that.

Feel free to try /garbage (or /garb). You'll find a few (useful?) goodies in there.

For more detailed information on how things work, have a look at the readme.txt files in the addon folders.

5.0v2
- fixed 'Reset statistics' button not working
- Fixed auto repair using guild funds. The config panel read and changed the wrong variable. You might have to re-check auto repair setting on any character. Guild repair now defaults to "off".
- fixed statistics getting bloated by vendoring high-auction items
- fixed lua error caused by invalid sorting function
- fixed restack lua error on combining e.g. leather scraps
- This commit will include most recent localization data
- removed unnecessary change to LDB
- fixed list options 'add' button to actually respond to OnDrag
- fixed loads and loads of global variables
- removed unset translations from generated localizations
- removed hard embedding of LibPeriodicTable - you might want to grab LibPeriodicTable (http://www.wowace.com/addons/libperiodictable-3-1/)
- lots of toying around with curse.com's packager script
- re-introduced curse.com's localization feature

5.0v1
* Many major and minor changes, rewrites, new options and more!
* A full change log is available on Curse.com

4.0v11
* Fixed lua error in constants.lua. This was caused by Blizzard removing the old totem/sigil/libram/relic item categories. About time, aye?
* This version contains a big remake of the Loot Manager: It will now look at all the loot in the loot window, not just one at a time. So it *should* make smarter decisions.
* added hard coded check to not try to sell to "Rusty Anvil" NPC (as it messes up your statistics)
* added TopFit outdated equipment as an option (works similar to unusable gear). You will need the most recent GitHub version of TopFit for it to work
* the current config UI __still needs to be cleaned up__ so sorry for the overlapping, just bear with it

4.0v8
* Fixed auto repair setting not being saved properly
* Let's see if Curse understands what I mean ...
* added (currently hidden) option to show which item was sold. Enable with /run BG_GlobalDB.showSellLog = true
* added check for BoP items, as they can't be auctioned (no matter what your AH addon may say ;) )
* fixed bug when using "Minimum free slots" slider
* fixed error thrown when deleting (some more testing needed)
* maybe fixed "attempt to compare with nil value" error thrown when looting (some more testing needed)
* fixed Ctrl/Alt-Clicks on LDB tooltip lines not working
* updated tooltip to be a little prettier
* added option to use icons in tooltip lines
* reverted tekKonfig back to normal. Forgot to do that previously ;)

4.0v7
Caution! It is best to remove any previous version of Broker_Garbage & Broker_Garbage-LootManager before updating! (your saved variables will be safe!)
* split off all options into Broker_Garbage-Config, a load on demand addon (this saves you ~400kb of memory if you don't need the options)
* fixed Archaeology problems
* Added [itemicon] to LDB display variables
* Repairing via guild funds as guild master now works as intended
* Added Blizzard's Equipment Manager sets for list management
* Added armor classes (cloth, leather, ...) as sets for list management. Use it e.g. to automatically sell cloth on your warrior. CAUTION! This does not check if the item is soulbound or not, unlike Sell Unusable Gear!)

4.0v6
* fixed 'compare with nil' error when using Enchantrix
* fixed LPT not being properly recognized

4.0v5
* changed the way Auctioneer & Enchantrix values get retrieved. It was a whole mess before and apparently didn't even work correctly!
* changed the way auction values get treated. BG is now aware if there is more than one auction addon loaded and chooses the highest available price it can find.
* updated disenchant levels, now includes cataclysm data (all based on Wowhead.com)
* updated item caching: The new GetItemInfo() made quite a fuss
* unknown list items will now get updated when hovering
* slightly widened the right column in the statistics view
* added AddonLoader support. Default is now: delayed
* BG's tooltip will now work in NinjaPanel! It required a OnLeave() hook to be used

4.0v4
* adjust width/column count in list view automatically fixed (?)
* adjusted unusable gear table. added new "relic" class (librams, totems, sigils all count as relic as of 4.0)
* fixed error when scanning professions
* minor fix for the sell icon not updating properly when auto selling (wherever that came from)
* did some localization tweaks: typos and caution messages ;)
* once again updated LPT version
* did some localization fixes
* added some slash commands:
/garbage tooltiplines <num>
/garbage tooltipheight <num>
/garbage freeslots <number>
* adjusted GetBagSlots() to only consider general bags
* added new tags for use in LDB display text:
[basicfree], [basicslots], [specialfree], [specialslots] to split bag data
[basicbagcolor], [specialbagcolor] to colorize only data for those types of bags
* updated readme.txt on these changes

LootManager changes:
* several minor documentation / localization changes
* added panel:Update() function
* added fix for FishingBuddy not working. This is an issue caused by the LootManager's auto close feature. If you encounter other addons not working properly and you think they might rely on the LOOT_CLOSED event, try disabling this option in the LootManager's options tab. For Fishing Buddy, it is now disabled by default - when fishing only.
* hopefully fixed BoP confirmation not working: yet again, I referenced the wrong variable.
* the same goes for closing the loot window.

4.0v3
* improper column count in list options panel (most likely) fixed
* error on loading options (most likely) fixed
* removed WotLK compatibility layer as 4.0 is live
* updated TOC to proper reflect that this is a 4.0 version
* removed soul shards from default lists, as they changed completely
* removed hunter ammo from default lists (obsolete)
* included most recent LibPeriodicTable data. I hope it gets a real update soon, it's just so horribly off in some categories ...

4.0v2
* fixed promote/demote and delete on lists not working
* fixed error that occured when removing the limit of a junk item
* fixed loot window closing when it's not meant to
* fixed tooltip display for options: money format, drop treshold, sell treshold
* added global tag to "clear all" and "auto confirm bop" tooltips (it was missing before)
* added option to not automatically close the loot window
* provided option to change the Junk List's behavior: toggle between 0c value (default) and actual value (new)
* cleaned up the help panel. Texts are the same but the code is now much neater
* fishing addons not working? try FishingBuddy!

Loot Manager:
* fixed loot master messages: they should now only showing up once
* fixed permanent autoloot
* rearranged autoloot action priorities - this should fix the "loot window closes too quickly" issue in 4.0 v1

4.0v1
* fixed live compatibility (wrong variable name slipped in ...)
* fixed "attempt to compare with nil value" error: referred to the wrong saved variable

4.0v0
* restructured options:
* combined basic options, category test & loot manager into one panel, using tabs
* basic options grouped by their purpose, e.g. all the tooltip settings in one place
* loot manager grouped by their purpose
* shortened & restructured functions to show LibPeriodicTable contents, e.g. when adding a category or using category test (much in favor of my sanity)

* Basic Options changes:
* changed the way "Use in Combat" works. It will now only effect LootSlot() and CloseLoot() functions (which cause addon blocked issues), rather than disable the whole addon if it's unchecked
* clearified label texts for "Drop Treshold" and "Sell treshold". Also, these now use dropdown menus instead of a slider.
* renamed delete "instantly" to "enforce". When checked, Broker_Garbage will try its best to keep your free slots at or above your specified "Minimum free slots".
* renamed "Pickpocket" to "Stealing" in order to use progressive forms on all of these options (call it a knack of mine, if you like).
* added option "Auto-Confirm BoP". When checked, Broker_Garbage will take BoP items without showing the popup.

* Loot Manager options changes:
* removed "Enable" checkbox. Simply use Blizzard's addon manager to disable the Loot Manager
* removed "Selective Looting" checkbox. Looting will take place if any of the "Looting" checkboxes are checked. The only option that went missing without this checkbox is coloring/highlighting loot when *not* autolooting. If you don't like it, you probably don't want the Loot Manager as a whole.
* renamed "Enchanter" to "Have Enchanter" to clearify its meaning. Note please, that if you are an enchanter yourself, this checkbox is meaningless. Use it to 'tell' your Alts to not vendor disenchantable items.
* changed "Money Format" from a slider to a dropdown menu. It just makes more sense that way.

* revised former "Delete instant", see explanation above
* fixed junk items being treated incorrectly
* fixed price inflation for included items (auction prices were used, even though vendor prices should have been)

--> This release is the same as posted in the Cataclysm category. The above are all the changes that occured on that version ;) So, just to make things clear: This version of BG and the one in the Cataclysm category are *identical*

3.3v29 It took quite a while, but I hope it's worth it! Lots of file changes in here, I suggest you remove your Broker_Garbage and Broker_Garbage-LootManager folders and do a clean install (just extract, as usual)
* libraries updated
* hunters cannot use thrown weapons (fixed)
* rogues can use 1h axes (fixed)
* items with forced vendor prices will no longer be sold automatically (fixed)
* items won't inflate your statistics: fixed wrong values getting assigned to forced/listed items
* rebuilt list options
* Updated localizations to mirror these changes, e.g. lists renamed, explanation texts etc.
* Updated (re-wrote) sell icon function. No more missing icons, I hope!
* improved sell icon (texture, size ...)
* Updated default lists
* LootManager: auto-destroy settings are now local (so you can auto-destroy items on your level 15 rogue, but not on your 80 mage)
* LootManager: combat setting now also applies to looting money and closing the loot window (as it always should have)
* LootManager: simple implementation of "private loot": when opening containers in your bag, group loot rules should be ignored
* LootManager: completely re-structured selective looting procedure. The LM should now only delete items and warn of such actions if you're allowed to take that item (no more auto-deleting items for ones that are being rolled for)
* LootManager: updated quest items to always be looted
* LootManager: removed libraries, as those should already be loaded by Broker_Garbage (which is a dependency, anyway!)
* LootManager: now warns if a "Inventory is full" UI error occured
Minor changes:
* removed unnessessary event hook as well as comments
* fixed error created by slash-adding limited items that the server does not know
* fixed list manipulations that were broken because of tooltip/attribute changes (in between versions)

3.3v28
* hopefully the sell icon will now show when it is supposed to
* fixed various minor bugs
* fixed Loot Manager priorities, they got somewhat mixed up. The messages should be more fitting now.
* adjusted some localization strings
* re-inserted "use in combat" checkbox
* fixed default list creation - note that on login, BG cannot scan your tradeskills, but you can use the "default lists" button anytime to have him re-scan
* updated included LPT files
* LDB tooltip and text should now refer to the same item again
* fixed Loot Manager saved variables bug. some settings were requested before they were initialized

3.3v27
* deathknights cannot wear shields. fixed
* fixed items on sell list not selling
* added option to use include list as sell list
* inventory scanning rewritten - will now only scan updated bags, and item info is cached <-- this is worth about 10 minor features and 100kB memory per scan saved
* Broker_Garbage-LootManager: Changed the way 'Warn Clams' and 'Warn Containers' work - they will now show a line in the tooltip
* refined security checks when deleting items
* changed the license from GPLv2 to BSD, mainly because it does all I really need and is much less painful to read ;)
* fixed the bug where BG would go nuts after visiting a merchant once
* many thanks to Zidomo and Cidrei for elaborate testing!

3.3v26
* scanning will now work properly again (I deleted 2 lines that shouldn't have been deleted)
* finally found why Sell Gear would not work - fixed! Gear would only get sold if the global threshold was greater than the Sell Gear treshold, which was not intended.
* BG_LootManager: removed unnessessary saved variables
* Notice: BG_LootManager won't be able to work with the CTRL disable key as CTRL+Click is already connected to the dressup functionality

3.3v25
* made Auto Repair more intelligent: It will tell you if you don't have enough money to repair
* removed /garbage stats slash command - the options panel provides the same information and more (and prettier)
* fixed BG trying to get item values before auction addons are loaded
* fixed the error that was caused by a debug message if you didn't have any junk on you
* changed the format of localization files to support partial translations
* fixed /garbage format reset that would still reset to the old display format

3.3v24
* fixed Sell Gear not selling items (at all)
* fixed tabards not being sold by Sell Gear
* fixed (manual) selling via the tooltip when at a vendor: items without a value will be deleted instead of trying to sell them (which would result in 'The vendor is not interested in this item' error)
* Create Default Lists button fixed. Left-click it to create character specific list entries
* loot window will not be automatically closed if you can't loot something because of missing bagspace (which made it really hard to actually loot the item manually)
* changed plugin handling
* added supported auction addons to .toc file
* updated LibQTip library

3.3v23 Hopefully fixed the 'Addon blocked' issue.
Added an options panel to test category strings. Updated some of the libraries.
Renamed 'Drop Quality' to 'Quality Treshold', 'Positive lists' to 'Whitelist' and 'Negative lists' to 'Blacklist'.
Added button to load default list options.

3.3v22 (Patch 3.3.3) Things fixed:
When 'Never repair guildbank' is checked, Broker_Garbage will now not touch your guild funds any more.
The tooltip may now show more than one stack of any item.
Solved Autosell list priority conflicts: ItemIDs have higher priority than LPT strings.
LootManager turned more talkative. Now uses proper localization strings.
New feature: Sell unusable equipment. This will for example sell plate if you're a clothie, the item is soulbound and you yourself can't disenchant.

3.3v21 several bug fixes, including: Missing enchanting values für > epic items, included tekKonfigDropdown, statistical data gathering cleaned up, Autosell bug when having excluded items in the inventory, display of over-treshold Autosell items ...
New features: Changed the way you may edit the LDB display text, the question mark will help you with (re)configuration. (to lessen lua errors caused by wrong input)
Added possibility to colorize the LDb display text according to your bag situation ([bagspacecolor] ... [endcolor]
You can now use [junkvalue] in the LDB display text, which will show what your junk/Autosell stuff is worth.
SHIFT-Click on the tooltip/the LDB when at a merchant will now sell the item, rather than destroy it.

3.3v20 Split Broker_Garbage basic addon and Broker_Garbage-LootManager into two addons. Fixed some bugs and auction value calculation.
Update: Stupid debug...

3.3v19 Non-limited but included items will be handled properly once again. Same goes for Auto Sell List items.

3.3v18 Autodestroy fixed, fixed promoting limited items

3.3v17 Added the Loot Manager! It uses your Include (never loot) and Exclude List (always loot). to disable it, read the description or the readme.txt.
Added item limits! Want to keep no more than 5 Soulshards? Simply use your mousewheel on the corresponding icon on your include list. Items within that limit will not be shown on the tooltip.
Finally 'fixed' the Sell Icon - it will now properly show if there's something to sell - or not.
Also added some default list settings.
Fixed quite a hand full of bugs, too. Simplified code.

3.3v16 LDB display text option added to interface options panel. Statistics panel added. Fixed a bug where dragging items to the plus icons didn't work. Fixed a bug that caused too many items to appear in the tooltip. Finally found & fixed the bug that made you open positive lists before negative lists ;)

3.3v15 /garbage commands added, LDB text made more customizable, 'pre' errors fixed. Birthday-to-be edition.

3.3v14 Added compatibility to Broker2FuBar. Category list menu reduced to interesting parts. Auto Sell Icon will now do its job.

3.3v13 Addid items to lists possible - once again. No more "LeftButton" added to any list. Fixed icons not updating if GetItemInfo was missing

3.3v12 Auto sell settings will now, once again, be properly saved. This fixed the checksound-error as well. Or is it the other way around? :P

3.3v11 Added LPT support - you can add categories to your lists by right clicking on the 'plus' icons. For more info, have a look at the readme.txt . There might still be bugs in there, but I didn't find any ;) Therefore tagging as beta (to keep the files consistent to curse.com's version).
Update: Told you, there would be bugs! Fixed desaturating icons. Fixed missing items crashing the addon (GetItemInfo on seasonal items sucks).

3.3v10 Bugfixes, once again. And no, an itemLink is NOT the same as an itemID ~.~ New lists should work properly now. Reset money earned/lost will now properly reset the local value, rather than the global one.

3.3v9 list management clarified, more lists added (have a look at the options or the readme file): Force Vendor Price & Auto-Sell. New: ALT-Click on an item in the tooltip and it will be added to your Vendor Price List.

3.3v8 no new features, just a bunch of bugfixes ... stupid stupid Macs ... hate them!

3.3v7 LDB plugin clicks should work for all displays, added "money earned" to tooltip info, shows "no items" instead of empty tooltip, show (or hide) icon to manually sell grays at a vendor

3.3v6 LDB plugin will now properly react to clicks. List Options should display properly

3.3v5 stupid me -.- left debug mode on ... should probably write a pre-release checklist or something. Indeed, I should. Missed something on the include list management.

3.3v4 Tooltip! Corrected auto-hide time, should(tm) work.
Interface! Added options menu to handle include/exclude lists. No more guessing what might be on there!

3.3v3 another try at fixing sticky tooltips (by having the LDB display having the work of hiding the tooltip, not the plugin)

3.3v2 deDE localisation fix, money chat message changed

3.3v1 first upload

Optional Files (0)

Comment Options

Page 13 of 18

« First

Last »

04-01-10, 08:22 PM
Zidomo A Cliff Giant Forum posts: 76 File comments: 1046 Uploads: 0	Gave the GitHub build a36ff3b of core.lua a try (the one that includes your suggested line change). It doesn't work either. Ran another instance, picked up another unusable rare item (leather helmet). Trying the sell button at vendor, the helmet never sold or showed up in the tooltip. Switched it to auto-sell and it didn't sell either.

04-01-10, 04:32 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by Zidomo
3.3v23, WoW 3.3.3a live, on a 80 Priest character. Problem with the Sell Gear function.

Ah, I see. Guess I forgot to add this to the variable that determines if you can use the sell button, or not. Sorry about that, must have missed it because I personally use the auto sell feature

Fixed it on GitHub. Get it there or just change line 682 in Broker_Garbage/core.lua from "isVendor = true" to "isSell = true".
I'm currently busy (three more exams next week), so just tell me if it still doesn't work as I've got no time to test it.

__________________
It all starts to make a creepy kind of sense. Avatar

Last edited by ckaotik : 04-01-10 at 05:28 AM.

04-01-10, 03:34 AM
Zidomo A Cliff Giant Forum posts: 76 File comments: 1046 Uploads: 0	3.3v23, WoW 3.3.3a live, on a 80 Priest character. Problem with the Sell Gear function. Have Sell Gear checkmarked and the Max. Quality slider set to Epic. Do a heroic instance that has no enchanter in party, win Fist of the Deity (which a Priest cannot use/equip). It has not previously been put on The Whitelist/Exclude list and is not there now. It does not show up in the Broker Garbage tooltip. But also, opening a vendor (having not picked up any gray junk during the run), the Garbage sell button is grayed out. The unusable Rare item cannot be dropped or sold by Broker Garbage. Then go back into options and click Rescan Inventory. Same thing, no change. Finally click Create default lists. Same thing, no change.

03-31-10, 04:44 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by lodewijk
i have experienced the same problem. for now i have gone back to the previous version untill it is fixed.

Are you using the most recent version? Which LDB display do you use? What exactly are you doing? Leftclick, rightclick, when at a vendor or not, on the LDB itself or on the tooltip ... ?
I tried this on my own machine but didn't find any defect. It never once equipped an item for me (well, it's not supposed to do so, anyway).

__________________
It all starts to make a creepy kind of sense. Avatar

03-31-10, 02:12 AM

lodewijk

A Deviate Faerie Dragon

Forum posts: 13

File comments: 120

Uploads: 0

Originally posted by Chmee
Just found this, and have been trying it out. I like it so far, but I had an interesting problem last night — I would shift-click on something to delete it, but instead of deleting it, it would be swapped with my equipped gear (when it was some piece of gray gear I was trying to delete). I didn't lose anything, but it was a bit scary, until I figured out what was going on. And I still don't know why it was doing it. There were no lua errors, for example.

i have experienced the same problem. for now i have gone back to the previous version untill it is fixed.

03-30-10, 09:58 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by Chmee
I would shift-click on something to delete it, but instead of deleting it, it would be swapped with my equipped gear (when it was some piece of gray gear I was trying to delete).

Hrm, that sounds strange. Would you mind trying out 3.3v23 and telling me if it helps or not?

@SkunkWerks: I found the problem you talked about. When you report something again, please provide a little more information

The 'Addon blocked' popup was caused by some cheap (and therefore insecure) hooking on my part and would only occur if you tried to loot in combat and afterwards wanted to delete something.
You will still get a message in your chatframe when looting in combat for the first time, but it should not break the addon anymore.

@Zidomo: I changed the scanning of unusable gear. Therefore now both tresholds will be used - the basic 'Quality Treshold' option to decide if the item will be shown in the tooltip and the 'Max. Quality' (belonging to 'Sell Gear') to decide if the item will be sold.
Also, the category test panel might help figuring out why items appear where the appear

__________________
It all starts to make a creepy kind of sense. Avatar

03-29-10, 11:57 PM
Chmee A Molten Giant Forum posts: 960 File comments: 18 Uploads: 0	Just found this, and have been trying it out. I like it so far, but I had an interesting problem last night — I would shift-click on something to delete it, but instead of deleting it, it would be swapped with my equipped gear (when it was some piece of gray gear I was trying to delete). I didn't lose anything, but it was a bit scary, until I figured out what was going on. And I still don't know why it was doing it. There were no lua errors, for example.

03-28-10, 05:08 PM
ckaotik A Fallenroot Satyr Forum posts: 29 File comments: 168 Uploads: 5	If you'd like to see those promised features, but can't wait for me to upload them here, you can get beta style versions here: BrokerGarbage (w/o LootManager), LootManager plugin. These are updated frequently and may contain bugfixes/improvements which are not "big" enough yet to get a new release here. To anyone, I highly encourage you to make use of the default list entries. If you didn't already use them (they've been included since 3.3v17), you can get them by using the 'Create default lists' button in the options (currently only available in beta versions). This will give you some suggestions what may be put on which list. Make sure to re-check you lists afterwards and also add any other entries you like. Now, Zidomo. There are various ways to not have an item getting sold by Broker_Garbage. These include: put the item (or item category) on your exclude list disable 'Sell Gear'. Simple, but works. No selling will be done. make sure it's not on your 'Auto Sell' list To have these items not show up on the tooltip, there are also several possiblities: put the item (or item category) on your exclude list set Broker_Garbage's 'Drop Quality' (poor naming. new: 'Quality Treshold') below that of the item in question make sure the item is not on your Include List I see absolutely no reason to provide yet another set of options, lists or whatever to do exactly this. It just overcomplicates things. There is also no need to just "guess" what Broker_Garbage might want to do as it just does what it is told. Have a look at the tooltip, it will show you only suggestions. Broker_Garbage doesn't do a thing if you tell it so, by default it sells Junk items (gray quality) and shows - only shows - cheap items. If your treshold is high enough and an item is cheap enough, it will eventually show up on the tooltip (to prevent this, see above). When you have 'Sell Gear' disabled, that is what it means: Broker_Garbage will not sell your unusable gear. If you have it enabled, though, it will sell only soulbound, unwearable gear (that excludes for example trinkets and stuff you class can wear, like shields for warriors) in case you're not an enchanter. If you still feel something gets on your tooltip that shouldn't, enable 'Show Source' to see where Broker_Garbage gets its value and why it puts the item on there. Explanations on those "codes" can be found in the readme.txt . __________________ It all starts to make a creepy kind of sense. Avatar Last edited by ckaotik : 03-28-10 at 05:11 PM.

03-28-10, 01:34 AM

Zidomo

A Cliff Giant

Forum posts: 76

File comments: 1046

Uploads: 0

Originally posted by ckaotik
Working on that... Probably due to the fact that those are faction arrows and are therefore soulbound. You can throw them out there by adding the ammo category to your exclude list That's what the list is for. Broker_Garbage only suggests cheap items, no matter if you need them or not. That's why setting up your lists properly is so important.

Yes. The exclude list isn't enough, though. With that list only, have to coordinate what you _think_ Broker Garbage might assign as a "Sell Gear" item with what it really will assign...heh. Large potential for selling stuff you didn't want it to. Despite the vendor buyback in the same session, the possibility exists for losing stuff you didn't want to.

As mentioned previously: hopefully the next version will completely exclude on its own any such items from appearing in the tooltip if "Sell Gear" is not turned on. And (better) include a built-in "black list" of soulbound+crafted/faction items that will never be sold unless you specifically add them to the "always sell" list.

Another way to go: add a selectable option for "confirmation-before-selling" (a popup box, etc.) that can be enabled for selling things at various quality levels.

For example, set it to pop up on "rare" or higher vendor-sells. The popup box would have "yes" and "no" buttons that would need to be pressed before anything happened. Similar to vendor-buy confirmation that exists in some reagent-buying mods like BuyDropper. It wouldn't replace the above options, but would also help make things safer.

Last edited by Zidomo : 03-28-10 at 03:09 AM.

03-27-10, 06:46 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by Ookami.kun
Since v21 whenever I obtained any trash items in my bag the LDB display on my bar would look like below. If I downgraded to v20 the issue didn't occur. I was hoping it might be fixed with this new release, but what ever the issue is, it's still there.

Well, have a look at the changelog:

3.3v21 [...] New features: Changed the way you may edit the LDB display text, the question mark will help you with (re)configuration. (to lessen lua errors caused by wrong input)

Just reset your LDB display string (options panel -> basic options, the 'x' at the bottom right). Said this about 4 comments earlier, too.
And yes, I'll do something about that in the next release.

Originally posted by Ookami.kun
Also, any clue why my Timeless Arrows are coming up as garbage?

Working on that... Probably due to the fact that those are faction arrows and are therefore soulbound. You can throw them out there by adding the ammo category to your exclude list

That's what the list is for. Broker_Garbage only suggests cheap items, no matter if you need them or not. That's why setting up your lists properly is so important.

You can get some basic list settings (including ammo if you're a hunter) by running this on all relevant characters:

Code:

/run BrokerGarbage:CreateDefaultLists()

This will add some default entries to your lists. It will usually be called if you don't have any saved variables yet, but for users that have had the addon quite some time now, it won't trigger automatically so just use the code above. In its current implementation, though, it might overwrite some of your global settings (it adds "20 Soulshards" as an entry, for example). I'll have a button and some clean up for that in the next release, too.

__________________
It all starts to make a creepy kind of sense. Avatar

03-26-10, 05:40 PM
Ookami.kun A Cliff Giant Forum posts: 79 File comments: 238 Uploads: 0	Since v21 whenever I obtained any trash items in my bag the LDB display on my bar would look like below. If I downgraded to v20 the issue didn't occur. I was hoping it might be fixed with this new release, but what ever the issue is, it's still there. Also, any clue why my Timeless Arrows are coming up as garbage? Thanks __________________

03-26-10, 12:24 PM

Zidomo

A Cliff Giant

Forum posts: 76

File comments: 1046

Uploads: 0

Originally posted by SkunkWerks
Since the last update, this seems to be triggering the dreaded "this addon has performed an action reserved only for the Blizzard UI" thing. Makes it pretty much impossible to delete anything from the tooltip.

Something is tainting; I haven't seen this with Broker Garbage 3.3v22.

To get a better ideas of what is tainting, use the following command ingame, exit and restart:

Code:

/console taintLog 1

Or add

Code:

SET taintLog "1"

to the \WTF\config.wtf file.

When it happens again, exit WoW, head to \World of Warcraft\Logs and look for a taint.log file. The info contained in it will help to determine what is causing the taint. But unlike regular mod errors, sometimes the mod(s) mentioned in that log have no connection at all to what is causing the taint.

Originally posted by ckaotik
This is intended if your drop treshold is at least uncommon. If it is not, though, that's easy to fix and will be included in 3.3v23. Unusable items are those you will never be able to wear. Tradeskill/level requirements are not considered when it comes to this.

Nope, drop/sell threshold for non-""Sell gear" items is set to the lowest: Poor. So hope to see a fix.

Originally posted by ckaotik
You would not possibly be using the sell button to sell (rather than autosell), are you? This message is a relic (and therefore uses the wrong variable) and will also be changed in 3.3v23.

Yes, using the vendor-sell button. Sorry, forgot to include this info.

Originally posted by ckaotik
I suspect the stone showed up because you were not using it, i.e. it lying in your inventory. BoP items will be considered the same as any other item, BG tries to find the best value (which is vendor if you can't disenchant) and therefore if your drop treshold is high enough, it will show up on the tooltip, whether you use 'Sell unusable gear', or not.

Yes, wasn't using the item, it was in a pack. That methodology is makes it more "dangerous" to use as well as more of a hassle.

A built-in blacklist for items such as that would remove some of the danger/hassle. Other such items I can think of offhand include enchanting rods (Runed Eternium Rod, etc.) & Jewelcrafting trinkets (Figurine - Monarch Crab, etc.). There may be others.

As well as my suggestion to keep all BOP items or items above your regular drop/sell threshold out of the tooltip when Sell gear is disabled. As noted above, the regular drop/sell threshold was set to Poor.

03-26-10, 05:29 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by SkunkWerks
That's the one I'm encountering. As far as I can tell, it's nothing to do with item type either. I can't use it in this condition.

Well, when does it happen, what do you do - click the LDB, click the tooltip - is it infight or our of fight, do you use other addons that could cause a conflict etc ...
Are you sure this is because of Broker_Garbage? Maybe test with just BG and an LDB display enabled? Which LDB display do you use?

__________________
It all starts to make a creepy kind of sense. Avatar

03-26-10, 05:00 AM

SkunkWerks

A Fallenroot Satyr

Forum posts: 21

File comments: 239

Uploads: 1

Originally posted by ckaotik
But I never once encountered the popup telling you to disable/ignore the addon - this one would indeed break the functionality.

That's the one I'm encountering. As far as I can tell, it's nothing to do with item type either. I can't use it in this condition.

03-26-10, 04:35 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

I haven't quite had the impression it makes the addon useless. Yes, sometimes you may get a chat message telling it couldn't do as it wished (dunno what the message is in English, as I'm in a german client), probably due to in-combat scanning and the likes. But I never once encountered the popup telling you to disable/ignore the addon - this one would indeed break the functionality.
There currently is a bug though which is connected to items without a value (like conjured water). Other than that it works fine for me ... so I don't quite know how to help you there

Originally posted by Zidomo
See that unexpectedly, in addition to some (proper) grey fur scraps being listed in the LDB tooltip, there is also a Mercurial Alchemist's Stone listed there that he's carrying (he is an Alchemist and can use that).

This is intended if your drop treshold is at least uncommon. If it is not, though, that's easy to fix and will be included in 3.3v23. Unusable items are those you will never be able to wear. Tradeskill/level requirements are not considered when it comes to this.

Originally posted by Zidomo
More oddly, head to a vendor to sell, the fur scraps (only) are sold, but the text feedback from Broker Garbage states that I've received cash from the sale of that blue item. Despite the fact it was not sold.

You would not possibly be using the sell button to sell (rather than autosell), are you? This message is a relic (and therefore uses the wrong variable) and will also be changed in 3.3v23.

Originally posted by Zidomo
Maybe don't include BOP items in the sell/drop list if you have the Sell gear option turned off? Or make (yet another) option to allow it--if the user wants--to stay in the tooltip so it can be deleted while at the same time not being sold via the mod at a vendor.

I suspect the stone showed up because you were not using it, i.e. it lying in your inventory. BoP items will be considered the same as any other item, BG tries to find the best value (which is vendor if you can't disenchant) and therefore if your drop treshold is high enough, it will show up on the tooltip, whether you use 'Sell unusable gear', or not.

Your descriptions are quite detailed, as always

It helps with finding the errors, though, so this is a good thing.

__________________
It all starts to make a creepy kind of sense. Avatar

Page 13 of 18

« First

Last »

Like Broker_Garbage? Feel free to buy me a drink (yummy, hot chocolate!)

Every donation is highly appreciated!

Report this File

Category Jump: