r42 | robin | Fri, 30 Oct 20 10:59:35 +0100
Changed paths:
M /trunk/zz_MiscHelper/core.lua
Fix childName/name mixup
------------------------------------------------------------------------
r41 | robin | Fri, 30 Oct 20 10:47:25 +0100
Changed paths:
M /trunk/zz_MiscHelper/core.lua
Make OnClick mandatory for zz
------------------------------------------------------------------------
r24 | robin | Fri, 30 Oct 20 10:46:21 +0100
Changed paths:
M /trunk/zzLibCommon/Common/ldb.lua
Make OnClick mandatory for zz, remove default click function
------------------------------------------------------------------------
r23 | robin | Thu, 15 Oct 20 00:38:45 +0200
Changed paths:
M /trunk/zzLibCommon/Common/ldb.lua
Adjust clickevent
------------------------------------------------------------------------
r22 | robin | Thu, 15 Oct 20 00:15:18 +0200
Changed paths:
M /trunk/zzLibCommon/Common/ldb.lua
Use self for OnClick
------------------------------------------------------------------------
r21 | robin | Wed, 14 Oct 20 23:47:56 +0200
Changed paths:
M /trunk/zzLibCommon/Common/ldb.lua
Add 'OnEnter', 'OnLeave'
------------------------------------------------------------------------
r20 | robin | Wed, 14 Oct 20 20:23:57 +0200
Changed paths:
M /trunk/zzLibCommon/Common/ldb.lua
Add 'iconCoords'
------------------------------------------------------------------------
r19 | robin | Wed, 14 Oct 20 16:43:14 +0200
Changed paths:
M /trunk/zzLibCommon/Common/ldb.lua
Add GetLDB
------------------------------------------------------------------------
r211 | nevcairiel | Tue, 13 Oct 20 12:33:04 +0200
Changed paths:
M /trunk/LibBabble-Inventory-3.0.toc
Update for WoW 9.0
------------------------------------------------------------------------
r40 | robin | Tue, 06 Oct 20 18:02:04 +0200
Changed paths:
M /trunk/zz_MiscHelper/core.lua
Disable autorepair by default
------------------------------------------------------------------------
r18 | robin | Sun, 04 Oct 20 22:38:24 +0200
Changed paths:
M /trunk/zzLibCommon/Common/ldb.lua
Allow parent addon to set 'modsDir' for embedded addons.
------------------------------------------------------------------------
r17 | robin | Sun, 04 Oct 20 22:37:12 +0200
Changed paths:
M /trunk/zzLibCommon/Common/common.lua
Expand HandleFuncList with arguments
------------------------------------------------------------------------
r39 | robin | Sun, 04 Oct 20 17:04:09 +0200
Changed paths:
M /trunk/zz_MiscHelper/Moduls/autogroup.lua
M /trunk/zz_MiscHelper/Moduls/autoport.lua
Fix for moved spells
------------------------------------------------------------------------
r16 | robin | Sat, 03 Oct 20 17:40:34 +0200
Changed paths:
M /trunk/zzLibCommon/Common/frames.lua
Create OnUpdate only once
------------------------------------------------------------------------
r15 | robin | Sat, 03 Oct 20 09:16:57 +0200
Changed paths:
M /trunk/zzLibCommon/Common/frames.lua
Fix visible dragbar after alt-tab to desktop
------------------------------------------------------------------------
r38 | robin | Mon, 28 Sep 20 16:49:41 +0200
Changed paths:
M /trunk/zz_MiscHelper/zz_MiscHelper.toc
------------------------------------------------------------------------
r37 | robin | Mon, 28 Sep 20 15:40:51 +0200
Changed paths:
M /trunk/zz_MiscHelper/zz_MiscHelper.toc
Update Toc 90001
------------------------------------------------------------------------
r14 | robin | Sun, 27 Sep 20 21:34:13 +0200
Changed paths:
M /trunk/zzLibCommon/Common/common.lua
Remove preloads, inits after startup
------------------------------------------------------------------------
r1239 | nevcairiel | Sun, 20 Sep 20 12:22:02 +0200
Changed paths:
M /trunk/AceGUI-3.0/widgets/AceGUIWidget-DropDown.lua
AceGUI-3.0: DropDown: Anchor all items to the dropdown frame instead of chaining anchors, fixes anchoring on WoW 9.0 with many items
------------------------------------------------------------------------
r13 | robin | Mon, 07 Sep 20 18:22:05 +0200
Changed paths:
M /trunk/zzLibCommon/Common/config.lua
Originally posted by Rilgamon hehe, without ppl complaining I'd think nobody cares
Complaining means there must be something right ... sounds stupid, I know
Actually it makes perfect sense - silence is far worse than feedback.
EDIT: Works great now! Thanks for your rapid responses!
I really like this addon as it handles accepting / performing many of the menial tasks. However, I was wondering if the auto-repair could be updated to use guild funds when available.
dude your mischelper broker had me dyin'!!! reading through what it does makes me think you were some dude who got hella peaved at little things in the game that you decided to make a mod that fixes them.... ALL AT ONCE!! lolz, no but i do use your repair broker, Thanks!!
The auto greed/disenchant wasn't working 100% for me (and didn't handle epics from new 5 mans) so i modified the code to only popup a need/greed/disenchant window when i could need on the item or it was a BoE blue or purple. Here is the changes to autogreed.lua:
Code:
local function START_LOOT_ROLL(event,id,...)
if (not id) then return end
local _, _, _, quality, bop, canNeed, _, canDE = GetLootRollItemInfo(id)
if(quality == 2 and not bop) then
RollOnLoot(id, canDE and 3 or 2)
elseif(quality == 3 and bop and not canNeed) then
RollOnLoot(id, canDE and 3 or 2)
elseif(quality == 3 and not bop and not canNeed) then
RollOnLoot(id, 2)
elseif(quality == 4 and bop and not canNeed) then
RollOnLoot(id, canDE and 3 or 2)
elseif(quality == 4 and not bop and not canNeed) then
RollOnLoot(id, 2)
end
end
Looks good, I found a bug in my initcode that I want to fix before I push a new release so it will take a little before you'll see this included.
Additionally I'd like to add an itemlevel trashhold to disenchant eg za/zg epics even if you can use them.
__________________
The cataclysm broke the world ... and the pandas could not fix it!
Yeah you could make the options quite extensive/complicated.
Like you said the item level - but also greed if it vendors over a certain amount (usually weapons) rather than DE it.
As an option though it would be useful to have the DE (if available) as an option rather than as part of the same configuration option.
As far as the item level things goes .. that could be a tricky thing to always get right. You would want to compared it to your current equipped gear i suppose .. what about off specs .. or if you want to collect gear for a future spec. you could turn the option off i suppose. Is it trying to do doing too much?
hehe, good ideas ... but I fear that would be overkill for a simple module of misc helper I'll try to steal some hours to check what can be done and what not this weekend
__________________
The cataclysm broke the world ... and the pandas could not fix it!
damn ... I tried to implement the canNeed part and found that you can need everything in a guildgroup even plate as a priest ... back to the drawingboard
__________________
The cataclysm broke the world ... and the pandas could not fix it!
A new version is pending and should work for random groups. A trashhold is not yet added so it will popup for loot you can need even if its way too low to be usefull
__________________
The cataclysm broke the world ... and the pandas could not fix it!
Ok, going through the options and code to work out what is what.
In the config: i see the new autogreed tab, but on the zz_MiscHelper tab there are the options 'AutoGReed Runed Orb/Choas Orb' and 'Greed or disenchant blue and green'.
The order of the config options in 'autogreed' tab makes it confusing as to exactly what is going to happen and this needs to be clear to know what to select.
So in a rough order/logic that it evaluates
The setting 'ignoreOrbs' makes the addon to show orb roll (no tooltip on this config item)
The setting 'Skip Need' need will show the roll for BoP items that you can need.
If BoP then
it will auto pass according to the 'Pass green/blue/epic BoE' check boxes
(this includes ones i can need on)
else
if i can need on it show roll window if better quality item than on slider and i set 'Skip Need'
if i set 'Greed BoE' then show if i set 'pass green/blue/epic BoE' or green and can DE (not sure about this as lua is not my native language)
else
.. not sure what your trying to do here ..
Anyway .. seems some options are confusing as you describing them as to what the addon is seeing them as not what the player is seeing them as. ie/ 'Skip Need' is 'Show Need'
Also things like if it is a BoP -BUT- i can need it then i may not get to need on it regardless of the 'Show/Skip Need' setting.
Hope you can see what i mean.
Some suggestions - and please take these as you will - done a fair bit of coding/program design in my time - but out of the industry now
I would have put the options in an order that code a structure to the internal logic.
So put the an option like 'Auto Greed Orbs' (in tooltip put somethign like 'Auto Greed Runed and Choas orbs') at the top.
call your need option 'Show Need Rolls' (tooltip something like 'Show rolls i can need on that are of the selected quality or better') and have a scale after that if you want for 'min quality'
call an option 'Show BoE rolls' (tooltip something like 'Show Bind-on-equip rolls that are of the selected quality or better')and have a separate min quality slider.
the logic then falls through to a catch all which would be to in reality Auto DE if possible, Auto Greed, Auto Pass or Show Loot Rolls. Given Auto Pass on Loot is an option that Blizz provides you can loose that option so it is really Auto Greed then another option Auto DE if possible.
(i dont mind coding these up if i get time but atm i am doing house renovations so not lots of time)
ignoreOrbs is included so that orbs can be handled by the greedorbs-module.
As you could roll need on them before 4.3 I added a choice which would fail if the autogreed-module was quicker to greed them. Not sure yet what I'll do of it now that you can roll greed only (need only in a guildgroup).
I'll go through the lines and explain what I try to do
Line 1: Allows other modules to decide what to do with the orb.
Line 3: This will show BoP if you can need them and have enabled skipNeed.
Line 4: arg1 is repsonsible for the disenchanting if possible and arg2 is the greed part.
Line 6: Handles BoP that are not handled by 3 so here we just check if you decided to pass for this quality or disenchant/greed.
Line 8: This will show BoE if you can need them above the selected showBoE-Value.
Line 10: Greed if you not enabled to pass for this quality. And a special case for green items to always disenchant/greed even if you can need it.
Line 12: Handles automated DE,Pass,Greed when you decide to not greedBoE.
I think this should cover all possible cases so far
__________________
The cataclysm broke the world ... and the pandas could not fix it!