Go to Page... |
Compatibility: | Chains of Domination (9.1.0) |
Updated: | 04-04-21 01:44 AM |
Created: | 05-02-09 11:08 PM |
Downloads: | 115,521 |
Favorites: | 619 |
MD5: | |
Categories: | Character Advancement, Map, Coords, Compasses |
QuestGuru is a Quest Log Enhancer.
If you are looking for the "Classic" version of QuestGuru click QuestGuru_Classic
I have split off QuestGuru and QuestGuru Sounds into two separate addons that don't rely on each other so that the community that really missed the sounds can have them with me delaying them because of the qork being done on QuestGuru. I hope this makes at least some people happy.
You can click > QuestGuru Sounds
Note: If you like this addon, please "Like it" on Curse.com.
All Donations support me and I thank you in advance for it.
Features include:
Comment Options |
Shareel |
View Public Profile |
Send a private message to Shareel |
Find More Posts by Shareel |
Add Shareel to Your Buddy List |
10-31-13, 01:52 PM | |
A Kobold Labourer
Forum posts: 0
File comments: 16
Uploads: 0
|
Cant really help with the achievement tracker as i know nothing about lua but this is the error i get when using portals, hearthstones etc. This is only having Questguru installed & no other addons.
Once this happens i have to log off & back on to get it working again as the tracked achievements are just totally stuck. They do not update with progress & i cannot click them or do anything, however, the rest of Questguru (log etc) still work fine after the error. Message: ...erface\AddOns\QuestGuru_Tracker\QGT_Achievements.lua:626: attempt to perform arithmetic on local 'j' (a nil value) Time: 10/31/13 19:45:30 Count: 1 Stack: ...erface\AddOns\QuestGuru_Tracker\QGT_Achievements.lua:626: in function `QGT_AchievementWatch_Update' ...rface\AddOns\QuestGuru_Tracker\QuestGuru_Tracker.lua:536: in function <...rface\AddOns\QuestGuru_Tracker\QuestGuru_Tracker.lua:514> [C]: in function `WatchFrame_Update' Interface\FrameXML\WatchFrame.lua:312: in function <Interface\FrameXML\WatchFrame.lua:247> Locals: achieveCount = 1 i = nil j = nil numEntries = 22 numQuests = 12 questCount = 0 _ = nil self = QGT_AchievementWatchFrame { 0 = <userdata> } numTrackedAchievements = 1 maxWidth = 0 heightUsed = 0 heightNeeded = 0 achievementID = 7308 achievementName = nil completed = nil description = nil icon = nil line = nil currLine = 0 achievementTitle = nil previousLine = nil nextXOffset = 0 linkButton = nil numCriteria = nil criteriaDisplayed = nil criteriaString = nil criteriaType = nil criteriaCompleted = nil quantity = nil totalQuantity = nil name = nil flags = nil assetID = nil quantityString = nil criteriaID = nil achievementCategory = 15110 achieveLine = <table> { 0 = <table> { } } watchLines = 40 sliderVal = 0 iconWidth = nil yOffset = nil titles = 0 statusBars = 0 yOffset = 0 xOffset = 0 (*temporary) = 0 (*temporary) = 0 (*temporary) = 1 (*temporary) = <function> defined @Interface\AddOns\QuestGuru_Tracker\QuestGuru_Tracker.lua:514 (*temporary) = <function> defined @Interface\AddOns\QuestGuru_Tracker\QGT_Achievements.lua:347 (*temporary) = 0 (*temporary) = nil (*temporary) = nil (*temporary) = true (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = "attempt to perform arithmetic on local 'j' (a nil value)"
Last edited by Reeb : 10-31-13 at 02:35 PM.
|
|
Reeb |
View Public Profile |
Send a private message to Reeb |
Find More Posts by Reeb |
Add Reeb to Your Buddy List |
10-31-13, 09:58 AM | ||
|
Patch the patch
Did whoever even test this with the popular AddOns? I mean, Titan Panel is not exactly a rarely used AddOn. I find it odd that on the forums that nobody mentioned switching to securehook functions as a solution to the taint issue. That won't work for everybody (and shouldn't be necessary anyway) but it did work for me. -g |
|
|
Gregity |
View Public Profile |
Send a private message to Gregity |
Find More Posts by Gregity |
Add Gregity to Your Buddy List |
10-31-13, 09:48 AM | |
|
WorldMap ?? not me...
QuestGuru doesn't use WorldMap and hasn't for a long time. Some of the Original code from Mr. Obrien has some WorldMap references, but those have been removed from the AddOn for a couple of years now.
Just to make sure, I did a content search on "WorldMap" and came up with zip except some old svn references from years ago. The error you mention is probably not from a current version of QuestGuru. Please delete the entire QuestGuru and QuestGuru-Tracker folders from your AddOns folder and reload a new copy. If you still get the error, please remove all other addons, restart WoW and see if you still get it. The mod that you used below is a global mod and will affect all AddOns, not just the one you placed it in so it may be hiding a taint from some other AddOn. -g |
|
Gregity |
View Public Profile |
Send a private message to Gregity |
Find More Posts by Gregity |
Add Gregity to Your Buddy List |
10-31-13, 02:29 AM | |
A Defias Bandit
Forum posts: 3
File comments: 8
Uploads: 0
|
I tested the new version. The QuestLog_OnShow and QuestLog_OnHide functions looking fine.
The WorldMapFrame still get the taint on WorldMapFrame_OnShow, if you display Quest locations and Quest text in the Map frame. I don't use an Map addon. I was able to reproduce this by opening/closing the Map two times, than the Quest Log two times and again the Map. Now you should get the taint warning each time when you open the Map. I fix this with ... setfenv(WorldMapFrame_OnShow, setmetatable({UpdateMicroButtons=function() end }, { __index = _G})) ... on Line #34 currently. The other two hacks from my last posting are no longer nessesary with the new version. |
|
Shareel |
View Public Profile |
Send a private message to Shareel |
Find More Posts by Shareel |
Add Shareel to Your Buddy List |
10-31-13, 12:03 AM | ||
|
Re: Achieve Tracker Issues
I'd help with the testing but I don't do scenarios at the moment. (Not a single level 90...too much time on Titan Panel.) I will install the update and see what happens. I'll also look at what Shareel posted as well. If I see anything strange, I'll post it in here. |
|
|
HonorGoG |
View Public Profile |
Send a private message to HonorGoG |
Find More Posts by HonorGoG |
Add HonorGoG to Your Buddy List |
10-30-13, 08:10 PM | |
|
Scenarios, etc, etc
The problem with any updates to really clean up the Scenario situation is still waiting until I'm not so buried and have some more free time to do extensive coding (and more extensive testing).
I do feel the pain and I (hate to admit) just disable the tracker when I do a scenario. |
|
Gregity |
View Public Profile |
Send a private message to Gregity |
Find More Posts by Gregity |
Add Gregity to Your Buddy List |
10-30-13, 08:07 PM | |
|
Achieve Tracker Issues
Hey all, I still don't have that problem fixed because I am not having the issue.
Anybody willing to help me isolate the error? You'd have to be comfortable editing the LUA code. Let me know. |
|
Gregity |
View Public Profile |
Send a private message to Gregity |
Find More Posts by Gregity |
Add Gregity to Your Buddy List |
10-30-13, 08:03 PM | |
|
QuestLog_OnShow (& OnHide) taint fixed
Howdy all,
Thanks for the news about the taints and some ideas. I ended up solving the problem another way. The problem is as stated and **SHAME ON BLIZZARD** for breaking nearly every addon that hooks an OnShow. Because I'm simply extracting information, I was able to use frame:HookScript to extract (OnHide) and use (OnShow) the information and bypass tainting the functions. A new download is available here and on Curse. -g |
|
Gregity |
View Public Profile |
Send a private message to Gregity |
Find More Posts by Gregity |
Add Gregity to Your Buddy List |
10-30-13, 11:22 AM | |
A Defias Bandit
Forum posts: 3
File comments: 8
Uploads: 0
|
@HonorGoG: Your fix does not work for me.
I come up with this solution after reading some postings in the official forums. I inserted... setfenv(WorldMapFrame_OnShow, setmetatable({UpdateMicroButtons=function() end }, { __index = _G})) setfenv(QuestLog_OnShow, setmetatable({ UpdateMicroButtons = function() end }, { __index = _G })) setfenv(QuestLog_OnHide, setmetatable({ UpdateMicroButtons = function() end }, { __index = _G })) ...right at line 34 of QuestGuru.lua after... QuestLogFrame:SetScript("OnDragStop", QuestLogFrame.StopMovingOrSizing) |
|
Shareel |
View Public Profile |
Send a private message to Shareel |
Find More Posts by Shareel |
Add Shareel to Your Buddy List |
10-30-13, 02:32 AM | |
|
IsDisabledByParentalControls Taint
As I've mentioned before, I love this addon. Blizzard changed some API functions for the 5.4.1 patch yesterday and besides blowing up a bunch of addons (including Titan Panel I might add), they appear to have modified the UpdateMicroButtons() call as well. This is something that the QuestLog_OnShow() uses which is part of the Blizzard FrameXML. To avoid this, I added the following to QuestGuru.lua at line #708 right before the QuestLog_OnShow() call. This will remove the error but is by no means a fix as the function is hooked to be blank now which is definitely not what Blizzard had in mind for a protected function.
C_StorePublic.IsDisabledByParentalControls = function () return false endEnjoy. |
|
HonorGoG |
View Public Profile |
Send a private message to HonorGoG |
Find More Posts by HonorGoG |
Add HonorGoG to Your Buddy List |
09-21-13, 09:55 AM | |
A Kobold Labourer
Forum posts: 0
File comments: 1
Uploads: 0
|
Sound issue
I only use questguru log, currently i think the tracker is not working well with all new stuf from Blizz(like scenario, proving ground etc like wolfetx's comment)
For the quest log, everything seems to be fine except some sound doesnt work. Some work is like default sound from blizzard, which doesnt have .ogg. I believe it's a common issue as sorha quest log sound doesnt work either. SilverDragon sound works, hope you can find a clue to deal with. Been using questguru for 4 years, very appreciate your work, think your addon is one of the best. Good luck with real life stuff. |
|
sonnt |
View Public Profile |
Send a private message to sonnt |
Find More Posts by sonnt |
Add sonnt to Your Buddy List |
09-17-13, 09:32 PM | |
A Defias Bandit
Forum posts: 3
File comments: 8
Uploads: 0
|
Bonus timers?
Hello, cany way we can see the bonbus timers for the heroic scenario's and the new proving grounds?
|
|
wolfetx |
View Public Profile |
Send a private message to wolfetx |
Find More Posts by wolfetx |
Add wolfetx to Your Buddy List |
09-17-13, 01:39 AM | |
|
YEA!
See subject. One of my favorites.
|
|
HonorGoG |
View Public Profile |
Send a private message to HonorGoG |
Find More Posts by HonorGoG |
Add HonorGoG to Your Buddy List |
09-16-13, 05:01 AM | |
A Kobold Labourer
Forum posts: 0
File comments: 16
Uploads: 0
|
I know this was only a toc update but this error still exists when using portals, hearthstones etc.
Message: ...erface\AddOns\QuestGuru_Tracker\QGT_Achievements.lua:626: attempt to perform arithmetic on local 'j' (a nil value) Time: 09/16/13 11:58:44 Count: 1 Stack: [C]: ? ...erface\AddOns\QuestGuru_Tracker\QGT_Achievements.lua:626: in function `QGT_AchievementWatch_Update' ...rface\AddOns\QuestGuru_Tracker\QuestGuru_Tracker.lua:536: in function <...rface\AddOns\QuestGuru_Tracker\QuestGuru_Tracker.lua:514> [C]: ? [C]: in function `WatchFrame_Update' Interface\FrameXML\WatchFrame.lua:312: in function <Interface\FrameXML\WatchFrame.lua:247> Locals: |
|
Reeb |
View Public Profile |
Send a private message to Reeb |
Find More Posts by Reeb |
Add Reeb to Your Buddy List |
You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.