Download
(5Kb)
Download
Updated: 04-10-09 08:41 AM
Pictures
File Info
Updated:04-10-09 08:41 AM
Created:02-21-09 05:50 AM
Downloads:4,947
Favorites:88
MD5:

Proc Borders

Version: 0003
by: Pons [More]

This mod makes it easier to notice procs that create a temporary buff by putting a colored border around spells affected by the buff.

For instance, prot warriors get a Sword and Board proc that makes Shield Slam free. Once you associate Shield Slam with Sword and Board, anytime Sword and Board procs it will put a border around Shield Slam. When the buff fades, the border disappears too.

Proc Borders was designed mostly for default action bars, but it should work with almost any action bar mod. It uses the borders already built into standard action buttons. If you have another mod that uses these borders (such as Dominos Buff) it can coexist but the behavior may be overriden.

Note: Proc Borders now has macro support thanks to hypehuman! I didn't think it'd be that easy.

All setup is done through the AddOn tab of the Interface Options screen. To get there, hit ESC until the game menu appears, then Interface->AddOns->Proc Borders. In the setup, you can enter a spell name, the buff that will trigger the border, and a color for the border.

changelog:
0003 4/10/09: Actual fix for losing settings. Sorry it took so long.
0002 3/18/09: Fix for losing settings by jaliborc. Macro/Macrotexter support by hypehuman.
0001 2/21/09: Initial release.

Optional Files (0)


Post A Reply Comment Options
Unread 03-14-09, 04:54 PM  
sun
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 104
Uploads: 1
doesn't work with buttonfacade ! need fix
Report comment to moderator  
Reply With Quote
Unread 03-09-09, 11:41 PM  
Jeania
An Aku'mai Servant
 
Jeania's Avatar

Forum posts: 39
File comments: 170
Uploads: 0
giving it a happy go ^_^ One question though...

In the screenshot it looked like you can add glyph type of buffs too? Just double checking ^_^
__________________
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Words to Remember:

"You never really learn much from hearing yourself talk." ~ George Clooney

*۝*Jeania/Anjelie ~ Dalaran*۝*
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Report comment to moderator  
Reply With Quote
Unread 03-09-09, 12:40 AM  
Bikther
An Aku'mai Servant
 
Bikther's Avatar

Forum posts: 37
File comments: 16
Uploads: 0
I am also having issue with it not saving between sessions.

any chance of a fix?
Report comment to moderator  
Reply With Quote
Unread 03-08-09, 07:24 AM  
WayfarerOmega
A Murloc Raider

Forum posts: 8
File comments: 26
Uploads: 0
I don't think it's on a per session basis that it loses settings. I just checked the settings on my healadin and fury warrior, then logged out, rebooted my computer, logged back in, and the settings were still there. Then I checked the settings on my warlock, who I haven't played in a week, and her settings were still there as well.

But it does lose settings from time to time and it happens often enough that one of the first things I do when I log in is check to see if my Proc Borders settings are still good. It's a great addon but the settings thing is getting kind of tiresome.
Report comment to moderator  
Reply With Quote
Unread 02-27-09, 01:49 PM  
jaliborc
A Chromatic Dragonspawn
 
jaliborc's Avatar
AddOn Author - Click to view AddOns

Forum posts: 196
File comments: 329
Uploads: 20
ProcBorders is not saving settings between sessions (at least, its not working for me).

I've looked at the code and seems that the problem is quite simple: the table ProcBordersBuffs is overrided on load (ProcBorders.lua, line 7):
Code:
ProcBordersBuffs = {}
If you need an empty table before the variables are loaded you can do the following:
Code:
local Buffs = {} --choose name you wish for the local, except ProcBordersBuffs

function b.OnLoad(self)
        ProcBordersBuffs = ProcBordersBuffs or {}
        Buffs = ProcBordersBuffs

	b:RegisterEvent("UNIT_AURA")
	b:RegisterEvent("ACTIONBAR_PAGE_CHANGED")
	b:RegisterEvent("ACTIONBAR_SLOT_CHANGED")
	b:RegisterEvent("UPDATE_SHAPESHIFT_FORM")
	b:SetScript("OnEvent",b.OnEvent)
	b.timer = 5
	b:Show()
end
Otherwise, simple wait for the PlayerLogin event to "load" the table:
Code:
function b.OnLoad(self)
        ProcBordersBuffs = ProcBordersBuffs or {}

	b:RegisterEvent("UNIT_AURA")
	b:RegisterEvent("ACTIONBAR_PAGE_CHANGED")
	b:RegisterEvent("ACTIONBAR_SLOT_CHANGED")
	b:RegisterEvent("UPDATE_SHAPESHIFT_FORM")
	b:SetScript("OnEvent",b.OnEvent)
	b.timer = 5
	b:Show()
end
Report comment to moderator  
Reply With Quote
Unread 02-26-09, 06:27 AM  
oXid_FoX
A Deviate Faerie Dragon
 
oXid_FoX's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 147
Uploads: 1
Thumbs up feature request

Very nice addon !

Features requested:
  • detect buff charges ; e.g. Shaman and their Maelstrom with 5 charges
  • enhance proc detection: I play on a french client, and there is no name changes between the buff Sacred Shield http://fr.wowhead.com/?spell=53601 and the proc.
  • being able to use shift-clic, but this is already asked

I know it's not easy changes to code... good luck anyway
Report comment to moderator  
Reply With Quote
Unread 02-24-09, 11:20 AM  
hypehuman
A Deviate Faerie Dragon
 
hypehuman's Avatar
AddOn Author - Click to view AddOns

Forum posts: 17
File comments: 87
Uploads: 8
In order to get it to work for macros, open up ProcBorders.lua and change this:
Code:
				if actionType=="spell" and spellID and spellID>0 and spellID<2000 then
					t[frameName] = GetSpellName(spellID,"spell")
				end
to this:
Code:
				if spellID and spellID>0 and spellID<2000 then
					if actionType=="spell" then
						t[frameName] = GetSpellName(spellID,"spell")
					elseif actionType=="macro" and spellID then --in this case, spellID is actually a macroIndex
						t[frameName] = GetMacroSpell(spellID)
					end
				end




EDIT: And to make this addon compatible with Macrotexter, change this:
Code:
		if frame:GetAttribute("type")=="action" and frameName then
to this:
Code:
		local typeAttr = frame:GetAttribute("type")
		if (typeAttr=="action" or typeAttr=="click") and frameName then

EDIT2: Thanks so much for this extremely useful addon! I've been using it for Nightfall, Hot Streak, and Glyph of Heroic Strike.
Last edited by hypehuman : 02-25-09 at 10:07 AM.
Report comment to moderator  
Reply With Quote
Unread 02-23-09, 05:54 PM  
jaliborc
A Chromatic Dragonspawn
 
jaliborc's Avatar
AddOn Author - Click to view AddOns

Forum posts: 196
File comments: 329
Uploads: 20
Great addon! Well done!
There are 2 improvements I would like to see though:
  • Being able to drag a spell to the action slot of the ProcBorders option window to set it, instead of having to write its name (and maybe some shift-click behavior for buffs, just like chat links work)
  • Being able to set multiple buffs per spell

Oh, and macros would be also interesting, but that has already been discussed.
Report comment to moderator  
Reply With Quote
Unread 02-23-09, 10:53 AM  
ereth
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 7
File comments: 44
Uploads: 5
This addon works quite nicely thanks for sharing it
Even thou you said it didn't support macros, could one hope that it will get support for them?
A lot of my spells are macros, and some sort of recognition of #showtooltip would be great

Dominos recognize them.
Report comment to moderator  
Reply With Quote
Unread 02-22-09, 08:07 PM  
personcube
A Murloc Raider

Forum posts: 7
File comments: 23
Uploads: 0
This is a great addon! I love it!

I can also confirm it works flawlessly with Bartender4! =)

I must make a recommendation though, which might be coming our way soon, already: perhaps allow for the 'scaling' of the borders, so we can enhance them or lighten them as we want, or even allow for 'other' effects, such as glowing borders, etc.

I'm not sure if any of that defiles your scope of the addon, though.

Great work, and I hope to see this thing continue to improve! ^^
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: