Endeavours Noob Stats

Major problems with the chat output of v2.9.

With Identity v30100 (a mod that hooks SendChatMessage and prepends text), errors when trying to click a name from the "Overall Data" (not Current Data) rows in ENStats:

"Identity-30100\\Identity.lua:110: bad argument #2 to 'format' (number expected, got string)\nIdentity-30100\\Identity.lua:110: in function `SendChatMessage'\nEN_Stats-2.9\\Core.lua:371: in function `DoReport'\nEN_Stats-2.9\\Core.lua:128: in function <Interface\\AddOns\\EN_Stats\\Core.lua:128>\n\n"

Nothing is output to chat.

Also tried with the similar Identity-2 (which does the same thing with slightly different code):

"identity-2-2.1-30000\\Identity-2.lua:108: bad argument #2 to 'format' (number expected, got string)\nidentity-2-2.1-30000\\Identity-2.lua:108: in function `SendChatMessage'\nEN_Stats-2.9\\Core.lua:371: in function `DoReport'\nEN_Stats-2.9\\Core.lua:128: in function <Interface\\AddOns\\EN_Stats\\Core.lua:128>\n\n"

Next, I relogged & tried to click an "Overall Data" row with neither of those mods active. Again, nothing is output to chat, but this time no errors.

Finally, went into an OS raid with this mod & Identity active. As is typical with PUGs in OS, many people failed. In "Current Data", tried to click a row to output to raid chat. But again, nothing happened and an error was thrown up:

"Identity-30100\\Identity.lua:110: bad argument #2 to 'format' (number expected, got string)\nIdentity-30100\\Identity.lua:110: in function `SendChatMessage'\nEN_Stats-2.9\\Core.lua:73: in function `?'\nCallbackHandler-1.0-3 (Ace3):146: in function <...Ons\\Ace3\\CallbackHandler-1.0\\CallbackHandler-1.0.lua:146>\n<string>:\"safecall Dispatcher[3]\":4: in function <[string \"safecall Dispatcher[3]\"]:4>\n<in C code>: ?\n<string>:\"safecall Dispatcher[3]\":13: in function `?'\nCallbackHandler-1.0-3 (Ace3):91: in function `Fire'\nLibFail-1.0-999 (EN_Stats):162: in function `FailEvent'\nLibFail-1.0-999 (EN_Stats):279: in function <...ace\\AddOns\\EN_Stats\\Libs\\LibFail-1.0\\LibFail-1.0.lua:195>\nLibFail-1.0-999 (EN_Stats):138: in function <...ace\\AddOns\\EN_Stats\\Libs\\LibFail-1.0\\LibFail-1.0.lua:132>\n\n"

These problems did not occur pre-WoW 3.1. And ENStats isn't the only mod that conflicts with Identity now; Loot Hog has the same problem. But many other mods here using SendChatMessage don't have a problem in combination with it: Accomplishment, Acheron, Auctioneer, BetterQuest, BigWigs, CastYeller, ClassLoot, GuildGreet, oRA2, Recount, RaidBuffStatus and so on. Hope you can resolve it.

I haven't had any issues with announcing, although I don't use these mods. Have you tried erasing all your WTF files related to EN_stats and then running it without those other mods? I have lots of chat mods and mods that hook into the SendChatMessage and have absolutely no problems whatsoever. I'd say its more likely a problem with the mods, as you have suggested, or possibly corrupted files. Regardless, if you can't find a fix, there are other Fail mods out there that you might be able to get to work with your other mods.

Also, since 3.1, Blizzard requires any addon that uses the SendChatMessage to be updated. I suspect that since Identity 2 is months old, the problem lies with itsoutdated code. Unfortunately, if this is the case, I doubt that Endeavour will be able to do much about this, as making correct code work with incorrect code isn't ideal. I'm not sure why Identity wouldn't work though, as it has been updated more recently than Identity 2. You might also post a bug on the Identity site, as they might have some insight to that too.

Features I'd like to see:

- Specific character data removal: I have pugs and guildies in my overall list, and I'd like to remove the pugs from there while keeping the guildie data.

- Slash command or option to pause collection of data: Something that I could type or check off if I am in a total Naxx pug and don't want it to record. Alternatively, something to reset the data just collected would work as well, similar to Recount, only when you leave a raid rather than when you join it.

- Sorting of columns by name or flip points: Its nice to see the top most fails, but I'd like to quickly be able to find someone's name and look at that.

- Option to report only the top x fails to chat

- Option to announce after combat is over: FailBot and EnsidiaFails both have this (I think one is a continuation of the other) and this is great. I dislike the raid chat spam, I don't have everyone in a custom channel, and I don't necessarily want to be distracted by /say spam in the middle of Heigan.

Great work, thanks so much, IMO the best fail mod out there simply because of the retention of data. Keep it up!