LUA Error when in raid

cokedrivers · 10-26-14, 09:19 AM

I keep getting this error when in a Raid:

Code:

4x [ADDON_ACTION_BLOCKED] AddOn 'BasicUI' tried to call the protected function 'Boss2TargetFrame:Show()'.
!BugGrabber\BugGrabber.lua:586: in function <!BugGrabber\BugGrabber.lua:586>
[C]: in function `Show'
FrameXML\TargetFrame.lua:110: in function `TargetFrame_Update'
FrameXML\TargetFrame.lua:174: in function `OnEvent'
FrameXML\UnitFrame.lua:676: in function <FrameXML\UnitFrame.lua:674>

Locals:
nil

If I disable my Unitframes.lua in game I no longer get the error so something in the coding is the issue.

Here is my Unitframes.lua code.

If you need more code please let me know.

And thanks for any help.

Coke

ObbleYeah · 10-26-14, 09:56 AM

you're doing a few things that might well cause taint since the boss frames are pretty sensitive, but I wouldn't be surprised if it was this:

Lua Code:

for i = 1, MAX_BOSS_FRAMES do
    local bossFrame = "Boss"..i.."TargetFrame"
    _G[bossFrame]:SetScale(db.boss.scale)
end

also i realise it's pedantic but would it be easier to do

Lua Code:

local bossFrame = _G["Boss"..i.."TargetFrame"]

instead

edit: also is the boss moving code commented out when you play? Speaking from experience, that'll definitely fuck it up.

Lombra · 10-26-14, 11:01 AM

Originally Posted by ObbleYeah

you're doing a few things that might well cause taint since the boss frames are pretty sensitive, but I wouldn't be surprised if it was this:

Lua Code:

for i = 1, MAX_BOSS_FRAMES do
    local bossFrame = "Boss"..i.."TargetFrame"
    _G[bossFrame]:SetScale(db.boss.scale)
end

I have done that before and I'm pretty sure it tainted stuff. Only makes sense, anyway.

semlar · 10-26-14, 12:49 PM

Setting the scale of secure frames wouldn't normally taint them, but overwriting functions like this will..

Lua Code:

PlayerHitIndicator.SetText = function() end
PetHitIndicator.SetText = function() end

The ui calls PlayerHitIndicator:SetText() and everything after that point is now tainted and can't do anything securely.

After looking at the TargetFrameTemplate, setting the scale actually will taint the frame because it has an OnSizeChanged handler which you're inadvertently calling by changing the scale.

cokedrivers · 10-26-14, 01:23 PM

Originally Posted by semlar

Setting the scale of secure frames wouldn't normally taint them, but overwriting functions like this will..

Lua Code:

PlayerHitIndicator.SetText = function() end
PetHitIndicator.SetText = function() end

The ui calls PlayerHitIndicator:SetText() and everything after that point is now tainted and can't do anything securely.

After looking at the TargetFrameTemplate, setting the scale actually will taint the frame because it has an OnSizeChanged handler which you're inadvertently calling by changing the scale.

So old school TargetFrame:SetScale() no longer works?

semlar · 10-26-14, 01:55 PM

I would try doing something like this, to securely scale the frame when it gets shown..

Lua Code:

SecureHandlerWrapScript(Boss1TargetFrame, 'OnShow', Boss1TargetFrame, 'self:SetScale(0.5)')

If you're scaling them in response to a button click, just create a secure frame, pass the frame handles for each boss frame (or other unit frame) into it, and set the scale when the button is clicked.