QuestFrames Help

[NeXxUSA]

Please check out this code. It is supposed to show the quest info in a movable frame, but it dosen't seem to be working. Any help/suggestions appreciated!

LINK

[Seerah]

Aside from generic globals, passing your desired frame name as the first argument to CreateFrame, calling a function that doesn't exist (or you're not showing all of your code), setting a fontstring to literally display "i", making new frames every time these functions are called, and not actually calling these 2 functions (again, probably not showing all of your code), what exactly are you having trouble with?

[MunkDev]

There are a lot of errors in this code.

local i= GetQuestObjectInfo

This doesn't do anything, unless you created a global function called GetQuestObjectInfo. There is no such global function provided by Blizzard. Also, "i" is usually an abbreviation of "index", which is used in loops. You should not use that variable name in a case like this.

MyFrame = CreateFrame("Quest Info") -- globally defined variable name, incorrect arguments
local MyFrame = CreateFrame("Frame", "QuestInfo", UIParent) -- localized, correct arguments

MyFrame is also not a good variable name and it should definitely not be globally defined. If you're going to keep using the same frame for multiple things, I suggest you create it in a higher scope and then refer to it directly in the functions.

MyFrame.text:SetAllPoints() -- no argument
MyFrame.text:SetAllPoints(MyFrame) -- match the points of MyFrame

SetAllPoints takes a frame or region as an argument.

MyFrame.text:SetText("i")

This will only put the letter "i" in the text box.

MyFrame:SetMovable(enable) -- "enable" is nil, it doesn't exist
MyFrame:SetMovable(true) -- true to enable, false to disable

enable isn't mentioned anywhere else in your code, so it will be nil in this case since it will be treated as a global variable (which, again, doesn't exist).

MyFrame = Frame("Quest Info") -- trying to grab the frame again?
local MyFrame = QuestInfo --  get the frame from global namespace

Unless you made it yourself, there is no global function called "Frame".

MyFrame:Clear() -- attempting to clear text?
MyFrame.text:SetText() -- this will clear the text field

If MyFrame is an arbitrary frame, then there is no function called "Clear" mixed in.

region = MyFrame:CreateTitleRegion() -- globally defined and pointless
local region = MyFrame:CreateTitleRegion() -- localized, but this is still pointless

You can't just copy & paste from wowprogramming. If you look at the argument listing for any function, you'll see that each argument has a data type and each return value has a label to let you know what's being returned. "region" just tells you that the function is returning a region (which could be a Frame, FontString, Texture, Button, etc). "enable" just tells you what the arugment you give the function will do. If you give it true then it will enable. If you give it false, then it will disable.

This code will still do nothing (since I'm not entirely sure what you're trying to do), but it's correctly written:

local QuestInfo = CreateFrame("Frame", "QuestInfo", UIParent)
 
QuestInfo:SetHeight(300)
QuestInfo:SetWidth(300)
QuestInfo:SetPoint("CENTER", 0, 0)
QuestInfo:SetBackdrop(StaticPopup1:GetBackdrop())
 
QuestInfo:EnableMouse(true)
QuestInfo:SetMovable(true)
QuestInfo:RegisterForDrag("LeftButton")
QuestInfo:HookScript("OnDragStart", QuestInfo.StartMoving)
QuestInfo:HookScript("OnDragStop", QuestInfo.StopMovingOrSizing)
 
QuestInfo.Text = QuestInfo:CreateFontString("$parentText", "BACKGROUND", "GameFontNormal")
QuestInfo.Text:SetAllPoints(QuestInfo)
QuestInfo.Text:SetText("This is your frame")
 
function QuestInfo:Accepted(...)
    local arg1, arg2, arg3 = ...
    self.Text:SetText(arg1 or arg2 or arg3)
end
 
function QuestInfo:Complete(...)
    local arg1, arg2, arg3 = ...
    self.Text:SetText()
end

[NeXxUSA]

Originally Posted by MunkDev There are a lot of errors in this code. local i= GetQuestObjectInfo This doesn't do anything, unless you created a global function called GetQuestObjectInfo. There is no such global function provided by Blizzard. Also, "i" is usually an abbreviation of "index", which is used in loops. You should not use that variable name in a case like this. MyFrame = CreateFrame("Quest Info") -- globally defined variable name, incorrect arguments local MyFrame = CreateFrame("Frame", "QuestInfo", UIParent) -- localized, correct arguments MyFrame is also not a good variable name and it should definitely not be globally defined. If you're going to keep using the same frame for multiple things, I suggest you create it in a higher scope and then refer to it directly in the functions. MyFrame.text:SetAllPoints() -- no argument MyFrame.text:SetAllPoints(MyFrame) -- match the points of MyFrame SetAllPoints takes a frame or region as an argument. MyFrame.text:SetText("i") This will only put the letter "i" in the text box. MyFrame:SetMovable(enable) -- "enable" is nil, it doesn't exist MyFrame:SetMovable(true) -- true to enable, false to disable enable isn't mentioned anywhere else in your code, so it will be nil in this case since it will be treated as a global variable (which, again, doesn't exist). MyFrame = Frame("Quest Info") -- trying to grab the frame again? local MyFrame = QuestInfo --  get the frame from global namespace Unless you made it yourself, there is no global function called "Frame". MyFrame:Clear() -- attempting to clear text? MyFrame.text:SetText() -- this will clear the text field If MyFrame is an arbitrary frame, then there is no function called "Clear" mixed in. region = MyFrame:CreateTitleRegion() -- globally defined and pointless local region = MyFrame:CreateTitleRegion() -- localized, but this is still pointless You can't just copy & paste from wowprogramming. If you look at the argument listing for any function, you'll see that each argument has a data type and each return value has a label to let you know what's being returned. "region" just tells you that the function is returning a region (which could be a Frame, FontString, Texture, Button, etc). "enable" just tells you what the arugment you give the function will do. If you give it true then it will enable. If you give it false, then it will disable. This code will still do nothing (since I'm not entirely sure what you're trying to do), but it's correctly written: local QuestInfo = CreateFrame("Frame", "QuestInfo", UIParent)   QuestInfo:SetHeight(300) QuestInfo:SetWidth(300) QuestInfo:SetPoint("CENTER", 0, 0) QuestInfo:SetBackdrop(StaticPopup1:GetBackdrop())   QuestInfo:EnableMouse(true) QuestInfo:SetMovable(true) QuestInfo:RegisterForDrag("LeftButton") QuestInfo:HookScript("OnDragStart", QuestInfo.StartMoving) QuestInfo:HookScript("OnDragStop", QuestInfo.StopMovingOrSizing)   QuestInfo.Text = QuestInfo:CreateFontString("$parentText", "BACKGROUND", "GameFontNormal") QuestInfo.Text:SetAllPoints(QuestInfo) QuestInfo.Text:SetText("This is your frame")   function QuestInfo:Accepted(...)     local arg1, arg2, arg3 = ...     self.Text:SetText(arg1 or arg2 or arg3) end   function QuestInfo:Complete(...)     local arg1, arg2, arg3 = ...     self.Text:SetText() end

Originally Posted by Seerah Aside from generic globals, passing your desired frame name as the first argument to CreateFrame, calling a function that doesn't exist (or you're not showing all of your code), setting a fontstring to literally display "i", making new frames every time these functions are called, and not actually calling these 2 functions (again, probably not showing all of your code), what exactly are you having trouble with?

Thanks for the response guys! I don't know lua(JS, C, C#, JQ, HTML guy myself) or the WoW API at all really. Could you guys point me in the direction of some tutorials(preferably videos) to help me get on my way? Thanks again for the detail in your responses! As far as the copy and paste thing, when I first started learning javascript I would compile various pieces of code a tweak and mash them together to my liking, and learn from what I see. Obviously the semi-self-taught route isn't going to work for Lua.

[SDPhantom]

Originally Posted by MunkDev "i" is usually an abbreviation of "index"

Actually, the use of the variable i in loops is based off usage in mathematical formulas. In both cases, they represent a set of numbers used in iteration. By "they", there are actually a series of them usually represented by i, j, and k. There can be more if necessary and continue along the alphabet.

Originally Posted by NeXxUSA I don't know lua(JS, C, C#, JQ, HTML guy myself) or the WoW API at all really. ... As far as the copy and paste thing, when I first started learning javascript I would compile various pieces of code a tweak and mash them together to my liking, and learn from what I see. Obviously the semi-self-taught route isn't going to work for Lua.

I'm actually self taught myself. Granted I've had Lua experience prior to when I first started writing addons. Before Lua, I've had experience with other languages such as JavaScript, C, PHP, etc. Once you get a taste of a variety of languages, you begin to see the similarities they all share. They all have variables, conditions, loops, and functions. They also have their own quirks that make them unique. Such as how strictly variables are typed, passing objects by reference or by value, even Lua's quirk with allowing functions to have multiple returns.

I know it isn't exactly what you asked for, but I would suggest taking a look at the Lua Reference Manual and the WoWPedia Tutorial.



As always, if you have any questions, feel free to ask.

[NeXxUSA]

Originally Posted by SDPhantom Actually, the use of the variable i in loops is based off usage in mathematical formulas. In both cases, they represent a set of numbers used in iteration. By "they", there are actually a series of them usually represented by i, j, and k. There can be more if necessary and continue along the alphabet. I'm actually self taught myself. Granted I've had Lua experience prior to when I first started writing addons. Before Lua, I've had experience with other languages such as JavaScript, C, PHP, etc. Once you get a taste of a variety of languages, you begin to see the similarities they all share. They all have variables, conditions, loops, and functions. They also have their own quirks that make them unique. Such as how strictly variables are typed, passing objects by reference or by value, even Lua's quirk with allowing functions to have multiple returns. I know it isn't exactly what you asked for, but I would suggest taking a look at the Lua Reference Manual and the WoWPedia Tutorial. As always, if you have any questions, feel free to ask.

Thanks! Any help is good help!

[Seerah]

To add to what SDPhantom said, using i (or j, or k) in those scenarios is just convention - those variables can be called whatever you like.

@MunkDev: the SetAllPoints method does not require an argument. If nil, it will default to the parent frame.

@NeXxUSA: I am self-taught as well. I'm a music (primarily) teacher. See here for more resources: http://www.wowinterface.com/forums/s...ad.php?t=43699

[MunkDev]

I'm not unfamiliar with practices when it comes to iteration variables, but I always thought the reason i was picked (and subsequently j and k) as an iteration variable, was because it's usually used to get a specific index in an array. I'm damaged from writing in C languages, so even when I do arbitrary examples of table iteration in Lua, I usually use i instead of k (key). Oh well, you learn something new everyday.

As for being self-taught; I didn't know a thing about Lua or addon coding about a year ago. Barely even looking at some of my old coding gives me a headache because of how inexperienced I was, and I'm sure I'm likely to feel the same about my current coding, somewhere down the road. I hope you didn't perceive my answer as harsh, I was merely trying to help. Things might be unclear right now, but if you keep at it, you'll get a grip of it all in no time.

[Seerah]

And that may well be how i became the conventional/traditional variable to use in that context. However, this also works quite as well.

for mycoolvar = 1, 3 do
     print(mycoolvar)
end

[SDPhantom]

I was just pointing out some trivia behind programming conventions. In the early days of computers, they were solely used for mathematical calculations. The formulas used for such literally was the program code these computers ran. It's these roots that many of our programming conventions originated from.