Say Health

NeXxUSA · 01-25-16, 02:09 PM

Hello, I need some help. This code doesn't work. As far as what it's supposed to do that is documented function by function below, as well as a general overview in the final comment. Please help me fix this. This is my first addon I'm going to see through to the end, as I scrapped my last one due to it being too advanced.

Code:


	Lua Code:
	--Check if right alt key is down. If true returns 1.
local function altDown()
    local isDown = IsRightAltKeyDown()
    return isDown
end
--Get current health
local function getHealth()
    local cHealth = UnitHealth("player")
    return cHealth
end
--Get max health
local function getMHealth()
    local mHealth = UnitMaxHealth("player")
    return mHealth
end
--All functions have bee declared
 
--If the function altDown returns 1, say current health over max health. Else, end. 
if altDown() == 1
            then SendChatMessage(getHealth() .. "/" .. getMHealth())
            else
end
--Purpose of the addon is to say "health/max" in /say chat when you press right alt.

Thanks!

Yukyuk · 01-25-16, 02:20 PM

Not tested but I think IsRightAltKeyDown() returns a true/false?

Fizzlemizz · 01-25-16, 02:24 PM

Why are you creating a bunch of functions to wrap single functions in?

Code:

    if IsRightAltKeyDown() then
    	SendChatMessage(UnitHealth("player") .. "/" .. UnitMaxHealth("player"))
    end

NeXxUSA · 01-25-16, 02:31 PM

Originally Posted by Yukyuk

Not tested but I think IsRightAltKeyDown() returns a true/false?

http://wowprogramming.com/docs/api/IsRightAltKeyDown says it returns 1 if true. Does the if statement need to be attached to anything? I think it may be that it is only check on initialization. If that's the case how do i fix it? Thanks!

NeXxUSA · 01-25-16, 02:36 PM

Originally Posted by Fizzlemizz

Why are you creating a bunch of functions to wrap single functions in?

Code:

    if IsRightAltKeyDown() then
    	SendChatMessage(UnitHealth("player") .. "/" .. UnitMaxHealth("player"))
    end

Like an exact copy and paste of my original cod

. Unfortunately it doesn't work.

Fizzlemizz · 01-25-16, 02:38 PM

Originally Posted by NeXxUSA

http://wowprogramming.com/docs/api/IsRightAltKeyDown says it returns 1 if true. Does the if statement need to be attached to anything? I think it may be that it is only check on initialization. If that's the case how do i fix it? Thanks!

All the documentation is user created so what might have been true at one point might not be today but noone has gone back to correct it.

test with:

Code:

/run print(IsRightAltKeyDown())

Fizzlemizz · 01-25-16, 02:41 PM

UnitMaxHealth should be UnitHealthMax

Code:

 
if IsRightAltKeyDown() then
    	SendChatMessage(UnitHealth("player") .. "/" .. UnitHealthMax("player"))
end

Edit, I'm guessing you don't lua errors turned on. If you are creating addons I would suggest gettting BugSack or Bugger to make you life ever so much easier.

NeXxUSA · 01-25-16, 02:45 PM

Originally Posted by Fizzlemizz

All the doumentation is user created so what might have been true at one point might not be today but noone has gone back to cotrrect it.

test with:

Code:

/run print(IsRightAltKeyDown())

Returns

stdin:1: attempt to call global 'IsRightAltKeyDown' (a nil value)
stack traceback
stdin:1: in main chunk
[C]: ?

Fizzlemizz · 01-25-16, 02:53 PM

Originally Posted by NeXxUSA

Returns

stdin:1: attempt to call global 'IsRightAltKeyDown' (a nil value)
stack traceback
stdin:1: in main chunk
[C]: ?

I meant for you to paste that into your chat edit box in-game for a quick test. Should return true or false depnding on wether the right alt key is down when you press enter.

SDPhantom · 01-25-16, 05:06 PM

One major problem is the main chunk of your code only runs once on load. To have functions run continuously or respond to an event, you need to create a frame to manage it.

Since we can respond to an event in order to accomplish our task, we'll do that.

Lua Code:

local EventFrame=CreateFrame("Frame");--    Create our frame
EventFrame:RegisterEvent("MODIFIER_STATE_CHANGED");--   Register event that fires when modifier key states change
EventFrame:SetScript("OnEvent",function(self,event,key,down)--  Registers this function to run when the frame receives an event
--  We only registered one event, so we don't need to check if it's MODIFIER_STATE_CHANGED
    if key=="RALT" and down==1 then--   Only trigger if Right Alt was pressed
        SendChatMessage(UnitHealth("player").."/"..UnitHealthMax("player"),"SAY");--    Send our message through the SAY channel
    end
end);

Tim · 01-25-16, 06:50 PM

Another alternative is...

Code:

local RALT = CreateFrame("Frame")
RALT:SetScript("OnKeyDown", function(self)
   if IsRightAltKeyDown() then
      SendChatMessage(UnitHealth("player").."/"..UnitHealthMax("player"), "SAY")
   end
end)

SDPhantom · 01-25-16, 07:58 PM

In order for OnKeyDown to work, you need to set Frame:EnableKeyboard(). The problem with this is it blocks keybinds from working unless Frame:SetPropagateKeyboardInput() is set. This causes another problem, once you set the frame to propagate keyboard events, OnKeyDown stops responding to modifier keys. Also, if this were to work, it would respond every time you press any key plus right Alt.

NeXxUSA · 01-25-16, 08:58 PM

Originally Posted by Tim

Another alternative is...

Code:

local RALT = CreateFrame("Frame")
RALT:SetScript("OnKeyDown", function(self)
   if IsRightAltKeyDown() then
      SendChatMessage(UnitHealth("player").."/"..UnitHealthMax("player"), "SAY")
   end
end)

Originally Posted by SDPhantom

One major problem is the main chunk of your code only runs once on load. To have functions run continuously or respond to an event, you need to create a frame to manage it.

Since we can respond to an event in order to accomplish our task, we'll do that.

Lua Code:

local EventFrame=CreateFrame("Frame");--    Create our frame
EventFrame:RegisterEvent("MODIFIER_STATE_CHANGED");--   Register event that fires when modifier key states change
EventFrame:SetScript("OnEvent",function(self,event,key,down)--  Registers this function to run when the frame receives an event
--  We only registered one event, so we don't need to check if it's MODIFIER_STATE_CHANGED
    if key=="RALT" and down==1 then--   Only trigger if Right Alt was pressed
        SendChatMessage(UnitHealth("player").."/"..UnitHealthMax("player"),"SAY");--    Send our message through the SAY channel
    end
end);

Originally Posted by Fizzlemizz

Why are you creating a bunch of functions to wrap single functions in?

Code:

    if IsRightAltKeyDown() then
    	SendChatMessage(UnitHealth("player") .. "/" .. UnitMaxHealth("player"))
    end

Originally Posted by Yukyuk

Not tested but I think IsRightAltKeyDown() returns a true/false?

Thanks guys! I've decided to just stick to the languages I know cause I have no idea what I'm doing. Thanks for the help though! Maybe I'll change my mind or eventually find my way back. I leave you with a dancing banana to remember me by.