a little help with frame names and more

[saxitoxin]

I would please like some help with some frame names and some other commands
I have made my character frame look (in my opinion) better in some ways. but I have some issues.



1. The borders from the " CharacterModelFrame " are still visible when I have expanded the frames, I would like to remove them, and could not find the name of those.
2. The borders around the itemslots are looking wierd after I moved them around, how can I remove them or add custom ones?
3. I would like to know if I can change the texture of a itemslot, specific the cape
4. Is it possible to make the character frame spawn on the center of the screen, I have tried to use "PaperDollFrame:SetPoint("CENTER", UIParent, "CENTER", 0, 0)" but it is not working

Thanks for any help

[Resike]

1. You need to hide these frames:

PaperDollInnerBorderTopLeft:Hide()
PaperDollInnerBorderTopRight:Hide()
PaperDollInnerBorderBottomLeft:Hide()
PaperDollInnerBorderBottomRight:Hide()
PaperDollInnerBorderLeft:Hide()
PaperDollInnerBorderRight:Hide()
PaperDollInnerBorderTop:Hide()
PaperDollInnerBorderBottom:Hide()
PaperDollInnerBorderBottom2:Hide()

2. You can remove the border from every slot frame like this, not sure how can you override this yet:

CharacterHeadSlot:DisableDrawLayer("Background")
CharacterNeckSlot:DisableDrawLayer("Background")
CharacterShoulderSlot:DisableDrawLayer("Background")
CharacterBackSlot:DisableDrawLayer("Background")
CharacterChestSlot:DisableDrawLayer("Background")
CharacterShirtSlot:DisableDrawLayer("Background")
CharacterTabardSlot:DisableDrawLayer("Background")
CharacterWristSlot:DisableDrawLayer("Background")
CharacterHandsSlot:DisableDrawLayer("Background")
CharacterWaistSlot:DisableDrawLayer("Background")
CharacterLegsSlot:DisableDrawLayer("Background")
CharacterFeetSlot:DisableDrawLayer("Background")
CharacterFinger0Slot:DisableDrawLayer("Background")
CharacterFinger1Slot:DisableDrawLayer("Background")
CharacterTrinket0Slot:DisableDrawLayer("Background")
CharacterTrinket1Slot:DisableDrawLayer("Background")
CharacterMainHandSlot:DisableDrawLayer("Background")
CharacterSecondaryHandSlot:DisableDrawLayer("Background")

3. Easiest way to do that is to extract the "Data/interface.MPQ/Interface/PaperDoll" folder with an MPQ extractor (I would suggest to use the MPQ Plugin for Total Commander), then copy this into your "Interface" folder, than just edit the images, but keep the names.

4. Use this code:

if ShowUIPanel then
    hooksecurefunc("ShowUIPanel", function(self)
        if self == CharacterFrame then
            CharacterFrame:ClearAllPoints()
            CharacterFrame:SetPoint("CENTER", UIParent, "CENTER", 0, 0)
        end
    end)
end
if CharacterFrame_Collapse then
    hooksecurefunc("CharacterFrame_Collapse", function(self)
        CharacterFrame:ClearAllPoints()
        CharacterFrame:SetPoint("CENTER", UIParent, "CENTER", 0, 0)
    end)
end
if CharacterFrame_Expand then
    hooksecurefunc("CharacterFrame_Expand", function(self)
        CharacterFrame:ClearAllPoints()
        CharacterFrame:SetPoint("CENTER", UIParent, "CENTER", 0, 0)
    end)
end

[saxitoxin]

Originally Posted by Resike ...

thanks for the answers, all worked but point 3
the icon I want to change is the same icon used by the chestslot, also this is why I want to change it. So I was wondering if I could override the texture selected for the back slot with my own texture?

[Resike]

Originally Posted by saxitoxin thanks for the answers, all worked but point 3 the icon I want to change is the same icon used by the chestslot, also this is why I want to change it. So I was wondering if I could override the texture selected for the back slot with my own texture?

Couln't find where does the game load those textures, if it's in the C code, then you can't really alter it.

Edit: Victory, try this code:

local frame = CreateFrame("FRAME")
frame:RegisterEvent("PLAYER_ENTERING_WORLD")
 
local function IsProtected(frame)
    if frame:IsProtected() and InCombatLockdown() then
        return true
    end
    return false
end
 
local function SetTexture(frame, texture)
    if IsProtected(frame) then
        return
    end
    if frame.lockTexture then
        local p = frame.lockTexture
        frame.lockTexture = nil
        frame:SetTexture(texture)
        frame.lockTexture = p
    end
end
 
local function LockTexture(frame)
    if IsProtected(frame) then
        return
    end
    if not frame.lockTexture then
        if not frame.lockTextureHook then
            hooksecurefunc(frame, "SetTexture", function(self)
                local id = GetInventoryItemID("player", GetInventorySlotInfo("BackSlot"))
                if id then
                    local texture = GetInventoryItemTexture("player", GetInventorySlotInfo("BackSlot"))
                    SetTexture(self, texture)
                else
                    local texture = "Interface\\PaperDoll\\UI-PaperDoll-Slot-SecondaryHand"
                    SetTexture(self, texture)
                end
            end)
            frame.lockTextureHook = true
        end
        frame.lockTexture = true
    end
end
 
local function UnlockTexture(frame)
    frame.lockTexture = nil
end
 
frame:SetScript("OnEvent", function(self, event, ...)
    LockTexture(CharacterBackSlotIconTexture)
end)

Just edit "Interface\\PaperDoll\\UI-PaperDoll-Slot-SecondaryHand" to any texture you want to use.

[Phanx]

That seems... incredibly overcomplicated. Nothing in the character frame is ever "protected" (that's only for the in-game store UI) and texture objects are never secure, so you can freely manipulate them in combat without any danger. Assuming the frame name and texture path in your code are correct, all you should need is this:

local setting
hooksecurefunc(CharacterBackSlotIconTexture, "SetTexture", function(self, texture)
     if not setting and string.find(texture, "PaperDoll") then
          setting = true
          self:SetTexture("Interface\\PaperDoll\\UI-PaperDoll-Slot-SecondaryHand")
          setting = nil
     end
end)

[Resike]

Originally Posted by Phanx That seems... incredibly overcomplicated. Nothing in the character frame is ever "protected" (that's only for the in-game store UI) and texture objects are never secure, so you can freely manipulate them in combat without any danger. Assuming the frame name and texture path in your code are correct, all you should need is this: local setting hooksecurefunc(CharacterBackSlotIconTexture, "SetTexture", function(self, texture) if not setting and string.find(texture, "PaperDoll") then setting = true self:SetTexture("Interface\\PaperDoll\\UI-PaperDoll-Slot-SecondaryHand") setting = nil end end)

The only reason i wrote it like that, so i could use this LockTexture in the future in other frames. I'm not sure about textures cannot be protected or not, since you could use a simple texture as a button, and also has SetPoint and ClearAllPoint methods, i just went with the safe method, but you could be right. The issue with your code, the game using the same texture for empty and equipped slots, so you need to add this:

local setting
hooksecurefunc(CharacterBackSlotIconTexture, "SetTexture", function(self, texture)
    if not setting and string.find(texture, "PaperDoll") then
        setting = true
        local id = GetInventoryItemID("player", GetInventorySlotInfo("BackSlot"))
        if id then
            local texture = GetInventoryItemTexture("player", GetInventorySlotInfo("BackSlot"))
            self:SetTexture(texture)
        else
            local texture = "Interface\\PaperDoll\\UI-PaperDoll-Slot-SecondaryHand"
            self:SetTexture(texture)
        end
        setting = nil
    end
end)

[saxitoxin]

Thanks alot for solutions to my problems, You have been to alot of help the both of you

[Phanx]

Originally Posted by Resike I'm not sure about textures cannot be protected or not, since you could use a simple texture as a button, and also has SetPoint and ClearAllPoint methods, i just went with the safe method, but you could be right.

You can't use a texture as a button. Textures have no mouse interactivity features whatsoever. You can put a texture on a button, which is maybe what you're thinking of.

Originally Posted by Resike The issue with your code, the game using the same texture for empty and equipped slots, so you need to add this:

Yes, that's what the string.find already accounts for -- equipped item textures will not have "PaperDoll" in their path, because item textures are all in "Interface\\Icons".

[Resike]

Originally Posted by Phanx You can't use a texture as a button. Textures have no mouse interactivity features whatsoever. You can put a texture on a button, which is maybe what you're thinking of.

I mixed it up with models, models can have pretty much any script functions as a button.

Originally Posted by Phanx Yes, that's what the string.find already accounts for -- equipped item textures will not have "PaperDoll" in their path, because item textures are all in "Interface\\Icons".

Makes sense.

[Lombra]

There's a perfect event to use for the texture thing, too. You should be able to use the frame in question, I reckon.

CharacterBackSlot:HookScript("OnEvent", function(self, event, slot, hasItem)
	if event == "PLAYER_EQUIPMENT_CHANGED" and slot == self:GetID() and not hasItem then
		self.icon:SetTexture([[stuff]])
	end
end)

[Resike]

Originally Posted by Lombra There's a perfect event to use for the texture thing, too. You should be able to use the frame in question, I reckon. CharacterBackSlot:HookScript("OnEvent", function(self, event, slot, hasItem) if event == "PLAYER_EQUIPMENT_CHANGED" and slot == self:GetID() and not hasItem then self.icon:SetTexture([[stuff]]) end end)

Nope, the event is okay, but the server side is very slow handling the items you equip or put them into bags or delete them, so the texture changes will be late and glitchy.

[Phanx]

Originally Posted by Resike Nope, the event is okay, but the server side is very slow handling the items you equip or put them into bags or delete them, so the texture changes will be late and glitchy.

There's also no guarantee that your handler for that event will be run before the default UI's handler for the same event. Hooking the actual texture change is a better solution all around.

[Lombra]

Originally Posted by Phanx There's also no guarantee that your handler for that event will be run before the default UI's handler for the same event. Hooking the actual texture change is a better solution all around.

Before? You mean after? I'm hooking the button in question, so it will run afterwards, and I'm pretty sure this is the event that's used by the default UI to update the texture, so there should be no way it could fail. Seems less hacky than hooking SetTexture, to me.

[Resike]

Originally Posted by Lombra Before? You mean after? I'm hooking the button in question, so it will run afterwards, and I'm pretty sure this is the event that's used by the default UI to update the texture, so there should be no way it could fail. Seems less hacky than hooking SetTexture, to me.

Yes but it runs after the server updated the values and vertified the item change, which takes much longer time, while the SetTexture runs in the middle of the change. At least that method seems to be smoother for me.
Also since i couldnt find where does the default UI set/update thoose textures in the Interface code, it probably gets updated in the C code.

[Phanx]

Originally Posted by Lombra Before? You mean after? I'm hooking the button in question, so it will run afterwards, and I'm pretty sure this is the event that's used by the default UI to update the texture, so there should be no way it could fail. Seems less hacky than hooking SetTexture, to me.

No, I mean, if two frames are registered for the same event, you can't guarantee which frame's event handler will run first. In practice they are usually run in the order registered, but it's technically undefined, like the order in which values are returned from pairs, so you shouldn't rely on it.

Originally Posted by Resike Also since i couldnt find where does the default UI set/update thoose textures in the Interface code, it probably gets updated in the C code.

PaperDollFrame.lua#2418

And after reading that it looks like the whole issue of hooking is irrelevant, and you can just change the default texture for any slot by putting the path to the desired texture under the "backgroundTextureName" key on the slot frame:

CharacterBackSlot.backgroundTextureName = "Path\\To\\MyNewEmptyCloakTexture"

Then the default UI will use that texture for the empty slot instead of the default one.

Source:
PaperDollFrame.lua#2289

[Resike]

Originally Posted by Phanx No, I mean, if two frames are registered for the same event, you can't guarantee which frame's event handler will run first. In practice they are usually run in the order registered, but it's technically undefined, like the order in which values are returned from pairs, so you shouldn't rely on it. PaperDollFrame.lua#2418 And after reading that it looks like the whole issue of hooking is irrelevant, and you can just change the default texture for any slot by putting the path to the desired texture under the "backgroundTextureName" key on the slot frame: CharacterBackSlot.backgroundTextureName = "Path\\To\\MyNewEmptyCloakTexture" Then the default UI will use that texture for the empty slot instead of the default one. Source: PaperDollFrame.lua#2289

Dayum, i just grepwin to slotnames, thats why i couln't find it.
Anyway based on this it would be intresting to write an addon to override item icontextures with their transmog icon.

[Lombra]

Originally Posted by Resike Yes but it runs after the server updated the values and vertified the item change, which takes much longer time, while the SetTexture runs in the middle of the change. At least that method seems to be smoother for me.

I don't understand. You can't update the texture until the server has made the change and sent the event to the client; the API returns won't be up to date until then. The default UI calls SetTexture in response to this event.

Originally Posted by Phanx No, I mean, if two frames are registered for the same event, you can't guarantee which frame's event handler will run first. In practice they are usually run in the order registered, but it's technically undefined, like the order in which values are returned from pairs, so you shouldn't rely on it.

Maybe. Either way, it's not two different frames. The slot buttons (eg CharacterBackSlot) are the frames responsible for setting their own textures. Although come to think of it, not sure if some other event updated the texture as well.

Anyway, setting that field will be better of course.

[Resike]

Originally Posted by Lombra I don't understand. You can't update the texture until the server has made the change and sent the event to the client; the API returns won't be up to date until then. The default UI calls SetTexture in response to this event.

If you hook both function/event then you can see that the SetTexture runs before the equip change:

hooksecurefunc(CharacterBackSlotIconTexture, "SetTexture", function(self, texture)
    print(self:GetTexture())
end)
 
CharacterBackSlot:HookScript("OnEvent", function(self, event, slot, hasItem)
    if event == "PLAYER_EQUIPMENT_CHANGED" then
        print(event)
    end
end)

And it should because when the equip change event triggers, you should be able to access the newly equipped item's texture properly. Between this 2 events the game still sets the original background texture, and in some cases it could be visible.

[Lombra]

The original SetTexture will be called before the OnEvent hook, yes, but it's still not really any different. SetTexture is done as part of the original event handler, which gets called before the hook. They both wait for the server to send the event.

There will never be any visible flicker as a result of these kind of things, because the UI isn't drawn until all code has finished executing.

[Resike]

Originally Posted by Lombra The original SetTexture will be called before the OnEvent hook, yes, but it's still not really any different. SetTexture is done as part of the original event handler, which gets called before the hook. They both wait for the server to send the event. There will never be any visible flicker as a result of these kind of things, because the UI isn't drawn until all code has finished executing.

Not sure, the first method i tried was based on this event, and i had some issues so mainly thats why i went with the settexture hook.