GameTooltip:GetItem() empty name and link

[evilbib]

Hey there,

so some tooltips return empty values (name = "" and link = []) if you use GameTooltip:GetItem(), for example tooltips from the QuestFrame and I believe the TradeSkillFrame.
My interface has item quality border coloring for tooltips but obviously not for said tooltips.

GameTooltip:HookScript('OnTooltipSetItem', function(self)
    local name, item = self:GetItem()
    if (item) then
        local quality = select(3, GetItemInfo(item))
        if (quality) then
            local r, g, b = GetItemQualityColor(quality)
            self:SetBeautyBorderTexture('white')
            self:SetBeautyBorderColor(r, g, b)
        else
            self:SetBeautyBorderTexture('white')
            self:SetBeautyBorderColor(1, 1, 1)
        end
    end
end)

I tried it with this function (this probably works only for quest items though)

name, texture, numItems, quality, isUsable = GetQuestItemInfo("type", index)

but the problem is that I have no idea how to get the index from the item I hover over.
Anyone has an idea how to approach this?

update:
The are six QuestProgressItem buttons according to the QuestFrame.xml, so I just hooked them all.
No idea if this is a good way to do this but it seems to be working.

for i = 1, 6 do 
    local questprog = _G['QuestProgressItem'..i]
    questprog:HookScript('OnEnter', function(self)
        local ID = self:GetID()
        local questitemtype = self.type
        local link = GetQuestItemLink(questitemtype, ID)
        if (link) then
            local quality = select(3, GetItemInfo(link))
            if (quality) then
                local r, g, b = GetItemQualityColor(quality)
                GameTooltip:SetBeautyBorderTexture('white')
                GameTooltip:SetBeautyBorderColor(r, g, b)
            end
        end
    end)
end

update2:
and here for the TradeSkillFrame

if (not TradeSkillFrame) then
    LoadAddOn('Blizzard_TradeSkillUI')
end
for i = 1, 8 do
    local tsr = _G['TradeSkillReagent'..i]
    tsr:HookScript('OnEnter', function(self)
        local ID = self:GetID()
        local skillindex = TradeSkillFrame.selectedSkill
        local link = GetTradeSkillReagentItemLink(skillindex, ID)
        if (link) then
            local quality = select(3, GetItemInfo(link))
            if (quality) then
                local r, g, b = GetItemQualityColor(quality)
                GameTooltip:SetBeautyBorderTexture('white')
                GameTooltip:SetBeautyBorderColor(r, g, b)
            end
        end
    end)
end
hooksecurefunc('TradeSkillItem_OnEnter', function(self)
    local link = GetTradeSkillItemLink(TradeSkillFrame.selectedSkill)
    if (link) then
        local quality = select(3, GetItemInfo(link))
        if (quality) then
            local r, g, b = GetItemQualityColor(quality)
            GameTooltip:SetBeautyBorderTexture('white')
            GameTooltip:SetBeautyBorderColor(r, g, b)
        end
    end
end)

But still I wonder if this is a good way to do it.

[Phanx]

Originally Posted by pingumania and here for the TradeSkillFrame if (not TradeSkillFrame) then     LoadAddOn('Blizzard_TradeSkillUI') end -- stuff happens here But still I wonder if this is a good way to do it.

That isn't; you should avoid forcibly loading any Blizzard addons, as they're not designed to handle that and you may cause other problems. A better way:

local function setupTradeSkillUI()
   -- stuff happens here
end
if TradeSkillFrame then
   setupTradeSkillUI()
else
   local f = CreateFrame("Frame")
   f:RegisterEvent("ADDON_LOADED")
   f:SetScript("OnEvent", function(f, event, name)
      if name == "Blizzard_TradeSkillUI" then
         setupTradeSkillUI()
      end
   end)
end

If you end up needing to wait for multiple addons to load, you can do it all from one frame:

local setupFuncs = {}

-- Blizzard_TradeSkillUI
tinsert(setupFuncs, function()
   if not TradeSkillFrame then
      return true
   end
   -- do your stuff here
end)

-- Some other addon
tinsert(setupFuncs, function()
   if not MagicalUnicornsFrame then
      return true
   end
   -- do stuff with MagicalUnicornsFrame and/or the addon that created it
end)

local f = CreateFrame("Frame")
f:RegisterEvent("ADDON_LOADED")
f:SetScript("OnEvent", function()
   for i = #setupFuncs, 1, -1 do
      local tryAgain = setupFuncs[i]()
      -- If it returned true, keep it and try again on the next event,
      -- otherwise it's done, so remove it from the table.
      if not tryAgain then
         tremove(setupFuncs, i)
         -- ^ Removing entries as we go is why we're looping backwards.
      end
   end
end)

I use this tactic in a few personal addons (border, general mods, etc.). The reason for using a simple list (indexed table) instead of using addon names as table keys is that not all addons are ready to hook/modify as soon as they load. Depending on what addons you're waiting for, you may need to listen for additional events to detect when they're ready to do stuff with.

[SDPhantom]

If your addon isn't doing anything until Blizzard_TradeSkillUI loads, then you should use the LoadWith tag in your TOC to tell the game to load your addon when Blizzard_TradeSkillUI does.

## LoadWith: Blizzard_TradeskillUI

[Phanx]

Based on the rest of the first post it appears to be a general tooltip modification, so it's handling all tooltips, not just ones coming from the tradeskill UI.

[Lombra]

Not fixed on PTR, so I'm looking at implementing workarounds for this, too. Not sure if it's better, but I'm leaning towards hooking the tooltip functions instead. (GameTooltip:SetQuestItem) Then you don't need to bother with waiting for addons to load, and it should be compatible with addons that replace the default quest frame.