SetOverrideBindingClick and unnamed buttons

[MunkDev]

Was curious if it's possible to override a binding to an unnamed button, using the click method.

Here are the arguments:
SetOverrideBindingClick(owner, isPriority, "key", "buttonName" [, "mouseButton"])

Since it doesn't actually take a frame reference but rather the name of the frame that should be clicked, this causes problem in dynamic environments where the buttons don't have names. Examples are plenty, but to name a few: quest log entries, POIs on the world map, garrison plots, etc. These buttons are indeed clickable, but lack names due to being dynamically added.

My idea was to add global references to these buttons, since I was hoping that the function uses the global namespace to find the button objects, but that doesn't seem to be the case. Dumping the reference node once it's been assigned does return the button in question, but it does not work in the override function as a name replacement.
This code runs fine on all buttons that are named when created. Is it possible to name these buttons post-creation?

Here's the code I'm using that doesn't work:

local addOn, db = ...
 
local function AddReference(node)
    local reference = addOn.."ReferenceNode"
    _G[reference] = node
    return reference
end
 
local function EnterNode(self, node)
    if node:IsEnabled() then
        local name = node:GetName() or AddReference(node)
        self:OverrideBindingClick(Cursor, "CP_R_RIGHT", name, "LeftButton")
        self:OverrideBindingClick(Cursor, "CP_R_LEFT", name, "RightButton")
        local enter = node:GetScript("OnEnter")
        node:LockHighlight()
        if enter then
            enter(node)
        end
    end
end

And here's the function wrapper that overrides the bindings:

function ConsolePort:OverrideBindingClick(owner, old, button, mouseClick)
    if not InCombatLockdown() then
        local key1, key2 = GetBindingKey(old)
        if key1 then SetOverrideBindingClick(owner, true, key1, button, mouseClick) end
        if key2 then SetOverrideBindingClick(owner, true, key2, button, mouseClick) end
    end
end

Edit: Adding image, demonstrating the issue.

[Lombra]

Not sure about retroactively specifying names. I doubt it.

Maybe you could make your own secure button wrappers, and have them click the unnamed buttons. The clickbutton attribute should work with frame references.

[MunkDev]

Originally Posted by Lombra Not sure about retroactively specifying names. I doubt it. Maybe you could make your own secure button wrappers, and have them click the unnamed buttons. The clickbutton attribute should work with frame references.

Yup, this is what I do currently. The problem is the damn HybridScrollFrames. SecureActionButtonTemplate doesn't seem to send both key states to the clickbutton, regardless of specifying runOnUp="true" in bindings.xml or using btn:RegisterForClicks("LeftButtonUp", "LeftButtonDown") on a secure action button.

The clickbutton action only seems to run on button up, meaning the scroll buttons on HybridScrollFrames only receive the key release. A quick glance in game will show you that the scrolling happens when you press down on the buttons, not up. I also can't replace or mess with the functions provided by the templated HybridScrollFrame because it will taint things, such as the GlyphFrame.

function HybridScrollFrame_OnMouseWheel (self, delta, stepSize)
    if ( not self.scrollBar:IsVisible() ) then
        return;
    end
    
    local minVal, maxVal = 0, self.range;
    stepSize = stepSize or self.stepSize or self.buttonHeight;
    if ( delta == 1 ) then
        self.scrollBar:SetValue(max(minVal, self.scrollBar:GetValue() - stepSize));
    else
        self.scrollBar:SetValue(min(maxVal, self.scrollBar:GetValue() + stepSize));
    end
end
 
function HybridScrollFrameScrollButton_OnClick (self, button, down)
    local parent = self.parent or self:GetParent():GetParent();
    
    if ( down ) then
        self.timeSinceLast = (self.timeToStart or -0.2);
        self:SetScript("OnUpdate", HybridScrollFrameScrollButton_OnUpdate);
        HybridScrollFrame_OnMouseWheel (parent, self.direction);
        PlaySound("UChatScrollButton");
    else
        self:SetScript("OnUpdate", nil);
    end
end

[SDPhantom]

I'm not sure if it would work, but have you tried assigning a reference to the button to a global, then giving SetOverideBindingClick() the name of the global?

[MunkDev]

Originally Posted by SDPhantom I'm not sure if it would work, but have you tried assigning a reference to the button to a global, then giving SetOverideBindingClick() the name of the global?

I thought that's what I was attempting to do?

I thought that would work, too, but it fails silently. Even if it does technically work, the binding still does nothing as opposed to binding a named button.

[SDPhantom]

You keep overwriting it, which might be what's messing up the binding. You need a unique global for each button.

[MunkDev]

Originally Posted by SDPhantom You keep overwriting it, which might be what's messing up the binding. You need a unique global for each button.

Tried adding an incremental integer at the end of the name, but to no avail. Using a compromise between overriding when it comes to scrollbuttons but using the clickbutton attribute sure works, but I'd rather make the override work since I won't have to fake up/down states with that.

Here's what that compromise looks like:

local function EnterNode(self, node)
    if node:IsEnabled() then
        local name = node:GetName() or AddReference(node)
        -- randomly picked direction because it seems to uniquely exist on scrollbuttons
        if node.direction then
            self:OverrideBindingClick(Cursor, "CP_R_RIGHT", name, "LeftButton")
            self:OverrideBindingClick(Cursor, "CP_R_LEFT", name, "RightButton")
        else
            self:SetClickButton(CP_R_RIGHT_NOMOD, node)
            -- right click will never work on unnamed frames using this approach
            self:OverrideBindingClick(Cursor, "CP_R_LEFT", name, "RightButton")
        end
        local enter = node:GetScript("OnEnter")
        node:LockHighlight()
        if enter then
            enter(node)
        end
    else
        self:SetClickButton(CP_R_RIGHT_NOMOD, doNothing)
    end
end

function ConsolePort:SetClickButton (button, clickbutton)
    button:SetAttribute("type", "click")
    button:SetAttribute("clickbutton", clickbutton)
end

CP_R_RIGHT_NOMOD is a secure action button.