Adding something to a small addon.

[Lesteryoung]

Hey, I found and partially made this addon that adds percent health to the default nameplates. I want to add to it that the percent only show on nameplates that are less than 100%. Could someone tell me how to do this or just do it for me? Much appreciated if anyone responds.

Here's the code:

CreateFrame('frame'):SetScript('OnUpdate', function(self, elapsed)
  for index = 1, select('#', WorldFrame:GetChildren()) do
        local f = select(index, WorldFrame:GetChildren())
        if f:GetName() and f:GetName():find('NamePlate%d') then
          f.h = select(1, select(1, f:GetChildren()):GetChildren())
          if f.h then
         if not f.h.v then
           f.h.v = f.h:CreateFontString(nil, "ARTWORK")  
           f.h.v:SetPoint("CENTER", 5, 0)
           f.h.v:SetFont(STANDARD_TEXT_FONT, 9, 'OUTLINE')
         else
           local _, maxh = f.h:GetMinMaxValues()
           local val = f.h:GetValue()
           f.h.v:SetText(string.format(math.floor((val/maxh)*100)).." %")
         end
          end
        end
  end
end)

[SDPhantom]

Please give meaningful names to your variables. Variable names such as f.h and f.h.v are bordering on obfuscation, which is a violation on Blizzard's Addon Policy.

2) Add-on code must be completely visible. The programming code of an add-on must in no way be hidden or obfuscated, and must be freely accessible to and viewable by the general public. World of Warcraft User Interface Add-On Development Policy

f.h = select(1, select(1, f:GetChildren()):GetChildren())

On another note, you should avoid making select(1,...) calls. It just wastes CPU cycles on a meaningless function call and does absolutely nothing.



With these and a few other optimizations in mind, here's what I could work out.

--  This table will link the StatusBars to our FontStrings
--  This is to keep the nameplate tables clean
local TextObjects={};
 
--  This processes the WorldFrame's children and populates our lookup table
local function ProcessWorldFrameChildren(...)
--  Scan through the children listed in our args
--  Dynamic indexing of arguments is the only practical use of select()
    for i=1,select("#",...) do
        local nameplate=select(i,...);
 
--      When we refer to a return from a function, call once, cache the value in a local, and check the local instead of using redundant calls
        local name=nameplate:GetName();
        if name and name:find("^NamePlate%d+$") then
--          No use of select() here, only the first return of these function calls are used anyway
            local statusbar=nameplate:GetChildren():GetChildren();
 
--          If we don't have a FontString for this StatusBar, we create one
            if not TextObjects[statusbar] then
                local text=statusbar:CreateFontString(nil,"OVERLAY");
                text:SetPoint("CENTER",5,0);
                text:SetFont(STANDARD_TEXT_FONT,9,"OUTLINE");-- Honestly, this is a copy of GameFontWhiteTiny
                text:SetTextColor(1,1,1);-- White color
 
--              Now we store the FontString in our lookup table
                TextObjects[statusbar]=text;
            end
        end
    end
end
 
--  We're avoiding wasting resources on an extra frame by hooking onto the WorldFrame
WorldFrame:HookScript("OnUpdate",function(self)
    ProcessWorldFrameChildren(WorldFrame:GetChildren());--  Look for new nameplates and register them
    for statusbar,text in pairs(TextObjects) do
--      Check if the nameplate is being rendered, the StatusBar will be visible if so, this is different than :IsShown()
        if statusbar:IsVisible() then
            local current=statusbar:GetValue();
            local _,max=statusbar:GetMinMaxValues();
            local percent=math.ceil(100*current/max);
 
            text:SetShown(percent<100);--   This controls when the text is shown
            text:SetFormattedText("%d%%",percent);
        end
    end
end);

[Tonyleila]

Have you Seen this one?
http://www.wowinterface.com/download...ameplates.html

[Lesteryoung]

Thanks so much Phantom!

Works fine and I learned a few things in the process.

I have a quick question, can I remove the text you wrote and take any blank space out to make it look cleaner. I'll use this addon forever so just asking in case I can make it look better in notepad.

Hopefully not being too picky. If I am don't bother responding. Thanks again!

[SDPhantom]

Originally Posted by Tonyleila Have you Seen this one? http://www.wowinterface.com/download...ameplates.html

This is the exact code the OP posted, he wanted a modification to only show when below 100%.

Originally Posted by Lesteryoung I have a quick question, can I remove the text you wrote and take any blank space out to make it look cleaner. I'll use this addon forever so just asking in case I can make it look better in notepad.

It'll work fine without the comments. They were just to point out improvements made with the new code and describe what it does. The blank lines, while unnecessary as well, make the code look better by visually defining blocks of code that perform a specific purpose.

PS: While Notepad does get the job done, you might want to look into a better IDE to use like Notepad++ or SciTE. Both are free and come with useful features for writing code.

[Lesteryoung]

Hey, can you set the font as a decimal or will it just round up or down to the nearest whole number?

[SDPhantom]

The height is measured in pixels, so anything other than a whole integer shouldn't visibly do anything.