Reputation Bar Issue

Aftermathhqt · 11-21-14, 12:34 PM

Hi everyone!

I have some issues with FACTION_BAR_COLORS.

Why i dont know

Lua Code:

Message: ...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:60: attempt to index field '?' (a nil value)
Time: 11/21/14 19:31:37
Count: 2
Stack: ...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:60: in function <...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:55>
 
Locals: FactionColors = <table> {
 6 = <table> {
 }
 2 = <table> {
 }
 8 = <table> {
 }
 3 = <table> {
 }
 1 = <table> {
 }
 4 = <table> {
 }
 5 = <table> {
 }
 7 = <table> {
 }
}
Name = nil
ID = 0
Min = 0
Max = 0
Value = 0
(*temporary) = <function> defined =[C]:-1
(*temporary) = <unnamed> {
 0 = <userdata>
 Shadow = <table> {
 }
 fadeInfo = <table> {
 }
 HasBorder = true
 Border = <table> {
 }
}
(*temporary) = nil
(*temporary) = <userdata>
(*temporary) = <userdata>
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field '?' (a nil value)"
ReputationBar = <unnamed> {
 0 = <userdata>
 Shadow = <table> {
 }
 fadeInfo = <table> {
 }
 HasBorder = true
 Border = <table> {
 }
}
ReputationBarFont = <unnamed> {
 0 = <userdata>
}

Lua Code:

if AftermathhUI.plugins.repbar == false then return end
 
local Reputation = CreateFrame("Frame", nil, UIParent)
 
local ReputationBar = CreateFrame('StatusBar', nil, UIParent)
 
local InvisFrame = CreateFrame("Frame", nil, ReputationBar)
InvisFrame:SetFrameStrata("HIGH")
InvisFrame:SetFrameLevel(5)
InvisFrame:SetAllPoints()
 
local ReputationBarFont = InvisFrame:CreateFontString(nil, 'OVERLAY')   
 
ReputationBar:SetPoint('LEFT', oUF_AftermathhPlayer, 223, -178)
ReputationBar:SetStatusBarTexture(AftermathhUI.media.texture)
ReputationBar:SetSize(235, 20)
ReputationBar:SetBackdrop({
    bgFile = AftermathhUI.media.blank,
    insets = {top = -1, left = -1, bottom = -1, right = -1},
    })
ReputationBar:SetBackdropColor(unpack(AftermathhUI.media.backdropcolor))
 
CreateBorderLight(ReputationBar, AftermathhUI.media.bordersize, AftermathhUI.bordercolor, AftermathhUI.bordercolor, AftermathhUI.bordercolor, 3)
    
ReputationBar:SetScript("OnEnter", function(self)
    if (not GetWatchedFactionInfo()) then
        return
    end 
 
    local Name, ID, Min, Max, Value = GetWatchedFactionInfo()
    GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
    GameTooltip:AddLine(string.format("%s (%s)", Name, _G["FACTION_STANDING_LABEL" .. ID]))
    GameTooltip:AddLine(string.format("%d / %d (%d%%)", Value - Min, Max - Min, (Value - Min) / (Max - Min) * 100), 1, 1, 1, 1, 1, 1)
    GameTooltip:Show()
    GameTooltip:Show()
end)
    
ReputationBar:SetScript("OnLeave", function()
    if GameTooltip:IsShown() then
    GameTooltip:Hide()
    end
end)
 
ReputationBar:SetAlpha(0)
ReputationBar:HookScript("OnEnter", function(self) UIFrameFadeIn(self, 1.2, self:GetAlpha(), 1) end)
ReputationBar:HookScript("OnLeave", function(self) UIFrameFadeIn(self, 0.8, self:GetAlpha(), 0) end)
 
ReputationBarFont:SetPoint('CENTER', ReputationBar)
ReputationBarFont:SetFont(AftermathhUI.media.font, 12, AftermathhUI.media.fontflag) 
if AftermathhUI.media.shadowoffset == true then
    ReputationBarFont:SetShadowOffset(1, -1)
    ReputationBarFont:SetShadowColor(0,0,0)
end
 
local function UpdateRep()
    local FactionColors = FACTION_BAR_COLORS
    local Name, ID, Min, Max, Value = GetWatchedFactionInfo()   
    ReputationBar:SetMinMaxValues(Min, Max)
    ReputationBar:SetValue(Value)
    ReputationBar:SetStatusBarColor(FactionColors[ID].r, FactionColors[ID].g, FactionColors[ID].b)
    ReputationBarFont:SetText(""..Min.." / "..Max.." - "..Name.."")
end
 
Reputation:RegisterEvent("UPDATE_FACTION")
Reputation:RegisterEvent("PLAYER_ENTERING_WORLD")
 
Reputation:SetScript("OnEvent", UpdateRep)

myrroddin · 11-21-14, 01:01 PM

Try this:

Code:

-- comment out or remove line 56
ReputationBar:SetValue(Value)
local c = FACTION_BAR_COLORS[ID]
ReputationBar:SetStatusBarColor(c.r * 255, c.g * 255, c.b * 255)
ReputationBarFont:SetText(""..Min.." / "..Max.." - "..Name.."")

Aftermathhqt · 11-21-14, 01:18 PM

Originally Posted by myrroddin

Try this:

Code:

-- comment out or remove line 56
ReputationBar:SetValue(Value)
local c = FACTION_BAR_COLORS[ID]
ReputationBar:SetStatusBarColor(c.r * 255, c.g * 255, c.b * 255)
ReputationBarFont:SetText(""..Min.." / "..Max.." - "..Name.."")

Seems to work, but now this happen

Lua Code:

Message: ...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:59: attempt to concatenate local 'Name' (a nil value)
Time: 11/21/14 20:18:28
Count: 8
Stack: ...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:59: in function <...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:55>
 
Locals: Name = nil
ID = 0
Min = 0
Max = 0
Value = 0
(*temporary) = <function> defined =[C]:-1
(*temporary) = <unnamed> {
 0 = <userdata>
}
(*temporary) = ""
(*temporary) = 0
(*temporary) = " / "
(*temporary) = 0
(*temporary) = " - "
(*temporary) = nil
(*temporary) = ""
(*temporary) = "attempt to concatenate local 'Name' (a nil value)"
ReputationBar = <unnamed> {
 0 = <userdata>
 Shadow = <table> {
 }
 Border = <table> {
 }
 HasBorder = true
}
ReputationBarFont = <unnamed> {
 0 = <userdata>
}

Lua Code:

if AftermathhUI.plugins.repbar == false then return end
 
local Reputation = CreateFrame("Frame", nil, UIParent)
 
local ReputationBar = CreateFrame('StatusBar', nil, UIParent)
 
local InvisFrame = CreateFrame("Frame", nil, ReputationBar)
InvisFrame:SetFrameStrata("HIGH")
InvisFrame:SetFrameLevel(5)
InvisFrame:SetAllPoints()
 
local ReputationBarFont = InvisFrame:CreateFontString(nil, 'OVERLAY')   
 
ReputationBar:SetPoint('LEFT', oUF_AftermathhPlayer, 223, -178)
ReputationBar:SetStatusBarTexture(AftermathhUI.media.texture)
ReputationBar:SetSize(235, 20)
ReputationBar:SetBackdrop({
    bgFile = AftermathhUI.media.blank,
    insets = {top = -1, left = -1, bottom = -1, right = -1},
    })
ReputationBar:SetBackdropColor(unpack(AftermathhUI.media.backdropcolor))
 
CreateBorderLight(ReputationBar, AftermathhUI.media.bordersize, AftermathhUI.bordercolor, AftermathhUI.bordercolor, AftermathhUI.bordercolor, 3)
    
ReputationBar:SetScript("OnEnter", function(self)
    if (not GetWatchedFactionInfo()) then
        return
    end 
 
    local Name, ID, Min, Max, Value = GetWatchedFactionInfo()
    
    GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
    GameTooltip:AddLine(string.format("%s (%s)", Name, _G["FACTION_STANDING_LABEL" .. ID]))
    GameTooltip:AddLine(string.format("%d / %d (%d%%)", Value - Min, Max - Min, (Value - Min) / (Max - Min) * 100), 1, 1, 1, 1, 1, 1)
    GameTooltip:Show()
    GameTooltip:Show()
end)
    
ReputationBar:SetScript("OnLeave", function()
    if GameTooltip:IsShown() then
    GameTooltip:Hide()
    end
end)
 
ReputationBar:SetAlpha(0)
ReputationBar:HookScript("OnEnter", function(self) UIFrameFadeIn(self, 1.2, self:GetAlpha(), 1) end)
ReputationBar:HookScript("OnLeave", function(self) UIFrameFadeIn(self, 0.8, self:GetAlpha(), 0) end)
 
ReputationBarFont:SetPoint('CENTER', ReputationBar)
ReputationBarFont:SetFont(AftermathhUI.media.font, 12, AftermathhUI.media.fontflag) 
if AftermathhUI.media.shadowoffset == true then
    ReputationBarFont:SetShadowOffset(1, -1)
    ReputationBarFont:SetShadowColor(0,0,0)
end
 
local function UpdateRep()
    local Name, ID, Min, Max, Value = GetWatchedFactionInfo()   
    
    ReputationBar:SetMinMaxValues(Min, Max)
    ReputationBar:SetValue(Value)
    ReputationBarFont:SetText(""..Min.." / "..Max.." - "..Name.."")
 
    local FactionColors = FACTION_BAR_COLORS[ID]
    ReputationBar:SetStatusBarColor(FactionColors.r, FactionColors.g, FactionColors.b)
end
 
Reputation:RegisterEvent("UPDATE_FACTION")
Reputation:RegisterEvent("PLAYER_ENTERING_WORLD")
 
Reputation:SetScript("OnEvent", UpdateRep)

myrroddin · 11-21-14, 02:22 PM

line 61 won't work because you are trying to concat strings and numbers incorrectly. You have too many quotes, and also putting both Min and Max in quotes will literally print the words Min and Max, not their values.

Code:

ReputationBarFont:SetText(Min .." / " ..Max .." - " ..Name)

But you are better using

Code:

ReputationBarFont:SetFormattedText("%d / %d - %s", Min, Max, Name)

Aftermathhqt · 11-21-14, 02:34 PM

Originally Posted by myrroddin

line 61 won't work because you are trying to concat strings and numbers incorrectly. You have too many quotes, and also putting both Min and Max in quotes will literally print the words Min and Max, not their values.

Code:

ReputationBarFont:SetText(Min .." / " ..Max .." - " ..Name)

But you are better using

Code:

ReputationBarFont:SetFormattedText("%d / %d - %s", Min, Max, Name)

Oh, i see

This happend :S

Lua Code:

Message: ...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:61: bad argument #4 to 'SetFormattedText' (string expected, got nil)
Time: 11/21/14 21:41:35
Count: 1
Stack: [C]: in function `SetFormattedText'
...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:61: in function <...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:56>
 
Locals: (*temporary) = <unnamed> {
 0 = <userdata>
}
(*temporary) = "%d / %d - %s"
(*temporary) = 0
(*temporary) = 0
(*temporary) = nil
(*temporary) = "string expected, got nil"

Choonstertwo · 11-21-14, 02:47 PM

Originally Posted by Game92

Oh, i see

This happend :S

Lua Code:

Message: ...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:61: bad argument #4 to 'SetFormattedText' (string expected, got nil)
Time: 11/21/14 21:41:35
Count: 1
Stack: [C]: in function `SetFormattedText'
...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:61: in function <...ce\AddOns\AftermathhUI\Modules\Blizzard\AfterRep.lua:56>
 
Locals: (*temporary) = <unnamed> {
 0 = <userdata>
}
(*temporary) = "%d / %d - %s"
(*temporary) = 0
(*temporary) = 0
(*temporary) = nil
(*temporary) = "string expected, got nil"

You're passing a nil value as the fourth argument to SetFormattedText, probably because GetWatchedFactionInfo() returns nil when there's no faction being watched.

You'll need to check that the player is actually watching a faction (i.e. GetWatchedFactionInfo() returns something other than nil) before you try to update the reputation bar. In fact you probably want to hide or disable the bar in some way if no faction is being watched.

myrroddin · 11-21-14, 02:47 PM

Post your full Lua file, please, including any changes. Need to review what it looks like currently.

Aftermathhqt · 11-21-14, 02:59 PM

Guess it should be something like this then?

Lua Code:

if AftermathhUI.plugins.repbar == false then return end
 
local Reputation = CreateFrame("Frame", nil, UIParent)
 
local ReputationBar = CreateFrame('StatusBar', nil, UIParent)
 
local InvisFrame = CreateFrame("Frame", nil, ReputationBar)
InvisFrame:SetFrameStrata("HIGH")
InvisFrame:SetFrameLevel(5)
InvisFrame:SetAllPoints()
 
local ReputationBarFont = InvisFrame:CreateFontString(nil, 'OVERLAY')   
 
ReputationBar:SetPoint('LEFT', oUF_AftermathhPlayer, 223, -178)
ReputationBar:SetStatusBarTexture(AftermathhUI.media.texture)
ReputationBar:SetSize(235, 20)
ReputationBar:SetBackdrop({
    bgFile = AftermathhUI.media.blank,
    insets = {top = -1, left = -1, bottom = -1, right = -1},
    })
ReputationBar:SetBackdropColor(unpack(AftermathhUI.media.backdropcolor))
 
CreateBorderLight(ReputationBar, AftermathhUI.media.bordersize, AftermathhUI.bordercolor, AftermathhUI.bordercolor, AftermathhUI.bordercolor, 3)
    
ReputationBar:SetScript("OnEnter", function(self)
    if (not GetWatchedFactionInfo()) then
        return
    end 
 
    local Name, ID, Min, Max, Value = GetWatchedFactionInfo()
    
    GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
    GameTooltip:AddLine(string.format("%s (%s)", Name, _G["FACTION_STANDING_LABEL" .. ID]))
    GameTooltip:AddLine(string.format("%d / %d (%d%%)", Value - Min, Max - Min, (Value - Min) / (Max - Min) * 100), 1, 1, 1, 1, 1, 1)
    GameTooltip:Show()
    GameTooltip:Show()
end)
    
ReputationBar:SetScript("OnLeave", function()
    if GameTooltip:IsShown() then
    GameTooltip:Hide()
    end
end)
 
ReputationBar:SetAlpha(0)
ReputationBar:HookScript("OnEnter", function(self) UIFrameFadeIn(self, 1.2, self:GetAlpha(), 1) end)
ReputationBar:HookScript("OnLeave", function(self) UIFrameFadeIn(self, 0.8, self:GetAlpha(), 0) end)
 
ReputationBarFont:SetPoint('CENTER', ReputationBar)
ReputationBarFont:SetFont(AftermathhUI.media.font, 12, AftermathhUI.media.fontflag) 
if AftermathhUI.media.shadowoffset == true then
    ReputationBarFont:SetShadowOffset(1, -1)
    ReputationBarFont:SetShadowColor(0,0,0)
end
 
local function UpdateRep()
    if GetWatchedFactionInfo() then
        local Name, ID, Min, Max, Value = GetWatchedFactionInfo()   
    
        ReputationBar:SetMinMaxValues(Min, Max)
        ReputationBar:SetValue(Value)
        ReputationBarFont:SetFormattedText("%d / %d - %s", Min, Max, Name)
 
        local FactionColors = FACTION_BAR_COLORS[ID]
        ReputationBar:SetStatusBarColor(FactionColors.r, FactionColors.g, FactionColors.b)
    end
end
 
Reputation:RegisterEvent("UPDATE_FACTION")
Reputation:RegisterEvent("PLAYER_ENTERING_WORLD")
 
Reputation:SetScript("OnEvent", UpdateRep)

or

Lua Code:

if AftermathhUI.plugins.repbar == false then return end
 
local Reputation = CreateFrame("Frame", nil, UIParent)
 
local ReputationBar = CreateFrame('StatusBar', nil, UIParent)
 
local InvisFrame = CreateFrame("Frame", nil, ReputationBar)
InvisFrame:SetFrameStrata("HIGH")
InvisFrame:SetFrameLevel(5)
InvisFrame:SetAllPoints()
 
local ReputationBarFont = InvisFrame:CreateFontString(nil, 'OVERLAY')   
 
ReputationBar:SetPoint('LEFT', oUF_AftermathhPlayer, 223, -178)
ReputationBar:SetStatusBarTexture(AftermathhUI.media.texture)
ReputationBar:SetSize(235, 20)
ReputationBar:SetBackdrop({
    bgFile = AftermathhUI.media.blank,
    insets = {top = -1, left = -1, bottom = -1, right = -1},
    })
ReputationBar:SetBackdropColor(unpack(AftermathhUI.media.backdropcolor))
 
CreateBorderLight(ReputationBar, AftermathhUI.media.bordersize, AftermathhUI.bordercolor, AftermathhUI.bordercolor, AftermathhUI.bordercolor, 3)
    
ReputationBar:SetScript("OnEnter", function(self)
    if (not GetWatchedFactionInfo()) then
        return
    end 
 
    local Name, ID, Min, Max, Value = GetWatchedFactionInfo()
    
    GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
    GameTooltip:AddLine(string.format("%s (%s)", Name, _G["FACTION_STANDING_LABEL" .. ID]))
    GameTooltip:AddLine(string.format("%d / %d (%d%%)", Value - Min, Max - Min, (Value - Min) / (Max - Min) * 100), 1, 1, 1, 1, 1, 1)
    GameTooltip:Show()
    GameTooltip:Show()
end)
    
ReputationBar:SetScript("OnLeave", function()
    if GameTooltip:IsShown() then
    GameTooltip:Hide()
    end
end)
 
ReputationBar:SetAlpha(0)
ReputationBar:HookScript("OnEnter", function(self) UIFrameFadeIn(self, 1.2, self:GetAlpha(), 1) end)
ReputationBar:HookScript("OnLeave", function(self) UIFrameFadeIn(self, 0.8, self:GetAlpha(), 0) end)
 
ReputationBarFont:SetPoint('CENTER', ReputationBar)
ReputationBarFont:SetFont(AftermathhUI.media.font, 12, AftermathhUI.media.fontflag) 
if AftermathhUI.media.shadowoffset == true then
    ReputationBarFont:SetShadowOffset(1, -1)
    ReputationBarFont:SetShadowColor(0,0,0)
end
 
local function UpdateRep()
    if (not GetWatchedFactionInfo()) then
        return
    end 
 
    local Name, ID, Min, Max, Value = GetWatchedFactionInfo()   
    
    ReputationBar:SetMinMaxValues(Min, Max)
    ReputationBar:SetValue(Value)
    ReputationBarFont:SetFormattedText("%d / %d - %s", Min, Max, Name)
 
    local FactionColors = FACTION_BAR_COLORS[ID]
    ReputationBar:SetStatusBarColor(FactionColors.r, FactionColors.g, FactionColors.b)
end
 
Reputation:RegisterEvent("UPDATE_FACTION")
Reputation:RegisterEvent("PLAYER_ENTERING_WORLD")
 
Reputation:SetScript("OnEvent", UpdateRep)

Choonstertwo · 11-21-14, 03:11 PM

Originally Posted by Game92

Guess it should be something like this then?

That will probably work, but you're calling GetWatchedFactionInfo twice per OnEvent/OnEnter when you only need to call it once.

I'd recommend either this:

lua Code:

local Name, ID, Min, Max, Value = GetWatchedFactionInfo()
if not Name then return end
 
-- Do watched faction stuff here

Or this:

lua Code:

local Name, ID, Min, Max, Value = GetWatchedFactionInfo()
if Name then 
    -- Do watched faction stuff here
end

Aftermathhqt · 11-21-14, 05:22 PM

Originally Posted by Choonstertwo

That will probably work, but you're calling GetWatchedFactionInfo twice per OnEvent/OnEnter when you only need to call it once.

I'd recommend either this:

lua Code:

local Name, ID, Min, Max, Value = GetWatchedFactionInfo()
if not Name then return end
 
-- Do watched faction stuff here

Or this:

lua Code:

local Name, ID, Min, Max, Value = GetWatchedFactionInfo()
if Name then 
    -- Do watched faction stuff here
end

Works perfectly now, thanks for the help!

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode