button("OnClick") & PLAYER_ENTERING_WORLD

wille480 · 01-22-17, 08:18 AM

Hey guys!
this is the code i have now! , this code does so if mybutton2 is clicked it will run the second code below the line and print out "HelyaAssist is now Disabled" , nothing with the code broken so far but that will be printed everytime i release from graveyard, reloadui manually and so on.. I only want that code to go off if mybutton2 is clicked. How do i do this? have tried alot of things like if statements and stuff but then i get an error ingame saying that it failed cuz it is trying to call frame a global nil value.

Lua Code:

mybutton2:SetScript("OnClick", function(self, button, down)
 local playerName = UnitName("player")
 DisableAddOn(folder, playerName)
 ReloadUI()
 eventHandlerE();
end)
 
------------------------------------
 
local frame = CreateFrame("FRAME", "FooAddonFrame");
frame:RegisterEvent("PLAYER_ENTERING_WORLD");
local function eventHandlerE(self, event, ...)
print('|cffffff00HelyaAssist is now Disabled')
 end
frame:SetScript("OnEvent", eventHandlerE);

tried this for example but did not work :/

Lua Code:

local ds = 0
 
mybutton2:SetScript("OnClick", function(self, button, down)
 local playerName = UnitName("player")
 DisableAddOn(folder, playerName)
 ReloadUI()
 ds = 1
end)
 
------------------------------------
if ds == 1 then 
local frame = CreateFrame("FRAME", "FooAddonFrame");
frame:RegisterEvent("PLAYER_ENTERING_WORLD");
local function eventHandlerE(self, event, ...)
print('|cffffff00HelyaAssist is now Disabled')
 end
end
frame:SetScript("OnEvent", eventHandlerE);

Best regards!

pas06 · 01-22-17, 10:27 AM

Lua Code:

local frame = CreateFrame("FRAME", "FooAddonFrame");
frame:RegisterEvent("PLAYER_ENTERING_WORLD");
local function eventHandlerE(self, event, ...)
print('|cffffff00HelyaAssist is now Disabled')
 end
frame:SetScript("OnEvent", eventHandlerE);

of course it does this. what you did with this few lines is register the event PLAYER_ENTERING_WORLD (http://wowprogramming.com/docs/event...ENTERING_WORLD) on your frame. Every time this event fires the function eventHandlerE is run.
Explanation:
frame:SetScript("OnEvent", eventHandlerE)
this means: run the function eventHandlerE whenever a event that is registered on that frame (via frame:RegisterEvent) fires

this should do the job:

Lua Code:

mybutton2:SetScript("OnClick", function(self, button, down)
    local playerName = UnitName("player")
    DisableAddOn(folder, playerName)
    ReloadUI()
    print('|cffffff00HelyaAssist is now Disabled')
end)

just keep in mind that the player might not notice your message because of "addon loaded spam" when the ui got reloaded.

wille480 · 01-22-17, 12:03 PM

Hello pas06!
The code you linked recently (the second code) is what i had before and the message will just be spammed over , that is why i have the code i poated in my first post because that will show the message last of everything so you can see the message, but the problem with that is that i can't make it trigger when only mybutton2 is clicked

Possible to sort it out with the code i had? So it only triggers on mybutton2 "OnClick"

pas06 · 01-22-17, 12:10 PM

hmm,

i was talking about replacing your whole code

Lua Code:

mybutton2:SetScript("OnClick", function(self, button, down)
 local playerName = UnitName("player")
 DisableAddOn(folder, playerName)
 ReloadUI()
 eventHandlerE();
end)
 
------------------------------------
 
local frame = CreateFrame("FRAME", "FooAddonFrame");
frame:RegisterEvent("PLAYER_ENTERING_WORLD");
local function eventHandlerE(self, event, ...)
print('|cffffff00HelyaAssist is now Disabled')
 end
frame:SetScript("OnEvent", eventHandlerE);

with

Lua Code:

mybutton2:SetScript("OnClick", function(self, button, down)
    local playerName = UnitName("player")
    DisableAddOn(folder, playerName)
    ReloadUI()
    print('|cffffff00HelyaAssist is now Disabled')
end)

wille480 · 01-22-17, 12:34 PM

Yes got that

,
But with that code only it will like not show the message because it will be like spammed over , had that code only before but it does not show it, like with elvui, when you do /reloadui , it will show "welcome to elvui version .. Bla bla" like that message does show and is not spammed over but i cant make it do that

Best regards

pas06 · 01-22-17, 01:04 PM

i don't see whats causing the message to get spammed.

Fizzlemizz · 01-22-17, 01:51 PM

This should show the message once every time a character logs in with the addon disabled.

Lua Code:

mybutton2:SetScript("OnClick", function(self, button, down)
    local playerName = UnitName("player")
    DisableAddOn(folder, playerName)
    ReloadUI()
end)
 
------------------------------------
 
local function eventHandlerE(self, event, ...)
    local playerName = UnitName("player")
    if GetAddOnEnableState(playerName, folder) == 0 then
        print('|cffffff00HelyaAssist is now Disabled')
    end
    self:UnregisterEvent("PLAYER_ENTERING_WORLD")
end
local frame = CreateFrame("FRAME", "FooAddonFrame");
frame:RegisterEvent("PLAYER_ENTERING_WORLD");
frame:SetScript("OnEvent", eventHandlerE);

Edit: Checked Enable State instead of Loaded

wille480 · 01-22-17, 05:42 PM

Hey fizzlemizz!

That code prints("HelyaAssist is now Disabled") on every reloadui you do.
Same issue as i had before

pas06 · 01-22-17, 07:01 PM

Please write your whole code/addon in here.

Fizzlemizz · 01-22-17, 07:33 PM

Originally Posted by wille480

Hey fizzlemizz!

That code prints("HelyaAssist is now Disabled") on every reloadui you do.
Same issue as i had before

Indeed because every ReloadUI causes a PLAYER_ENTERING_WORLD event to fire. If you are only wanting the message to be printed after pressing the button each time, you will have to save the fact that it was pressed into a SavedVariable and then check it on PLAYER_ENTERING_WORLD

To your .toc file add the following (or use some other unique addon specific name for the variable):

Code:

    ## SavedVariables: wille480Addon

Lua Code:

mybutton2:SetScript("OnClick", function(self, button, down)
    local playerName = UnitName("player")
    DisableAddOn(folder, playerName)
    wille480Addon = true
    ReloadUI()
end)
     
    ------------------------------------
     
local function eventHandlerE(self, event, ...)
    local playerName = UnitName("player")
    if wille480Addon and GetAddOnEnableState(playerName, folder) == 0 then
        wille480Addon = nil
        print('|cffffff00HelyaAssist is now Disabled')
    end
    self:UnregisterEvent("PLAYER_ENTERING_WORLD")
end
local frame = CreateFrame("FRAME", "FooAddonFrame");
frame:RegisterEvent("PLAYER_ENTERING_WORLD");
frame:SetScript("OnEvent", eventHandlerE);

wille480 · 01-23-17, 08:10 AM

Hello FizzleMizz! : )
The code you sent in your last post did not work , I don't know if it the code or if i am doing wrong..

This is my whole LUA Code for my addon.

Lua Code:

local TaintOfTheSea     = GetSpellInfo(228054)
local Ticker            = 0
local MoveMessage       = "{moon} MOVE TO MOON {moon}"
local DispelMessage     = "Dispell on {moon} in "
local debuffexists      = false 
local titleFont = [=[Interface\Addons\HelyaAssist\fonts\accid___.ttf]=]
local folder = [=[Interface\Addons\HelyaAssist\HelyaAssist.toc]=]
local ds = 0
 
-- Adds HelyaAssist to interface in addons
local myAddon = {};
myAddon.panel = CreateFrame( "Frame", "myAddonPanel", UIParent);
myAddon.panel.name = "HelyaAssist";
InterfaceOptions_AddCategory(myAddon.panel);
 
--Create the button (enable)
local mybutton1 = CreateFrame("Button","mybutton", myAddon.panel, "UIPanelButtonTemplate")
mybutton1:SetPoint("CENTER", -255,220)
mybutton1:SetWidth(80)
mybutton1:SetHeight(22)
mybutton1:SetText("Enabled")
 
--Create the button (disable)
mybutton2 = CreateFrame("Button","mybutton", myAddon.panel, "UIPanelButtonTemplate")
mybutton2:SetPoint("CENTER", -160,220)
mybutton2:SetWidth(80)
mybutton2:SetHeight(22)
mybutton2:SetText("Disabled")
 
--Text in panel
 MOD_TextFrame = CreateFrame("Frame", nil, myAddonPanel);
 MOD_TextFrame:ClearAllPoints();
 MOD_TextFrame:SetHeight(300);
 MOD_TextFrame:SetWidth(300);
 MOD_TextFrame:SetScript("OnUpdate", MOD_TextFrame_OnUpdate);
 MOD_TextFrame.text = MOD_TextFrame:CreateFontString(nil, "BACKGROUND", "PVPInfoTextFont");
 MOD_TextFrame.text:SetAllPoints();
 MOD_TextFrame:SetPoint("CENTER", -245, 260);
 MOD_TextFrameTime = 0;
 MOD_TextFrame.text:SetText('|cffffff00HelyaAssist');
 MOD_TextFrame.text:SetFont(titleFont, 19);
 
 --If mybutton2 is clicked, then disable HelyaAssist (disable button)
mybutton2:SetScript("OnClick", function(self, button, down)
    local playerName = UnitName("player")
    DisableAddOn(folder, playerName)
    wille480Addon = true
    ReloadUI()
end)
 
-- PLAYER_ENTERING_WORLD for Disable button
local function eventHandlerE(self, event, ...)
    local playerName = UnitName("player")
    if HelyaAssistAddon and GetAddOnEnableState(playerName, folder) == 0 then
        HelyaAssistAddon = nil
        print('|cffffff00HelyaAssist is now Disabled')
    end
    self:UnregisterEvent("PLAYER_ENTERING_WORLD")
end
local frame = CreateFrame("FRAME", "FooAddonFrame");
frame:RegisterEvent("PLAYER_ENTERING_WORLD");
frame:SetScript("OnEvent", eventHandlerE);
 
 
--If MyButton1 is clicked , then Enable HelyaAssist (enable button)
mybutton1:SetScript("OnClick", function(self, button, down)
local playerName2 = UnitName("player")
EnableAddOn(folder, playerName2)
ReloadUI()
end)
 
 
 
 
-- PLAYER_ENTERING_WORLD for Enable button
 
 
 
 
local function UpdateTicker()
    if Ticker < 1 or not debuffexists then return end
 
    SendChatMessage((Ticker > 5) and MoveMessage or DispelMessage .. Ticker, "Yell", nil, name)
    Ticker = Ticker - 1
 
    C_Timer.After((Ticker > 5) and 1.5 or 0.4, UpdateTicker)
end
 
local function UNIT_AURA()
    local name, _, _, _, _, duration, expires = UnitDebuff("player", TaintOfTheSea)
   
    if name then
        if not debuffexists then
            debuffexists = true --player just got the debuff
            Ticker = 6
            UpdateTicker()
        end
    else
        debuffexists = false -- doesn't exist
    end
end
 
local eventframe = CreateFrame("Frame")
eventframe:RegisterUnitEvent("UNIT_AURA", "player")
eventframe:SetScript("OnEvent", UNIT_AURA)

This is my .toc file

Lua Code:

## Interface: 70100
## Author: Lmannen (Ingame Name = Bishoop)
## Version: 1.0
## Title: HelyaAssist
## Notes: Triggered guild addon
## DefaultState: enabled
 
## SavedVariables: HelyaAssistAddon
 
HelyaAssist.lua

Should be easier now as you can see for yourself how the code looks like so far!

best regards guys and ty for help so far!

myrroddin · 01-23-17, 09:27 AM

mybutton2 on line 24 is a global variable. I take it that is not intended? Also, when you come back to this code in a year or two, are you immediately going to know what mybutton1 and mybutton2 are used for? They are hardly descriptive in their names.

The point being, at a glace, I have no idea what they do, and neither will you in a year or two.

pas06 · 01-23-17, 10:29 AM

hi, i am currently looking through your code. why do you even wan't to disable the addon through the addon panel? As a user i usually disable addons through the build in addon list. in my opinion it would be better if the addon automatically runs when the player is in combat with helya and is sleeping if not. (no need for ui options anymore)
For what is this OnUpdate in line 35 good for?

my suggestion would be this(untested, no guarantee if its working or not)

Lua Code:

local TaintOfTheSea     = GetSpellInfo(228054)
local Ticker            = 0
local MoveMessage       = "{moon} MOVE TO MOON {moon}"
local DispelMessage     = "Dispell on {moon} in "
local debuffexists      = false 
local eventframe = CreateFrame("Frame")
 
 
local function UpdateTicker()
    if Ticker < 1 or not debuffexists then return end
 
    SendChatMessage((Ticker > 5) and MoveMessage or DispelMessage .. Ticker, "Yell", nil, name)
    Ticker = Ticker - 1
 
    C_Timer.After((Ticker > 5) and 1.5 or 0.4, UpdateTicker)
end
 
local function eventframe.UNIT_AURA()
    local name, _, _, _, _, duration, expires = UnitDebuff("player", TaintOfTheSea)
   
    if name then
        if not debuffexists then
            debuffexists = true --player just got the debuff
            Ticker = 6
            UpdateTicker()
        end
    else
        debuffexists = false -- doesn't exist
    end
end
 
local function eventframe:ENCOUNTER_START(EncounterID)
    if EncounterID == 1829 then 
        print("|cffffff00HelyaAssist is now enabled")
        self:RegisterUnitEvent("UNIT_AURA", "player")
        self:RegisterEvent("ENCOUNTER_END")
    end
end
local function eventframe:ENCOUNTER_END()
    print("|cffffff00HelyaAssist is now disabled")
    self:UnregisterEvent("UNIT_AURA")
end
 
 
eventframe:RegisterEvent("ENCOUNTER_START")
eventframe:SetScript("OnEvent", function(self, event, ...)
        self[event](...)        
end);

Fizzlemizz · 01-23-17, 10:33 AM

Because you're still setting wille480Addon in the OnClick but checking for HelyaAssistAddon in the OnEvent. Change wille480Addon to HelyaAssistAddon.

wille480 · 01-23-17, 10:44 AM

Originally Posted by Fizzlemizz

Because you're still setting wille480Addon in the OnClick but checking for HelyaAssistAddon in the OnEvent. Change wille480Addon to HelyaAssistAddon.

Hey guys to for help! responding to your quote here fizzlemizz!
I just noticed that i missed to change it to HelyaAssistAddon , Changed everyone else but did not look properly!

Ty for help
best regards

wille480 · 01-23-17, 10:46 AM

Originally Posted by pas06

hi, i am currently looking through your code. why do you even wan't to disable the addon through the addon panel? As a user i usually disable addons through the build in addon list. in my opinion it would be better if the addon automatically runs when the player is in combat with helya and is sleeping if not. (no need for ui options anymore)
For what is this OnUpdate in line 35 good for?

my suggestion would be this(untested, no guarantee if its working or not)

Lua Code:

local TaintOfTheSea     = GetSpellInfo(228054)
local Ticker            = 0
local MoveMessage       = "{moon} MOVE TO MOON {moon}"
local DispelMessage     = "Dispell on {moon} in "
local debuffexists      = false 
local eventframe = CreateFrame("Frame")
 
 
local function UpdateTicker()
    if Ticker < 1 or not debuffexists then return end
 
    SendChatMessage((Ticker > 5) and MoveMessage or DispelMessage .. Ticker, "Yell", nil, name)
    Ticker = Ticker - 1
 
    C_Timer.After((Ticker > 5) and 1.5 or 0.4, UpdateTicker)
end
 
local function eventframe.UNIT_AURA()
    local name, _, _, _, _, duration, expires = UnitDebuff("player", TaintOfTheSea)
   
    if name then
        if not debuffexists then
            debuffexists = true --player just got the debuff
            Ticker = 6
            UpdateTicker()
        end
    else
        debuffexists = false -- doesn't exist
    end
end
 
local function eventframe:ENCOUNTER_START(EncounterID)
    if EncounterID = 1829 then 
        print("|cffffff00HelyaAssist is now enabled")
        self:RegisterUnitEvent("UNIT_AURA", "player")
        self:RegisterEvent("ENCOUNTER_END")
    end
end
local function eventframe:ENCOUNTER_END()
    print("|cffffff00HelyaAssist is now disabled")
    self:UnregisterEvent("UNIT_AURA")
end
 
 
eventframe:RegisterEvent("ENCOUNTER_START")
eventframe:SetScript("OnEvent", function(self, event, ...)
        self[event](...)        
end);

Oh hey pas06!
Thank you for the help , basicly why i disable through addon panel is because i can't find anyway around it :O , all i find is that on wowprogrammings own api site , Basicly my addon will run on every difficulty etc.. even on maw of soul dungeon so i thought it would be a good idea to have a enable and disable button because to be honest , in maw of soul , this addon is not necessary at all and can be annoying to not have a option to disable it! , But yea like i said , i can't find any way around it.

Best regards!

pas06 · 01-23-17, 10:48 AM

my way should be the way around it, it checks for the encounter id of helya 1829. if the encounter has this id it basically starts the addon.
Edit:Changed line 33 of the code i posted in post #13

Fizzlemizz · 01-23-17, 11:09 AM

To clear up a few problems with your original code, the addon wouldn't have been disabled as DisableAddon requires just the folder name, not the full path (The WoWProgramming discription is a little cryptic):

Code:

DisableAddon("HelyaAssist")

The other problem is that once disabled, the addon would not be loaded again after the ReloadUI() (because it's disabled) so the message would never be printed.

wille480 · 01-23-17, 11:21 AM

Originally Posted by Fizzlemizz

To clear up a few problems with your original code, the addon wouldn't have been disabled as DisableAddon requires just the folder name, not the full path (The WoWProgramming discription is a little cryptic):

Code:

DisableAddon("HelyaAssist")

The other problem is that once disabled, the addon would not be loaded again after the ReloadUI() (because it's disabled) so the message would never be printed.

Ah okey roger ! ty

so it is fully disabled now with the code you sent me?

btw one more question<3

Lua Code:

buttonEnable:SetScript("OnClick", function(self, button, down)
local playerName = UnitName("player")
EnableAddOn(folder, playerName)
HelyaAssistAddon = false
ReloadUI()
end)
 
-------------------------------------
 
local function eventHandlerE(self, event, ...)
    local playerName = UnitName("player")
    if HelyaAssistAddon and GetAddOnEnableState(playerName, folder) == 0 then
        HelyaAssistAddon = nil
        print('|cffffff00HelyaAssist is now Disabled')
    end
    if HelyaAssistAddon and GetAddOnEnableState(playerName, folder) == 1 then
    HelyaAssistAddon = nil
    print('|cffffff00HelyaAssist is now Enabled')
    end
    self:UnregisterEvent("PLAYER_ENTERING_WORLD")
end
local frame = CreateFrame("FRAME", "FooAddonFrame");
frame:RegisterEvent("PLAYER_ENTERING_WORLD");
frame:SetScript("OnEvent", eventHandlerE);

Trying to make the same for the enabled button , so if buttonEnable is clicked, print('|cffffff00HelyaAssist is now Enabled')

I think i have gotten everything right so far except

Lua Code:

if HelyaAssistAddon and GetAddOnEnableState(playerName, folder) == 1 then
    HelyaAssistAddon = nil -- think this one is wrong because for disabled if statement this is nil aswell.         
    print('|cffffff00HelyaAssist is now Enabled')
    end

That line "HelyaAssistAddon=nil" , i think that is wrong if i wanna have it enable the addon , But can not find what to set it to , tried with true and false.

pas06 · 01-23-17, 11:27 AM

i don't get the logic behind this. You wan't to enable an addon from an disabled addon?