Simple How to Hide and Show Window Help?

[Zireko]

I'm simply trying to understand how to show and hide a from with a right mouse click. Here is the code where I think I don't have it correct. I'm remembering how I did this with Elder Scrolls Online so I was trying it this way and mixed it with a way to do it in wow that I've found online. However it's not working.

The Code for Hidding and showing the frame with right mouse click to my button.

local frame = CreateFrame("Button", ZBarOptionFrame, UIParent)
 
ZBarOptionFrame:RegisterForClicks("AnyUp")
ZBarOptionFrame:SetScrpit("OnClick", function(self, button, ...)
    if (button == "RightButton") then
        if ZBarOptionFrame:IsShown() then
            ZBarOptionFrame:SetHidden(false)
        else
            ZBarOptionFrame:SetHidden(true)
        end
    end
end)

Here is the entire lua code I have so far remember I'm still working on this so it's not finished at all yet.

--Want to add Show Hide function for each window. ( barQWindow, barAWindow, barMWindow, barCWindow )
--With the Show Hide I want to add this in an addon options window.
--Want to add a lock frame for each window. 
--With lock frame I want to add this in an addon options window.
 
--Create a button using lua that pulls up a window for ZBar Options.
 
-- creates a generic button in the middle of the screen --
ZBarButton = CreateFrame("Button","ZBarButton",UIParent,"UIPanelButtonTemplate")
ZBarButton:SetPoint("CENTER",0,0)
ZBarButton:SetWidth(30)
ZBarButton:SetHeight(30)
ZBarButton:SetText("ZB")
ZBarButton:SetMovable(true)
ZBarButton:RegisterForDrag("LeftButton")
ZBarButton:SetScript("OnDragStart",ZBarButton.StartMoving)
ZBarButton:SetScript("OnDragStop",ZBarButton.StopMovingOrSizing)
 
ZBarOptionFrame = CreateFrame("Frame")
ZBarOptionFrame:ClearAllPoints()
ZBarOptionFrame:SetBackdrop(StaticPopup1:GetBackdrop())
ZBarOptionFrame:SetHeight(300)
ZBarOptionFrame:SetWidth(300)
ZBarOptionFrame:SetHidden(true)
 
ZBarOptionFrame.text = ZBarOptionFrame:CreateFontString(nil, "BACKGROUND", "GameFontNormal")
ZBarOptionFrame.text:SetAllPoints()
ZBarOptionFrame.text:SetText("ZBar Options Verison 1.0")
ZBarOptionFrame:SetPoint("CENTER", 0, 0)
 
local frame = CreateFrame("Button", ZBarOptionFrame, UIParent)
 
ZBarOptionFrame:RegisterForClicks("AnyUp")
ZBarOptionFrame:SetScrpit("OnClick", function(self, button, ...)
    if (button == "RightButton") then
        if ZBarOptionFrame:IsShown() then
            ZBarOptionFrame:SetHidden(false)
        else
            ZBarOptionFrame:SetHidden(true)
        end
    end
end)

Please if you write code back to me show it completely with all information and deep examples. I'm still very new to coding.

[Seerah]

You should be getting an error. Make sure that you have Lua errors shown in your Interface Options. Also, install an error catching addons (BugSack is an example) to catch errors that happen early in the loading process.

frame:SetHidden(false) is API from ESO. You'll need to use the frame API provided by WoW.

frame:Hide()
frame:Show()

/edit: you also have a typo on line 34

[Seerah]

Oh, and another thing. Unless you ABSOLUTELY need your button to have a global name, accessible from outside of your addon, then don't bother giving it a global name. You can just do:

local frame = CreateFrame("Button", nil, UIParent)

If you DO want it to have a global name, then use the local you are assigning your button to as your reference in the Lua code. Locals are faster than global lookups.

frame:RegisterForClicks("AnyUp")
frame:SetScript("OnClick", function(self, button, ...)
    if (button == "RightButton") then
        if frame:IsShown() then
            frame:Hide()
        else
            frame:Show()
        end
    end
end)

/edit: heh... just noticed that you had the :SetHidden() call backwards anyway

[SDPhantom]

You can use frame:SetShown(). In combination with this, you can toggle a frame's visibility with the following line.

frame:SetShown(not frame:IsShown())

[Zireko]

I have tried everything you've suggested also I've flipped things around re-named my frame and it's still not working. My button that I made in the code isn't working with a right click to show and hide the window. Any way here is the code as of right now. Still don't know what I'm doing wrong yet.

--Want to add Show Hide function for each window. ( barQWindow, barAWindow, barMWindow, barCWindow )
--With the Show Hide I want to add this in an addon options window.
--Want to add a lock frame for each window. 
--With lock frame I want to add this in an addon options window.
 
--Create a button using lua that pulls up a window for ZBar Options.
 
-- creates a generic button in the middle of the screen --
ZBarButton = CreateFrame("Button","ZBarButton",UIParent,"UIPanelButtonTemplate")
ZBarButton:SetPoint("CENTER",0,0)
ZBarButton:SetWidth(30)
ZBarButton:SetHeight(30)
ZBarButton:SetText("ZB")
ZBarButton:SetMovable(true)
ZBarButton:RegisterForDrag("LeftButton")
ZBarButton:SetScript("OnDragStart",ZBarButton.StartMoving)
ZBarButton:SetScript("OnDragStop",ZBarButton.StopMovingOrSizing)
 
ZBarOptionFrame = CreateFrame("Frame")
ZBarOptionFrame:ClearAllPoints()
ZBarOptionFrame:SetBackdrop(StaticPopup1:GetBackdrop())
ZBarOptionFrame:SetHeight(300)
ZBarOptionFrame:SetWidth(300)
ZBarOptionFrame:Hide(true)
 
ZBarOptionFrame.text = ZBarOptionFrame:CreateFontString(nil, "BACKGROUND", "GameFontNormal")
ZBarOptionFrame.text:SetAllPoints()
ZBarOptionFrame.text:SetText("ZBar Options Verison 1.0")
ZBarOptionFrame:SetPoint("CENTER", 0, 0)
 
local frame = CreateFrame("Button", nil, UIParent)
 
frame:RegisterForClicks("AnyUp")
frame:SetScript("OnClick", function(self, button, ...)
    if (button == "RightButton") then
        if frame:IsShown() then
            frame:Hide()
        else
            frame:Show()
        end
    end
end)

[Rilgamon]

I'm a little confused.
You're creating two buttons and a frame. For the second button you set up OnClick to hide itself but nothing declaring how your button should look like. (Difficult to click again once it is hidden btw)
The first you set up to be dragable.

Which button is supposed to do what when why?