Onupdate

[Resike]

I started working on this little project today, which imitates the rank style gui and sounds stytem from Devil May Cry 5. However i feel the the CPU usage is quite high for an addon with only 1 onupdate event. (5-6ms/s)

Here is my code:

local _, ns = ...
local DevilMayCry = { }
ns.DevilMayCry = DevilMayCry

local BaseSize = 128
local TextureSize = 128
local AnimSize = 300
local ReachedMax = false

local Frame = CreateFrame("Frame", nil, UIParent)
Frame:SetPoint("CENTER", 500, 450)
Frame:SetFrameStrata("Medium")
Frame:SetFrameLevel(0)
Frame:SetWidth(TextureSize)
Frame:SetHeight(TextureSize)
Frame:SetAlpha(0.99)
Frame:SetMovable(true)
Frame:EnableMouse(true)
Frame:SetClampedToScreen(false)
Frame:RegisterForDrag("LeftButton")

local Background = Frame:CreateTexture("Texture", "Background")
Background:SetTexture("Interface\\Addons\\DevilMayCry\\Textures\\Background")
Background:SetWidth(TextureSize)
Background:SetHeight(TextureSize)
Background:SetBlendMode("Disable")
Background:SetDrawLayer("Background", 0)
Background:SetAllPoints(Frame)

local Foreground = Frame:CreateTexture("Texture", "Background")
Foreground:SetTexture("Interface\\Addons\\DevilMayCry\\Textures\\Foreground")
Foreground:SetWidth(TextureSize)
Foreground:SetHeight(TextureSize)
Foreground:SetBlendMode("Disable")
Foreground:SetDrawLayer("Background", 1)
Foreground:SetPoint("Bottom", Frame, "Bottom")

local UpdateFrame = CreateFrame("Frame", nil)
local TimeSinceLastUpdate = 0
local NextUpdate = 0.0050

function DevilMayCry.StartMove(frame, button)
	if button ~= "LeftButton" then
		return
	end
	frame:StartMoving()
end

Frame:SetScript("OnMouseDown", DevilMayCry.StartMove)

function DevilMayCry.StopMove(frame, button)
	if button ~= "LeftButton" then
		return
	end
	frame:StopMovingOrSizing()
	local x = math.floor(frame:GetLeft() + (frame:GetWidth() - UIParent:GetWidth()) / 2 + 0.5)
	local y = math.floor(frame:GetTop() - (frame:GetHeight() + UIParent:GetHeight()) / 2 + 0.5)
	frame:ClearAllPoints()
	frame:SetPoint("CENTER", x, y)
end

Frame:SetScript("OnMouseUp", DevilMayCry.StopMove)

function DevilMayCry:Foreground()
	if Foreground:GetHeight() > TextureSize * 0.9999 then
		ReachedMax = true
	end
	if Foreground:GetHeight() <= 0 then
		-- Test Mode
		Frame:SetWidth(TextureSize)
		Frame:SetHeight(TextureSize)
		Background:SetAllPoints(Frame)
		Foreground:SetWidth(TextureSize)
		Foreground:SetHeight(TextureSize)
		Foreground:SetTexCoord(0, 0, 0, 1, 1, 0, 1, 1)
	else
		local y = Foreground:GetHeight() / TextureSize
		if y > 1 then
			Foreground:SetHeight(TextureSize)
			y = 1
		end
		Frame:SetHeight(TextureSize)
		Frame:SetWidth(TextureSize)
		Background:SetAllPoints(Frame)
		if Foreground:GetWidth() > TextureSize then
			Foreground:SetWidth(Foreground:GetWidth() - ((TextureSize / 128) * 0.1))
		end
		Foreground:SetHeight(Foreground:GetHeight() - ((TextureSize / 128) * 0.1))
		local ULx, ULy, LLx, LLy, URx, URy, LRx, LRy = Foreground:GetTexCoord()
		Foreground:SetTexCoord(ULx, 1 - y, LLx, LLy, URx, 1 - y, LRx, LRy)
	end
	return 0.0050
end

function DevilMayCry:SetTextureSize(size)
	local LastSize = TextureSize
	TextureSize = size
	Foreground:SetWidth(Foreground:GetWidth() * TextureSize / LastSize)
	Foreground:SetHeight(Foreground:GetHeight() * TextureSize / LastSize)
end

function DevilMayCry:AnimateTexture()
	DevilMayCry:SetTextureSize(AnimSize)
	if AnimSize >= (BaseSize + 2) then
		AnimSize = AnimSize - 2
	else
		AnimSize = 300
		ReachedMax = false
	end
end

function DevilMayCry_IncreaseHeight(percent)
	if Foreground:GetHeight() < (TextureSize * (1 - percent)) then
		Foreground:SetHeight(Foreground:GetHeight() + (TextureSize * percent))
	else
		Foreground:SetHeight(TextureSize)
	end
	if Foreground:GetWidth() <= (TextureSize) then
		Foreground:SetWidth(Foreground:GetWidth() * 1.12)
	else
		Foreground:SetWidth(TextureSize * 1.12)
	end
end

function DevilMayCry:OnUpdate(elapsed)
	TimeSinceLastUpdate = TimeSinceLastUpdate + elapsed
	while TimeSinceLastUpdate > NextUpdate do
		TimeSinceLastUpdate = TimeSinceLastUpdate - NextUpdate
		if ReachedMax == true then
			DevilMayCry:AnimateTexture()
		end
		NextUpdate = DevilMayCry:Foreground()
	end
end

UpdateFrame:SetScript("OnUpdate", DevilMayCry.OnUpdate)

GitHub:

https://github.com/Resike/DevilMayCry

[semlar]

You have a while loop inside of your OnUpdate function, so every frame you're telling the game to stop everything until that while condition is satisfied.

You probably want an if statement or something.

[Resike]

Originally Posted by semlar You have a while loop inside of your OnUpdate function, so every frame you're telling the game to stop everything until that while condition is satisfied. You probably want an if statement or something.

Yes because i manually set the update times with that while.

[suicidalkatt]

Just out of curiosity, any particular reason you don't just use a statusbar and set the orientation to vertical?

You just need to use if and reset your variable:

function DevilMayCry:OnUpdate(elapsed)
    TimeSinceLastUpdate = TimeSinceLastUpdate + elapsed
    if TimeSinceLastUpdate > 0.005 do
        if ReachedMax == true then
            DevilMayCry:AnimateTexture()
        end
        TimeSinceLastUpdate = 0
    end
end

[Resike]

Originally Posted by suicidalkatt Just out of curiosity, any particular reason you don't just use a statusbar and set the orientation to vertical? You just need to use if and reset your variable: function DevilMayCry:OnUpdate(elapsed)     TimeSinceLastUpdate = TimeSinceLastUpdate + elapsed     if TimeSinceLastUpdate > 0.005 do         if ReachedMax == true then             DevilMayCry:AnimateTexture()         end         TimeSinceLastUpdate = 0     end end

Hmm, i never used statusbars yet however i'm not sure i can animate them properly. However i'll try them, i'm not sure which is the best method for this task yet i just started this project today.

[Vrul]

Is that going to be a cooldown timer? Will there eventually be more than one thing making it need to be modular?

[Resike]

Originally Posted by Vrul Is that going to be a cooldown timer? Will there eventually be more than one thing making it need to be modular?

Most likely you deal damage to fill the bar, when the bar is filled then you go to the next streak, when it's becomes empty it gonna reset all of your streak.

[myrroddin]

FYI, you do not need to explicitly check if a variable is true (or 1/nil). Lua assumes that. Likewise for false or nil. The only time you need to check the latter is for tri-state variables true/false/nil.

-- all the same in Lua, if the returns for var are either 1/nil or true/false
if var then
if var == true then
if var == 1 then
if var ~= false then
if var ~= nil then
 
if not var then
if var == nil then 
if var == false then
if var ~= true then
if var ~= 1 then
 
-- if the returns for var are nil/1/2 or true/false/nil
-- these are not the same
if not var then
if var == false then
if var ~= true then
if var ~= nil then

It is preferable, when writing code, if the variable only has two return values, to do the following, because it is much, much easier to read, especially later when you come back.

if var then
if not var then

[Resike]

Originally Posted by myrroddin FYI, you do not need to explicitly check if a variable is true (or 1/nil). Lua assumes that. Likewise for false or nil. The only time you need to check the latter is for tri-state variables true/false/nil. -- all the same in Lua, if the returns for var are either 1/nil or true/false if var then if var == true then if var == 1 then if var ~= false then if var ~= nil then   if not var then if var == nil then if var == false then if var ~= true then if var ~= 1 then   -- if the returns for var are nil/1/2 or true/false/nil -- these are not the same if not var then if var == false then if var ~= true then if var ~= nil then It is preferable, when writing code, if the variable only has two return values, to do the following, because it is much, much easier to read, especially later when you come back. if var then if not var then

Yes i'm aware of that but isn't is faster only to compare to 1 thing rather then to two?

[Phanx]

if var then

... is not comparing "var" to anything at all, let alone to two things. Functionally, it achieves the same result as:

if var ~= nil and var ~= false then

... but it's not actually the same thing.

[SDPhantom]

Originally Posted by Resike Yes I'm aware of that but isn't it faster only to compare to 1 thing rather then to two?

If you really want to look into it, we can break down how the lines work. When you compare with if var==true then, you are running a binary operation (==) that returns a boolean value after comparing var and true, then feeding it into the if ... then statement. If you use if var then, you bypass the binary operation and feed var directly into it