DataStore and Wowhead_Looter with Followers

[myrroddin]

Nulgar and I found the same errors in two different AddOns that scan recipe data. DataStore_Crafts and Wowhead_Looter.

My theory, after looking at the former's code is that when you assign a Follower to a building, in our case Ahm to the Enchanter within your Garrison, the AddOns attempt to get recipe link information when the player talks to them.

Of course, your trade skill window opens and instant problems. This is because, I believe, Followers do not have to worry about materials or components, and thus do not have true recipes from which to get links.

• DataStore_Craft bug page: http://wow.curseforge.com/addons/dat...al-link-error/
• Wowhead forum post: http://www.wowhead.com/forums&topic=...88467#p3788467

I am wondering if and how to determine if you are interracting with a Follower, and if yes, exit out so the errors never happen.

[myrroddin]

All I need is the following pseudo-code. Trouble is, I don't know how to learn if we are interracting with a Follower, or any NPC for that matter.

if interracting with Follower then
    return
end

*edit * Would this work?

local followers = C_Garrison.GetFollowers() -- table with all the followers

for i = 1, GameTooltip:Numlines() do
	if GameTooltip[i]:GetText():match(followers.name) then
		return
	end
end

[myrroddin]

I am very close, I think. I am getting a nested loop error that I can't spot.

-- experiment to exit out if interacting with a Follower
local followers = followers or {}
table.wipe(followers)
followers = C_Garrison.GetFollowers() -- table with all the followers
local foundFollower = nil
 
for i = 1, GameTooltip:NumLines() do
    for k , v in pairs(followers) do
        if GameTooltipTextLeft..i:GetText():match(tostring(v.name)) then
            foundFollower = true
            return  -- found match
        end
    end
end
    
if foundFollower then return end

And here is the error, and line 482 in the error equates to line 9 above. GameTooltipTextLeft..i <-- not finding i.

40x DataStore_Crafts\DataStore_Crafts-r56.lua:482: attempt to index local 'i' (a number value)
DataStore_Crafts\DataStore_Crafts-r56.lua:482: in function <DataStore_Crafts\DataStore_Crafts.lua:452>
DataStore_Crafts\DataStore_Crafts-r56.lua:532: in function <DataStore_Crafts\DataStore_Crafts.lua:529>
DataStore_Crafts\DataStore_Crafts-r56.lua:624: in function <DataStore_Crafts\DataStore_Crafts.lua:617>

[Lombra]

IsNPCCrafting()

[Duugu]

if _G["GameTooltipTextLeft"..i]:GetText():match(tostring(v.name)) then

[myrroddin]

Originally Posted by Lombra IsNPCCrafting()

Thank you, I didn't find that, even after a search. Works like a charm!

-- experiment to exit out if interacting with a Follower
local followers = followers or {}
table.wipe(followers) -- just in case
followers = C_Garrison.GetFollowers() -- table with all the followers
local foundFollower = nil
 
for i = 1, #followers do
    local id = followers.followerID
    if IsNPCCrafting(id) then
        foundFollower = true
    end
end
if foundFollower then return end

[Lombra]

There are no arguments. Just call it to determine whether the currently open tradeskill window belongs to an(y) NPC.

[myrroddin]

D'oh. That's the trouble with new APIs not being documented. I tried doing a dump, but it was best guess.

[cokedrivers]

Originally Posted by myrroddin D'oh. That's the trouble with new APIs not being documented. I tried doing a dump, but it was best guess.

Phanx linked me to here maybe this will help you.

Coke

[Phanx]

Yep, the Blizz UI code is actually a good place to look if an API isn't documented on Wowpedia or WoWProgramming yet. Just don't look at their actual code writing unless you're looking for entertainment.