Professions

[cokedrivers]

I'm trying to modify a Datatext what i have so far is...

The tooltip will show me all my professions Primary, Seconday and Tradeskills.

What I would like to be able to do is

Left Click = Open Profession 1
Right Click = Open profession 2
Mouse Wheel Click = Open Profession Frame.

Stat:SetScript("OnMouseDown", function(self, btn)
	if btn == "LeftButton" then
		(Code to Open First Profession)
	elseif btn == "MiddleButton" then
		(Code to Open Professions Window)
	elseif btn == "Rightbutton" then
		(Code to Open Second Profession)
	end
end)

Any Help on this would be great. I'm still new to .lua codeing so please if you try to help be very expansive on your explinations.

Thanks

Coke

[cokedrivers]

Shameless Bump!

Maybe one of you coders can help.

I am able to find the profession im looking for but i can not get it to toggle it or cast the spell.

This is what I have so far.

Stat:SetScript('OnMouseDown', function(self, btn)

	prof1, prof2 = GetProfessions()
	skillName1 = GetProfessionInfo(prof1)
	skillName2 = GetProfessionInfo(prof2)

	if btn == 'LeftButton' then
		if(skillName1 == 'Mining')then
			CastSpellByName('Smelting')
		elseif(skillName1 == 'Inscription')then
			CastSpellByName('Inscription')
		elseif(skillName1 == 'Leatherworking')then
			CastSpellByName('Leatherworking')
		elseif(skillName1 == 'Jewelcrafting')then
			CastSpellByName('Jewelcrafting')
		elseif(skillName1 == 'Alchemy')then
			CastSpellByName('Alchemy')
		elseif(skillName1 == 'Blacksmithing')then
			CastSpellByName('Blacksmithing')
		elseif(skillName1 == 'Engineering')then
			CastSpellByName('Engineering')
		elseif(skillName1 == 'Enchanting') then
			CastSpellByName('Enchanting')
		elseif(skillName1 == 'Herbalism')then
			print('Herbalism has no options!')
		elseif(skillName1 == 'Tailoring')then
			CastSpellByName('Tailoring')
		elseif(skillName1 == 'Skinning')then
			print('Skinning has no options!')
		else
			print('No Profession Found!')
		end
	elseif btn == 'MiddleButton' then
		ToggleSpellBook("professions")
		
	elseif btn == 'RightButton' then
		if(skillName2 == 'Mining')then
			ToggleFrame(MRTSkillFrame)
		elseif(skillName2 == 'Inscription')then
			CastSpellByName('Inscription')
		elseif(skillName2 == 'Leatherworking')then
			CastSpellByName('Leatherworking')
		elseif(skillName2 == 'Jewelcrafting')then
			CastSpellByName('Jewelcrafting')
		elseif(skillName2 == 'Alchemy')then
			CastSpellByName('Alchemy')
		elseif(skillName2 == 'Blacksmithing')then
			CastSpellByName('Blacksmithing')
		elseif(skillName2 == 'Engineering')then
			CastSpellByName('Engineering')
		elseif(skillName2 == 'Enchanting')then
			CastSpellByName('Enchanting')
		elseif(skillName2 == 'Herbalism')then
			print('Herbalism has no options!')
		elseif(skillName2 == 'Tailoring')then
			CastSpellByname('Tailoring')
		elseif(skillName2 == 'Skinning')then
			print('Skinning has no options!')
		else
			print('No Profession Found!')
		end	
	end

end)

As you can see with the "LeftButton" i set the Enchanting to print and it does so i believe everything is ok up to the point of opening the profession itself.

Thanks in advance for any help.

Coke

[gmarco]

I was trying to achieve a similar result (a profession LDB), but was very confusing about a thing.

The code:

local prof1, prof2, arch, fish, cook, faid = GetProfessions()

will find some index for professions that the pg actually has and I can decode all them with something like this:

local function mkmyprof(x,y)
    name, icon, rank, top, _, _, _, _, _, _ = GetProfessionInfo(y)    
    myprof[x]={name, icon, rank, top}
end
 
if prof1    then mkmyprof(1,prof1)  end
if prof2    then mkmyprof(2,prof2)  end
if arch     then mkmyprof(3,arch)   end 
if fish     then mkmyprof(4,fish)   end
if cook     then mkmyprof(5,cook)   end
if faid     then mkmyprof(6,faid)   end

What I really don't understand is that the indexes are not unique per profession of the pg.

So prof1 for a pg can have an index that for another pg could be of another prof while I thought it was an index unique for the profession and so prof1=herbalism should always be identified by the number 6 for example.

I try to explain better with an example:

local prof1, prof2, arch, fish, cook, faid = GetProfessions()

in a PG with prof1=herbalism and prof2=inscription I get:
6,9,10,8,7,5

while in a pg with prof1=tailoring and prof2=engineering I get:
7,8,10,9,6,5

As I wrote before I can decode this happily (name, rank, etc etc) but it is very difficult for me now try to do some check like:

if prof1 == herbalism don't let it be pressed because it is a protected action.

I can't use the name (I got Erbalismo italian client, an english friends wll get Herbalism and so on ...) nor I can't use the index.

Probably I can check the icon but I think this is not the right way to do this thing :-)


Btw the full addon skeleton is:

local ADDON = ...
 
local myprof = {}
local name, icon, rank, top
local x, y
local playerName = UnitName("player");
 
local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local prof1, prof2, arch, fish, cook, faid = GetProfessions()
 
local function mkmyprof(x,y)
    name, icon, rank, top, _, _, _, _, _, _ = GetProfessionInfo(y)    
    myprof[x]={name, icon, rank, top}
end
 
if prof1    then mkmyprof(1,prof1)  end
if prof2    then mkmyprof(2,prof2)  end
if arch     then mkmyprof(3,arch)   end 
if fish     then mkmyprof(4,fish)   end
if cook     then mkmyprof(5,cook)   end
if faid     then mkmyprof(6,faid)   end
 
local dataobj = ldb:NewDataObject("MyProf", {type = "data source", text = "myprof"})
dataobj.OnClick = function(self, button)  
 
    if (button == "LeftButton") then    
        if prof1 then 
            dataobj.icon = myprof[1][2]
            dataobj.text = myprof[1][1]
            CastSpellByName(myprof[1][1])
        end
    elseif ( button == "RightButton" ) then             
        if prof2 then 
            dataobj.icon = myprof[2][2]
            dataobj.text = myprof[2][1]
            CastSpellByName(myprof[2][1])
        end
    end
 
end
 
function dataobj:OnEnter()
    GameTooltip:SetOwner(self, "ANCHOR_NONE")
    GameTooltip:SetPoint("TOPLEFT", self, "BOTTOMLEFT")
    GameTooltip:ClearLines()
    dataobj.OnTooltipShow(GameTooltip)
    GameTooltip:Show()
end
 
function dataobj:OnTooltipShow()
    GameTooltip:AddLine(playerName .. " skills", 1,1,1);
    if prof1    then GameTooltip:AddDoubleLine(myprof[1][1], myprof[1][3])  end;
    if prof2    then GameTooltip:AddDoubleLine(myprof[2][1], myprof[2][3])  end;
    if arch     then GameTooltip:AddDoubleLine(myprof[3][1], myprof[3][3])  end;
    if fish     then GameTooltip:AddDoubleLine(myprof[4][1], myprof[4][3])  end;
    if cook     then GameTooltip:AddDoubleLine(myprof[5][1], myprof[5][3])  end;
    if faid     then GameTooltip:AddDoubleLine(myprof[6][1], myprof[6][3])  end;
end
 
function dataobj:OnLeave()
    GameTooltip:Hide()
end

Thanks.

[Torhal]

Here's what I'm doing in AckisRecipeList_QuickScan to make this work no matter which locale is being played. Of course, this is just the relevant code, and is tailored for Ackis Recipe List (the mining and smelting stuff) so you'll need to modify to suit what you're doing. Look at the code for the actual AddOn for more details.

-------------------------------------------------------------------------------
-- Constants
-------------------------------------------------------------------------------
local MINING_NAME = GetSpellInfo(32606)
local SMELTING_NAME = GetSpellInfo(61422)

local VALID_PROFESSIONS = {
        [GetSpellInfo(2259)] = true, -- Alchemy
        [GetSpellInfo(2018)] = true, -- Blacksmithing
        [GetSpellInfo(2550)] = true, -- Cooking
        [GetSpellInfo(7411)] = true, -- Enchanting
        [GetSpellInfo(4036)] = true, -- Engineering
        [GetSpellInfo(746)] = true, -- First Aid
        [GetSpellInfo(2108)] = true, -- Leatherworking
        [SMELTING_NAME] = true, -- Smelting
        [GetSpellInfo(3908)] = true, -- Tailoring
        [GetSpellInfo(25229)] = true, -- Jewelcrafting
        [GetSpellInfo(45357)] = true, -- Inscription
        [GetSpellInfo(53428)] = true, -- Runeforging
}

-------------------------------------------------------------------------------
-- Variables.
-------------------------------------------------------------------------------
local known_professions = {
        ["prof1"] = false,
        ["prof2"] = false,
        ["archaeology"] = false,
        ["fishing"] = false,
        ["cooking"] = false,
        ["firstaid"] = false,
}

-- When you want to update information:
                        local known = known_professions

                        known.prof1, known.prof2, known.archaeology, known.fishing, known.cooking, known.firstaid = _G.GetProfessions()

-- The main part
                for profession, index in pairs(known_professions) do
                        if index then
                                local name, icon, rank, maxrank, numspells, spelloffset, skillline = _G.GetProfessionInfo(index)

                                if name == MINING_NAME then
                                        name = SMELTING_NAME
                                end

                                if VALID_PROFESSIONS[name] then
                                    -- Do your stuff here.
                                end
                        end
                end

[Tageshi]

There is no ID for profession names, but there is spellid for profession spell on your spellbook.

You can get profession spell names like below:

#Alchemy
/dump (GetSpellInfo(2259))
#Blacksmithing
/dump (GetSpellInfo(2018))
#Enchanting
/dump (GetSpellInfo(7411))
#Engineering
/dump (GetSpellInfo(4036))
#Herb Gathering
/dump (GetSpellInfo(2366))
#Inscription
/dump (GetSpellInfo(45357))
#Jewelcrafting
/dump (GetSpellInfo(25229))
#Leatherworking
/dump (GetSpellInfo(2108))
#Smelting
/dump (GetSpellInfo(2656))
#Skinning
/dump (GetSpellInfo(8613))
#Tailoring
/dump (GetSpellInfo(3908))

And then you can get profession spell names of your characters like below:

/dump GetSpellBookItemName(select(6,GetProfessionInfo((GetProfessions())))+1, BOOKTYPE_PROFESSION)
/dump GetSpellBookItemName(select(6,GetProfessionInfo(select(2, GetProfessions())))+1, BOOKTYPE_PROFESSION)

Compare these two names.
(Don't try to compare spellid directly. Spellid will change depending on profession ranks.)

[SDPhantom]

This is what I can come up with for a somewhat simple solution. This follows the pattern of which all tradeskill windows are listed at index 1 of their associated offset. I included a lookup table that prevents the attempt to open a window for a profession that doesn't have one. Currently, this is Herbalism and Skinning.

--  To support other locales, restricted tradeskills are listed by their icon path, which never changes between locales
local Restricted={
    ["Interface\\Icons\\Trade_Herbalism"]=true;--   Herbalism
    ["Interface\\Icons\\INV_Misc_Pelt_Wolf_01"]=true;-- Skinning
};
 
Stat:SetScript("OnMouseDown", function(self, btn)
--  Handle middle button and exit immediately
    if btn == "MiddleButton" then
        ToggleSpellBook(BOOKTYPE_PROFESSION);
        return;
    end
 
--  Get profession IDs
    local prof1,prof2=GetProfessions();
    local tex,offset;
 
--  Select based on button pressed
    if btn=="LeftButton" and prof1 then
        local _; _,tex,_,_,_,offset=GetProfessionInfo(prof1);
    elseif btn=="RightButton" and prof2 then
        local _; _,tex,_,_,_,offset=GetProfessionInfo(prof2);
    else return; end
 
--  Open tradeskill
    if not Restricted[tex] then--   Don't run if no tradeskill window
        CastSpell(offset+1,BOOKTYPE_PROFESSION);
    end
end);

[cokedrivers]

Im not sure if this will work for a LDB and maybe you can add or adjust some of the code, But this is what I use on nData for professions:

local nData = LibStub("AceAddon-3.0"):GetAddon("nData")

------------------------------------------------------------------------
--	 Professions Plugin Functions
------------------------------------------------------------------------
nData.pluginConstructors["pro"] = function()

	db = nData.db.profile

	local plugin = CreateFrame('Button', nil, Datapanel)
	plugin:RegisterEvent('PLAYER_ENTERING_WORLD')
	plugin:SetFrameStrata('BACKGROUND')
	plugin:SetFrameLevel(3)
	plugin:EnableMouse(true)
	plugin.tooltip = false

	local Text = plugin:CreateFontString(nil, 'OVERLAY')
	Text:SetFont(db.font, db.fontSize,'THINOUTLINE')
	nData:PlacePlugin(db.pro, Text)

	local function Update(self)
		local prof1, prof2 = GetProfessions()
			if prof1 ~= nil then
				Text:SetFormattedText(hexa.."Professions"..hexb)
			else
				Text:SetFormattedText(hexa.."No Professions"..hexb)
			end
		self:SetAllPoints(Text)
	end

	plugin:SetScript('OnEnter', function()
		if InCombatLockdown() then return end
		local anchor, panel, xoff, yoff = nData:DataTextTooltipAnchor(Text)
		GameTooltip:SetOwner(panel, anchor, xoff, yoff)
		GameTooltip:ClearLines()
		GameTooltip:AddLine(hexa..PLAYER_NAME.."'s"..hexb.." Professions")
		GameTooltip:AddLine' '		
		for i = 1, select("#", GetProfessions()) do
			local v = select(i, GetProfessions());
			if v ~= nil then
				local name, texture, rank, maxRank = GetProfessionInfo(v)
				GameTooltip:AddDoubleLine(name, rank..' / '..maxRank,.75,.9,1,.3,1,.3)
			end
		end
		GameTooltip:AddLine' '
		GameTooltip:AddLine("|cffeda55fLeft Click|r to Open Profession #1")
		GameTooltip:AddLine("|cffeda55fMiddle Click|r to Open Spell Book")
		GameTooltip:AddLine("|cffeda55fRight Click|r to Open Profession #2")
		
		GameTooltip:Show()
	end)


	plugin:SetScript("OnClick",function(self,btn)
		local prof1, prof2 = GetProfessions()
		if btn == "LeftButton" then
			if prof1 then
				if (GetProfessionInfo(prof1) == ('Herbalism')) then
					print('|cff33ff99nData:|r |cffFF0000Herbalism has no options!|r')
				elseif(GetProfessionInfo(prof1) == ('Skinning')) then
					print('|cff33ff99nData:|r |cffFF0000Skinning has no options!|r')
				elseif(GetProfessionInfo(prof1) == ('Mining')) then
					CastSpellByName("Smelting")
				else	
					CastSpellByName((GetProfessionInfo(prof1)))
				end
			else
				print('|cff33ff99nData:|r |cffFF0000No Profession Found!|r')
			end
		elseif btn == 'MiddleButton' then
			ToggleSpellBook(BOOKTYPE_PROFESSION)	
		elseif btn == "RightButton" then
			if prof2 then
				if (GetProfessionInfo(prof2) == ('Herbalism')) then
					print('|cff33ff99nData:|r |cffFF0000Herbalism has no options!|r')
				elseif(GetProfessionInfo(prof2) == ('Skinning')) then
					print('|cff33ff99nData:|r |cffFF0000Skinning has no options!|r')
				elseif(GetProfessionInfo(prof2) == ('Mining')) then
					CastSpellByName("Smelting")
				else
					CastSpellByName((GetProfessionInfo(prof2)))
				end
			else
				print('|cff33ff99nData:|r |cffFF0000No Profession Found!|r')
			end
		end
	end)


	plugin:RegisterForClicks("AnyUp")
	plugin:SetScript('OnUpdate', Update)
	plugin:SetScript('OnLeave', function() GameTooltip:Hide() end)

	return plugin -- important!
end

Now this only opens the professions 1 and 2 not any secondary professions like First-Aid, Cooking or Archeology. But it is set that a left click will open your profession one (unless it is skinning or herbalism at this point it will print in general chat "Skinning has no options.") then middle click will open your spell book and right click opens your second profession.

Not sure if this is the direction your heading but this is what I have been using for a bout a year and seems to work for me.

Coke

Here is a screenshot of the tooltip for my professions:

[Phanx]

Here is some code I wrote a while back for LibDataBroker that does what you describe, and may be helpful:

http://forums.wowace.com/attachment....9&d=1392003088

[gmarco]

Thanks very much to all for the kind the replies.

Now I have better ideas on "how it works" this thing of the profession :-)
... and I have seen also how much elegant lua code could be ... :-)

I'll try to check all your suggestions and rewrite everything today or tomorrow.
I'll post here the feedback ...

Thanks again very much to all.

[gmarco]

Here it is a first "stable" :-) release:

-- I want to say thanks to the people in wowinterface forum for the help, code and over all ... patience :-)
-- Phanx, Torhal, Tageshi, SDPhantom, cokedrivers and all the others. 
-- [url]http://www.wowinterface.com/forums/showthread.php?p=299262#post299184[/url]
 
local ADDON = ...
local prgname = "|cffffd200myprof|r"
local playerName = UnitName("player");
 
local Restricted={
    ["Interface\\Icons\\Trade_Herbalism"]=true;--   Herbalism
    ["Interface\\Icons\\INV_Misc_Pelt_Wolf_01"]=true;-- Skinning
};
 
local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local dataobj = ldb:NewDataObject("MyProf", {
    type = "data source",
    icon = "Interface\\Minimap\\Tracking\\Repair",
    text = playerName .. " skills",
})
 
-- idea and code by SDPhantom ----------
dataobj.OnClick = function(self, button)  
    
    if button == "MiddleButton" then
        ToggleSpellBook(BOOKTYPE_PROFESSION);
        return;
    end
 
--  Get profession IDs
    local prof1,prof2=GetProfessions();
    local tex,offset;
 
--  Select based on button pressed
    if button=="LeftButton" and prof1 then
        local _; name,tex,_,_,_,offset=GetProfessionInfo(prof1);
    elseif button=="RightButton" and prof2 then
        local _; name,tex,_,_,_,offset=GetProfessionInfo(prof2);
    else return; end
 
--  Open tradeskill
    if not Restricted[tex] then--   Don't run if no tradeskill window
        CastSpell(offset+1,BOOKTYPE_PROFESSION);
    else
        print(prgname .. " Error: " .. name .. " has no tradeskill window")
    end
end
 
function dataobj:OnEnter()
    GameTooltip:SetOwner(self, "ANCHOR_NONE")
    GameTooltip:SetPoint("TOPLEFT", self, "BOTTOMLEFT")
    GameTooltip:ClearLines()
    dataobj.OnTooltipShow(GameTooltip)
    GameTooltip:Show()
end
 
function dataobj:OnTooltipShow()
    local i
 
    GameTooltip:AddLine(" ")
 
    -- thanks to: cokedrivers 
    -- [url]http://www.wowinterface.com/downloads/info19814-nData.html[/url]
    for i = 1, select("#", GetProfessions()) do
            local v = select(i, GetProfessions());
            if v ~= nil then
                local name, _, rank, maxRank = GetProfessionInfo(v)
                GameTooltip:AddDoubleLine(name, rank..' / '..maxRank)
            end
        end
        GameTooltip:AddLine(" ")
        GameTooltip:AddDoubleLine("Left Click", "Open Profession #1")
        GameTooltip:AddDoubleLine("Right Click", "Open Profession #2")
        GameTooltip:AddDoubleLine("Middle Click", "Open Spellbook")
end
 
function dataobj:OnLeave()
    GameTooltip:Hide()
end

When I succeded in finding some more time I'll try to cleanup a little bit :-)
Thanks again.

[Phanx]

local _; name,tex,_,_,_,offset=GetProfessionInfo(prof1);

This is creating a local variable "_" and global variables "name", "tex", and "offset". They should all be local:

    --  Select based on button pressed
    local name, tex, offset, _
    if button == "LeftButton" and prof1 then
        name, tex, _, _, _, offset = GetProfessionInfo(prof1)
    elseif button == "RightButton" and prof2 then
        name, tex, _, _, _, offset = GetProfessionInfo(prof2)
    else
        return
    end

On a side note, addons are not macros. There is no character limit. You don't need to mash everything together. Add spaces between variables, around operators, etc. Put each statement on its own line. Your code will be much more readable, and thus easier to maintain, if you let it breathe.

Also, semicolons are useless ugly clutter in Lua. Get rid of them, unless you are already used to programming in some other language that requires them, in which case you should still get rid of them. Different programming languages have different syntaxes, just like different human languages -- you'll be better at any of them if you use them as they're meant to be used, rather than trying to shoehorn them into some other language's conventions.

[gmarco]

Thanks very much Phanx.

After your input and corrections the code looks like this way:

-- I want to say thanks to the people in wowinterface forum for the help, code and over all ... patience :-)
-- Phanx, Torhal, Tageshi, SDPhantom, cokedrivers and all the others. 
-- [url]http://www.wowinterface.com/forums/showthread.php?p=299262#post299184[/url]
 
local ADDON = ...
local prgname = "|cffffd200myprof|r"
local playerName = UnitName("player")
 
local Restricted={
    ["Interface\\Icons\\Trade_Herbalism"]=true,         --  Herbalism
    ["Interface\\Icons\\INV_Misc_Pelt_Wolf_01"]=true,   --  Skinning
};
 
local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local dataobj = ldb:NewDataObject("MyProf", {
    type = "data source",
    icon = "Interface\\Minimap\\Tracking\\Repair",
    text = playerName .. " skills"
})
 
-- idea and code by SDPhantom ----------
dataobj.OnClick = function(self, button)  
 
    if button == "MiddleButton" then
        ToggleSpellBook(BOOKTYPE_PROFESSION)
        return
    end
 
--  Get profession IDs
    local prof1,prof2=GetProfessions()
    local tex,offset
 
--  Select based on button pressed
    local name, tex, offset, _
    if button == "LeftButton" and prof1 then
        name, tex, _, _, _, offset = GetProfessionInfo(prof1)
    elseif button == "RightButton" and prof2 then
        name, tex, _, _, _, offset = GetProfessionInfo(prof2)
    else
        return
    end
 
--  Open tradeskill
    if not Restricted[tex] then         --   Don't run if no tradeskill window
        CastSpell(offset+1,BOOKTYPE_PROFESSION)
    else
        print(prgname .. " Error: " .. name .. " has no tradeskill window")
    end
end
 
function dataobj:OnEnter()
    GameTooltip:SetOwner(self, "ANCHOR_NONE")
    GameTooltip:SetPoint("TOPLEFT", self, "BOTTOMLEFT")
    GameTooltip:ClearLines()
    dataobj.OnTooltipShow(GameTooltip)
    GameTooltip:Show()
end
 
function dataobj:OnTooltipShow()
    local i
    GameTooltip:AddLine(" ")
    
    -- code by: cokedrivers 
    -- [url]http://www.wowinterface.com/downloads/info19814-nData.html[/url]
    for i = 1, select("#", GetProfessions()) do
        local v = select(i, GetProfessions())
        if v ~= nil then
            local name, texture, rank, maxRank = GetProfessionInfo(v)
            GameTooltip:AddDoubleLine(name, rank..' / '..maxRank)
        end
    end
    GameTooltip:AddLine(" ")
    GameTooltip:AddDoubleLine("Left Click", "Open Profession #1")
    GameTooltip:AddDoubleLine("Right Click", "Open Profession #2")
    GameTooltip:AddDoubleLine("Middle Click", "Open Spellbook")
end
 
function dataobj:OnLeave()
    GameTooltip:Hide()
end

Only a question:
Is it important to declare local also the "_" var ?

Thanks again.

[Lombra]

Originally Posted by gmarco Only a question: Is it important to declare local also the "_" var ?

Yes! The underscore is not in any way special and will leak like any other variable. It's arguably even more important to make sure that it's local, since it's so common that a conflict is at even greater risk.

[Phanx]

When Blizzard leaks a global underscore, and you leak a global underscore, you break the entire UI. It has happened before. Don't do it.

[gmarco]

Uhm ... I begin to be scared :-)

I think I have to double check all my addons ...

Probably add to all of them :

local _

is the right thing to do ... (if not present :-)

[Phanx]

That's the lazy solution, but really you should just make sure you're not leaking any globals. Anywhere you define a variable, stick a "local" in front of it. If you need it accessible in a higher scope, define it in that higher scope with no value (just "local myVariable") and then give it its value later, but as a general rule, keep variables in the narrowest scope necessary. If it only needs to exist inside a certain function, make sure it's defined as local inside that function. If it only needs to exist inside a certain for loop, keep it inside the loop, etc.

You can use WowGlobalFinder to help you find all the leaks in your code.

[gmarco]

Thanks for your kind reply Phanx...

I have opened a new post about this here:
http://www.wowinterface.com/forums/s...ad.php?t=50333

Thanks again.

[SDPhantom]

Originally Posted by Phanx local _; name,tex,_,_,_,offset=GetProfessionInfo(prof1); This is creating a local variable "_" and global variables "name", "tex", and "offset". They should all be local:

I had tex and offset defined as locals in the section before it, literally the previous running line. gmarco added name without adding it to the upvalue list making it leak into global namespace. Making "_" a local specifically in the if block was an attempt to isolate the value as it was not needed anywhere.

Originally Posted by Phanx On a side note, addons are not macros. There is no character limit. You don't need to mash everything together. Add spaces between variables, around operators, etc. Put each statement on its own line. Your code will be much more readable, and thus easier to maintain, if you let it breathe. Also, semicolons are useless ugly clutter in Lua. Get rid of them, unless you are already used to programming in some other language that requires them, in which case you should still get rid of them. Different programming languages have different syntaxes, just like different human languages -- you'll be better at any of them if you use them as they're meant to be used, rather than trying to shoehorn them into some other language's conventions.

Lua was created to be flexible with its syntax. I agree semicolons are optional, as are most spaces. I'm not going to sit here and debate on which programming style is better, but yours is not the only way and you should stop pushing everyone into thinking that. Nobody except Blizzard is trying to "shoehorn" Lua into anything. It's created with options as intended to make people from all other languages comfortable using it. The only time "shoehorning" one language to act like another is bad is when you impede the standard performance of the language itself. Hint, Blizzard and their division by zero errors. -.-;

[Phanx]

Originally Posted by SDPhantom Lua was created to be flexible with its syntax. ... yours is not the only way and you should stop pushing everyone into thinking that.

If you're the only person who's ever going to look at your code, sure, do whatever you want. But if you want other people to be able to read your code and help you with it, you should make some attempt to make it easy to read. Mashing everything together by omitting every possible space is the opposite of making your code easy to read, and I will continue to complain whenever people ask me to read code that looks like a copypasta from the Arenajunkies forum.

[SDPhantom]

Tbh, all this nitpicking is really irritating. You're complaining about semicolons at the end of each line and comas aren't enough separation between a list of names. Just stop and think about it. Is this really worth the fuss over?

It's a programming language, not grammar school.