Help understanding Blizzard magic when Crafting

[bsmorgan]

Apparently Druids (and Warlocks) can't craft while shapeshifted. The Blizzard Tradeskill UI solves this problem by automagically shifting to "normal" form when you click the "Create" button. The Skillet UI gets an error "You are in shapeshift form" instead.

I've looked at Blizzard_TradeSkillUI.lua and Blizzard_TradeSkillUI.xml and I don't see any "magic", the create button calls "DoTradeSkill(TradeSkillFrame.selectedSkill, TradeSkillInputBox:GetNumber());".

Skillet calls "DoTradeSkill(skillIndexLookup[command.recipeID],command.count)" as well.

Can anyone provide some insight into how the "magic" works so I can implement it in Skillet?

[Resike]

Originally Posted by bsmorgan Apparently Druids (and Warlocks) can't craft while shapeshifted. The Blizzard Tradeskill UI solves this problem by automagically shifting to "normal" form when you click the "Create" button. The Skillet UI gets an error "You are in shapeshift form" instead. I've looked at Blizzard_TradeSkillUI.lua and Blizzard_TradeSkillUI.xml and I don't see any "magic", the create button calls "DoTradeSkill(TradeSkillFrame.selectedSkill, TradeSkillInputBox:GetNumber());". Skillet calls "DoTradeSkill(skillIndexLookup[command.recipeID],command.count)" as well. Can anyone provide some insight into how the "magic" works so I can implement it in Skillet?

The function is probably gets executed in the C server side code, so you can't really see into that.

My guess would be since it's gets called by a secure Blizzard addon it can run codes like shapeshit into and out of forms. While when it gets called by a 3rd party addon, that part of the code fails silently and you only get the error message.

Long story short you won't be able to do this without breaking the TOS.

[p3lim]

Just do it securely?

[Resike]

Originally Posted by p3lim Just do it securely?

Worth a try, but it might not work even like that.

[bsmorgan]

Thanks for the insight. I'll close the Skillet ticket that was entered but now I can at least explain why!

[SDPhantom]

What I've done before is create a SecureActionButton that runs /cancelform and put the DoTradeSkill() call in a PostClick handler. You can also do button:HookScript() on the OnClick handler to securely post-hook the existing script used by the SecureActionButtonTemplate.

Method 1:

local button=CreateFrame("Button",nil,nil,"SecureActionButtonTemplate");
button:RegisterForClicks("AnyUp");
button:SetAttribute("type","macro");
button:SetAttribute("macrotext",SLASH_CANCELFORM1);-- Using this constant makes sure this code works on all locales
 
button:SetScript("PostClick",function(self,button)
    -- Do stuff and make your DoTradeSkill() call here
);

Method 2:

local button=CreateFrame("Button",nil,nil,"SecureActionButtonTemplate");
button:RegisterForClicks("AnyUp");
button:SetAttribute("type","macro");
button:SetAttribute("macrotext",SLASH_CANCELFORM1);-- Using this constant makes sure this code works on all locales
 
button:HookScript("OnClick",function(self,button)
    -- Do stuff and make your DoTradeSkill() call here
);