Concerning Zonide's Scouter

[Ketho]

I want to ask your opinions about Zonide's Scouter, more specifically about the addon's code.

I think the author spent a lot of work on it and takes it seemingly very serious. But there are a few things off, for example there are a lot of leaking globals. He said he's open to advice (on MMO-Champion), but might disagree on stuff.

http://www.mmo-champion.com/threads/...nide-s-Scouter
http://wow.curseforge.com/addons/zonides-scouter/files/

Originally Posted by Zonide OH! I almost forgot (again), if anyone reading this has any suggestions for changes or additions to the addon, I am willing to listen and consider them.

[Phanx]

Re: globals, "a lot" seems to be an understatement... pretty much everything is a global, he's using a lot of meaningless gibberish variable names, inconsistent indentation makes the code unnecessarily annoying to read, he doesn't seem aware that you can reuse a function instead of creating it over and over again, etc. I would refuse to use this addon on general principle because of how ugly its code is.

[Vlad]

It's ok, Phanx. Just imagine how many don't know lua and love this addon! Regardless of the leaking globals!