UnitGUID issue in flex mode?

[zork]

Someone posted this error in the comments on my tooltip mod

Message: Interface\AddOns\rTooltip\core.lua:128: Usage: UnitGUID("unit") Time: 09/14/13 18:55:34 Count: 8 Stack: [C]: in function `UnitGUID' Interface\AddOns\rTooltip\core.lua:128: in function <Interface\AddOns\rTooltip\core.lua:126> [C]: ? Locals: (*temporary) = nil

What I'm doing is the following:

local unit = select(2, self:GetUnit()) or (GetMouseFocus() and GetMouseFocus():GetAttribute("unit")) or (UnitExists("mouseover") and "mouseover")
local guid = UnitGUID(unit) or nil
if not guid then return end

Full code: http://code.google.com/p/rothui/sour...p/core.lua#125

I tested UnitGUID(unitID). When entering an invalid unitID it just returns nil.
What could make the function fail? It works flawlessly in any case I know. No issues with cross-realms.

I have not tested Flex raids yet. Am I missing something?

*edit* ------------------------
Ok...I think I forgot to catch nil and type. So going to add:

if not unit or (unit and type(unit) ~= "string") then return end

This should do it.

[SDPhantom]

You could do this:

local guid=unit and UnitGUID(unit);

If unit is nil, it won't run UnitGUID() and return nil. Otherwise, if UnitGUID() doesn't return anything useful, it'll return nil anyway.



If you want to check type too, you can do this:

local guid=(type(unit)=="string" and UnitGUID(unit) or nil);

Note the == operator will return a boolean value. If this doesn't matter to any following code, you may strip off the "or nil".

[Seerah]

I'm really tired and was out all day at a street fair, so I may be forgetting something. But why aren't you just using "mouseover" for your unit?

[zork]

When you hover a unitframe you need to check for the unit attribute of that unitframe. Or check if the player target sth then self:GetUnit() will return a unit. I don't think mouseover works on unitframes.

[semlar]

I'm pretty sure hovering over a unit frame is just like hovering over the unit.

[Dridzt]

Originally Posted by semlar I'm pretty sure hovering over a unit frame is just like hovering over the unit.

This is somewhat correct, it works the same within combatlog range, but not outside it.
(I think that's also rather new behavior, I know I noticed it around 5.3)